From patchwork Fri Mar 1 14:39:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Wakely X-Patchwork-Id: 1906729 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=gAGAZXMY; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TmW6R1WC6z1yX7 for ; Sat, 2 Mar 2024 01:43:11 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 312CE3858C5F for ; Fri, 1 Mar 2024 14:43:09 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0DE373858D39 for ; Fri, 1 Mar 2024 14:42:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0DE373858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0DE373858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709304166; cv=none; b=eOnl07x5jaSrSCn438M8RJ2qjd0Hc0qp+DajmUzHYc3kUblprIN5OskGNukL3UlssWMEPzHmVCSkly+g1P2RYGRQN3TvER6Lpw43ECw72iLeXvJap4xYGRqhr5yKECFLCkICXK5pCccvAOoCTA8ZxBPb8GqE9DX6+s7gQI6MlmY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709304166; c=relaxed/simple; bh=SwcNqhMuug5bIrB6CfH7/qMAJUx7WlyXloUBQvnH0XY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=XgywQMINpIe47d6E1b8ZQ95NiYoqtAOtEBiKSRZ4QtptPmP1CXHQ0o5htE6BnGZCFFxnA5L3z4e2ugfvCcRCgaWWbO6aKjT7mXueBuQZrAg4XOouzy0CDTmwj2dOxaE7YDjVxF7+eR5NffmLeBMl+CU8QsGHKrrXyjOsABEQbKQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709304163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QVw+9p1pDqvgr1qZrxiKrg/VKWapCqWm13TYjn1yj5A=; b=gAGAZXMY/g/hjpCq3U6F8EwT7md6wxDZQWpEZ4C8qTR0r5gGyNRQmby753sl8KJa6U3OLz DYkIRcleLlSULTlQKNB12Akor0LHYlqT1nfOsdX7lfcKwtanTjLRPoBwye0LTT6DtkhL08 qgKfKruHWMwNAVUeIj/e9aQdtJxdmtM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-571-yt9MfFR2PW6SCfER8flvKw-1; Fri, 01 Mar 2024 09:42:42 -0500 X-MC-Unique: yt9MfFR2PW6SCfER8flvKw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A1D5F85A58F; Fri, 1 Mar 2024 14:42:39 +0000 (UTC) Received: from localhost (unknown [10.42.28.150]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6D86CAC11; Fri, 1 Mar 2024 14:42:39 +0000 (UTC) From: Jonathan Wakely To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: [PATCH] libstdc++: Use [] for empty argument to automake macro Date: Fri, 1 Mar 2024 14:39:21 +0000 Message-ID: <20240301144238.94065-1-jwakely@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Does this look reasonable to push? There are lots of other uses of AM_ENABLE_MULTILIB(, ..) in the tree, but I'll leave others to "fix" those if needed. -- >8 -- This seems to be needed to build with --enable-maintainer-mode but I don't understand why it doesn't fail in the normal build. libstdc++-v3/ChangeLog: * configure.ac: Use [] for empty argument to AM_ENABLE_MULTILIB macro. --- libstdc++-v3/configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libstdc++-v3/configure.ac b/libstdc++-v3/configure.ac index 37396bd6ebb..1d6a94a16f2 100644 --- a/libstdc++-v3/configure.ac +++ b/libstdc++-v3/configure.ac @@ -11,7 +11,7 @@ AC_CONFIG_HEADER(config.h) ### am handles this now? ORIGINAL_LD_FOR_MULTILIBS=$LD # Find the rest of the source tree framework. -AM_ENABLE_MULTILIB(, ..) +AM_ENABLE_MULTILIB([], ..) # Gets build, host, target, *_vendor, *_cpu, *_os, etc. #