From patchwork Thu Feb 29 13:11:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Romain Naour X-Patchwork-Id: 1906316 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=buildroot.org (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver=patchwork.ozlabs.org) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Tls700hHZz23qX for ; Fri, 1 Mar 2024 00:11:24 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id EC986822F2; Thu, 29 Feb 2024 13:11:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Plz6Y61iTW3R; Thu, 29 Feb 2024 13:11:17 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 08064822FC Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 08064822FC; Thu, 29 Feb 2024 13:11:17 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id CBB511BF2EF for ; Thu, 29 Feb 2024 13:11:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id C6575608FA for ; Thu, 29 Feb 2024 13:11:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D_aT232mZQwW for ; Thu, 29 Feb 2024 13:11:14 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::436; helo=mail-wr1-x436.google.com; envelope-from=romain.naour@smile.fr; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 2DD886086C DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 2DD886086C Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by smtp3.osuosl.org (Postfix) with ESMTPS id 2DD886086C for ; Thu, 29 Feb 2024 13:11:13 +0000 (UTC) Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-33d568fbf62so490526f8f.3 for ; Thu, 29 Feb 2024 05:11:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709212272; x=1709817072; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iC5O2ZnzfFN7RDxph9Ki1u8Ev/uNb0b038MRQdA7E4A=; b=tyBm+14X2Ip4mp7U57Vc+977HBDATjoE/kU2Q/G/vjJm/Y/3x3dQQmtgimQfmaLmSy P43Kvu4eM8bNSl0yKCqKLSu2M7x/QreHHhlEZ0bexcYzvNnjDWT2VYWfibTMbuB7WOI2 GzFonUceZtEODiG3DKq4UBhGJn2YbrpdLGu/nGJbH5i3t29nXTWscf9IFfvP3lso+cXx KAZK9NnB49lQM0saMhyt3UgjwP08321Le9FkRNbFSq5UTK5OFUQh06C6XfmQ2/lB03WS gKOA6oqIzBXcmLV3tYgMrt2d7rACA5UaR36r3lIzI0HaR7eGkM7BBTSj0yBBIdCz785c NZZw== X-Gm-Message-State: AOJu0YyoQh7t98wYeNNyGyHsdP9nXbg8dWHBZj0e94rKA/Ybf7ziE8Uq GbK+4XjY/QjGmalVeVOkvoqBFFhqxj2OatonJMbaiNtcPFvL/cPlkJqEzgTBBpahqrHQDDW5mwM N X-Google-Smtp-Source: AGHT+IHMYmjbbq+PhOpUltO5iDRmUi6D/J8WuIDQzeKgRVEWX55s2RtNSanMB0r6xftjanEgfKhwCA== X-Received: by 2002:adf:fe50:0:b0:33d:d7be:5850 with SMTP id m16-20020adffe50000000b0033dd7be5850mr1355335wrs.65.1709212271580; Thu, 29 Feb 2024 05:11:11 -0800 (PST) Received: from P-NTS-Evian.home (2a01cb05945b7e009bdc688723a24f31.ipv6.abo.wanadoo.fr. [2a01:cb05:945b:7e00:9bdc:6887:23a2:4f31]) by smtp.gmail.com with ESMTPSA id v6-20020a5d59c6000000b0033d926bf7b5sm1796562wry.76.2024.02.29.05.11.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 05:11:11 -0800 (PST) From: Romain Naour To: buildroot@buildroot.org Date: Thu, 29 Feb 2024 14:11:07 +0100 Message-ID: <20240229131108.363533-1-romain.naour@smile.fr> X-Mailer: git-send-email 2.43.2 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smile-fr.20230601.gappssmtp.com; s=20230601; t=1709212272; x=1709817072; darn=buildroot.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=iC5O2ZnzfFN7RDxph9Ki1u8Ev/uNb0b038MRQdA7E4A=; b=yJTtS9eBpBx73/vtWSkAPd58sFc2fK9hz23ygpfKTQ2A2x7Mtfje4z8cFvG+qRz/XX unY4D1qzHS6nas2nOrrrFzqnr/JUjFeiECbtv43eLXrdv28T1YSjTDbuNl76VZ9jjn/R ihrbH7MzfsVp9Nta9Ucv/4ABas/KrDm/L2UUTokxyfpUm/zdZALGfZV+cAd1Q++i/INa WJHX9l++rGBBN9Rsq6TXPrr1qbBZRkYnPP+ALmxCJlUaizazMD6BfznCnfJxmiCu2RHE X+mmAdsmTvg4LE0ukaLz/oEnTZjkfj7QXS13X4kEc52nyeKV9bxtqcxsP+nulgGL58tg wvSw== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=none dis=none) header.from=smile.fr X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=smile-fr.20230601.gappssmtp.com header.i=@smile-fr.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=yJTtS9eB Subject: [Buildroot] [PATCH 1/2] package/rust: use host libraries from HOST_DIR X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Romain Naour Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" host-rust package depends on several host packages to provide tools and libraries but it doesn't take into account HOST_DIR while building rustc compiler. Indeed, rustc needs zlib and fail to link if zlib is not installed on the host. error: could not compile `rustc_driver` (lib) due to previous error If zlib is installed on the host, we can notice it with ldd tool (while it should be linked with the one provided by Buildroot host-zlib). ldd [...]TestRust/host/bin/rustc libz.so.1 => /lib64/libz.so.1 Provide HOST_LDFLAGS using llvm.ldflags in config.toml. (HOST_LDFLAGS provide -L$(HOST_DIR)/lib -Wl,-rpath,$(HOST_DIR)/lib) With that fixed, rustc_driver link with libz from HOST_DIR but the host-rust build still fail later due to another issue. error: could not compile `rustdoc-tool` (bin "rustdoc_tool_binary") due to previous error Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/6256881545 http://autobuild.buildroot.org/results/a6b/a6b28783f29e6b729824bf42679a62f72ad5bee0 Signed-off-by: Romain Naour --- package/rust/rust.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/package/rust/rust.mk b/package/rust/rust.mk index f7a5c0fcd5..c464e77f4f 100644 --- a/package/rust/rust.mk +++ b/package/rust/rust.mk @@ -64,6 +64,7 @@ define HOST_RUST_CONFIGURE_CMDS echo 'cc = "$(TARGET_CROSS)gcc"'; \ echo '[llvm]'; \ echo 'ninja = false'; \ + echo 'ldflags = "$(HOST_LDFLAGS)"'; \ ) > $(@D)/config.toml endef From patchwork Thu Feb 29 13:11:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Romain Naour X-Patchwork-Id: 1906317 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=buildroot.org (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver=patchwork.ozlabs.org) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Tls7252jHz23qX for ; Fri, 1 Mar 2024 00:11:26 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id AFF15822FC; Thu, 29 Feb 2024 13:11:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9SZs8SLVNS-m; Thu, 29 Feb 2024 13:11:19 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org ED5658237E Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id ED5658237E; Thu, 29 Feb 2024 13:11:18 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 19E3B1BF2EF for ; Thu, 29 Feb 2024 13:11:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 0606841770 for ; Thu, 29 Feb 2024 13:11:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ckkAleilJQMO for ; Thu, 29 Feb 2024 13:11:14 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::329; helo=mail-wm1-x329.google.com; envelope-from=romain.naour@smile.fr; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 3D1994027F DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 3D1994027F Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by smtp2.osuosl.org (Postfix) with ESMTPS id 3D1994027F for ; Thu, 29 Feb 2024 13:11:14 +0000 (UTC) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-412bf3d52d7so3406965e9.2 for ; Thu, 29 Feb 2024 05:11:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709212272; x=1709817072; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tmu7WV8LbnrDCbkWWMP+crLdelhWxR/XMPfDA7f8WAE=; b=d72LVvqJzL4kmcQCsjMJMVM5Gp4RtHxxDW4AdA2F2sAeILDyFjQCFm7K/1qHXx418+ xVRcug3wKRAmeY7sRCO+x39NZOB2TRgwhdMMkkdmtUrgurLFWrCYJ5anuR3fzonnUOez 33p5IUYUYX1rk63i3oi/XlTS9FJuhD3vSVdd/ZEe/H5g9+h8AWWwWqn7ugtgSC4BXF7W kdaNLrfTVbgZOh3PQfRMe0uPdWpb66Vnhpa/dEXHVLduFeM3VY8J3VuzrKEmJDjKaKmM I0FV01/U+PxrfXaOBQITKfWFPW32K3vIIRZjPdLCqK+vM9MVORr5mTLAFLPiOruFKrbo aX8w== X-Gm-Message-State: AOJu0YwCjNmyT8Nar7N0OAIkNAiUftc946yWVBflooUAkWDL+wTNUBMi rp7M85v5V6AII3ZKHBwZPSx1yLaW2hnZPMENjbHbIQVnAPsJqFSHc24GAphWa8N7/OzsDgPUlyX b X-Google-Smtp-Source: AGHT+IGTBcxRf4qIHI8/g94Z4XY+834OR8CDYxULhYotQOpCwkZ5R9KQP6U/U45InidEdpzojT6f0Q== X-Received: by 2002:a5d:544c:0:b0:33d:87e9:5903 with SMTP id w12-20020a5d544c000000b0033d87e95903mr1635763wrv.15.1709212272207; Thu, 29 Feb 2024 05:11:12 -0800 (PST) Received: from P-NTS-Evian.home (2a01cb05945b7e009bdc688723a24f31.ipv6.abo.wanadoo.fr. [2a01:cb05:945b:7e00:9bdc:6887:23a2:4f31]) by smtp.gmail.com with ESMTPSA id v6-20020a5d59c6000000b0033d926bf7b5sm1796562wry.76.2024.02.29.05.11.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 05:11:11 -0800 (PST) From: Romain Naour To: buildroot@buildroot.org Date: Thu, 29 Feb 2024 14:11:08 +0100 Message-ID: <20240229131108.363533-2-romain.naour@smile.fr> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240229131108.363533-1-romain.naour@smile.fr> References: <20240229131108.363533-1-romain.naour@smile.fr> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smile-fr.20230601.gappssmtp.com; s=20230601; t=1709212272; x=1709817072; darn=buildroot.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tmu7WV8LbnrDCbkWWMP+crLdelhWxR/XMPfDA7f8WAE=; b=x+FzHOouV9EfP0xPGSpxPFK/AD5/jLB9e80+EiOpsXglzA6r8eef+W1V9QDpvOd7E8 JaYloDW5qCvPRftcyHsVZRwxf345vkBlgw0/bTBYN9ZJCcmQWjXsNiSIVJvMNI61QZtX DaaJdtsZVDcpWrktvn55AnE/yzY2UwnPjZhkkGQHerq312qb7OQ7owep1GKot4HTGlu+ 3ca4CXkc4rm4jN7u5LphcI+N4xXfXOu+zWavmBGRlTMRIzCKWeQfEwGLwv+fSbLa905m 93sN5Mr0J3DjmOnyF18uXqPFBdFEuMDDi9DqjgTUDakKXvNQ2zNGzL7icjooazwH1+AM Jpdw== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=none dis=none) header.from=smile.fr X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=smile-fr.20230601.gappssmtp.com header.i=@smile-fr.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=x+FzHOou Subject: [Buildroot] [PATCH 2/2] package/rust: provide RUSTFLAGS for cargo X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Romain Naour Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" While building the rust toolchain, the build system endup using cargo (from [...]/output/build/host-rust-bin-1.74.1/cargo/bin/cargo) to build some tool like rustdoc-tool. But the host-rust package doesn't use the cargo infractructure (since it provide cargo binary) and some cargo environment varialble [1] is not set to crosscompile cargo packages in the rust toolchain. For exemple, we usually set RUSTFLAGS="-C link-arg=-Wl,-rpath,$(HOST_DIR)/lib" to force cargo using libraries provided by Buildroot in $(HOST_DIR)/lib. RUSTFLAGS is actually needed to find zlib library (host-zlib) to link rustdoc-tool when zlib is not installed on the host. Fixes: error: could not compile `rustdoc-tool` (bin "rustdoc_tool_binary") due to previous error [1] https://gitlab.com/buildroot.org/buildroot/-/blob/2024.02-rc1/package/pkg-cargo.mk?ref_type=tags#L167 Signed-off-by: Romain Naour --- package/rust/rust.mk | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/package/rust/rust.mk b/package/rust/rust.mk index c464e77f4f..cbe79cd8e3 100644 --- a/package/rust/rust.mk +++ b/package/rust/rust.mk @@ -69,7 +69,9 @@ define HOST_RUST_CONFIGURE_CMDS endef define HOST_RUST_BUILD_CMDS - cd $(@D); $(HOST_MAKE_ENV) $(HOST_DIR)/bin/python$(PYTHON3_VERSION_MAJOR) x.py build + cd $(@D); $(HOST_MAKE_ENV) \ + RUSTFLAGS="$(addprefix -C link-args=,$(HOST_LDFLAGS))" \ + $(HOST_DIR)/bin/python$(PYTHON3_VERSION_MAJOR) x.py build endef HOST_RUST_INSTALL_OPTS = \