From patchwork Fri Feb 2 08:34:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 1894403 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=cebitec.uni-bielefeld.de header.i=@cebitec.uni-bielefeld.de header.a=rsa-sha256 header.s=20200306 header.b=IShuc8Vs; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TR8Gv6y73z23gx for ; Fri, 2 Feb 2024 19:35:18 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7DF2F38582AC for ; Fri, 2 Feb 2024 08:35:16 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id A83D73858D33 for ; Fri, 2 Feb 2024 08:34:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A83D73858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cebitec.uni-bielefeld.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A83D73858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=129.70.160.84 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706862866; cv=none; b=epNWexTSv9TePJyH5PlRUqeval07SfjwRSUjQlW+dwytg99fI+6sEorJez0nZaxFyPPQtDb/HTmtOUZ7BiKrtQts5vN1OGSRU91agbaFztgOdkCT9VqN8eUe2TR/LbRqWnOFqU2MDZ+FE1cuB9haRQ3xbPMkYyp+FRrx4nUc7Es= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706862866; c=relaxed/simple; bh=xJ4nqDVKlkjhZv4ax5ksPGXiogcclwQFwoL4drCx1/U=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=B90EVfHnAisDDNqZYyRmuBpvA1j9MTpkllsgR9miCi6eQBFt/RtNRoLMHNe6MlhocIJJAh3ZPX4Zr3zHF86WJvZanMuJv9/vZGRkvfu69anaozVGKSPn7Q3FpK9cld7MHvR3cf8gmdZYMBZACdSadZ+WLUU3G68LHEh2lhuOK+U= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 79ED266756; Fri, 2 Feb 2024 09:34:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= cebitec.uni-bielefeld.de; h=content-type:content-type :mime-version:user-agent:message-id:date:date:subject:subject :from:from:received:received; s=20200306; t=1706862862; bh=xJ4nq DVKlkjhZv4ax5ksPGXiogcclwQFwoL4drCx1/U=; b=IShuc8VsAlQ2F1pUWTZ6P PwYZxqnHFJ7DCDH+LYwFFo6UrHitPbwbIX3Dr9s7sMVVsqQldulhdUZAH8tWzR9q HymFKYvdY4LC/xN7ovBT3icu+v3wc/vBArBzWiugZLVDae/W0DE8i+WHPF/pYk2+ 7D2Ecx9k2+srAwyOWjCglsZdJI82sm5/NFqFcIhWVhGn5no+vP29BryUuF5DKYDj vjMO6y1DeOZeIF+1hDXcji8enJ/P79d+0jqvu2TLCu1h1lc51+0H6Y9efjB1go9Q j2jlKDclyOVSMmeymoYYgNJgYVqbvZIfFfJlLYDd5XaZpC1TeNA4FUGs5WuNfAYd A== X-Virus-Scanned: amavisd-new at cebitec.uni-bielefeld.de Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Qdc8igqKKriJ; Fri, 2 Feb 2024 09:34:22 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p5085539e.dip0.t-ipconnect.de [80.133.83.158]) (Authenticated sender: ro) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 4FB716689C; Fri, 2 Feb 2024 09:34:22 +0100 (CET) From: Rainer Orth To: gcc-patches@gcc.gnu.org Cc: qing zhao Subject: [COMMITTED] testsuite: i386: Fix gcc.target/i386/apx-ndd-cmov.c on Solaris/x86 Date: Fri, 02 Feb 2024 09:34:21 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v) MIME-Version: 1.0 X-Spam-Status: No, score=-3790.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, KAM_NUMSUBJECT, KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org gcc.target/i386/apx-ndd-cmov.c FAILs on 64-bit Solaris/x86 with the native assembler: FAIL: gcc.target/i386/apx-ndd-cmov.c scan-assembler-times cmove[^\\n\\r]*, %eax 1 FAIL: gcc.target/i386/apx-ndd-cmov.c scan-assembler-times cmovge[^\\n\\r]*, %eax 1 The gas vs. as difference is - cmove c+4(%rip), %esi, %eax + cmovl.e c+4(%rip), %esi, %eax - cmovge %ecx, %edx, %eax + cmovl.ge %ecx, %edx, %eax This patch accounts for both forms. Tested on i386-pc-solaris2.11 (as and gas) and i686-pc-linux-gnu. Committed to trunk. Rainer # HG changeset patch # Parent b7b9c1365b7c54f5c0e618608af26512175c3333 testsuite: i386: Fix gcc.target/i386/apx-ndd-cmov.c on Solaris/x86 diff --git a/gcc/testsuite/gcc.target/i386/apx-ndd-cmov.c b/gcc/testsuite/gcc.target/i386/apx-ndd-cmov.c --- a/gcc/testsuite/gcc.target/i386/apx-ndd-cmov.c +++ b/gcc/testsuite/gcc.target/i386/apx-ndd-cmov.c @@ -1,7 +1,7 @@ /* { dg-do compile { target { ! ia32 } } } */ /* { dg-options "-O2 -m64 -mapxf" } */ -/* { dg-final { scan-assembler-times "cmove\[^\n\r]*, %eax" 1 } } */ -/* { dg-final { scan-assembler-times "cmovge\[^\n\r]*, %eax" 1 } } */ +/* { dg-final { scan-assembler-times "cmov(l\.)?e\[^\n\r]*, %eax" 1 } } */ +/* { dg-final { scan-assembler-times "cmov(l\.)?ge\[^\n\r]*, %eax" 1 } } */ unsigned int c[4];