From patchwork Tue Jan 30 08:39:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 1892702 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SFF0Skma; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TPJY85zvjz23fD for ; Tue, 30 Jan 2024 19:41:16 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 306393858426 for ; Tue, 30 Jan 2024 08:41:12 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id DF9E93858CDA for ; Tue, 30 Jan 2024 08:39:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DF9E93858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DF9E93858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706603967; cv=none; b=dqObi41pCXvaY+MyL8j4WsJDvtuKPDI7TTpUcD7pRWyv10zuShnbiXVtX09lsXYOnoAO2d+6ByuK3dHDSNqpR7XvoF3kc2iqFmctBnkFoI6dsKvp3+0AldEfjU/NTl0/+ZPraespzcTqTFd+HIgTcwFDs6yY06HROaEIDfNZVv8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706603967; c=relaxed/simple; bh=2VyBQuKeXGJdBvouuolUPGw/66Z15pD8ouwxZqUp4+w=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=Hxkl0w/hZQ03WeTcuYDGtHMtefgqZ7+r+q9i5RdQe06m4e/dZM7EzhKozq3h0704OG/s87hAlFNuCyo7TNkjGA8rohoZGqOwn6huna+hUVSmwU9jg+r+TMzmtIkvQ/hqkZV7kxFCFlPJA4qqiyMSU0OmNVRjakKkMNqLz6RxsOs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706603957; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=ZPjT6H2Bj/aEvtBZOgjUGtzlYJIs1i3h+tBOPwMmMts=; b=SFF0SkmaYflHm3G6EbulVvax8i0X9QXcGe6Bp5jJ2i+M/HtIagJHwoEcgKrDQtE8v3iWMI vaONO1gBQP03hdjsqFS5NLbNd7pWsAK6AzucqR6Gyrtt0D8xgo8YeFKn6yMng2QPqhFw+x nz6ZStiDr1Zrd6YjEA8RwlWrSs53mME= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-427-rFohY9l1PKWOo5auOJ-eYA-1; Tue, 30 Jan 2024 03:39:15 -0500 X-MC-Unique: rFohY9l1PKWOo5auOJ-eYA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 264B2185A781; Tue, 30 Jan 2024 08:39:15 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DEB6A492BE4; Tue, 30 Jan 2024 08:39:14 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 40U8dClV1616881 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 30 Jan 2024 09:39:12 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 40U8dBxl1616880; Tue, 30 Jan 2024 09:39:11 +0100 Date: Tue, 30 Jan 2024 09:39:11 +0100 From: Jakub Jelinek To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: [committed] testsuite: Fix up pr113622-{2,3}.c for i686-linux [PR113622] Message-ID: References: <20240129121131.1FE083858CDA@sourceware.org> MIME-Version: 1.0 In-Reply-To: <20240129121131.1FE083858CDA@sourceware.org> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Jakub Jelinek Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org On Mon, Jan 29, 2024 at 01:05:51PM +0100, Richard Biener wrote: > * gcc.target/i386/pr113622-2.c: New testcase. > * gcc.target/i386/pr113622-3.c: Likewise. The 2 new tests FAIL for me on i686-linux: .../gcc/testsuite/gcc.target/i386/pr113622-2.c:5:14: error: data type of 'a' isn't suitable for a register .../gcc/testsuite/gcc.target/i386/pr113622-2.c:5:29: error: data type of 'b' isn't suitable for a register .../gcc/testsuite/gcc.target/i386/pr113622-2.c:5:44: error: data type of 'c' isn't suitable for a register The problem is that the tests use vectors of double, something added only in SSE2, while the testcases ask for just -msse which only provides vectors of floats. So, either it should be using floats instead of doubles, or we need to add -msse2 to dg-options. I've done the latter. Tested on x86_64-linux with RUNTESTFLAGS='--target_board=unix\{-m32/-march=i686,-m64\} i386.exp=pr113622*.c' and committed to trunk as obvious. 2024-01-30 Jakub Jelinek PR middle-end/113622 * gcc.target/i386/pr113622-2.c: Use -msse2 instead of -msse in dg-options. * gcc.target/i386/pr113622-3.c: Likewise. Jakub --- gcc/testsuite/gcc.target/i386/pr113622-2.c.jj 2024-01-29 23:54:36.330418899 +0100 +++ gcc/testsuite/gcc.target/i386/pr113622-2.c 2024-01-30 08:54:27.227934561 +0100 @@ -1,5 +1,5 @@ /* { dg-do compile } */ -/* { dg-options "-msse -w" } */ +/* { dg-options "-msse2 -w" } */ typedef double __attribute__ ((vector_size (16))) vec; register vec a asm("xmm5"), b asm("xmm6"), c asm("xmm7"); --- gcc/testsuite/gcc.target/i386/pr113622-3.c.jj 2024-01-29 23:54:36.330418899 +0100 +++ gcc/testsuite/gcc.target/i386/pr113622-3.c 2024-01-30 08:54:32.867854967 +0100 @@ -1,5 +1,5 @@ /* { dg-do compile } */ -/* { dg-options "-msse" } */ +/* { dg-options "-msse2" } */ typedef double __attribute__ ((vector_size (16))) vec;