From patchwork Tue Apr 17 09:30:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neil Armstrong X-Patchwork-Id: 899160 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="UAA1+VeR"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 40QKkf4ZZSz9s15 for ; Tue, 17 Apr 2018 19:31:22 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 393ACC21E1E; Tue, 17 Apr 2018 09:30:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 127B3C21DD7; Tue, 17 Apr 2018 09:30:53 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 0E865C21D74; Tue, 17 Apr 2018 09:30:37 +0000 (UTC) Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by lists.denx.de (Postfix) with ESMTPS id A4E12C21DA1 for ; Tue, 17 Apr 2018 09:30:34 +0000 (UTC) Received: by mail-wr0-f195.google.com with SMTP id o15so2506172wro.11 for ; Tue, 17 Apr 2018 02:30:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=7pI70WFKZmrfApX5m0rEEZfS/ky9FW8EUNh5bZk7Za0=; b=UAA1+VeRFDr69pQ2Gku0dSqXWOCn3SJ+YVW9tHXAfupvuRHgMs8Uc96SbCaRo3xKeS jur3W9DppeX0ieDvXGgHyIA0qqplmUtwGShcN0IREgyq1Oh3R7DVvickrOlu3XzmIMUi edQnwxNLlsfSaqn5JkiN2XMN8CLODhfF8qeU+wIuk7zhY78NilJmzdy2sIyRts+EWfBx VJFV6dH3vFcpepaYBoHdzVAH49WyABZuwBBJ9P+e0IOyI4Pjs5zNoCNVL8pA7okwSN9q dmM088lpiJoKqpCymf+0Yn+IQWaSSWI6f3ge/ZRinSPi7Y+4EKUctV7L9Dn8QMdENomr 8rkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=7pI70WFKZmrfApX5m0rEEZfS/ky9FW8EUNh5bZk7Za0=; b=oD4KAQuuWKVt2l6WE91a1l/EyqPxg/CBWwg71c7/AaF0lYDQoUgVzYR/TUWSRRHUbw i55u+SOsxVMd2YfiEKZJlsx4+FChulGCa3qZ1/6Cv4YL/jRbrpfqqA/9QgQ8tVXm7eJa haAg0NocACpzQbfWkSnZmP0t8SOvXx6WXtCax9SCl0LCBBoeGdzW8DT5CMifGS1zSYwG 6Gg8QTyinpkVBaX94zf/GkfAgbs5OaEJCCDls9gsQmHHeM1XFH1GrA0xUFghccUwu9/b qO0kr6f2wlLClBHfv8A9zE2iZtr/aqNEzH5lxLcTyto5iRj/EvY53lypB8ipahs+cIud vKxw== X-Gm-Message-State: ALQs6tBa35EXoz0yLogRCkE28dwylp6hxxVLN54hL9BQHdvW2ec3SJ8S hf6O3JzNFYnyZOEnmB4PIrMMkw== X-Google-Smtp-Source: AIpwx4/4WbGQpzea2XC+2njqlWIUYI2oA1GgnN342bZr3Sv+kJ6Dii19Cv1LXCyT2V9WN8f9MOtoxQ== X-Received: by 10.28.134.138 with SMTP id i132mr393678wmd.101.1523957434195; Tue, 17 Apr 2018 02:30:34 -0700 (PDT) Received: from bender.baylibre.local ([90.63.244.31]) by smtp.gmail.com with ESMTPSA id r19sm12932082wrg.8.2018.04.17.02.30.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 17 Apr 2018 02:30:33 -0700 (PDT) From: Neil Armstrong To: trini@konsulko.com, u-boot@lists.denx.de Date: Tue, 17 Apr 2018 11:30:31 +0200 Message-Id: <1523957431-16612-1-git-send-email-narmstrong@baylibre.com> X-Mailer: git-send-email 2.7.4 Cc: linux-amlogic@lists.infradead.org Subject: [U-Boot] [PATCH] clk: fix clk_get_bulk when phandle error X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" This fixes the Coverity Defect CID 175347 when dev_count_phandle_with_args() returns a negative value. Fixes: a855be87da49 ("clk: Add get/enable/disable/release for a bulk of clocks") Signed-off-by: Neil Armstrong --- drivers/clk/clk-uclass.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c index 6e99b3b..53f418b 100644 --- a/drivers/clk/clk-uclass.c +++ b/drivers/clk/clk-uclass.c @@ -111,8 +111,8 @@ int clk_get_bulk(struct udevice *dev, struct clk_bulk *bulk) bulk->count = 0; count = dev_count_phandle_with_args(dev, "clocks", "#clock-cells"); - if (!count) - return 0; + if (count < 1) + return count; bulk->clks = devm_kcalloc(dev, count, sizeof(struct clk), GFP_KERNEL); if (!bulk->clks)