From patchwork Fri Jan 26 13:24:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakob Meng X-Patchwork-Id: 1891315 X-Patchwork-Delegate: horms@verge.net.au Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=LLc2cMNA; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TLz2X36Cfz23fD for ; Sat, 27 Jan 2024 00:25:08 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 087BE81EAA; Fri, 26 Jan 2024 13:25:03 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 087BE81EAA Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=LLc2cMNA X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1TZhkVG9mIWD; Fri, 26 Jan 2024 13:25:02 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 2E79381E77; Fri, 26 Jan 2024 13:25:01 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 2E79381E77 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A1418C0072; Fri, 26 Jan 2024 13:25:00 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id C1EA4C0037 for ; Fri, 26 Jan 2024 13:24:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 9132C60EE2 for ; Fri, 26 Jan 2024 13:24:58 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 9132C60EE2 Authentication-Results: smtp3.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=LLc2cMNA X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dM8swfFp4kbG for ; Fri, 26 Jan 2024 13:24:58 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id C82B860B53 for ; Fri, 26 Jan 2024 13:24:57 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org C82B860B53 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706275496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cf0VdJJB9lujFc8+rqxnjY2y/2RAM27ZH4cqfD9O288=; b=LLc2cMNAWE6CalLPhML6Ia1dbZejEoe/0YRYSsRgsnxakrfs+73Kc7nuQrdCG0VPIlwLYJ nPU52UupUNHuOJbEYqw4QB96bezs7iRXuqTu6Bg6PDzJuOyZov5OkKZECdp2yM+SIQ1dNg UolfdsRP+MMY2qJSeIMes3nBKCc7Gnk= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-349-dCLHIBaDOKq7hUKGmKoS2Q-1; Fri, 26 Jan 2024 08:24:55 -0500 X-MC-Unique: dCLHIBaDOKq7hUKGmKoS2Q-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-40e9d8e9a39so7391715e9.0 for ; Fri, 26 Jan 2024 05:24:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706275494; x=1706880294; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cf0VdJJB9lujFc8+rqxnjY2y/2RAM27ZH4cqfD9O288=; b=QBSnMgmPntSm/5Fr3cdGJmlif0276oFMCusHhu8n8rS5z/oVo5OBRjXTHf329XEZsi Vi/qfygBLHukpS9f35Mx+dJnKkI41yNPzFtcjaD5hZ5yrn8Lp1+vU2+qb+pKlvH4VyU6 F2zT5HnZ86oJP8hYPuyG/0PPUUTEP6UJrsKWbCc8IdZnejAUuxJX6eVwPI83SrTQfTBi ek7vIpnnlahpXDZFAnoKLq3/sBIppP5ORrCWuUK6vASxvBCiCCSebp7z5oVdWYN8y6Th gw+4pC013ugU/kfFmPYdIg/ovPvkx85YKVapGulJ7pfDxdvZCGykMCueHNFPt3JD8iyB ypYQ== X-Gm-Message-State: AOJu0YyzNoJjyTpbPtoU4Gms/NVLtgMKs1kJHt6Myv5PUxRQTU7uNgG1 PWiQ8j88YcC0QDIkoNXCVStvWGLfiU5j2DuvqRlwYAmUV/e8o4cItOgm4EOasxlF9bwKefPVK1g baUN5OfprBB9Flq7XX77ATt7ne55gB+PJ2FaqJg3GyxNu4h1bpXYnSiJ6/P0rOyU5h1fiUK83mh wzBzqyaS/jfkufGLV1vKJqauNPGqJl X-Received: by 2002:a05:600c:3d0a:b0:40e:4e95:c3 with SMTP id bh10-20020a05600c3d0a00b0040e4e9500c3mr904685wmb.73.1706275494571; Fri, 26 Jan 2024 05:24:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IGOynmc4Z43jjT8DkhgUaJJ1Wm77u1ktK2xzT+6Dh7Y27DPt2Y5RdtDMLXyo2sBrnI4SHhkqw== X-Received: by 2002:a05:600c:3d0a:b0:40e:4e95:c3 with SMTP id bh10-20020a05600c3d0a00b0040e4e9500c3mr904673wmb.73.1706275494204; Fri, 26 Jan 2024 05:24:54 -0800 (PST) Received: from positronik4lide.redhat.com ([87.122.59.226]) by smtp.gmail.com with ESMTPSA id bk7-20020a0560001d8700b0033addbf2d2csm679995wrb.9.2024.01.26.05.24.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 05:24:53 -0800 (PST) From: jmeng@redhat.com To: dev@openvswitch.org, i.maximets@ovn.org, amusil@redhat.com Date: Fri, 26 Jan 2024 14:24:51 +0100 Message-Id: <20240126132451.25157-1-jmeng@redhat.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [ovs-dev] [PATCH v2] dpif-netdev: Increase MAX_RECIRC_DEPTH to 8. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" From: Jakob Meng In a scenario where OVN does load balancing and then SNAT with a OVS userspace datapath [0], the recirc_depth may be greater than 6. In that case, ovs-vswitchd might drop packets and raise warnings: dpif_netdev|WARN|Packet dropped. Max recirculation depth exceeded. Increasing MAX_RECIRC_DEPTH to 8 solves this issue. [0] https://github.com/ovn-org/ovn/blob/dd5cd73e3df1bfb1a215cb45d1e2e03eff1d049a/tests/system-ovn-kmod.at#L740 Reported-at: https://issues.redhat.com/browse/FDP-251 Signed-off-by: Jakob Meng Acked-by: Simon Horman --- lib/dpif-netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index c1981137f..46e24d204 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -99,7 +99,7 @@ VLOG_DEFINE_THIS_MODULE(dpif_netdev); #define FLOW_DUMP_MAX_BATCH 50 /* Use per thread recirc_depth to prevent recirculation loop. */ -#define MAX_RECIRC_DEPTH 6 +#define MAX_RECIRC_DEPTH 8 DEFINE_STATIC_PER_THREAD_DATA(uint32_t, recirc_depth, 0) /* Use instant packet send by default. */