From patchwork Thu Jan 25 00:38:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Pinski X-Patchwork-Id: 1890431 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=quicinc.com header.i=@quicinc.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=eslIRoIJ; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TL24j68myz23f0 for ; Thu, 25 Jan 2024 11:38:45 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5D0B43858422 for ; Thu, 25 Jan 2024 00:38:43 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by sourceware.org (Postfix) with ESMTPS id E9DBE3858416 for ; Thu, 25 Jan 2024 00:38:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E9DBE3858416 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=quicinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E9DBE3858416 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706143101; cv=none; b=odeuO0ClSCbKL19Nf92vcjF0KBprRhSiHV8BKYly5SNVCHouZf4omVEVl3oj2D39FdWZSYUaTkKT9bl2MO9Ov/NUO7/vSZkiNkT2owUEJRdCq94tQS96MAs4zqhTqITY1c5/IWzyRYHbfP4OWqfPhtQKTd1Vv7YlbnnlQKPbp1U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706143101; c=relaxed/simple; bh=fAg7N2uCt16DoC7WFaX2+yASzB/5zcbK4iR8Z31Z/Dk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=NxKOohA7oK/3DfgtowhpzrRor13Vzloxp1EtT9+TBkiKmRSHM0+DQUpVQzBLuFXtWWS/FKHednI2uQB6RQUjsnKDQe++2m9gJdlJV1W4ASUZocwGT+zdE47d77x9WPdQ2hj+58u259QiBdDaCV9JTAlumOKy+Q22imwik/AKKJk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40P0C4GE016469 for ; Thu, 25 Jan 2024 00:38:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding:content-type; s=qcppdkim1; bh=ekyIYoR hoIwZJrVLhy7zo354l9KUOis5mq2GqjF1YVw=; b=eslIRoIJP/gaZzqZE4JdCW9 i2JKqSmctwzR6Y9DbHtqYQfLH/ZKx72WW4QF5jcWonHHPRwSnSyhgetoUPpCJAlF MFP++sdNCGmtBWdnkyFdsVbTUIz9cpsU6UjLu43ltK/ewgms/S1CZtxlXbcgkAe1 T914BB3/r+oYG0POYgS5YlNmzPWvmb+oLiy9g4Duju9EYeT48Z5HJiNjQrvTCVMV fQVCeFiZpVfIVHbtr8HRLm1PxeY1Cycgux+CfBHSdLHfaXB/rPOsAK8/rCXCZb7n 0gsUxIgcmeLKIPRx9jEvtBfzQGWe6DXQrqyBoCCrPoGNplvmiJlHJPAJ///oeag= = Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3vu81g8nwh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 25 Jan 2024 00:38:17 +0000 (GMT) Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 40P0cG6P008739 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 25 Jan 2024 00:38:16 GMT Received: from hu-apinski-lv.qualcomm.com (10.49.16.6) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Wed, 24 Jan 2024 16:38:16 -0800 From: Andrew Pinski To: CC: Andrew Pinski Subject: [COMMITTED] Fix check_effective_target_vect_long_mult Date: Wed, 24 Jan 2024 16:38:04 -0800 Message-ID: <20240125003804.4176747-1-quic_apinski@quicinc.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01a.na.qualcomm.com (10.47.209.196) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: MoiaY9AxevQgX75XnVCF3BRroGw9F4sZ X-Proofpoint-ORIG-GUID: MoiaY9AxevQgX75XnVCF3BRroGw9F4sZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-24_12,2024-01-24_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 suspectscore=0 phishscore=0 adultscore=0 spamscore=0 malwarescore=0 impostorscore=0 mlxscore=0 mlxlogscore=921 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401190000 definitions=main-2401250002 X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org My last commit I tested on aarch64 but vect_long_mult was not actually invoked and I didn't notice that I was missing a `[` in front of check_effective_target_aarch64_sve. When I ran the testsuite on x86_64, I got the failure. Committed as obvious after testing on x86_64. gcc/testsuite/ChangeLog: * lib/target-supports.exp (check_effective_target_vect_long_mult): Fix small typo for aarch64*-*-*. Signed-off-by: Andrew Pinski --- gcc/testsuite/lib/target-supports.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp index 82520119026..49e748caf17 100644 --- a/gcc/testsuite/lib/target-supports.exp +++ b/gcc/testsuite/lib/target-supports.exp @@ -9092,7 +9092,7 @@ proc check_effective_target_vect_long_mult { } { || ([istarget sparc*-*-*] && [check_effective_target_ilp32]) || ([istarget aarch64*-*-*] && ([check_effective_target_ilp32] - || check_effective_target_aarch64_sve])) + || [check_effective_target_aarch64_sve])) || ([istarget mips*-*-*] && [et-is-effective-target mips_msa]) || ([istarget riscv*-*-*]