From patchwork Fri Jan 12 08:50:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1885907 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=bivzWVFe; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=CFhCyVQZ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=bivzWVFe; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=CFhCyVQZ; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TBFcf0syQz1yP3 for ; Fri, 12 Jan 2024 19:50:58 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1EAB0385840E for ; Fri, 12 Jan 2024 08:50:56 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id AFD3C3858C66 for ; Fri, 12 Jan 2024 08:50:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AFD3C3858C66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AFD3C3858C66 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705049430; cv=none; b=GvJ4NKqKn+u2IwQF6xJ3hDIIvrqn/6aO3ntwXS9QyG1UY0d1UPvWFWbo5Kx/vjazacztYjO1DZ/Oz3U3KAzqy596DJEXvTlYWRTnh7CR/PLMWLZrq3vw95kgQojwdWqYwC/Tbt9UPIB5Js8hShPH4plm5XFETQd7P+6/wSrfNg4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705049430; c=relaxed/simple; bh=M6Zg/KWOQHJ87xnnjLPubpAiWabKgHZ1d3kgYexih+4=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version:Message-Id; b=ZQcEG4JT33xPeD7r+NBJPvqHgFOJK8c6fZbKIDuAp8vH49j4rkphh+SQBcBesyI2FbwrkROtiykBg4xEmZIJAk1ztJp/rKPzSSGmicKt4TbX26rn07jv3rO+uH7t4o8YITc5b0MZV2hXPCRA+UWP6shDl7ue98FltgOkscLLA04= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 803BA1FC0D for ; Fri, 12 Jan 2024 08:50:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1705049425; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=fRtsWIZfaAyjgd9e3rE93DXNcHmtZejtGg4AWn0CECI=; b=bivzWVFe4Fs13d0s8ijQgvsYYGGZihyiFOGpBo5l7NKvotU8qD0JLFxKRdKKONAVq4l6LG vuNlFvL3FIzG8IAhqlczHfH6xZp5atADGIvp+oFuOXQ8jrESEsnUIeLR4ziZzM8uhwF2Sy Jbbn/Fa3UoVD4dTlVS4bLGpNi4J9VW8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1705049425; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=fRtsWIZfaAyjgd9e3rE93DXNcHmtZejtGg4AWn0CECI=; b=CFhCyVQZCfEYDNaAWkTMxzjYBC5ir01MBKPSvKnnVwpvUj58olcQWUVmUFeZwBZM4SoWNs /0vVyO9/STRe8BAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1705049425; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=fRtsWIZfaAyjgd9e3rE93DXNcHmtZejtGg4AWn0CECI=; b=bivzWVFe4Fs13d0s8ijQgvsYYGGZihyiFOGpBo5l7NKvotU8qD0JLFxKRdKKONAVq4l6LG vuNlFvL3FIzG8IAhqlczHfH6xZp5atADGIvp+oFuOXQ8jrESEsnUIeLR4ziZzM8uhwF2Sy Jbbn/Fa3UoVD4dTlVS4bLGpNi4J9VW8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1705049425; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=fRtsWIZfaAyjgd9e3rE93DXNcHmtZejtGg4AWn0CECI=; b=CFhCyVQZCfEYDNaAWkTMxzjYBC5ir01MBKPSvKnnVwpvUj58olcQWUVmUFeZwBZM4SoWNs /0vVyO9/STRe8BAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 641DA136A4 for ; Fri, 12 Jan 2024 08:50:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Ifu5FlH9oGUuKgAAD6G6ig (envelope-from ) for ; Fri, 12 Jan 2024 08:50:25 +0000 Date: Fri, 12 Jan 2024 09:50:16 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] middle-end/113344 - is_truth_type_for vs GENERIC tcc_comparison MIME-Version: 1.0 Message-Id: <20240112085025.641DA136A4@imap1.dmz-prg2.suse.org> Authentication-Results: smtp-out2.suse.de; none X-Spam-Level: X-Spam-Score: -1.31 X-Spamd-Result: default: False [-1.31 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[gcc-patches@gcc.gnu.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.01)[45.45%] X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org On GENERIC tcc_comparison can have int type so restrict the PR113126 fix to vector types. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR middle-end/113344 * match.pd ((double)float CMP (double)float -> float CMP float): Perform result type check only for vectors. * fold-const.cc (fold_binary_loc): Likewise. --- gcc/fold-const.cc | 2 +- gcc/match.pd | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/fold-const.cc b/gcc/fold-const.cc index 9feb31f5c8b..594ea843d9c 100644 --- a/gcc/fold-const.cc +++ b/gcc/fold-const.cc @@ -12901,7 +12901,7 @@ fold_binary_loc (location_t loc, enum tree_code code, tree type, newtype = TREE_TYPE (targ1); if (element_precision (newtype) < element_precision (TREE_TYPE (arg0)) - && is_truth_type_for (newtype, type)) + && (!VECTOR_TYPE_P (type) || is_truth_type_for (newtype, type))) return fold_build2_loc (loc, code, type, fold_convert_loc (loc, newtype, targ0), fold_convert_loc (loc, newtype, targ1)); diff --git a/gcc/match.pd b/gcc/match.pd index 0bcf3153ff2..e42ecaf9ec7 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -6799,7 +6799,7 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) ? TREE_TYPE (@00) : type1); } (if (element_precision (TREE_TYPE (@0)) > element_precision (newtype) - && is_truth_type_for (newtype, type)) + && (!VECTOR_TYPE_P (type) || is_truth_type_for (newtype, type))) (cmp (convert:newtype @00) (convert:newtype @10))))))))