From patchwork Wed Jan 10 16:44:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Maciej Nowak X-Patchwork-Id: 1885049 X-Patchwork-Delegate: robimarko@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=L7WjUF+7; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=terefe.re header.i=@terefe.re header.a=rsa-sha256 header.s=default header.b=wwBtYyHT; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4T9DHK59D2z1yPp for ; Thu, 11 Jan 2024 03:47:25 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Ba0lj5mbQUhQLDVFEcGrTbclHPx7c0Wq452V0thySUg=; b=L7WjUF+7WruJUU 9scrkj18GUUD7X10ZMsb9ANkjYRz/BOkthhWlkmLL7A+lDlFjezR8WAvGhhQJnvnv46Chece9RxZN uTvgRUAvdKwEU/sTMujw/nMbeBurAeyS91qoGKSu5zSV3Y2TVjawzucZyBldtNO9z8esszs/a7ZqY A9LRLXe01qniRgLbxXNhp4G4fO2EXABXEkkefhqVJ162AOk6K6jLx7EcUig0w+7A2WGHmkRdUMddA zxzpkTXJw45soQN5LoqaJymGLUr9d0C5Zg7ZT/cKxaeXUOvzJXU7hwGHOj1hAoo/U4ObjeW3a2jKb TB35v590ZtC02xHkBQvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNbhT-00Cyx2-07; Wed, 10 Jan 2024 16:45:07 +0000 Received: from terefe.re ([5.255.96.200]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNbhP-00CyvV-1a for openwrt-devel@lists.openwrt.org; Wed, 10 Jan 2024 16:45:05 +0000 Received: from localhost.localdomain (unknown [212.106.161.103]) by terefe.re (Postfix) with ESMTPSA id E12601FFD8; Wed, 10 Jan 2024 17:44:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=terefe.re; s=default; t=1704905100; bh=pj3upqeo5H0H1nfLx90mCm7K++Oj6lGWNoqXkFGXW4g=; h=From:To:Cc:Subject:Date:From; b=wwBtYyHTron4WxO/7kfcdjmwO9k8rniaG/aO/YMLR1J8EKsWCNGeypAteJHtflGR9 BbmrFjoo27QJRqvltq36U/fQ4U3uJf5mz/NB7fEAEHVw67sV9kfDUXBX/fjWFdpXop V8ZyJAf7L+GClISY7qCcvfWKsOYV65wgFhgFk3lIVtRAXDGnCC+ma2x7cY+/npvKQr kCxsqkfTXj2+EdX2erAVvxClj5TjCWMNJV6Xr/7xByVKHr85nduw5eBPvwU/U6xUlU j7Au08RULdAPvvi5v6ftveveOFg1STGuQz5gpEr1Ng7aK1bLY5sOeYpPR/5+yMs9L5 KjN+O+19FFemg== From: Tomasz Maciej Nowak To: openwrt-devel@lists.openwrt.org Cc: Tomasz Maciej Nowak Subject: [PATCH] mvebu: fill additional info for mvneta tx queue workaround patch Date: Wed, 10 Jan 2024 17:44:48 +0100 Message-ID: <20240110164448.4526-1-tmn505@terefe.re> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240110_084503_665495_4C9F0E36 X-CRM114-Status: UNSURE ( 7.29 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Tomasz Maciej Nowak Because some still unresolved bugs in this driver, which sprout occasional questions what this patch works around, point to the issue which started this. Being here, fill headers required by git am. Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org From: Tomasz Maciej Nowak Because some still unresolved bugs in this driver, which sprout occasional questions what this patch works around, point to the issue which started this. Being here, fill headers required by git am. Signed-off-by: Tomasz Maciej Nowak --- .../mvebu/patches-5.15/700-mvneta-tx-queue-workaround.patch | 5 +++++ .../mvebu/patches-6.1/700-mvneta-tx-queue-workaround.patch | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/target/linux/mvebu/patches-5.15/700-mvneta-tx-queue-workaround.patch b/target/linux/mvebu/patches-5.15/700-mvneta-tx-queue-workaround.patch index 32e8ef4b7d87..039dbc06dd04 100644 --- a/target/linux/mvebu/patches-5.15/700-mvneta-tx-queue-workaround.patch +++ b/target/linux/mvebu/patches-5.15/700-mvneta-tx-queue-workaround.patch @@ -1,3 +1,6 @@ +From: Felix Fietkau +Subject: mvneta: tx queue workaround + The hardware queue scheduling is apparently configured with fixed priorities, which creates a nasty fairness issue where traffic from one CPU can starve traffic from all other CPUs. @@ -5,6 +8,8 @@ CPU can starve traffic from all other CPUs. Work around this issue by forcing all tx packets to go through one CPU, until this issue is fixed properly. +Ref: https://github.com/openwrt/openwrt/issues/5411 + Signed-off-by: Felix Fietkau --- --- a/drivers/net/ethernet/marvell/mvneta.c diff --git a/target/linux/mvebu/patches-6.1/700-mvneta-tx-queue-workaround.patch b/target/linux/mvebu/patches-6.1/700-mvneta-tx-queue-workaround.patch index 15762be81d40..f80d4e301ada 100644 --- a/target/linux/mvebu/patches-6.1/700-mvneta-tx-queue-workaround.patch +++ b/target/linux/mvebu/patches-6.1/700-mvneta-tx-queue-workaround.patch @@ -1,3 +1,6 @@ +From: Felix Fietkau +Subject: mvneta: tx queue workaround + The hardware queue scheduling is apparently configured with fixed priorities, which creates a nasty fairness issue where traffic from one CPU can starve traffic from all other CPUs. @@ -5,6 +8,8 @@ CPU can starve traffic from all other CPUs. Work around this issue by forcing all tx packets to go through one CPU, until this issue is fixed properly. +Ref: https://github.com/openwrt/openwrt/issues/5411 + Signed-off-by: Felix Fietkau --- --- a/drivers/net/ethernet/marvell/mvneta.c