From patchwork Mon Dec 18 13:42:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xi Ruoyao X-Patchwork-Id: 1877461 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xry111.site header.i=@xry111.site header.a=rsa-sha256 header.s=default header.b=k3niEIdu; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Sv1HY0K04z23yc for ; Tue, 19 Dec 2023 00:43:21 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 11A3A3857C56 for ; Mon, 18 Dec 2023 13:43:19 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id 34FD93858034 for ; Mon, 18 Dec 2023 13:43:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 34FD93858034 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 34FD93858034 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=89.208.246.23 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702906988; cv=none; b=OwEvaCMNHnAbXRv5qmj8y3Y4t/Ay7V5U0qJUh76RaOER9mKJlbbrLil2Z0DLTG9n6uRjRGdc8Ind0EVfezCC/PtlAGM76DNhVCv/6xiIbeNz0IwvtIoQDExx4WMHCCrKD7dyyXQx8+Yc0Wd1bkAmE0nMOlJiDHOGVMlbGd6j1Bw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702906988; c=relaxed/simple; bh=i1m6ndtyHZidHsIYiDVo0dXf6MdTwwQU1xYYVgURp3w=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=D0l4LggiTOw2HWJ4MCjZaA5gXuRrDRVeVyhaQe/+ri9bGHVaMSxdB32zPdEVAwYGK6kYhk7+5FrHfe6hQ8EXQlyqPOCSnGRzkr/PAKPoJa/fl9rpxI2gP1OX4tqUSvada6ORy04rJrNkqagCmZUqKtjnLOYW6QTDhOlb7Af8pYs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1702906986; bh=i1m6ndtyHZidHsIYiDVo0dXf6MdTwwQU1xYYVgURp3w=; h=From:To:Cc:Subject:Date:From; b=k3niEIduGrPT+fzzafZXadu0oE3s9v0VtLccOV2pS+6caRu0EJ3Pbup2CB/3umCG4 S2Kc+JmJBcqLnxvvaguaAexK8GLiuQvX72zvf+aWkBPrRM2cpQ7tlYEwfp8zOd6ACY wfLA5dWsfcJzi5yQ+0nkojf20jGuua08jWGSb0+s= Received: from stargazer.. (unknown [113.200.174.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id BF9DF670CB; Mon, 18 Dec 2023 08:43:03 -0500 (EST) From: Xi Ruoyao To: gcc-patches@gcc.gnu.org Cc: Jakub Jelinek , chenglulu , i@xen0n.name, xuchenghua@loongson.cn, c@jia.je, Xi Ruoyao Subject: [PATCH] middle-end: Call negate_rtx instead of simplify_gen_unary expanding rotate shift [PR113033] Date: Mon, 18 Dec 2023 21:42:02 +0800 Message-ID: <20231218134251.1513432-1-xry111@xry111.site> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, LIKELY_SPAM_FROM, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org With simplify_gen_unary we end up with a not fully expanded RTX like (set (reg:SI 90) (and:SI (neg:SI (reg:SI 80)) (const_int 63))) Then it will cause an ICE with unrecognizable insn. gcc/ChangeLog: PR middle-end/113033 * expmed.cc (expand_shift_1): When expanding rotate shift, call negate_rtx instead of simplify_gen_unary (NEG, ...). --- Bootstrapped and regtested on x86_64-linux-gnu and loongarch64-linux-gnu. Ok for trunk? gcc/expmed.cc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/gcc/expmed.cc b/gcc/expmed.cc index 05331dd5d82..f9e416b9549 100644 --- a/gcc/expmed.cc +++ b/gcc/expmed.cc @@ -2634,9 +2634,7 @@ expand_shift_1 (enum tree_code code, machine_mode mode, rtx shifted, (mode, GET_MODE_BITSIZE (scalar_mode) - INTVAL (op1)); else { - other_amount - = simplify_gen_unary (NEG, GET_MODE (op1), - op1, GET_MODE (op1)); + other_amount = negate_rtx (GET_MODE (op1), op1); HOST_WIDE_INT mask = GET_MODE_PRECISION (scalar_mode) - 1; other_amount = simplify_gen_binary (AND, GET_MODE (op1), other_amount,