From patchwork Fri Dec 8 16:20:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinayak Yadawad X-Patchwork-Id: 1873863 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=q6zjfAYw; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=IPurjIvA; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=ERxLd6Hv; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SmxH16x11z23mf for ; Sat, 9 Dec 2023 03:21:47 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=6XqSZMNraeBJeX8UIV+HmxVxH8z8lbuQS7UWX5j8aOk=; b=q6z jfAYwjXudDsihvzaOSbIZeQ+QrGJ1NadS4oZYyscNpTSQjkWfdWff+BeLIL5hu6NZJO33BrjN2a2N IGKGZtyii2lAQs21KALX6qvwWrgPo6Esrnf7KNSCBuvhqbjS7wG7HHNdSV2UzNUMSbCEPcCZcY5hv bew5A2faOtefb+/xCZwV7HluQPik25O/oTsoLQRSE6HMVOvGN43tY6VwO4z3SW5Q9kCE0PjrttVGx cYGAirNc/AT4ru16g7mNmVZsymSihNorEqiuxIqaymtL69ELiwQrjbKWrmtzbbESXrtivYAPJnmRe mh41xwXvrIAhOkU6ultiWRNMPPd2cWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rBdar-00G00i-0F; Fri, 08 Dec 2023 16:20:49 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rBdao-00G00S-0h for hostap@bombadil.infradead.org; Fri, 08 Dec 2023 16:20:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:In-Reply-To:References; bh=Kq2IMmLyya8OgK0Gm7HVZgzTL0hGo/Ew9hnpg8Q7Gvo=; b=IPurjIvAqwsJRbDCrGPjucOng6 H01GawtrLnpElEQdPjkPOvUQD+Wt37L+ntTM2SI2QoFQ9Yic1NJK7QNF15wS38BiYPadkeObP/GVV ORLTaQtKTMj7eqD8nSlLEEFc0LzYr9M2frmQAxGgL364IZ3nEJwckAY6P617JVDu8l5Cr+hxJ54Ru zK4OAmS2Q8mzMnntRXf5iu4GumivETn96NLUzhTBvsv2bj8tAwSJCiQEj/pjxRftWkVP6Wp85DF2g viwrscBqB8bFNW/S6o+4NGz84ob6uRIKj1SJbmnkWFW40oW6p2zQRuwsnjFJxBBItoQk/9dEJzMdk nh+Yv6uQ==; Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rBdah-006dch-1Z for hostap@lists.infradead.org; Fri, 08 Dec 2023 16:20:44 +0000 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1d05212a7c5so16963685ad.0 for ; Fri, 08 Dec 2023 08:20:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1702052434; x=1702657234; darn=lists.infradead.org; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=Kq2IMmLyya8OgK0Gm7HVZgzTL0hGo/Ew9hnpg8Q7Gvo=; b=ERxLd6Hv4/ucJA4mFekcENTO5WyGi5Bt6HvyIsnUoiWEDElNNkZROrUrdyQzaDpmB1 achhcnQe55VtdfvcYCHlw+m9QbAGodNi53PD+mUF5zE6SLZW0XpodVv4mNiNV/4bkY1i zcUgCAByvINao/FHJmjx1cZF1BmfegVIXiMZ4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702052434; x=1702657234; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Kq2IMmLyya8OgK0Gm7HVZgzTL0hGo/Ew9hnpg8Q7Gvo=; b=hpPDiTLrjMtMjdWYylitoULwRNitakWpOZppJ6iezXDUzjxBVwpdkZd+te56GnAajV zt/PXLCUwoKCcD6huwTQr58EY1M28SzbGJT4syRqSV2Qjl9H5egc9f4F+HAQTPhU1PgC UvwAxRy+EEkrMHC0pxmyOJ6XgeJwLux2/LSbYfX7f+TygyiImiGaqSiesQvw05vGHuIQ IXmzAv1QYoA5QgwnqQ9RX1YM+M3qeXm5ZY1lpPU4+Actepf2vv6Md3oqj3KmEPAQpMwU ZRhKkUDlqyoqOY+qT+CdkQ6bDSYcNEP1k5nhJCoTQC6nikMiILv/kr1NKe0ruf+tG/BP bl9w== X-Gm-Message-State: AOJu0Yy18exSl7UDUHsSrtFddHMmwiM2Aq3OCdO9WVj6O8kMQeq0zxRb 4TsTX+OVNQzVOYPrhg7qDOA/6VoYxU7fXv7C10l/S1UG1C6CWfUCGyrtnFn4fOI4i3fBNocGBrB MmAc3vrQC8ABcjcZTX47wlp0lxtw8NZXRiztL6eiDWGFUE8KCkhI0OoMVVo0bf1zQcUSqTECtir PS7YB+w6mrTkLN+A== X-Google-Smtp-Source: AGHT+IFP4n+biZUm3TLn60qP4BqXLm/vVcuABomxMwcODEcEiRcmeu42W8JWE7zo8biHmCFKjUar/A== X-Received: by 2002:a17:902:c215:b0:1d0:a084:affd with SMTP id 21-20020a170902c21500b001d0a084affdmr229357pll.73.1702052434244; Fri, 08 Dec 2023 08:20:34 -0800 (PST) Received: from ibnvda0196.ibn.broadcom.net ([192.19.252.250]) by smtp.gmail.com with ESMTPSA id d11-20020a170902c18b00b001bc6e6069a6sm1883020pld.122.2023.12.08.08.20.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Dec 2023 08:20:33 -0800 (PST) From: Vinayak Yadawad To: hostap@lists.infradead.org Cc: jithu.jance@broadcom.com, Vinayak Yadawad Subject: [PATCH 1/1] hostapd: Use attribute NL80211_ATTR_BSSID to trigger scan for specifc BSSID Date: Fri, 8 Dec 2023 21:50:23 +0530 Message-Id: X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231208_162040_443901_2CB44A11 X-CRM114-Status: GOOD ( 12.61 ) X-Spam-Score: 0.8 (/) X-Spam-Report: Spam detection software, running on the system "desiato.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: With changes to optimize scan for specific BSSID, there arises a scenario where in nl80211_trigger_scan is called with a scan randomization enabled. A combination of NL80211_ATTR_MAC and scan randomiz [...] Content analysis details: (0.8 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:635 listed in] [list.dnswl.org] 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 1.0 MIME_NO_TEXT No (properly identified) text body parts -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org With changes to optimize scan for specific BSSID, there arises a scenario where in nl80211_trigger_scan is called with a scan randomization enabled. A combination of NL80211_ATTR_MAC and scan randomization results in invalid error for the scan request. In order to fix the issue we use attribute NL80211_ATTR_BSSID instead of NL80211_ATTR_MAC. Signed-off-by: Vinayak Yadawad --- src/drivers/driver_nl80211_scan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/drivers/driver_nl80211_scan.c b/src/drivers/driver_nl80211_scan.c index 736db6406..ebedb01c6 100644 --- a/src/drivers/driver_nl80211_scan.c +++ b/src/drivers/driver_nl80211_scan.c @@ -385,7 +385,7 @@ int wpa_driver_nl80211_scan(struct i802_bss *bss, if (params->bssid) { wpa_printf(MSG_DEBUG, "nl80211: Scan for a specific BSSID: " MACSTR, MAC2STR(params->bssid)); - if (nla_put(msg, NL80211_ATTR_MAC, ETH_ALEN, params->bssid)) + if (nla_put(msg, NL80211_ATTR_BSSID, ETH_ALEN, params->bssid)) goto fail; }