From patchwork Thu Apr 12 01:48:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jia-Ju Bai X-Patchwork-Id: 897448 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Fos2qA4X"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40M3j92Dkcz9s0n for ; Thu, 12 Apr 2018 11:48:45 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752638AbeDLBsc (ORCPT ); Wed, 11 Apr 2018 21:48:32 -0400 Received: from mail-pl0-f68.google.com ([209.85.160.68]:35041 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751633AbeDLBsb (ORCPT ); Wed, 11 Apr 2018 21:48:31 -0400 Received: by mail-pl0-f68.google.com with SMTP id 61-v6so2742906plb.2; Wed, 11 Apr 2018 18:48:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=cXGGCcswwRTAWT71jF/xG8H5hThQXfOhy+EIAOWYthg=; b=Fos2qA4XKWyqDNYqwKd1tHpbL3VjlhtGn0QZLSMgQA7gr62slobf1FeSM1rii6tJpZ t3hVKkLADfBkZk0y5lHoC5mozloUxCUQLZUO5uwttvYuJNO7q14I9kjcSkw8K9rVI3U8 1shB4U4b/MO2gNuo60YJOLblOafG9cnu8kZ5fg/9ZAy1KYIZ79OIAik/a48sNY2makQ0 mfywrw4qIUTW43F+CRl6f3Kj3cU3lG6kr31H9iKikpIKCwkv0ogvh42tnTFyDZqe3USA Trfv/i96nhPA3+RawNzHjaUh7Ynr3OhRWAASdyKuQw0IsTQODW/i4O1xuNIW4Kh+dZMx Jgpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=cXGGCcswwRTAWT71jF/xG8H5hThQXfOhy+EIAOWYthg=; b=pmkggGt6/INApBj1Wf5OiL8Vfq/EGy6yrZwYRFr/EU1uYk0ijvUT17Y3EULCK8vBlS 2DMwK0COXH0x/6Xr/Fzmj6FBRDtyPK5Ap4oL+iF1GrI2Hyju7rhP9tGrlyGHgVxoyngG D2HUwItuhOw9mNVtd5iS95Q850jRDHSiUqe36nxpc3JubFB5k27X8QhxvXLejwoEapSm vxNyT2nRDQlwYmXXbUqa+qjVEstMS3AZ4Hy+HPmNuKtDmSkz3JT3KzC6qJ0x0JUYFJy+ n+NH4yLVSkRgHibA7laKTd5Mwhwu2XyX4WtKd9EbCsgzI6D4ZFfhL9Z15wkscROORZ4/ VnfA== X-Gm-Message-State: ALQs6tDiURWDo6jRc9Mh43j5AWYPbhlS+UTiZ2oJ68Ll0hF84jK80Su1 tQneafSqcmUeCOn7WeGkKvg= X-Google-Smtp-Source: AIpwx48Dsz0GjBMKEKdXGKtAJYAGzbwbHc8avXc1lwJ5RxxTljX0g8l9MtS8dU16zgx/m4es1XfCiw== X-Received: by 2002:a17:902:a704:: with SMTP id w4-v6mr3264706plq.5.1523497710567; Wed, 11 Apr 2018 18:48:30 -0700 (PDT) Received: from oslab.tsinghua.edu.cn ([2402:f000:1:4413:e50f:6d1:658e:8ac3]) by smtp.gmail.com with ESMTPSA id m185sm5169532pfc.88.2018.04.11.18.48.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 11 Apr 2018 18:48:30 -0700 (PDT) From: Jia-Ju Bai To: f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, preid@electromag.com.au Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH v2] net: dsa: b53: Using sleep-able operations in b53_switch_reset_gpio Date: Thu, 12 Apr 2018 09:48:22 +0800 Message-Id: <1523497702-7200-1-git-send-email-baijiaju1990@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org b53_switch_reset_gpio() is never called in atomic context. The call chain ending up at b53_switch_reset_gpio() is: [1] b53_switch_reset_gpio() <- b53_switch_reset() <- b53_reset_switch() <- b53_setup() b53_switch_reset_gpio() is set as ".setup" in struct dsa_switch_ops. This function is not called in atomic context. Despite never getting called from atomic context, b53_switch_reset_gpio() calls non-sleep operations mdelay() and gpio_set_value(). They are not necessary and can be replaced with msleep() and gpio_set_value_cansleep(). This is found by a static analysis tool named DCNS written by myself. And I also manually check it. Signed-off-by: Jia-Ju Bai Reviewed-by: Phil Reid Acked-by: Florian Fainelli --- v2: * Use gpio_set_value_cansleep() to replace gpio_set_value() additionally. Thanks for Florian and Phil for good advice. --- drivers/net/dsa/b53/b53_common.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c index 274f367..36cc60d 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -596,11 +596,11 @@ static void b53_switch_reset_gpio(struct b53_device *dev) /* Reset sequence: RESET low(50ms)->high(20ms) */ - gpio_set_value(gpio, 0); - mdelay(50); + gpio_set_value_cansleep(gpio, 0); + msleep(50); - gpio_set_value(gpio, 1); - mdelay(20); + gpio_set_value_cansleep(gpio, 1); + msleep(20); dev->current_page = 0xff; }