From patchwork Wed Apr 11 03:33:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jia-Ju Bai X-Patchwork-Id: 897013 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="lbedUH/X"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40LV533l6pz9s3B for ; Wed, 11 Apr 2018 13:33:59 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752591AbeDKDds (ORCPT ); Tue, 10 Apr 2018 23:33:48 -0400 Received: from mail-pl0-f68.google.com ([209.85.160.68]:45497 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751546AbeDKDdo (ORCPT ); Tue, 10 Apr 2018 23:33:44 -0400 Received: by mail-pl0-f68.google.com with SMTP id e22-v6so349192plj.12; Tue, 10 Apr 2018 20:33:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=GC9drIeTnStbM+mqADMuVIWXulXRLf4FrnezzoMROdI=; b=lbedUH/XmPuer13bv0J1r5Y5njrEEohoAUXw2HY9AAi1MkmlYw2Fo0aTBUk8vQqlCf C1NgxO3TCUm5ysPY78TmvJqJwvgZBdJ70Qca8vg2kd2gbCPwsZ2XDqJ1MAePiUmrGbEB M/a1FlGW94NIwxvHudldni6FUh2fbV6zTxv1L7yRz6uTpUtBis0v9BJx3+GQveZ+0W2V p2kKQJioLXoZ3CNFGJemdJ3ZF7n8NyHPf7maZQ2PpO8MA7zuxX05y2iYd1Ssv3EmJXXB jmmrt9p+HZ9cpEvPdvV8RFVgzp8TKN8rrVj1qysTEsM+J2IWwrO/NKTuUgF6ToFRqC6/ nRdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=GC9drIeTnStbM+mqADMuVIWXulXRLf4FrnezzoMROdI=; b=o5fqgKr/NhxlrdZTrHdhO0KO7oPWC0jlq+QxU5tj/G2xuWIN9tGonUl1H8n0fTlrwH funywb3iRyqfiGhbQcKtkeoKro8iDKhFSo1CRdNVGnACw3Vj6CLu+Q88Fw1CgXQt5/wv 2nvia1Qi5itBGuEidgiWAubyJjM+Jh2fUhDRHspgp1bgpz+V4BADYK0F76Hco7wOWlI7 iHzUXd6k95kdjwrcjMjwdUjSgy+RXfB8IOas5Au5o3VMPcxXFgNHGlYqoZlthBhl3RYB f/yxEWAC6a/GmUu5byjqjNk6Z7AP6IOZ1VdefwaOVjsyZWl4Vq8KI31j91vXBzIFPzgH Iadw== X-Gm-Message-State: ALQs6tBIVlgoDCBNclYSUO7ays+WKE/HwO7/3y/cbKJHAjR2N4OElbAO LOhqf5BiRAzLP/9Octc0qzg= X-Google-Smtp-Source: AIpwx48ABltSZ8xU5JbaV56YgeGP/vDhb/ofSkokgkXYd6cpUH/u8niKKCOqWLT74gDx0z5VKBJ5fA== X-Received: by 2002:a17:902:1744:: with SMTP id i62-v6mr3248971pli.62.1523417624421; Tue, 10 Apr 2018 20:33:44 -0700 (PDT) Received: from oslab.tsinghua.edu.cn ([2402:f000:1:4413:edc8:c1dd:b0a8:461d]) by smtp.gmail.com with ESMTPSA id a75sm322513pfg.135.2018.04.10.20.33.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 10 Apr 2018 20:33:43 -0700 (PDT) From: Jia-Ju Bai To: isdn@linux-pingi.de, davem@davemloft.net, johannes.berg@intel.com, arvind.yadav.cs@gmail.com, stephen@networkplumber.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH 1/2] isdn: hisax_fcpcipnp: Replace mdelay with usleep_range in fcpci_init Date: Wed, 11 Apr 2018 11:33:37 +0800 Message-Id: <1523417617-3249-1-git-send-email-baijiaju1990@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org fcpci_init() is never called in atomic context. The call chain ending up at fcpci_init() is: [1] fcpci_init() <- fcpcipnp_setup() <- fcpnp_probe() fcpnp_probe() is set as ".probe" in struct pnp_driver. This function is not called in atomic context. Despite never getting called from atomic context, fcpci_init() calls mdelay() to busily wait. This is not necessary and can be replaced with usleep_range() to avoid busy waiting. This is found by a static analysis tool named DCNS written by myself. And I also manually check it. Signed-off-by: Jia-Ju Bai --- drivers/isdn/hisax/hisax_fcpcipnp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/hisax_fcpcipnp.c b/drivers/isdn/hisax/hisax_fcpcipnp.c index e4f7573..4789c9d 100644 --- a/drivers/isdn/hisax/hisax_fcpcipnp.c +++ b/drivers/isdn/hisax/hisax_fcpcipnp.c @@ -706,7 +706,7 @@ static inline void fcpci_init(struct fritz_adapter *adapter) outb(AVM_STATUS1_ENA_IOM | adapter->irq, adapter->io + AVM_STATUS1); - mdelay(10); + usleep_range(10000, 11000); } // ---------------------------------------------------------------------- From patchwork Wed Apr 11 03:33:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jia-Ju Bai X-Patchwork-Id: 897014 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="vIRI7Jwz"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40LV5C5ltmz9s3B for ; Wed, 11 Apr 2018 13:34:07 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752794AbeDKDeB (ORCPT ); Tue, 10 Apr 2018 23:34:01 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:36262 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752734AbeDKDd7 (ORCPT ); Tue, 10 Apr 2018 23:33:59 -0400 Received: by mail-pf0-f195.google.com with SMTP id g14so284432pfh.3; Tue, 10 Apr 2018 20:33:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=RbaQrWij9BCZrHgn3fl02LFRkN9sqtCcpA+xvKUXZvE=; b=vIRI7Jwz4/3O4o7WAD76IHfTyOTxPhQvqkl7589eSxJkE5tt9IVsDTNIKv9c03cTNh ZpqMar2PGmCsfwHBclR+FQ+8nMzNb5R7+ZkUyOp+ONVAzuSfxZ9KMMFhbj0Aj2J+XC0K VSzZJ9LbCBSfhSbYM4cDRbBTQWkTx0P/SWHJZdTsUD3kbhTP1OMsbcc+S5xSJqlarvhd mW1zrFFffbrnJK+hGcqmND1XwO9EJkciQcvq/emHD6EIJie75InBMVKmihjKjzVLtnbP Onm1A0b2/CtYIgg9p07SnUAzrFhxawa1nlhfE9J5Ca5Qq9SaAN+bBGbRMi+MIBFqe8NN Fb9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=RbaQrWij9BCZrHgn3fl02LFRkN9sqtCcpA+xvKUXZvE=; b=C8ovJ1tBePAUzcn2VH8IC/kE1OIc53lFlMgWYjPu8olRpfukTBYoKjo0AAby4yQTP2 DCqygQp8c7CTlMCYjmGfZIETE4ajy0/kGcq8kZbi/mgwDO+nT7DpjwRxzhcIoGhQu+Ph 0s8efdb98fXKDMNkhY6PSKzhDdOhhu8FGJTpOIjvr6UBpZqlA0UYBLfn3jnJ7xZC9Tfp KPcyF+Ch35JIFZmuLvLnL2ZOCV81pLmMj2Duj0CEfe7HMtQ+4V69bh0UPqX95n1yIr9U H7WIkVHd8Tz11VY8wsK0DPXjVCPqjb0TfQugBI63hJb7os+xE1ypjyonq1d9OP6eWj3X bn3A== X-Gm-Message-State: ALQs6tDxpaap1yFWNFAEc4Lht16+pZvHvjeMLC4/Z7NfJk8r1XwvDnDA eKrSh7fiATcEa83qEKysdIg= X-Google-Smtp-Source: AIpwx4846WKyV5To7lm8OCJuyCLwlERsF/ePer2krzY/fSvKiObj5PiLAmoHp8esr4Lva7CyPMgFrQ== X-Received: by 10.99.119.2 with SMTP id s2mr2157433pgc.436.1523417638699; Tue, 10 Apr 2018 20:33:58 -0700 (PDT) Received: from oslab.tsinghua.edu.cn ([2402:f000:1:4413:edc8:c1dd:b0a8:461d]) by smtp.gmail.com with ESMTPSA id 75sm318782pfx.71.2018.04.10.20.33.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 10 Apr 2018 20:33:58 -0700 (PDT) From: Jia-Ju Bai To: isdn@linux-pingi.de, davem@davemloft.net, stephen@networkplumber.org, johannes.berg@intel.com, arvind.yadav.cs@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH 2/2] isdn: hisax_fcpcipnp: Replace mdelay with usleep_range in fcpcipnp_setup Date: Wed, 11 Apr 2018 11:33:51 +0800 Message-Id: <1523417631-3295-1-git-send-email-baijiaju1990@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org fcpcipnp_setup() is never called in atomic context. The call chain ending up at fcpcipnp_setup() is: [1] fcpcipnp_setup() <- fcpnp_probe() fcpnp_probe() is set as ".probe" in struct pnp_driver. This function is not called in atomic context. Despite never getting called from atomic context, fcpcipnp_setup() calls mdelay() to busily wait. This is not necessary and can be replaced with usleep_range() to avoid busy waiting. This is found by a static analysis tool named DCNS written by myself. And I also manually check it. Signed-off-by: Jia-Ju Bai --- drivers/isdn/hisax/hisax_fcpcipnp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/isdn/hisax/hisax_fcpcipnp.c b/drivers/isdn/hisax/hisax_fcpcipnp.c index e4f7573..06068a42 100644 --- a/drivers/isdn/hisax/hisax_fcpcipnp.c +++ b/drivers/isdn/hisax/hisax_fcpcipnp.c @@ -772,11 +772,11 @@ static int fcpcipnp_setup(struct fritz_adapter *adapter) // Reset outb(0, adapter->io + AVM_STATUS0); - mdelay(10); + usleep_range(10000, 11000); outb(AVM_STATUS0_RESET, adapter->io + AVM_STATUS0); - mdelay(10); + usleep_range(10000, 11000); outb(0, adapter->io + AVM_STATUS0); - mdelay(10); + usleep_range(10000, 11000); switch (adapter->type) { case AVM_FRITZ_PCIV2: