From patchwork Wed Nov 22 03:42:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinayak Yadawad X-Patchwork-Id: 1867127 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=lWUnDzf5; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=VbNxrGuc; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SZnCq1N3fz1ySN for ; Wed, 22 Nov 2023 14:43:51 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=MsREn/FfqFua0BfhxwThRKV4bDnDy34DeU7I/BfKo+o=; b=lWU nDzf5WKmuyiX3NQYSYLG7OylhjsjjR+R7DPYlbnMDDlfJ5LJwUDMpmIjzlubxHpKJKynTDtLBp8I5 XB7mRGUeZve97V1Dk6NI+sR4YmACpyAxpuwX82eMj98UD9V/bmji184KjZbfsYFuK0LnTt91PeKe+ Ijq1Ymc7NGs7HxzH70Y5pExr9W7HxYdqWXNPlN0ygysnnq3nMXywSggMV0VOHyY1e5NjG8T7fcW9u qXQd333aGZ6It7Ffz2sacGRCJGnuJgRjvq7Q5hvW1FNSUq3cXCuqCvFr+80ogeRmxkEKaazzFmQJ0 GjYv/VL464QVRauHkuHfwDVseNpr4ew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r5e8Q-000YwI-1w; Wed, 22 Nov 2023 03:42:42 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r5e8N-000YvQ-02 for hostap@lists.infradead.org; Wed, 22 Nov 2023 03:42:41 +0000 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-1cf678043fdso19220015ad.2 for ; Tue, 21 Nov 2023 19:42:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1700624557; x=1701229357; darn=lists.infradead.org; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=kEkhHDeIA8VNQvEfzyPccXykoqgT/01Tov3UPIEHVvU=; b=VbNxrGuc16Nt5MRNe+ee1o1f33c/dMWyWfPHIfHlTTuLpgF4MWylhrRD0D/cfQlIe8 v6RVDOmM3Y7uD4CyjtcB8lxfZvCt3tBWTSCYgzwHOClIH2hbQCCfN6VHqTl2Q0HoKyLG Cqqqp7hTFUMN4AT42rfc9PAhJcFKSDtOvHTAY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700624557; x=1701229357; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kEkhHDeIA8VNQvEfzyPccXykoqgT/01Tov3UPIEHVvU=; b=HtCg9jgcFZl4/rNMtW2a4dY0o0bSs/uxkJ/ZSCJJBsoNzRxqg4Wz2zFCxxuGI2stOx W94AhAGaHBx157xI9GrSFDOR4B1ZrfwykJG4cXn3O/O96NwqzMkUfYJdK6SJPMpYdknI bCR+wcVwmYHgB5S3/o3BEme0jvFhpu8p5lsrY5/cg4F9KaczMIRLgXe2Ncxx9Lrt4WVi SK9jLQ8IZJmlyhXuTxX71sofGYyM3/t7ltPKjvV8OI7x7Z6YVpky68zWHoJDHvz/22Dd NDgr11l9yRttBsgQXasMDBrO+g6O1nZkvJqR7B5ybNZMczYgY4rVS1P2/645hm32HBUU a9xw== X-Gm-Message-State: AOJu0YzV750nIj7BfvMa/3x2py8fMAktXhiefzTIdPTfyWtOJE8B8v59 7BHiCOKWfH3X21tSHhQVnRxZmWjCVb8RVFmYDkd930Qt00l0aTuC8M1wz2kQdWB/FUo9x/CvR/J +FhY378wgGt9sdAQc1tVSHk9pQc6mBQwbRua6FyAgXBVpm3OwQocCZVgQRLYu+emeDUrCNJtkhL P3Vxn+++I8fhf0rg== X-Google-Smtp-Source: AGHT+IEjsmNbzh0vENmx7qR8r7qMvDbkUAdQQaESyuofdyZFCNy1xOhQtpGGWFpoSnl8m8yAtYt5xw== X-Received: by 2002:a17:902:ced1:b0:1cc:6597:f421 with SMTP id d17-20020a170902ced100b001cc6597f421mr1496280plg.48.1700624556636; Tue, 21 Nov 2023 19:42:36 -0800 (PST) Received: from ibnvda0196.ibn.broadcom.net ([192.19.252.250]) by smtp.gmail.com with ESMTPSA id d5-20020a170902c18500b001b89891bfc4sm8695417pld.199.2023.11.21.19.42.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Nov 2023 19:42:35 -0800 (PST) From: Vinayak Yadawad To: hostap@lists.infradead.org Cc: jithu.jance@broadcom.com, Vinayak Yadawad Subject: [PATCH 1/1] hostapd: Fix reference to correct driver capability flag Date: Wed, 22 Nov 2023 09:12:29 +0530 Message-Id: <4f82c09a873aee92b32078bf770b155080c4048b.1700569147.git.vinayak.yadawad@broadcom.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231121_194239_411723_1582CAA6 X-CRM114-Status: GOOD ( 11.79 ) X-Spam-Score: 0.6 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Current change fixes reference to the appropriate driver capability flags2. Additional debug prints are added for the purpose of debuggability. Signed-off-by: Vinayak Yadawad --- src/drivers/driver_nl80211.c | 24 ++++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) Content analysis details: (0.6 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:634 listed in] [list.dnswl.org] 1.0 MIME_NO_TEXT No (properly identified) text body parts -0.2 DKIMWL_WL_HIGH DKIMwl.org - High trust sender X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Current change fixes reference to the appropriate driver capability flags2. Additional debug prints are added for the purpose of debuggability. Signed-off-by: Vinayak Yadawad --- src/drivers/driver_nl80211.c | 24 ++++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c index ac63e6405..bce9220de 100644 --- a/src/drivers/driver_nl80211.c +++ b/src/drivers/driver_nl80211.c @@ -5111,17 +5111,25 @@ static int wpa_driver_nl80211_set_ap(void *priv, goto fail; if ((params->key_mgmt_suites & WPA_KEY_MGMT_PSK) && - (drv->capa.flags & WPA_DRIVER_FLAGS2_4WAY_HANDSHAKE_AP_PSK) && - params->psk_len && - nla_put(msg, NL80211_ATTR_PMK, params->psk_len, params->psk)) - goto fail; + (drv->capa.flags2 & WPA_DRIVER_FLAGS2_4WAY_HANDSHAKE_AP_PSK) && + params->psk_len) { + if (nla_put(msg, NL80211_ATTR_PMK, params->psk_len, params->psk)) { + wpa_printf(MSG_ERROR, "nl80211: Setting PSK failed"); + goto fail; + } else + wpa_printf(MSG_DEBUG, "nl80211: Setting PSK for offload"); + } if (wpa_key_mgmt_sae(params->key_mgmt_suites) && (drv->capa.flags2 & WPA_DRIVER_FLAGS2_SAE_OFFLOAD_AP) && - params->sae_password && - nla_put(msg, NL80211_ATTR_SAE_PASSWORD, - os_strlen(params->sae_password), params->sae_password)) - goto fail; + params->sae_password) { + if (nla_put(msg, NL80211_ATTR_SAE_PASSWORD, + os_strlen(params->sae_password), params->sae_password)) { + wpa_printf(MSG_ERROR, "nl80211: Setting SAE password failed"); + goto fail; + } else + wpa_printf(MSG_DEBUG, "nl80211: SAE password for offload"); + } if (params->key_mgmt_suites & WPA_KEY_MGMT_IEEE8021X_NO_WPA && (!params->pairwise_ciphers ||