From patchwork Mon Nov 20 18:02:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Jambor X-Patchwork-Id: 1866172 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa header.b=fvtQ/Nli; dkim=pass header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=AagGZYw7; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SYwMg6jw0z1ySC for ; Tue, 21 Nov 2023 05:02:39 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 19B1C3858C30 for ; Mon, 20 Nov 2023 18:02:37 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 43DEA3858D35 for ; Mon, 20 Nov 2023 18:02:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 43DEA3858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=suse.cz ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 43DEA3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:67c:2178:6::1d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700503346; cv=none; b=DuS+HxIvkhfZOOCZxCYm6ohkl42ssTgQy638GNZuZJLoPbfFOxzvlbZwDMlpt1SYqFTZdJR2FQGuPeGIC9glKyH7S0kRrv3duMKQzYCWJ24wm05D2afUpqCw1t2xasiIONnoLP52DOsT5h7qCwOVjBZVZAm+aNtp85bT+/wzV3o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700503346; c=relaxed/simple; bh=FAaUosk4krxfUr5vcdSjdScjywRvuu5AdvGtZivvd9o=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=rkJTUhNOpWcetM+WL5L7q884sf40HDw2BpBFvSpA3gKmgE/X9qAVg3M3WVL9g2uU4iGOnqfYPhd3Kwh+IR4YiJplwuXnrYkAikp9od/Ua4wJdlo7VWj9f8yYxf/heOiT/OP0sxN4V9kr8VmRz5EmSHZN48jxRwDPtKX9r5Dzm7A= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 11E691F895; Mon, 20 Nov 2023 18:02:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1700503343; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=atlMtK5aj1hCiDAP6vjwlkg0NgkvOO7qbSDPeloG+pc=; b=fvtQ/NliO7p8pgA1b9o9ffpAkP4aC14Y9BMOJwSpvHTpbislnZQHMJ7vJl3d3zSxb6toz5 3W65prJeqvrVIZT6oK9zivI/4z9Tvidbd44eWNUOF/ch6tV8qyP4k+pZSTBD9uUP0xgVcq x5tVfVN67iHqpR62T5G9TaOjmKQD0OY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1700503343; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=atlMtK5aj1hCiDAP6vjwlkg0NgkvOO7qbSDPeloG+pc=; b=AagGZYw7HE1sCr3Lxruw3pwJgISs8F1lNLbkqeZ8t/uZXyCcao076MSJ1MHvFvMdBeB8sB b2/rYGegwG9hA+CQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0D8F0134AD; Mon, 20 Nov 2023 18:02:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id BXFGAy+fW2VxIgAAMHmgww (envelope-from ); Mon, 20 Nov 2023 18:02:23 +0000 From: Martin Jambor To: Richard Biener , gcc-patches@gcc.gnu.org Cc: Subject: [PATCH] Bump LTO_minor_version In-Reply-To: <20230920091921.BD9D91333E@imap2.suse-dmz.suse.de> References: <20230920091921.BD9D91333E@imap2.suse-dmz.suse.de> User-Agent: Notmuch/0.37 (https://notmuchmail.org) Emacs/29.1 (x86_64-suse-linux-gnu) Date: Mon, 20 Nov 2023 19:02:22 +0100 Message-ID: MIME-Version: 1.0 Authentication-Results: smtp-out2.suse.de; none X-Spam-Level: X-Spam-Score: -2.10 X-Spamd-Result: default: False [-2.10 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.982]; RCPT_COUNT_TWO(0.00)[2]; INVALID_MSGID(1.70)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-3.00)[99.99%] X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, INVALID_MSGID, SPF_HELO_NONE, SPF_SOFTFAIL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Hi Richi, On Wed, Sep 20 2023, Richard Biener wrote: > The following turns MAX_NUM_CHAINS and MAX_CHAIN_LEN to params which > allows to experiment with raising them. For the testcase in PR111489 > raising MAX_CHAIN_LEN from 5 to 8 avoids the bogus diagnostics > at -O2, at -O3 we need a MAX_CHAIN_LEN of 6. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. > > PR tree-optimization/111489 > * doc/invoke.texi (--param uninit-max-chain-len): Document. > (--param uninit-max-num-chains): Likewise. > * params.def (-param=uninit-max-chain-len=): New. > (-param=uninit-max-num-chains=): Likewise. > * gimple-predicate-analysis.cc (MAX_NUM_CHAINS): Define to > param_uninit_max_num_chains. > (MAX_CHAIN_LEN): Define to param_uninit_max_chain_len. > (uninit_analysis::init_use_preds): Avoid VLA. > (uninit_analysis::init_from_phi_def): Likewise. > (compute_control_dep_chain): Avoid using MAX_CHAIN_LEN in > template parameter. our test attempting to detect that LTO_minor_version should have been bumped but wasn't is failing and eye-balling backports to the gcc-13 branch, this looks like a likely culprit? Unless I am mistaken, params are streamed and therefore they alter the LTO format? If so, I'd like to propose the obvious fix, OK for gcc-13 (after some testing)? Thanks, Martin [PATCH] Bump LTO_minor_version I believe r13-8039-g06ee3438a4fcf9 has changed LTO format and therefore we should bump the minor version of the GCC 13 LTO format. gcc/ChangeLog: 2023-11-20 Martin Jambor * lto-streamer.h (LTO_minor_version): Bump. --- gcc/lto-streamer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/lto-streamer.h b/gcc/lto-streamer.h index fc7133d07ba..75cebcd02d3 100644 --- a/gcc/lto-streamer.h +++ b/gcc/lto-streamer.h @@ -122,7 +122,7 @@ along with GCC; see the file COPYING3. If not see form followed by the data for the string. */ #define LTO_major_version GCC_major_version -#define LTO_minor_version 0 +#define LTO_minor_version 1 typedef unsigned char lto_decl_flags_t;