From patchwork Mon Nov 20 12:39:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinayak Yadawad X-Patchwork-Id: 1865985 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=U45sqTin; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=hONeK8N7; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SYnFX52gmz1yRg for ; Mon, 20 Nov 2023 23:41:50 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=zV2nr+uYmnpo6Ylw1fL7ekPCxb+KPyr4hjJPHnvFFok=; b=U45 sqTinfoCxYb7htlcB6UUUwtT9m1J4WkphK8tYfYU0tcl4h5AokVVZeozZIzwDelUcMdaythI4d7q0 GLvXl8zrXLX4zg73LM33WY3h9MONWa45wvJDcRb4DEMCm0hgC/o4HjkVqhMgsLKCYL2zgYbtFBiVi QbsiMRJYR4Y3JQcRiMX86V5KZAJsUpHO/fF89XMx2VMis0sWDNzqvr4UEBwIb/gGLUxGZqZNGoCTS P0AX0jQt5D4SXTeWbq8RmiF8cRgLnDJYT85NrFWf1KWfrWxuApdft5DgQwjcNMgJ9bPNhRQvjDmpq vCr+oeNFfG7GIPhsT9jwYF6nt9pI3UA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r53Zn-00C1ne-30; Mon, 20 Nov 2023 12:40:31 +0000 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r53Z4-00C1OI-1m for hostap@lists.infradead.org; Mon, 20 Nov 2023 12:40:28 +0000 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-6cb74a527ceso768565b3a.2 for ; Mon, 20 Nov 2023 04:39:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1700483982; x=1701088782; darn=lists.infradead.org; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=kvmkABr6S7KjHEbE21HhNLVHrnf0VyEF4OwCZuMIrYY=; b=hONeK8N73ypo0+9VZ90CC1SiydqaAZFTpAH+UXALxAoRLuslJawDneQPDmcsSJa1Gd Ghj02xr5YrxpEUT2NTkj4gDbC3arXS/+cIEOE5jiMAA68SCb3hu8AJLiVKFR1Ub5uQ7T mnSiy2Z0/ooi0yoM9eDdxp2IIwF0MQdLG42Kw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700483982; x=1701088782; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kvmkABr6S7KjHEbE21HhNLVHrnf0VyEF4OwCZuMIrYY=; b=XTN9In3v3uW2hTPO+YfgtswucXn72VR/55lcC2lAhc3jUnWpwf57eTzkB9ZWwExQKo xe7V3c8DGQmhdKRAAdF2xFd9zfHIYLoqtPIAtjSiZ9DRYyjlqQwlPTWYX7QOkmuBYtA9 JI9MQMjxkC22PXA1ajM5mp51FLfVOF+9vM56Wy6z5CI/sx6ETCgtJB7DYEjzvZlWBEw/ mnHWFWVbQcW8BwNCysupV8KSdVzgJmd0oRk2HYir97ZHjr4swH2y2uV1zKLOowQoLPkM on3vLQNSz6vws6yIoluSCCvUDR6Uzns9pfm7G5vNhTOp7K3cOsuV0bXxnHA+Gu+c5SrH oPNQ== X-Gm-Message-State: AOJu0YwFSetZokoZBHsMjiPMAxSH6rraY3pab709NVtTBDXZEGMul27P hYRlMnjSqFTxZ0xdo19FvQ3k6YWMhJd6DhfEvTlZcRc/R9JsRgqKq4QF5K6A3suTeT0WZUyhAiw rClgvVR/+dExNF4O6QQZ0DK0rSOj7GBPIF43rg0g7Cv9zN7Lf++KkkNGvaGdYO3fZ7D1TAtJQ/X dejQtWGECHGm9tUQ== X-Google-Smtp-Source: AGHT+IFloONFC7Lu291k8ACIOw9Wub4eFy6AnIHb6bFR7h14h5RVV3qbRB6CfPUcCxE16CmvgTESOg== X-Received: by 2002:a05:6a20:551b:b0:180:d45e:727c with SMTP id ko27-20020a056a20551b00b00180d45e727cmr4310283pzb.46.1700483981528; Mon, 20 Nov 2023 04:39:41 -0800 (PST) Received: from ibnvda0196.ibn.broadcom.net ([192.19.252.250]) by smtp.gmail.com with ESMTPSA id u34-20020a056a0009a200b006b73af176c7sm5942156pfg.157.2023.11.20.04.39.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Nov 2023 04:39:40 -0800 (PST) From: Vinayak Yadawad To: hostap@lists.infradead.org Cc: jithu.jance@broadcom.com, Vinayak Yadawad Subject: [PATCH 1/1] hostapd: Update port authorized indication for mlo address Date: Mon, 20 Nov 2023 18:09:33 +0530 Message-Id: <242e2cca96b18ce6f048695e65663cc186652e16.1700483639.git.vinayak.yadawad@broadcom.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231120_043946_679247_074FD032 X-CRM114-Status: GOOD ( 11.64 ) X-Spam-Score: 0.6 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Handling of port authorized event for STA currently handles the connected BSSID. This needs additional handling to support the MLD AP address in case of MLO connection. The connected_addr expected by [...] Content analysis details: (0.6 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:431 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 1.0 MIME_NO_TEXT No (properly identified) text body parts -0.2 DKIMWL_WL_HIGH DKIMwl.org - High trust sender X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Handling of port authorized event for STA currently handles the connected BSSID. This needs additional handling to support the MLD AP address in case of MLO connection. The connected_addr expected by cfg80211_port_authorized is mld_addr for ML connection case. Signed-off-by: Vinayak Yadawad --- src/drivers/driver_nl80211_event.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/src/drivers/driver_nl80211_event.c b/src/drivers/driver_nl80211_event.c index 0091032e5..10e016bfc 100644 --- a/src/drivers/driver_nl80211_event.c +++ b/src/drivers/driver_nl80211_event.c @@ -3495,6 +3495,7 @@ static void nl80211_port_authorized(struct wpa_driver_nl80211_data *drv, { const u8 *addr; union wpa_event_data event; + const u8 *connected_addr; os_memset(&event, 0, sizeof(event)); @@ -3511,13 +3512,16 @@ static void nl80211_port_authorized(struct wpa_driver_nl80211_data *drv, wpa_printf(MSG_DEBUG, "nl80211: Port authorized for STA addr " MACSTR, MAC2STR(addr)); - } else if (is_sta_interface(drv->nlmode) && - os_memcmp(addr, drv->bssid, ETH_ALEN) != 0) { - wpa_printf(MSG_DEBUG, - "nl80211: Ignore port authorized event for " MACSTR - " (not the currently connected BSSID " MACSTR ")", - MAC2STR(addr), MAC2STR(drv->bssid)); - return; + } else if (is_sta_interface(drv->nlmode)) { + connected_addr = drv->sta_mlo_info.valid_links ? + drv->sta_mlo_info.ap_mld_addr : drv->bssid; + if (os_memcmp(addr, connected_addr, ETH_ALEN) != 0) { + wpa_printf(MSG_DEBUG, + "nl80211: Ignore port authorized event for " MACSTR + " (not the currently connected BSSID " MACSTR ")", + MAC2STR(addr), MAC2STR(connected_addr)); + return; + } } if (tb[NL80211_ATTR_TD_BITMAP]) {