From patchwork Tue Nov 7 02:27:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jiang, Haochen" X-Patchwork-Id: 1860496 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Bv9uqniM; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SPXF83Y01z1yQg for ; Tue, 7 Nov 2023 13:27:53 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DAEB63858D33 for ; Tue, 7 Nov 2023 02:27:50 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by sourceware.org (Postfix) with ESMTPS id B7488385841B for ; Tue, 7 Nov 2023 02:27:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B7488385841B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B7488385841B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=192.55.52.120 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699324059; cv=none; b=Zenb5YeTUxDZIqHIJIgfEETsnV4VNCDd0P7inK/WLJxFvWYPYFXL45Brr7hLh716IvI86nMKjClu31sDEUA0g73Ga2txye3M+F9NDlNo3n2I/aD27Jjk6FJBEfQkrDgj6wfC57ViugjLprvIL5pAXFbBYN3GS5QeeNrLaVRnVjw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699324059; c=relaxed/simple; bh=GgW0HtOYVOsT1POwLaw+ewyaxo9XBmpzUpPED+F6Nko=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=SlFiW6zDoJJ6S1qfmuBS6hQItu53eh0KkMN4f8JSlKuMrkJnPOxw2rTWSEc4Ab1lLX/xoJ4Lwvv8vZ8GBFiW6vIBUwmWFX84760rwXcwhWzPT+0frwJlJ2McX0cd6cjmFVKvRSyeoQe7lwZ0f574B9pgKnS65ushK3w4vxX4z6Y= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699324057; x=1730860057; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=GgW0HtOYVOsT1POwLaw+ewyaxo9XBmpzUpPED+F6Nko=; b=Bv9uqniMTBePGgVHRyWeiCeu7KGpGTczgP0qKDb0BtkJTzIg8BLITfAI 9bP3frcOdPOnse07nntOQvsero+6Jcp/x6bPv1wS9ZVJD3qjzaiLE9bgV vcTPIBpf0v53LnzkVf8DwtBVzZacv/IzYSrEnz8s/ej4tQsdbHWOgmZFX KXZwKaitEUj0JWicOqHkvaOM37Vc9auZsJgCUxLI0JzP4FhUFuE8AVAfj ptqpsq/LiSefB4V7FN3frsWtO0kBys3baJJpHzVI7EMvaaW5fC+tctXi0 Y4sy9ye1LslKlBk3N2P2LSCF91iYDiNg99fxQ32aTmRkrM2ZrjlGaMjep Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10886"; a="388290993" X-IronPort-AV: E=Sophos;i="6.03,282,1694761200"; d="scan'208";a="388290993" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2023 18:27:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,282,1694761200"; d="scan'208";a="10257310" Received: from shvmail03.sh.intel.com ([10.239.245.20]) by orviesa001.jf.intel.com with ESMTP; 06 Nov 2023 18:27:35 -0800 Received: from shliclel4217.sh.intel.com (shliclel4217.sh.intel.com [10.239.240.127]) by shvmail03.sh.intel.com (Postfix) with ESMTP id 17B141005717; Tue, 7 Nov 2023 10:27:34 +0800 (CST) From: Haochen Jiang To: gcc-patches@gcc.gnu.org Cc: hongtao.liu@intel.com, ubizjak@gmail.com Subject: [PATCH] i386: Fix isa attribute for TI/TF andnot mode Date: Tue, 7 Nov 2023 10:27:34 +0800 Message-Id: <20231107022734.368277-1-haochen.jiang@intel.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Hi all, This patch aims fo fix the wrong isa attribute which caused regression on PR111907. Regtested on x86_64-pc-linux-gnu. Ok for trunk? Thx, Haochen gcc/ChangeLog: PR target/111907 * config/i386/i386.md (avx_noavx512vl): Add missing definition. * config/i386/sse.md (*andnot3): Change isa attribute from avx_noavx512f to avx_noavx512vl. gcc/testsuite/ChangeLog: PR target/111907 * gcc.target/i386/pr111907.c: New test. --- gcc/config/i386/i386.md | 2 ++ gcc/config/i386/sse.md | 2 +- gcc/testsuite/gcc.target/i386/pr111907.c | 8 ++++++++ 3 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.target/i386/pr111907.c diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md index ecc74e9994e..8f2f6e5d908 100644 --- a/gcc/config/i386/i386.md +++ b/gcc/config/i386/i386.md @@ -919,6 +919,8 @@ (eq_attr "isa" "avx") (symbol_ref "TARGET_AVX") (eq_attr "isa" "avx_noavx512f") (symbol_ref "TARGET_AVX && !TARGET_AVX512F") + (eq_attr "isa" "avx_noavx512vl") + (symbol_ref "TARGET_AVX && !TARGET_AVX512VL") (eq_attr "isa" "noavx") (symbol_ref "!TARGET_AVX") (eq_attr "isa" "avx2") (symbol_ref "TARGET_AVX2") (eq_attr "isa" "noavx2") (symbol_ref "!TARGET_AVX2") diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md index e6a5c7911d5..33198756bb0 100644 --- a/gcc/config/i386/sse.md +++ b/gcc/config/i386/sse.md @@ -5169,7 +5169,7 @@ output_asm_insn (buf, operands); return ""; } - [(set_attr "isa" "noavx,avx_noavx512f,avx512vl,avx512f_512") + [(set_attr "isa" "noavx,avx_noavx512vl,avx512vl,avx512f_512") (set_attr "addr" "*,gpr16,*,*") (set_attr "type" "sselog") (set (attr "prefix_data16") diff --git a/gcc/testsuite/gcc.target/i386/pr111907.c b/gcc/testsuite/gcc.target/i386/pr111907.c new file mode 100644 index 00000000000..5275e9400ed --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr111907.c @@ -0,0 +1,8 @@ +/* { dg-do compile } */ +/* { dg-options "-mavx512f -mno-evex512" } */ + +_Float128 +foo (_Float128 d, _Float128 e) +{ + return __builtin_copysignf128 (d, e); +}