From patchwork Fri Oct 27 17:04:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Stubbs X-Patchwork-Id: 1856343 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SH8DZ0xCRz202k for ; Sat, 28 Oct 2023 04:05:17 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7CAC73860763 for ; Fri, 27 Oct 2023 17:05:15 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id A2DC33858C2B for ; Fri, 27 Oct 2023 17:05:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A2DC33858C2B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A2DC33858C2B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=68.232.129.153 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698426305; cv=none; b=uowoyxlSFSKaWD3VgSC0tVWq5Tm5h7sZMZP4nhcGMBloLP6XJC//zb69s1fqVzVv4PRK1JLBgnqbWfY7vi/BOMG6uM3T+zl//btR+m8cZ05xUENgk5CaS/2drdKt/gdP22hdSQRKRBjwavKopJoZK7xS3+jLZMmy6b6s2idYHlA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698426305; c=relaxed/simple; bh=4CmNm1nDWMGCbGqGzDQ9xoLbjUiVCNYrFn5yxsqLbwY=; h=Message-ID:Date:MIME-Version:To:From:Subject; b=msA3uXyT17JFhXq++FB4lv533JuCGqOZ0WkPux9RWhRZz6TucN4bVuVO3d8aQgH9+mW+G9Y9t84f5W+10ah+uv3n+9KHgFV6jLSgMVtOV81Cj2Arxi8OYdvQxkV/00NPsPfNUnmlMx2N4Ih06DK0m67+IW0D6594FBtPuZ4O2lk= ARC-Authentication-Results: i=1; server2.sourceware.org X-CSE-ConnectionGUID: 4ZkyhH9fQByz1VUWZgeCpg== X-CSE-MsgGUID: hX99Oa6yQvadnrxGHqz1Qw== X-IronPort-AV: E=Sophos;i="6.03,256,1694764800"; d="scan'208";a="23786013" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 27 Oct 2023 09:05:02 -0800 IronPort-SDR: 6raCYVwDnah63z8P7/Il14mzDgrIH3gBozxPlqwvq2m0cneEYUp3X6saYzVR/VyarufuWkjKD4 tyvEfySI/M59YZ4BHMcf0KgBTJp2RVhwy31KcOgRaU1kyFp3Lp+i/6Wogk9b+k1h0jHjR6ZGQ3 NrYCaT/SCokHHd4kQaTqpOSII5kh1gh6DaA7H8M6R485QgHGPwPiFTWXLPf+6WkgNruRtxO+v6 4yPYYbjHKBSK0hvytBTeC7WW/pGFjDuwbWH8dx8e2Yn4AbR+4MRo68b5m8mCpIg6RJQYM2I7ni trw= Message-ID: <80c4653a-1838-416d-bd78-17a338c61fb2@codesourcery.com> Date: Fri, 27 Oct 2023 18:04:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB To: "gcc-patches@gcc.gnu.org" From: Andrew Stubbs Subject: [committed] amdgcn: silence warnings X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) To svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org This trivial patch adds the "operands" keyword to the condition in a couple of patterns that cause warnings about "missing" mode specifiers. With the iterators, there were a large number of warnings about these cases that have now been silenced. Andrew amdgcn: silence warnings The operands really should be VOIDmode, so the warnings are false. gcc/ChangeLog: * config/gcn/gcn-valu.md (vec_extract_nop): Mention "operands" in condition to silence the warnings. (vec_extract_nop): Likewise. * config/gcn/gcn.md (*movti_insn): Likewise. diff --git a/gcc/config/gcn/gcn-valu.md b/gcc/config/gcn/gcn-valu.md index c128c819c89..39c1dc5b7b4 100644 --- a/gcc/config/gcn/gcn-valu.md +++ b/gcc/config/gcn/gcn-valu.md @@ -948,7 +948,8 @@ (define_insn "vec_extract_nop" (match_operand:V_1REG 1 "register_operand" " 0,v") (match_operand 2 "ascending_zero_int_parallel" "")))] "MODE_VF (mode) < MODE_VF (mode) - && mode == mode" + && mode == mode + /* This comment silences a warning for operands[2]. */" "@ ; in-place extract %0 v_mov_b32\t%L0, %L1" @@ -961,7 +962,8 @@ (define_insn "vec_extract_nop" (match_operand:V_2REG 1 "register_operand" " 0,v") (match_operand 2 "ascending_zero_int_parallel" "")))] "MODE_VF (mode) < MODE_VF (mode) - && mode == mode" + && mode == mode + /* This comment silences a warning for operands[2]. */" "@ ; in-place extract %0 v_mov_b32\t%L0, %L1\;v_mov_b32\t%H0, %H1" diff --git a/gcc/config/gcn/gcn.md b/gcc/config/gcn/gcn.md index a3d8beefd6d..e6a9ac60b57 100644 --- a/gcc/config/gcn/gcn.md +++ b/gcc/config/gcn/gcn.md @@ -694,7 +694,7 @@ (define_insn_and_split "*movti_insn" (define_insn "prologue_use" [(unspec_volatile [(match_operand 0 "register_operand")] UNSPECV_PROLOGUE_USE)] - "" + "1 /* This comment silences a warning for operands[2]. */" "" [(set_attr "length" "0")])