From patchwork Fri Oct 20 10:40:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleg Endo X-Patchwork-Id: 1852436 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SBh1t4MWrz23jM for ; Fri, 20 Oct 2023 21:40:34 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 78C963858024 for ; Fri, 20 Oct 2023 10:40:32 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mailout08.t-online.de (mailout08.t-online.de [194.25.134.20]) by sourceware.org (Postfix) with ESMTPS id 861A73858D35 for ; Fri, 20 Oct 2023 10:40:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 861A73858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=t-online.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=t-online.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 861A73858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=194.25.134.20 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697798421; cv=none; b=ig1m5CVZ+H+o+0zXfF9NyM1llhV5oN84C8L4374p5O/VaFVWTQFdTZ7StouufSm8v5D64JaidLzTbTz8BxLU1ydCk9Tg1ENBXP95QcaNR6669GIvYDcVwPiYq0wPxmvOLY2GS67xYiLnV5eaSdLgcsCMC9TyxS8sJ793Jlqrp68= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697798421; c=relaxed/simple; bh=qhhWvmL5ZD1SbRt1iCIBtbnMsB0Tz+al1cC8svsx+9I=; h=Message-ID:Subject:From:To:Date:MIME-Version; b=YsLL+1DWVOkJZNxUsQQZyd1IJPAIkUdtdTFrEGemKGpl5wXmnOXdiAsX+WIgFOknyz0pZstJeiHwY0Pm8XYwCdgcsoCanvWxuN5NNoVQCurOq0nfz0//VnecCLWvXsYZgOf4/gUQO+s3irpU0EzqjeKmsk6Rh84/rJv5u/uxyiw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fwd71.aul.t-online.de (fwd71.aul.t-online.de [10.223.144.97]) by mailout08.t-online.de (Postfix) with SMTP id 35E962243B for ; Fri, 20 Oct 2023 12:40:18 +0200 (CEST) Received: from localhost.localdomain ([115.165.108.210]) by fwd71.t-online.de with (TLSv1.3:TLS_AES_256_GCM_SHA384 encrypted) esmtp id 1qtmvO-0w5AUS0; Fri, 20 Oct 2023 12:40:14 +0200 Message-ID: Subject: [SH][committed] Fix PR 101177 From: Oleg Endo To: gcc-patches Date: Fri, 20 Oct 2023 19:40:10 +0900 User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-TOI-EXPURGATEID: 150726::1697798415-D2FFAD5E-F5289F96/0/0 CLEAN NORMAL X-TOI-MSGID: 6b04ac5c-0089-4856-87c6-234ec71d7a64 X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org The attached patch fixes PR 101177. Committed to master, cherry-picked to GCC-13, GCC-12 and GCC-11. Sanity tested with 'make all-gcc'. Cheers, Oleg gcc/ChangeLog: PR target/101177 * config/sh/sh.md (unnamed split pattern): Fix comparison of find_regno_note result. From 3ce4e99303d01d348229cca22bf8d3dd63004e01 Mon Sep 17 00:00:00 2001 From: Oleg Endo Date: Fri, 20 Oct 2023 18:48:34 +0900 Subject: [PATCH] SH: Fix PR 101177 Fix accidentally inverted comparison. gcc/ChangeLog: PR target/101177 * config/sh/sh.md (unnamed split pattern): Fix comparison of find_regno_note result. --- gcc/config/sh/sh.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config/sh/sh.md b/gcc/config/sh/sh.md index 76e7774..93374c6 100644 --- a/gcc/config/sh/sh.md +++ b/gcc/config/sh/sh.md @@ -841,9 +841,9 @@ rtx reg = operands[0]; if (SUBREG_P (reg)) reg = SUBREG_REG (reg); gcc_assert (REG_P (reg)); - if (find_regno_note (curr_insn, REG_DEAD, REGNO (reg)) != NULL_RTX) + if (find_regno_note (curr_insn, REG_DEAD, REGNO (reg)) == NULL_RTX) FAIL; /* FIXME: Maybe also search the predecessor basic blocks to catch more cases. */ -- libgit2 1.3.2