From patchwork Thu Oct 19 04:31:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Zhukov X-Patchwork-Id: 1851397 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=yandex.ru header.i=@yandex.ru header.a=rsa-sha256 header.s=mail header.b=VuewOxmt; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4S9vtp3BP3z1ypX for ; Thu, 19 Oct 2023 15:31:45 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id A046983A9C; Thu, 19 Oct 2023 04:31:43 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org A046983A9C Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=yandex.ru header.i=@yandex.ru header.a=rsa-sha256 header.s=mail header.b=VuewOxmt X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id enLK79YB9gTt; Thu, 19 Oct 2023 04:31:42 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id B2B5583868; Thu, 19 Oct 2023 04:31:41 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org B2B5583868 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 84F3FC0071; Thu, 19 Oct 2023 04:31:41 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 967FAC0032 for ; Thu, 19 Oct 2023 04:31:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 5C15741D0E for ; Thu, 19 Oct 2023 04:31:39 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 5C15741D0E Authentication-Results: smtp2.osuosl.org; dkim=pass (1024-bit key) header.d=yandex.ru header.i=@yandex.ru header.a=rsa-sha256 header.s=mail header.b=VuewOxmt X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AENnuxxFZrFL for ; Thu, 19 Oct 2023 04:31:38 +0000 (UTC) Received: from forward101a.mail.yandex.net (forward101a.mail.yandex.net [178.154.239.84]) by smtp2.osuosl.org (Postfix) with ESMTPS id 03A0E400FD for ; Thu, 19 Oct 2023 04:31:37 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 03A0E400FD Received: from mail-nwsmtp-mxback-production-main-54.iva.yp-c.yandex.net (mail-nwsmtp-mxback-production-main-54.iva.yp-c.yandex.net [IPv6:2a02:6b8:c0c:848b:0:640:6778:0]) by forward101a.mail.yandex.net (Yandex) with ESMTP id 6CB8560AC4 for ; Thu, 19 Oct 2023 07:31:30 +0300 (MSK) Received: from mail.yandex.ru (2a02:6b8:c0c:5f0b:0:640:41ca:0 [2a02:6b8:c0c:5f0b:0:640:41ca:0]) by mail-nwsmtp-mxback-production-main-54.iva.yp-c.yandex.net (mxback/Yandex) with HTTP id KVdmcm2WASw0-WVoUv4d5; Thu, 19 Oct 2023 07:31:29 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1697689889; bh=uHgAFt+C66GTvrp9xCiwuNTM6VlNIwHDgEI2Y/laINw=; h=Message-Id:Date:Subject:To:From; b=VuewOxmt7iM+G5B1L1EtRKnfDt6/Xn33aINHYkOwpUdwVMti3vGYQYryctDriJNJV rmrnXN/zK/+l7SL2/Funq+i7dxMCUbG0ZP9TDUP5cf/tc/WJA8r0IVsPA6noq6kdMm yIOeXUrYSJLaBvsISDPuDQphvp0elovyTpjvtK20= Authentication-Results: mail-nwsmtp-mxback-production-main-54.iva.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Received: by jjcwlhzhm4ck4unt.iva.yp-c.yandex.net with HTTP; Thu, 19 Oct 2023 07:31:29 +0300 From: Igor Zhukov Envelope-From: fsb4000@yandex.ru To: dev@openvswitch.org MIME-Version: 1.0 X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Thu, 19 Oct 2023 11:31:29 +0700 Message-Id: <2340231697689889@jjcwlhzhm4ck4unt.iva.yp-c.yandex.net> Subject: [ovs-dev] [PATCH ovn v2] fix a copy-paste typo X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Although this typo does not cause a real error. Look at my test: https://gcc.godbolt.org/z/hdKc389vd Signed-off-by: Igor Zhukov Acked-by: Mark Michelson --- controller/ofctrl.c | 2 +- northd/northd.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/controller/ofctrl.c b/controller/ofctrl.c index a1676a788..63b0aa975 100644 --- a/controller/ofctrl.c +++ b/controller/ofctrl.c @@ -2202,7 +2202,7 @@ ofctrl_meter_bands_alloc(const struct sbrec_meter *sb_meter, struct ovn_extend_table_info *entry, struct ovs_list *msgs) { - struct meter_band_entry *mb = mb = xzalloc(sizeof *mb); + struct meter_band_entry *mb = xzalloc(sizeof *mb); mb->n_bands = sb_meter->n_bands; mb->bands = xcalloc(mb->n_bands, sizeof *mb->bands); for (int i = 0; i < sb_meter->n_bands; i++) { diff --git a/northd/northd.c b/northd/northd.c index 916068d44..f8b046d83 100644 --- a/northd/northd.c +++ b/northd/northd.c @@ -15765,7 +15765,7 @@ build_lrouter_nat_defrag_and_lb(struct ovn_datapath *od, struct hmap *lflows, !lport_addresses_is_empty(&od->lb_force_snat_addrs); for (int i = 0; i < od->nbr->n_nat; i++) { - const struct nbrec_nat *nat = nat = od->nbr->nat[i]; + const struct nbrec_nat *nat = od->nbr->nat[i]; struct eth_addr mac = eth_addr_broadcast; bool is_v6, distributed_nat; ovs_be32 mask;