From patchwork Tue Oct 10 20:05:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alec Panoviciu X-Patchwork-Id: 1846067 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=z7jmtcBB; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4S4n7l2xBMz1yq4 for ; Wed, 11 Oct 2023 07:10:10 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=8px/VefqzW7C/hCKolZaLMqRmtR8MwhgiAztNVriOvI=; b=z7jmtcBB0Ybdy/ Acz0LwD5/W3bHA0F06bw+Yn7KtKrlv53b1QeraM7ulz558teiXBho03hrSU5li5vI36VgmIAZfk9g MTRwoGFepV376D4NZiOyiLnI7OL38V3e8UyAbWfx0z64aUXhAl3CrZ9bfclKCezXn9JweX0iVNvBk 5B+a7mCAPwreEKc9oNXbfMZ4QFPX14chuVjxdW9y6FKFCk6NozsMVFHDZSFXeHnOT6NKZZzB/7Nke OlKVL8bkPIPoUDmWGmla4s3K82awca8lLNrxS4TJ/YXstiij0APBryZ7/taQQAxGlckKe59F2MbDM B1FIOjojTumUSnjYnUvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qqIzh-00E6Au-0I; Tue, 10 Oct 2023 20:06:17 +0000 Received: from mail-cwxgbr01on20700.outbound.protection.outlook.com ([2a01:111:f403:261b::700] helo=GBR01-CWX-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qqIzc-00E6A0-1z for openwrt-devel@lists.openwrt.org; Tue, 10 Oct 2023 20:06:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YSYpaQQ/U5jjsAttxCdJbQR8C0YUz+5xaMaWchZJcC74DLZ0paLn9r+Y91nxAItYOTu5fI6WurUqkCHYXia751LkD4V2NBS1Pmw1u9asbSDqGEWWY0baIFZ0PJrnpJp4inCkBLkIIA1cjEVxkMNwNrBsBokV/w5K1rU/fcKtyqqhb4MqlPsXdsTi5b0+xTh9zoPWmbYtlo01bUHWS4jMHLErYyPRxiodufBbDXgkufvtpOukw0oKiSpOCGzEyW8WCv4ExAaEoEUWMhagOPkPT7RSWctA4TnuH/IF1SZFhQw/hsuyPp14aQCiiuWPkAh3w8vYOHwg8U2zGJTtRkX2wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bJxUMwi3I9ubYGvtBQHzhKHuZnPgbgdS8HDg7gF+p7U=; b=dswSbvldFPuJzwTTrnBhwboyphlSR/pmCMsVyWL18Iubluev2LpIW5CPcK3mEW0H4F6fae51EhF1EG9TYids3QKaZ02CJxd2OxoDaK+bkhtGeX+DqAenJWEhWEAS0PaYZR59kbMPJgVDOKbHk4JhFWfUX7fZcrx84/TP2ZW35JrVlZr3zVdADqNegBtLsKuP885CYihf4r6XosLA9NL7fkHFbVd+v6RcjR8IjKg6Qf2mgPcapgSMkFfwgc/hAmq+A4UeG1lN3xEP7WyDQVVG66PpmkAQm5O6MuSM2W3mQLzbLydf1b9SwC4EcuiGPYr+sQ+rDViRBbfN7QLpUSPs1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 154.60.82.149) smtp.rcpttodomain=lists.openwrt.org smtp.mailfrom=infiniphy.com; dmarc=none action=none header.from=infiniphy.com; dkim=none (message not signed); arc=none Received: from LO4P265CA0199.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:318::16) by LO3P265MB2234.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:bd::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.38; Tue, 10 Oct 2023 20:06:00 +0000 Received: from LO2GBR01FT035.eop-gbr01.prod.protection.outlook.com (2603:10a6:600:318:cafe::1f) by LO4P265CA0199.outlook.office365.com (2603:10a6:600:318::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.36 via Frontend Transport; Tue, 10 Oct 2023 20:06:00 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 154.60.82.149) smtp.mailfrom=infiniphy.com; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=infiniphy.com; Received-SPF: Fail (protection.outlook.com: domain of infiniphy.com does not designate 154.60.82.149 as permitted sender) receiver=protection.outlook.com; client-ip=154.60.82.149; helo=build.infiniphy.com; Received: from build.infiniphy.com (154.60.82.149) by LO2GBR01FT035.mail.protection.outlook.com (10.152.42.162) with Microsoft SMTP Server id 15.20.6886.23 via Frontend Transport; Tue, 10 Oct 2023 20:05:59 +0000 Received: from apanovic (uid 10001) (envelope-from apanovic@infiniphy.com) id 6008f by build.infiniphy.com (DragonFly Mail Agent v0.13); Tue, 10 Oct 2023 21:05:59 +0100 From: Alec Panoviciu To: openwrt-devel@lists.openwrt.org Cc: Alec Panoviciu Subject: [PATCH] base-files: force /overlay to be remounted ro during shutdown. Date: Tue, 10 Oct 2023 21:05:56 +0100 Message-Id: <20231010200556.1532915-1-apanovic@infiniphy.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LO2GBR01FT035:EE_|LO3P265MB2234:EE_ X-MS-Office365-Filtering-Correlation-Id: 0ba87bd6-18cb-4d60-7a76-08dbc9cc5283 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /DtxnPmXczlBLTOPua2CGVgvrVD7OmKanNoltI5whPXXEyy6F47tPb9msPNSFfheLF2I1hzcG7gXY6RwbjBDdwq+iBCekReMBSvNt1FC3EcCFyhRo6qHjCPLG8ZwNOZLepP3CBxZF8JDqtK0tLY2eOi8pUeH58GOh6/c9+b5VyTDGynVAJSyqmJ+elCsvDzfttaxZlPRJkhiFbvan/AB1KZh8OPAeP+/d85y3N6zRyanCSFZcczp6mFV/AkwYo7n9FkGSLxnZaUUz9arHzyzclze0hH3LUp+VYjQevDILk8b7SD7K8Kv9Aztiwdxht/60h0SmQqsf6xMAS//+sz4YBvRNQkCeOUn4pv6p07cLbtPY1S/hzH1l7lcGVXmsNToFhlFiTLJtjJUGW78ZuU6WItblpX4SJD5wAbOSUEWuz1XOfmZG0isE0aIWJwG7Hk3RMUNOqFqX1ZVAyLQ4/szV4NBYcve4CCKYZwrVZ6ayBX6Jq53i6On/5XGkuK0Zxt7ZdJOtgK9eXXrlLAgHzS70fcV5brd9z7fPZogRxVq3wcdYF+kg5GQjE6kCXhCP76sx3d/FLiccuuouBwFn+1GOYGRXvbyX+92r5Nio3PtR7Fux1zSOhclO9MnvEh9UBJV5S2a7KzvKJR3VD9a+ERAjFI5rB/DSYOV8puVIXRtI4JeXowqBm96s4YI6Kbk7jxN40tSRGbDHQbJxI4DMw7YnMGRDl64/W7MYYvBT+W5KCg1QOSRotZZ+/R/X4b/iF0sqKru0W+ZH6RpqH/fzpJkcjJmybdUhd1rn5FMWPxDRvCy5TumQ7R99LP8ZB+EM4FURM9i5A9ot9iCWg3/sHBJsUwUvcv/xR8u8A40KBd22Ao= X-Forefront-Antispam-Report: CIP:154.60.82.149;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:build.infiniphy.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(346002)(396003)(39830400003)(376002)(136003)(230922051799003)(186009)(451199024)(1800799009)(82310400011)(64100799003)(46966006)(36840700001)(26005)(40480700001)(107886003)(1076003)(426003)(336012)(2616005)(36200700002)(478600001)(36860700001)(36756003)(6666004)(86362001)(47076005)(8676002)(6916009)(316002)(356005)(70206006)(4744005)(70586007)(4326008)(2906002)(8936002)(81166007)(34070700002)(5660300002)(41300700001)(83380400001)(36900700001);DIR:OUT;SFP:1102; X-OriginatorOrg: infiniphy.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 20:05:59.6823 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0ba87bd6-18cb-4d60-7a76-08dbc9cc5283 X-MS-Exchange-CrossTenant-Id: b6e91b25-c79e-49f2-b3ce-f165ac718a33 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=b6e91b25-c79e-49f2-b3ce-f165ac718a33;Ip=[154.60.82.149];Helo=[build.infiniphy.com] X-MS-Exchange-CrossTenant-AuthSource: LO2GBR01FT035.eop-gbr01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO3P265MB2234 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231010_130612_676466_07254E05 X-CRM114-Status: UNSURE ( 7.12 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.0 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: When using overlayfs the '/bin/umount -a -d -r' command doesn't actually unmount the upper fs as it's still referenced by the overlay. This workaround makes the upper fs appear busy so it at least get [...] Content analysis details: (-0.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org When using overlayfs the '/bin/umount -a -d -r' command doesn't actually unmount the upper fs as it's still referenced by the overlay. This workaround makes the upper fs appear busy so it at least gets remounted readonly. Signed-off-by: Alec Panoviciu --- package/base-files/files/etc/init.d/umount | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package/base-files/files/etc/init.d/umount b/package/base-files/files/etc/init.d/umount index b764ae1..1776adc 100755 --- a/package/base-files/files/etc/init.d/umount +++ b/package/base-files/files/etc/init.d/umount @@ -9,5 +9,6 @@ restart() { stop() { sync - /bin/umount -a -d -r + # force /overlay to be remounted ro if present + (cd /overlay ; /bin/umount -a -d -r ) }