From patchwork Wed Oct 4 17:54:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 1843558 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=Pj0vMgAo; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2620:137:e000::1:20; helo=out1.vger.email; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by legolas.ozlabs.org (Postfix) with ESMTP id 4S12Pr4y6bz1ypx for ; Thu, 5 Oct 2023 04:54:24 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243508AbjJDRyY (ORCPT ); Wed, 4 Oct 2023 13:54:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233325AbjJDRyX (ORCPT ); Wed, 4 Oct 2023 13:54:23 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BB41A6 for ; Wed, 4 Oct 2023 10:54:20 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1c6219307b2so152685ad.1 for ; Wed, 04 Oct 2023 10:54:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1696442059; x=1697046859; darn=vger.kernel.org; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=jX2uWsXtP9/TsUD1yDjaCqCakJXSq2uJNAMcVdge+Ng=; b=Pj0vMgAoGsOVfCeOlmRhoWgQ5kvGeuUECOLaXEN2aaJaCjrOc8CPHrlj6J8kirC43Q 6Mtc4rkGpC/k4bzFTWQuko2CzjTTlM0b9TUVMHytKOXiGxgUwq6efm38IzQdCGsGq0Mn gkWQciwPwRtVHU+zgH3v03A4aZcix6PTHByKE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696442059; x=1697046859; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=jX2uWsXtP9/TsUD1yDjaCqCakJXSq2uJNAMcVdge+Ng=; b=Kyi5Xch8bKtJggol/Z1jPlYychfaFyrYZJUDiR4B9KCDzDcw4AhqShxhxQXaRi5UjQ YVwDFqSdAof666plsPqv5AFwDG6kKWsKXV2LJ6k4yhZTsROQBJ35fWTM0/y9UeIyJGAM 46DgE3jWP7PxZEvbDNHoFDYRoVqdYLVCx+GN/DrPSFLiaV3bJFD8irEHV0U49KLguxfe H0lM+n+wK3dpbVT51PUrIoaXdBlH0kpIm6+PRkzPkRObBnMevDr4B6L4TlinPUOK2HyU KxxQ4BgGuVKzx9OeSQ48x4IRZE3sCtXD4LdtDHmee/uEscKYKx6qCDC7mhHSrMc72cvl UaTA== X-Gm-Message-State: AOJu0YzZLowHZmZfmCaSQ63Xkc5tYezz6yv6AaqkCd7Shf25q37GU4sI O9zNZA7Z1bxLH3xq0eVup+KrUaIVQFwzWyF2NPSCW68YlwbgJeyFak9TGSMTCr5HN9MZGZ4fI3C rd3quhfHw9tC1kxKkQMmHam9nAKxND+5AI+a5SaxBSyiKZNJsLe/jLf+rLB2LWGBm0OVGrAgylh 3OHbrZf/hy2sD8FA== X-Google-Smtp-Source: AGHT+IEDGkz49afCA7loanGGtOjk/7qRD4MRj4Kjf1x5HLRaOMqIYVelZjMDkh7Q2JMQ2Rn8r0newQ== X-Received: by 2002:a17:902:ce8b:b0:1bc:7441:d81a with SMTP id f11-20020a170902ce8b00b001bc7441d81amr3597033plg.6.1696442059415; Wed, 04 Oct 2023 10:54:19 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id g6-20020a170902c38600b001b567bbe82dsm4008921plg.150.2023.10.04.10.54.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 10:54:18 -0700 (PDT) From: Florian Fainelli To: linux-pwm@vger.kernel.org Cc: Florian Fainelli , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Broadcom internal kernel review list , linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] pwm: brcmstb: Utilize appropriate clock APIs in suspend/resume Date: Wed, 4 Oct 2023 10:54:14 -0700 Message-Id: <20231004175414.1738475-1-florian.fainelli@broadcom.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MIME_NO_TEXT, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org The suspend/resume functions currently utilize clk_disable()/clk_enable() respectively which may be no-ops with certain clock providers such as SCMI. Fix this to use clk_disable_unprepare() and clk_prepare_enable() respectively as we should. Fixes: 3a9f5957020f ("pwm: Add Broadcom BCM7038 PWM controller support") Signed-off-by: Florian Fainelli Acked-by: Uwe Kleine-König --- drivers/pwm/pwm-brcmstb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pwm/pwm-brcmstb.c b/drivers/pwm/pwm-brcmstb.c index a3faa9a3de7c..a7d529bf76ad 100644 --- a/drivers/pwm/pwm-brcmstb.c +++ b/drivers/pwm/pwm-brcmstb.c @@ -288,7 +288,7 @@ static int brcmstb_pwm_suspend(struct device *dev) { struct brcmstb_pwm *p = dev_get_drvdata(dev); - clk_disable(p->clk); + clk_disable_unprepare(p->clk); return 0; } @@ -297,7 +297,7 @@ static int brcmstb_pwm_resume(struct device *dev) { struct brcmstb_pwm *p = dev_get_drvdata(dev); - clk_enable(p->clk); + clk_prepare_enable(p->clk); return 0; }