From patchwork Mon Sep 25 07:20:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Berg X-Patchwork-Id: 1838922 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=SzBqXQ8K; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=sipsolutions.net header.i=@sipsolutions.net header.a=rsa-sha256 header.s=mail header.b=Ujw36tmC; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RvDrB6Zpkz1yqR for ; Mon, 25 Sep 2023 17:23:38 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GqZPsZcM1dObDynUomA739l1D6yCYuYz7sY04ggNMLw=; b=SzBqXQ8K+XmVLd erRYfxUragcFU0Nxi1dP9QBxgLBX4Bj1/Xkv+plyysz4ELuhlNOhwDEsWi0qmTe8duRIEMYp4xZ6I SNbgzqbU1jLwsKSAQKjvCjmsTHeS+lXghxsIxSDtZu0J9yaZCoqrtFhCNcTyyYiUhxf36u4dkhY4b LRDpuVtKAirX0i8E12+Bxso1akP2Dw3RzY+8L14Kr5hJ9XIq3YYr9Lzf4Kz+zQVWXBaeYh9VCPMAw jxQ/LX9dVLPQE7HDojVNWdcBc0KP5+4YCQ9e5kViqHrYkU2nOGyT0777pYqU1+M7jU9bpSR7nY9v/ nFZDxqg6A19xaH88Rr8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvS-00DYDC-39; Mon, 25 Sep 2023 07:22:38 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:242:246e::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvP-00DYBK-0c for hostap@lists.infradead.org; Mon, 25 Sep 2023 07:22:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Content-Type:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=X9ixbOk4IuB00HyFszqVe2iPij1FrhnfAzeYCuqEGNo=; t=1695626555; x=1696836155; b=Ujw36tmCeY3SQTiauflvEzJ/Cl3iUgXWUX6+3kXGu3k0dgN 4EHp2hHQGaDP84WjnuN4Qk9EbRkYByj+R/ZekZRGa9VmukzXyigylR8B+9mLMypxAcl+HKyCgIBbN TFW1Qs2RXHUUBxUPdAywNWywtHydHyBWsbSlqkt1jnZyeus6WWC+Uss1m+sGdOu0WYE+HgGhIcGCI /1M/945arPqTcmHyhfRuB5nqzK16QTpqFMCTj3NRbMVFQlgDOyeIia1LLi5Ms9A5up9gt/BQbrTi0 MCRE+I0E9jRctcnEziwtjjcA/nS63EfLMxK4WGrXyA6/b3L8oFNXXgd+ZqUvAolw==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1qkfvM-003GNz-0O; Mon, 25 Sep 2023 09:22:32 +0200 From: Johannes Berg To: hostap@lists.infradead.org Cc: Johannes Berg Subject: [PATCH 01/17] tests: wait for radio work to start after DPP_LISTEN command Date: Mon, 25 Sep 2023 09:20:41 +0200 Message-ID: <20230925092039.b9c7d876320b.I41dc7a5a9e9ad2ef63cd773f0fc6fe894a4875ff@changeid> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230925072039.49987-18-johannes@sipsolutions.net> References: <20230925072039.49987-18-johannes@sipsolutions.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_002235_230650_87178124 X-CRM114-Status: UNSURE ( 9.88 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Johannes Berg Since DPP listen is a radio work, it doesn't start immediately and then we can end up missing whatever happens next in the test. Wait for the radio work to start before continuing the test. Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Johannes Berg Since DPP listen is a radio work, it doesn't start immediately and then we can end up missing whatever happens next in the test. Wait for the radio work to start before continuing the test. Signed-off-by: Johannes Berg --- tests/hwsim/wpasupplicant.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tests/hwsim/wpasupplicant.py b/tests/hwsim/wpasupplicant.py index bd53a1ec0991..2fdaa2c5a711 100644 --- a/tests/hwsim/wpasupplicant.py +++ b/tests/hwsim/wpasupplicant.py @@ -1545,6 +1545,15 @@ class WpaSupplicant: cmd += " role=" + role if "OK" not in self.request(cmd): raise Exception("Failed to start listen operation") + # Since DPP listen is a radio work, make sure it has started + # by the time we return and continue with the test, since it + # usually will send something this side should receive. + work_started = "dpp-listen@" + self.ifname + ":" + str(freq) + ":1" + for i in range(10): + if work_started in self.request("RADIO_WORK show"): + return + time.sleep(0.01) + raise Exception("Faield to start DPP listen work") def dpp_auth_init(self, peer=None, uri=None, conf=None, configurator=None, extra=None, own=None, role=None, neg_freq=None, From patchwork Mon Sep 25 07:20:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Berg X-Patchwork-Id: 1838921 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=ISNbYXhi; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=sipsolutions.net header.i=@sipsolutions.net header.a=rsa-sha256 header.s=mail header.b=Rjxy3wWh; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RvDrC28l5z26jS for ; Mon, 25 Sep 2023 17:23:39 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nvpPzdQRwYX8oct61v82xsWiI0E3gBL3y+Zgq5qMYbU=; b=ISNbYXhiDY2V+k mqj6LMxFUfyAKH5y3UlRuz+JfOGC283lXYa+Vtz7c0rZIEC1QdNaMjCQytLEKDRHCs8fuq3wgObf5 As4+xsjebBxgcmZNgVK16UyQZhr5y3x8YKkOTq71foPwfwyezXQSwuSON/WRVYvJ/g6j+QfEWUgqG FnrazC96hPNar9VIeGQ8jI8MoA7dI15DGNJTDYTCFf7lg4zQULIRwBupkTg48pk56D3EbcSNCPYOF wHPgQtI/LSmipXCFbaxiHfop8UT2YVLJET3evm5KrObL9wUJZpu2xKl5j75Vcza0DCjXagEuPC5uO oEHXeiYN0ngcK0ZSBY+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvU-00DYDh-0O; Mon, 25 Sep 2023 07:22:40 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:242:246e::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvP-00DYBQ-2H for hostap@lists.infradead.org; Mon, 25 Sep 2023 07:22:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Content-Type:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=5fJdTIZqVihd/ZxziHFXAWC0IGSFzYrf9+GcTsnXtHI=; t=1695626555; x=1696836155; b=Rjxy3wWhYVE9DEQdsZ6zz8abeRFB5dX4NKilPCHwhmGi2Ue MbmXOVktIRlI5FtU4HYQ3w0JBRGXk9eFkA2j7MjXOLG8cmrlD6oHXQJ0e0y7nYkNPmY2Qm7NSxenh lO5Y4Dyhjt1BbUdLKso8p+FnNLI4n6EiwrIWXisc9J/KjeS6Dm2zH4n8Ohn6+PEOTHNBbIJswDGxo 6G8LggJGUsNsmwLzTwPBbtBbHCF9gLQRbJ29Rt2XbWvC1fcTPMrpSD/tB/4w1c65/nitQd18r3cHy cEqVSaOTAxw7+J8ivO/w3+Rq/1tSf0KRH8gZM7Vn6fmrZReWUAvNTmc1WyPVB5BA==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1qkfvN-003GNz-0N; Mon, 25 Sep 2023 09:22:33 +0200 From: Johannes Berg To: hostap@lists.infradead.org Cc: Johannes Berg Subject: [PATCH 02/17] tests: ft/rrm: wait for STA before check_beacon_req() Date: Mon, 25 Sep 2023 09:20:42 +0200 Message-ID: <20230925092039.419e3b129b6a.I7cc4b1b96d93d0659636424f491e03ba41b638e1@changeid> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230925072039.49987-18-johannes@sipsolutions.net> References: <20230925072039.49987-18-johannes@sipsolutions.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_002235_745359_7D3CB092 X-CRM114-Status: UNSURE ( 9.66 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Johannes Berg check_beacon_req() will request from hostapd to request a beacon report from the STA, but that only works if it already knows about the STA. Due to scheduling issues, it may not know even if wpa_s rep [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Johannes Berg check_beacon_req() will request from hostapd to request a beacon report from the STA, but that only works if it already knows about the STA. Due to scheduling issues, it may not know even if wpa_s reports it has successfully connected, so also wait for the STA to show up in hostapd before check_beacon_req(). Signed-off-by: Johannes Berg --- tests/hwsim/test_ap_ft.py | 3 +++ tests/hwsim/test_rrm.py | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/tests/hwsim/test_ap_ft.py b/tests/hwsim/test_ap_ft.py index a2f1a4ead431..0e9d04775e56 100644 --- a/tests/hwsim/test_ap_ft.py +++ b/tests/hwsim/test_ap_ft.py @@ -3476,6 +3476,7 @@ def test_ap_ft_roam_rrm(dev, apdev): dev[0].flush_scan_cache() dev[0].connect(ssid, psk=passphrase, key_mgmt="FT-PSK", proto="WPA2", scan_freq="2412") + hapd0.wait_sta() check_beacon_req(hapd0, addr, 1) params = ft_params2(ssid=ssid, passphrase=passphrase) @@ -3485,10 +3486,12 @@ def test_ap_ft_roam_rrm(dev, apdev): dev[0].scan_for_bss(bssid1, freq=2412) dev[0].roam(bssid1) + hapd1.wait_sta() check_beacon_req(hapd1, addr, 2) dev[0].scan_for_bss(bssid0, freq=2412) dev[0].roam(bssid0) + hapd0.wait_sta() check_beacon_req(hapd0, addr, 3) def test_ap_ft_pmksa_caching(dev, apdev): diff --git a/tests/hwsim/test_rrm.py b/tests/hwsim/test_rrm.py index a67554f0aebf..86cde92936b4 100644 --- a/tests/hwsim/test_rrm.py +++ b/tests/hwsim/test_rrm.py @@ -2193,18 +2193,22 @@ def test_rrm_reassociation(dev, apdev): addr = dev[0].own_addr() dev[0].flush_scan_cache() dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") + hapd.wait_sta() check_beacon_req(hapd, addr, 1) dev[0].request("REASSOCIATE") dev[0].wait_connected() + hapd.wait_sta() check_beacon_req(hapd, addr, 1) hapd2 = hostapd.add_ap(apdev[1]['ifname'], params) bssid2 = hapd2.own_addr() dev[0].scan_for_bss(bssid2, freq=2412) dev[0].roam(bssid2) + hapd2.wait_sta() check_beacon_req(hapd2, addr, 2) dev[0].scan_for_bss(bssid, freq=2412) dev[0].roam(bssid) + hapd.wait_sta() check_beacon_req(hapd, addr, 3) From patchwork Mon Sep 25 07:20:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Berg X-Patchwork-Id: 1838923 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=KMk9vow5; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=sipsolutions.net header.i=@sipsolutions.net header.a=rsa-sha256 header.s=mail header.b=bgMhCMuS; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RvDr96B4Nz1ynF for ; Mon, 25 Sep 2023 17:23:37 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Vdw3hDisPA8VhGaNrNcOJasM3714H2arx996k2khuOY=; b=KMk9vow5qixNF6 uO2Yyhz/sEPmw/tymyG7u92+oZO8Y0NVNjFyn0pM7M/TWbR+b3dIsRnYUAjCszhgeePPSyA3eWXDw 5lalrRmevNBePT+1RiSQ63g0ybuArzcjuBZUn1haZJblf5BgQWktFFsS8aL4akrW7dBK3IkVJQPpL mrPH3b0ahwq3ilIdwwakUSzWhku51+E6yXH3tMIh5AdH+pMn/xFxewBInPFCOsvEhrlcKLiKtFORc 85xe+CbVulPWfxwhxkHew8nb2ZNxO8WG7BMO+jrrkb2AJ7CglGeqjjwq0YeFZcMZt3Kx8XfBo5d7c GoMVWSfyqqTHFqz/vZ9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvV-00DYEI-13; Mon, 25 Sep 2023 07:22:41 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:242:246e::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvQ-00DYBf-0A for hostap@lists.infradead.org; Mon, 25 Sep 2023 07:22:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Content-Type:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=7y0hPNLBcQItnUbQy4dd/i4idTF4+jT1Q6mddQZtzS0=; t=1695626555; x=1696836155; b=bgMhCMuS3zWu76zIqLaPosw7EDdKlYszetFdiDDDUrfqETh /UT4Z+l7XkCsgBBLKjMHHdGOffKoo9JXfwdQt6cq0nunhp9Xh17nyJ4GNLVqlQ9teFu385DddkM+Q Q8HyL+pHt2jH2/coEB+IR6S0Th9W5MXtWsYMcZFfyHyWfxbRNDehTOHKcL9jSTjIn+w26W+BnR799 RwAmS62XeImjl5TXKCZywzELPtCLzlwtyg/q+Bw82qfjPmucMv59+W/qnIFjJrApbzjTe/ZNfRMdF 2ENRIEE5y8SqPPk3W/uHGdFOgDTRxtprZ42R/fd5C4AKsrL1LDDIn2iy45U43beQ==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1qkfvN-003GNz-2b; Mon, 25 Sep 2023 09:22:34 +0200 From: Johannes Berg To: hostap@lists.infradead.org Cc: Johannes Berg Subject: [PATCH 03/17] tests: persistent_go_client_list: ignore client order Date: Mon, 25 Sep 2023 09:20:43 +0200 Message-ID: <20230925092039.296dd9014214.I5be157df6a5c085a5baa55eb4cc51d3cd0c13b90@changeid> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230925072039.49987-18-johannes@sipsolutions.net> References: <20230925072039.49987-18-johannes@sipsolutions.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_002236_087547_294D321B X-CRM114-Status: GOOD ( 11.25 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Johannes Berg Clients could connect in a different order depending on timing differences, don't check for the order here. Signed-off-by: Johannes Berg --- tests/hwsim/test_p2p_persistent.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Johannes Berg Clients could connect in a different order depending on timing differences, don't check for the order here. Signed-off-by: Johannes Berg --- tests/hwsim/test_p2p_persistent.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/hwsim/test_p2p_persistent.py b/tests/hwsim/test_p2p_persistent.py index c1610d2d444d..d81c845722b7 100644 --- a/tests/hwsim/test_p2p_persistent.py +++ b/tests/hwsim/test_p2p_persistent.py @@ -337,7 +337,7 @@ def test_persistent_go_client_list(dev): raise Exception("Timeout on group restart (on client)") dev[1].group_form_result(ev) clients = dev[0].global_request("GET_NETWORK " + id + " p2p_client_list").rstrip() - if clients != addr1 + " " + addr2: + if set(clients.split()) != set((addr1, addr2)): raise Exception("Unexpected p2p_client_list entry(4): " + clients) dev[2].remove_group() From patchwork Mon Sep 25 07:20:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Berg X-Patchwork-Id: 1838927 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=RopcZafB; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=sipsolutions.net header.i=@sipsolutions.net header.a=rsa-sha256 header.s=mail header.b=XmZwinEm; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RvDrD1lsmz26jW for ; Mon, 25 Sep 2023 17:23:39 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iWKoZAtjVA26NCpT/9yVy2mvYmYnmcFjfe4sxhMXRS8=; b=RopcZafB8IiwMv gpyslup6Dhw5mZz6BAQWSdMXuzYNP9pIJmqjDTM42j21HSutoZycmtZya/P+NBfDroYjwBvwVWwKl 9hVFO1dBuB/UXsW0IWAr7rLhBwFSQ72NcsKamrKYt0vloN3b3qTa5cfkZnMjeb00vIcJ6FFHvjNOK bj/Dwj1uEqhKa9gY5qkl832vI5j12WFfZFtHRgR/rD9cQgCs7TNfnH8pSlOq+1gPriZiL8cuykW3O TRGgkRkmRkMzaTyVQbN2AFOBy34sSVDkiExB+gBnZlHZzsyFSGiUvCwDbSEOSnQUynDJ4BkQ3P76h nBbVj4XQ5gClmRy+aF0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvW-00DYFA-1m; Mon, 25 Sep 2023 07:22:42 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:242:246e::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvR-00DYCS-2k for hostap@lists.infradead.org; Mon, 25 Sep 2023 07:22:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Content-Type:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=9ZG8c8Uzj6/GftBJc8T3cLeW6R511IEP+MOd53xR6W0=; t=1695626557; x=1696836157; b=XmZwinEmW4rmxcSAeXmhMPR5wfiWr4fnrqRS5V0Q2CbbUt0 mrpeZnkq2oBKs6kCCWsC8d4zFPx675BBYzuIj1uqYYUaNYiUokWPlyUOgieCY4I63euGx/EA1/0i9 HfLTKrkWFir7rZOz0aq4Czv+xUNybimvmIpbguvLgAaelxQno2O50iYLPkEe0B8IJcXVS+Bb2xxU1 ED1VYt4hEfxnPGOZZW+PFDVAJxqbwtgeNKBhjeb9tRSpXOhgaQ91NGbLB3yFspKCDkwWCCduMF7UK rfjNdaM3FkEmq0ZCb5yzCFgNHaBoTbgvAeo/bPeHHFDNFCisWtMsJvczSelObYSw==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1qkfvO-003GNz-2Q; Mon, 25 Sep 2023 09:22:35 +0200 From: Johannes Berg To: hostap@lists.infradead.org Cc: Johannes Berg Subject: [PATCH 04/17] tests: pasn: try get_ptksa() from AP a few times Date: Mon, 25 Sep 2023 09:20:44 +0200 Message-ID: <20230925092039.ed41d90e2359.Ic7a8fd97e17f41ae381142051f91aa6c059bb798@changeid> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230925072039.49987-18-johannes@sipsolutions.net> References: <20230925072039.49987-18-johannes@sipsolutions.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_002237_926224_CE766CEC X-CRM114-Status: GOOD ( 13.21 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Johannes Berg We wait for the PASN auth to complete on the wpas side, but there's no indication of this on the AP side. So if scheduling ordering is bad, we can ask the AP for the PTKSA cache before it even receive [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Johannes Berg We wait for the PASN auth to complete on the wpas side, but there's no indication of this on the AP side. So if scheduling ordering is bad, we can ask the AP for the PTKSA cache before it even received the frame from the kernel and created the PTKSA entry. To fix this, try this a few times, to see if it becomes available. Signed-off-by: Johannes Berg --- tests/hwsim/test_pasn.py | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/tests/hwsim/test_pasn.py b/tests/hwsim/test_pasn.py index 427e51474373..956d2b358a67 100644 --- a/tests/hwsim/test_pasn.py +++ b/tests/hwsim/test_pasn.py @@ -52,10 +52,25 @@ def check_pasn_ptk(dev, hapd, cipher, fail_ptk=False, clear_keys=True, sta_ptksa = dev.get_ptksa(hapd.own_addr(), cipher) ap_ptksa = hapd.get_ptksa(dev.own_addr(), cipher) + # There's no event indicating hostapd has finished + # processing - so just try once more if it isn't + # yet available, it might become available still. + for i in range(10): + if ap_ptksa: + break + time.sleep(0.1) + ap_ptksa = hapd.get_ptksa(dev.own_addr(), cipher) + if not (sta_ptksa and ap_ptksa): if fail_ptk: return - raise Exception("Could not get PTKSA entry") + if not sta_ptksa and not ap_ptksa: + source = 'both' + elif sta_ptksa: + source = 'ap' + else: + source = 'sta' + raise Exception("Could not get PTKSA entry from %s" % source) logger.info("sta: TK: %s KDK: %s" % (sta_ptksa['tk'], sta_ptksa['kdk'])) logger.info("ap : TK: %s KDK: %s" % (ap_ptksa['tk'], ap_ptksa['kdk'])) From patchwork Mon Sep 25 07:20:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Berg X-Patchwork-Id: 1838931 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=zbr9ac2n; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=sipsolutions.net header.i=@sipsolutions.net header.a=rsa-sha256 header.s=mail header.b=pcWC7/iy; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RvDrD24Khz26jZ for ; Mon, 25 Sep 2023 17:23:39 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0sYX4xMAAf108a+iMyX7NWSCYE06K/7jBBxYNCV6BOw=; b=zbr9ac2ntbe/Gl 8tR+TqBOckvykbUID9h3MzXwpMmcwJiv5CJGCe/Xr6m1pxL7K5Y8iVzw50u6Q7CAd9Bq5wforjeUc tlQEbney3LtQWuHEOW/TQ2CuU3PcBiw+gXvgNwjvthqU3zynJbfPL5Zlio0qYTSW2bqpHxh4bVgqz 10GJ6lCEwwTHUR7YrrUNI6qpNRWqbXMeA88A//ItaPT5/cHxwNym09Yvjdc5md8xDC4MuUhChG65H BvBprSlJxaE8yIGLGrZbz5bvPuF95gE+WYNW09PaWpIhC9U52oPkxTNpNQfcB2eQMurdOseDKVLvt +WLfMevkPbJBSifB0kEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvY-00DYGE-0f; Mon, 25 Sep 2023 07:22:44 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:242:246e::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvS-00DYCU-0Y for hostap@lists.infradead.org; Mon, 25 Sep 2023 07:22:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Content-Type:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=axeonhGaFAZgsSWeXSPrZuyrGcFuj5C10CEWj/PmmAQ=; t=1695626558; x=1696836158; b=pcWC7/iyzyHDjFHRAQtH6SEWPmT6UHaVBdnrUpRayck6wV0 MG6jVaR7YTTzS6tNIblF8vh1uRECKwyYFAh9PX2jnz9v3RCuj87WeKX4zYMyQgXDlXi8IEwcR6hdU nYFxoRSa+Gc7m8QgCg7AKAwhxXBVcO2v8m/MSm0+druRHPBsaToMzafdib4xDuao8ycXs87CbgD1l S5zPZ7KdBLgQ2eP4VyxS037DXpTOEZEEORF7T68JtDe7ZHrfOz+EWOmes9LgzE3P1noNlBCn8VTLR azqBFEAnZXgS7RW8dz92FtlLlS0tzAYlCyKxV9aVeXvVV7WAotCh8/1qcbUTZAtw==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1qkfvQ-003GNz-0U; Mon, 25 Sep 2023 09:22:36 +0200 From: Johannes Berg To: hostap@lists.infradead.org Cc: Johannes Berg Subject: [PATCH 05/17] tests: rrm: wait for AP STA before requests to AP Date: Mon, 25 Sep 2023 09:20:45 +0200 Message-ID: <20230925092039.610d5d15bc03.Id3f27b2ef62775282a6458284275ab0b6c941eb6@changeid> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230925072039.49987-18-johannes@sipsolutions.net> References: <20230925072039.49987-18-johannes@sipsolutions.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_002238_367648_93F11AFC X-CRM114-Status: UNSURE ( 9.21 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Johannes Berg Before requesting anything about the specific STA from the AP wait for it to show up, so that things don't fail if the hostapd process didn't yet get time to process things. Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Johannes Berg Before requesting anything about the specific STA from the AP wait for it to show up, so that things don't fail if the hostapd process didn't yet get time to process things. Signed-off-by: Johannes Berg --- tests/hwsim/test_rrm.py | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/tests/hwsim/test_rrm.py b/tests/hwsim/test_rrm.py index 86cde92936b4..7dc2359d8144 100644 --- a/tests/hwsim/test_rrm.py +++ b/tests/hwsim/test_rrm.py @@ -859,6 +859,7 @@ def test_rrm_beacon_req_table(dev, apdev): dev[0].scan_for_bss(apdev[1]['bssid'], freq=2412) dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() req = build_beacon_request(mode=2) token = run_req_beacon(hapd, addr, req) @@ -899,6 +900,7 @@ def test_rrm_beacon_req_frame_body_fragmentation(dev, apdev): dev[0].flush_scan_cache() dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() req = build_beacon_request(mode=2) token = run_req_beacon(hapd, addr, req) @@ -941,6 +943,7 @@ def test_rrm_beacon_req_last_frame_indication(dev, apdev): dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() # The request contains the last beacon report indication subelement req = build_beacon_request(mode=2) @@ -998,6 +1001,7 @@ def test_rrm_beacon_req_table_detail(dev, apdev): dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() logger.info("Reporting Detail 0") req = build_beacon_request(mode=2) @@ -1063,6 +1067,7 @@ def test_rrm_beacon_req_table_request(dev, apdev): dev[0].flush_scan_cache() dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() req = build_beacon_request(mode=2) token = run_req_beacon(hapd, addr, req + "020101" + "0a03000106") @@ -1107,6 +1112,7 @@ def test_rrm_beacon_req_table_request_oom(dev, apdev): dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() req = build_beacon_request(mode=2) with alloc_fail(dev[0], 1, @@ -1152,6 +1158,7 @@ def test_rrm_beacon_req_table_bssid(dev, apdev): dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() bssid2 = hapd2.own_addr() req = build_beacon_request(mode=2, bssid=bssid2) @@ -1177,6 +1184,7 @@ def test_rrm_beacon_req_table_ssid(dev, apdev): dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() bssid2 = hapd2.own_addr() req = build_beacon_request(mode=2) @@ -1220,6 +1228,7 @@ def test_rrm_beacon_req_table_info(dev, apdev): dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() logger.info("Unsupported reporting information 1") req = build_beacon_request(mode=2) @@ -1248,6 +1257,7 @@ def test_rrm_beacon_req_table_unknown_subelem(dev, apdev): dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() req = build_beacon_request(mode=2) token = run_req_beacon(hapd, addr, req + "330101" + "fe00") @@ -1266,6 +1276,7 @@ def test_rrm_beacon_req_table_truncated_subelem(dev, apdev): dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() req = build_beacon_request(mode=2) token = run_req_beacon(hapd, addr, req + "0001") @@ -1283,6 +1294,7 @@ def test_rrm_beacon_req_table_rsne(dev, apdev): dev[0].connect("rrm-rsn", psk="12345678", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() req = build_beacon_request(mode=2) token = run_req_beacon(hapd, addr, req + "020101" + "0a0130") @@ -1333,6 +1345,7 @@ def test_rrm_beacon_req_table_vht(dev, apdev): dev[0].connect("rrm-vht", key_mgmt="NONE", scan_freq="5180") addr = dev[0].own_addr() + hapd.wait_sta() req = build_beacon_request(opclass=240, mode=2) token = run_req_beacon(hapd, addr, req) @@ -1369,6 +1382,7 @@ def test_rrm_beacon_req_active(dev, apdev): dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() req = build_beacon_request(duration=100, mode=1) token = run_req_beacon(hapd, addr, req) @@ -1399,6 +1413,7 @@ def test_rrm_beacon_req_active_ignore_old_result(dev, apdev): dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() req = build_beacon_request(chan=1, duration=100, mode=1) token = run_req_beacon(hapd, addr, req) @@ -1447,6 +1462,7 @@ def test_rrm_beacon_req_active_many(dev, apdev): dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() ok = False for j in range(3): @@ -1476,6 +1492,7 @@ def test_rrm_beacon_req_active_ap_channels(dev, apdev): dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() req = build_beacon_request(chan=255, duration=100, mode=1) token = run_req_beacon(hapd, addr, req + "dd0111" + "330351010b" + "dd0111") @@ -1502,6 +1519,7 @@ def test_rrm_beacon_req_active_no_ir(dev, apdev): dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() req = build_beacon_request(opclass=118, chan=52, duration=100, mode=1) token = run_req_beacon(hapd, addr, req) @@ -1526,6 +1544,7 @@ def test_rrm_beacon_req_passive_ap_channels(dev, apdev): dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() req = build_beacon_request(chan=255, duration=100) token = run_req_beacon(hapd, addr, req + "330351010b" + "3300" + "dd00") @@ -1553,6 +1572,7 @@ def test_rrm_beacon_req_active_single_channel(dev, apdev): dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() req = build_beacon_request(chan=11, duration=100, mode=1) token = run_req_beacon(hapd, addr, req) @@ -1573,6 +1593,7 @@ def test_rrm_beacon_req_active_ap_channels_unknown_opclass(dev, apdev): dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() req = build_beacon_request(chan=255, duration=100, mode=1) token = run_req_beacon(hapd, addr, req + "3303ff010b") @@ -1594,6 +1615,7 @@ def test_rrm_beacon_req_active_ap_channel_oom(dev, apdev): dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() with alloc_fail(dev[0], 1, "wpas_add_channels"): req = build_beacon_request(chan=255, duration=100, mode=1) @@ -1614,6 +1636,7 @@ def test_rrm_beacon_req_active_scan_fail(dev, apdev): dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() with alloc_fail(dev[0], 1, "wpa_supplicant_trigger_scan"): req = build_beacon_request(chan=255, duration=100, mode=1) @@ -1635,6 +1658,7 @@ def test_rrm_beacon_req_active_zero_duration(dev, apdev): dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() req = build_beacon_request(mode=1) token = run_req_beacon(hapd, addr, req) @@ -1649,6 +1673,7 @@ def test_rrm_beacon_req_active_fail_random(dev, apdev): hapd = hostapd.add_ap(apdev[0], params) dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() with fail_test(dev[0], 1, "os_get_random;wpas_rm_handle_beacon_req"): req = build_beacon_request(duration=100, mode=1) @@ -1669,6 +1694,7 @@ def test_rrm_beacon_req_passive(dev, apdev): dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() req = build_beacon_request(duration=100) token = run_req_beacon(hapd, addr, req) @@ -1695,6 +1721,7 @@ def test_rrm_beacon_req_passive_no_match(dev, apdev): dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() req = build_beacon_request(chan=1, duration=100, bssid="02:11:22:33:44:55") token = run_req_beacon(hapd, addr, req) @@ -1713,6 +1740,7 @@ def test_rrm_beacon_req_passive_no_match_oom(dev, apdev): dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() req = build_beacon_request(chan=1, duration=100, bssid="02:11:22:33:44:55") with alloc_fail(dev[0], 1, "wpabuf_resize;wpas_beacon_rep_scan_process"): @@ -1739,6 +1767,7 @@ def test_rrm_beacon_req_active_duration_mandatory(dev, apdev): dev[0].connect("rrm", key_mgmt="NONE", scan_freq="2412") addr = dev[0].own_addr() + hapd.wait_sta() req = build_beacon_request(duration=100, mode=1) token = run_req_beacon(hapd, addr, "req_mode=10 " + req) @@ -1781,6 +1810,7 @@ def test_rrm_beacon_req_passive_scan_vht(dev, apdev): dev[0].connect("rrm-vht", key_mgmt="NONE", scan_freq="5180") addr = dev[0].own_addr() + hapd.wait_sta() req = build_beacon_request(opclass=128, duration=100) token = run_req_beacon(hapd, addr, req) @@ -1837,6 +1867,7 @@ def test_rrm_beacon_req_passive_scan_vht160(dev, apdev): raise Exception("Unexpected SIGNAL_POLL value: " + str(sig)) addr = dev[0].own_addr() + hapd.wait_sta() req = build_beacon_request(opclass=129, duration=100) token = run_req_beacon(hapd, addr, req) From patchwork Mon Sep 25 07:20:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Berg X-Patchwork-Id: 1838935 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=tGzWDRF0; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=sipsolutions.net header.i=@sipsolutions.net header.a=rsa-sha256 header.s=mail header.b=oFEac94s; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RvDrH1FFpz1yqR for ; Mon, 25 Sep 2023 17:23:43 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=05oNKuTCAq4usM9HsKUGteBe2xi80fZpVkT3mQCkOAw=; b=tGzWDRF0EBZHeS hfxbCEP2qAceDALf/09gXG4mk11LPkyAuKxqMx8y68pMDrSACU9mFlIMm2DigddCMpUsD2MekthNc 3HQlapqqpdTqW++nRQk7roqOVUwYU4esYbXwdWuEENtszJmS9iMIN6CnTTucuqsp+oFY3mlO4eZ9d Ov6kNnWyn9RAgV046PwqdwW4sGMduNKZlDCxGTfpenCHpWiXjT29wHYf/+ordGQm+anRrRX/FUZ5y fOkaFF11cPiPTk49avVR6HNsdI3JLh1KOMgHHSoZcBhAQNkMiV17mhmIeGVfxqFelGE5KWQmqnKSu wSB5MCStDM+4zeo8avEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvZ-00DYGy-1W; Mon, 25 Sep 2023 07:22:45 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:242:246e::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvT-00DYD9-0t for hostap@lists.infradead.org; Mon, 25 Sep 2023 07:22:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Content-Type:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=6fF7exTb+tIF9gZdvy3F1XoxO7ghJP3F6a0eV2Devb4=; t=1695626559; x=1696836159; b=oFEac94sTMXx8Q3jN73P+wP9OLnQVQk1LVnPiEmR+osxTbZ 92hmLe+x3JR4XRRHIJ0bwXFw+Ftn14Lvf6CSBwBxdOUA/GqexyRK2FBFUJh0kvEKRN1Oms4GJKJ6U ltRqVeuG7BcNcLwQUSf7E65DFZq+v7d4PrOJFEt7oSGO0Ek4kGf6BPpbTuYHr4La7Kv5qFOLdMPDb SgbIZ3WI1EkL9tmTBPspt4ZRbVT7SdDE4EG8bL5ya3v40HWJ7+BDWJqLk9QrmBTx9gkLo/GYBJ1wC 9hLKqUvSrMbPOlNpiiZN1BHRS6GHLj4o3TjI4PIpprlT9TlHydPF88bJPzzgwk9w==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1qkfvQ-003GNz-2s; Mon, 25 Sep 2023 09:22:37 +0200 From: Johannes Berg To: hostap@lists.infradead.org Cc: Johannes Berg Subject: [PATCH 06/17] tests: autogo_legacy: wait for 4-way-HS Date: Mon, 25 Sep 2023 09:20:46 +0200 Message-ID: <20230925092039.398609f344a0.I3e723d36888dc148896abce2bb92f780fbca7016@changeid> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230925072039.49987-18-johannes@sipsolutions.net> References: <20230925072039.49987-18-johannes@sipsolutions.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_002239_311939_8DDBC358 X-CRM114-Status: UNSURE ( 8.23 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Johannes Berg We need to wait for the 4-way-HS to be completed on the GO side, so the GO will actually have marked the station as authorized and will forward packets. Signed-off-by: Johannes Berg --- tests/hwsim/test_p2p_autogo.py | 2 ++ 1 file changed, 2 insertions(+) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Johannes Berg We need to wait for the 4-way-HS to be completed on the GO side, so the GO will actually have marked the station as authorized and will forward packets. Signed-off-by: Johannes Berg --- tests/hwsim/test_p2p_autogo.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/hwsim/test_p2p_autogo.py b/tests/hwsim/test_p2p_autogo.py index 5453894d77f1..0801172e3a8c 100644 --- a/tests/hwsim/test_p2p_autogo.py +++ b/tests/hwsim/test_p2p_autogo.py @@ -336,9 +336,11 @@ def test_autogo_legacy(dev): logger.info("Connect legacy non-WPS client") dev[2].request("FLUSH") dev[2].request("P2P_SET disabled 1") + dev[0].dump_monitor() dev[2].connect(ssid=res['ssid'], psk=res['passphrase'], proto='RSN', key_mgmt='WPA-PSK', pairwise='CCMP', group='CCMP', scan_freq=res['freq']) + dev[0].wait_event(["EAPOL-4WAY-HS-COMPLETED"]) hwsim_utils.test_connectivity_p2p_sta(dev[1], dev[2]) dev[2].request("DISCONNECT") From patchwork Mon Sep 25 07:20:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Berg X-Patchwork-Id: 1838936 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=YOJoFfDb; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=sipsolutions.net header.i=@sipsolutions.net header.a=rsa-sha256 header.s=mail header.b=imMIbLB7; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RvDrH2fXCz1yqT for ; Mon, 25 Sep 2023 17:23:43 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oK4qw071nBn43gaP53dipV0hqgK7FPDIn9pxt8DCoYU=; b=YOJoFfDbfBumqw EFGXDDsRp8U0a5XiGZh3PoEbRbLw3p3IsyQg49uUUevmg0l3Y2LJKtsLb6KG3kzayiv/JxCtGuAoH bLB9C2jCKd9pIgYBDFTadk5wZbEgRqyjrIO4sOAAiygj0kxYMQ8CezV6mbiSfQg55EaoiySaQ1Ha5 t3pPwxWsFLY53/mD/QsVTpJgnYcD9SlnzS9UiZfF91r5pNmxWa8QvFScX0aUYB88A0IHcWeLntjgW s92xFYFBttNd3E4608blF5h7lbvjEciNWaeTewKgh1poFDjcNs7P0dTlJOYbl5/akBqvzTyO0QG7x E7AAlpQEbKu9v1NElT2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvb-00DYHw-00; Mon, 25 Sep 2023 07:22:47 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:242:246e::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvU-00DYDa-12 for hostap@lists.infradead.org; Mon, 25 Sep 2023 07:22:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Content-Type:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=6NePgFChLtvlAflwPud+Ba9JZ6M+xD4y0qUycw7kGEw=; t=1695626560; x=1696836160; b=imMIbLB7Ss/eE1qQDWLaBs/Bn1Xj05z6LMkkk29lQ6fmOEm oUx2/+hwiBBo25GWwAfni5qjvEGfcn75zuBD2SwtcVcm8zr/F7VQjqYdrYDvFIm017NZZxCwEsHza LZFJujeXOWUeirm7PZmcttFjQiWa8MLZhoB3FcDsPCHJFckc9R+PAUiOKTNJ56qhEx6erDF9D7zSF 1w2V84bPwsxETQbP4iPz8qh4AJqD7k5vs9wYrfBskvgZ7ALAUboRoOqunin6scmM3GlPWdO0VnidG gBul64ESa0sfig7ewYuKobLv/IrjjG3M0PyFMXi5WU9ZHdb8Vt5my1hrqUR/ORIg==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1qkfvS-003GNz-03; Mon, 25 Sep 2023 09:22:38 +0200 From: Johannes Berg To: hostap@lists.infradead.org Cc: Johannes Berg Subject: [PATCH 07/17] tests: test_ap_hs20_connect_no_full_match: add appropriate waits Date: Mon, 25 Sep 2023 09:20:47 +0200 Message-ID: <20230925092039.e4a893286d57.Ic9d8b8dc99392f37f1ccd1220ef4abd85ae5b44b@changeid> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230925072039.49987-18-johannes@sipsolutions.net> References: <20230925072039.49987-18-johannes@sipsolutions.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_002240_391665_EA553E36 X-CRM114-Status: UNSURE ( 9.08 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Johannes Berg We need to appropriately wait for the STA to connect/disconnect before continuing with the test, add that. Signed-off-by: Johannes Berg --- tests/hwsim/test_ap_hs20.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Johannes Berg We need to appropriately wait for the STA to connect/disconnect before continuing with the test, add that. Signed-off-by: Johannes Berg --- tests/hwsim/test_ap_hs20.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/hwsim/test_ap_hs20.py b/tests/hwsim/test_ap_hs20.py index 53335902cce3..151061721ca9 100644 --- a/tests/hwsim/test_ap_hs20.py +++ b/tests/hwsim/test_ap_hs20.py @@ -1380,7 +1380,7 @@ def test_ap_hs20_connect_no_full_match(dev, apdev): params = hs20_ap_params() params['hessid'] = bssid params['anqp_3gpp_cell_net'] = "555,444" - hostapd.add_ap(apdev[0], params) + hapd = hostapd.add_ap(apdev[0], params) dev[0].flush_scan_cache() dev[0].hs20_enable() @@ -1400,8 +1400,12 @@ def test_ap_hs20_connect_no_full_match(dev, apdev): if "below_min_backhaul=1" not in ev: raise Exception("below_min_backhaul not reported") interworking_connect(dev[0], bssid, "TTLS") + # wait for sta to connect so it can actually disconnect later + hapd.wait_sta() dev[0].remove_cred(id) dev[0].wait_disconnected() + # wait for sta to disconnect so it can send GAS query + hapd.wait_event(["AP-STA-DISCONNECTED"], timeout=1) vals = {'imsi': "555444-333222111", 'eap': "SIM", 'milenage': "5122250214c33e723a5dd523fc145fc0:981d464c7c52eb6e5036234984ad0bcf:000000000123", From patchwork Mon Sep 25 07:20:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Berg X-Patchwork-Id: 1838930 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=wnKiHrHo; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=sipsolutions.net header.i=@sipsolutions.net header.a=rsa-sha256 header.s=mail header.b=YXZWY3N7; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RvDrD23Jhz26jY for ; Mon, 25 Sep 2023 17:23:39 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Seoy077edHli1Onnk7HxDyMGU9a3ZeqJfUXrU5M4d50=; b=wnKiHrHopKqaRS IgVlB/IDREgY4fHFX+rFO5mccIaoa81oYCujNhL1Uu+wVKEMP4eAtORnkcQI2jyjgLrPwuxam4MJT MPCUZohAU388CCnX+tcWNf8bdPCWSOt9K8qbOKe9NjBV/afC9xN15XnkSOasaRbXHtPhlIHPBmY0z ZZqiSuQgdRD9mOmIt0TVk+veoQ/JzoN3+9VkfjMtlvxKKadPAqCs9p/uSnK1O5OPpbDBchu9x/F3F DLTZ3zIGWIxFyTZxHkPHXaIcI0X0TuuQ2n3VtdXwx2OcIY6sovDVzyfW7Xq9fgBEse+bkNloFwaVM piLtxZIWWMMs9aPkBAhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkfve-00DYKe-1m; Mon, 25 Sep 2023 07:22:50 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:242:246e::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvV-00DYDo-0I for hostap@lists.infradead.org; Mon, 25 Sep 2023 07:22:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Content-Type:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=AaVFUnYv6pSWnDKOc680OzfaCUkObEW2CBDpVyGV2gw=; t=1695626560; x=1696836160; b=YXZWY3N7a1d5TqjiN0I4InQ7jg06bRk+ZXD0dzWUEIH57+n KxE7v12dvlfDWR0b56QreuypwvEHxyOuXo5d0vgcKnsGs2r2EK0y4inhxHCcQ0JL876UXF/xDdctv DhLfQdKWKEpyFoAdV1kTvFyB9Uigj2h8dpyr5nG8Fjg/NTi1OpS21mfnJeJbqyYtZ7dFd3ATF6yLA 5GgdVTc+Ow4D89UFL1Gj6dE1wJnceTMHzIPeJLs0vS7n2A+YgNxozkiOvdWC96rhuYw3mKi7wbKra WlKSy4BSB7SZv5qv8UAqcg8qN87IH5Cycfn8c3m8dT7vKa87JWvVHVvIyjCiGs5A==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1qkfvS-003GNz-2x; Mon, 25 Sep 2023 09:22:39 +0200 From: Johannes Berg To: hostap@lists.infradead.org Cc: Johannes Berg Subject: [PATCH 08/17] tests: ap_hs20: add more wait_sta() Date: Mon, 25 Sep 2023 09:20:48 +0200 Message-ID: <20230925092039.df799790c600.I96bf26669af98cb2975854924504e35782ee7664@changeid> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230925072039.49987-18-johannes@sipsolutions.net> References: <20230925072039.49987-18-johannes@sipsolutions.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_002241_302139_9CAB06FD X-CRM114-Status: UNSURE ( 9.94 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Johannes Berg We should always wait_sta() so that we know we can even deauth next, otherwise the key might not be installed yet by the time we try to connect to the next AP. Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Johannes Berg We should always wait_sta() so that we know we can even deauth next, otherwise the key might not be installed yet by the time we try to connect to the next AP. Signed-off-by: Johannes Berg --- tests/hwsim/test_ap_hs20.py | 66 ++++++++++++++++++++----------------- 1 file changed, 36 insertions(+), 30 deletions(-) diff --git a/tests/hwsim/test_ap_hs20.py b/tests/hwsim/test_ap_hs20.py index 151061721ca9..cf52a8b562e7 100644 --- a/tests/hwsim/test_ap_hs20.py +++ b/tests/hwsim/test_ap_hs20.py @@ -1509,7 +1509,7 @@ def test_ap_hs20_gas_with_another_ap_while_associated(dev, apdev): bssid = apdev[0]['bssid'] params = hs20_ap_params() params['hessid'] = bssid - hostapd.add_ap(apdev[0], params) + hapd = hostapd.add_ap(apdev[0], params) bssid2 = apdev[1]['bssid'] params = hs20_ap_params() @@ -1571,6 +1571,7 @@ def _test_ap_hs20_gas_while_associated_with_pmf(dev, apdev): 'domain': "example.com"}) interworking_select(dev[0], bssid, "home", freq="2412") interworking_connect(dev[0], bssid, "TTLS") + hapd.wait_sta() logger.info("Verifying GAS query while associated") dev[0].request("FETCH_ANQP") @@ -1739,8 +1740,10 @@ def test_ap_hs20_disallow_aps(dev, apdev): if "FAIL" not in dev[0].request("INTERWORKING_CONNECT 00:11:22:33:44:55"): raise Exception("Invalid INTERWORKING_CONNECT not rejected") -def policy_test(dev, ap, values, only_one=True): +def policy_test(dev, ap, hapd, values, only_one=True): dev.dump_monitor() + if hapd is not None: + hapd.dump_monitor() if ap: logger.info("Verify network selection to AP " + ap['ifname']) bssid = ap['bssid'] @@ -1776,6 +1779,9 @@ def policy_test(dev, ap, values, only_one=True): if bssid and conn_bssid != bssid: raise Exception("bssid information points to incorrect BSS") + if hapd is not None: + hapd.wait_sta() + dev.remove_cred(id) dev.dump_monitor() return events @@ -1794,35 +1800,35 @@ def test_ap_hs20_prefer_home(dev, apdev): check_eap_capa(dev[0], "MSCHAPV2") params = hs20_ap_params() params['domain_name'] = "example.org" - hostapd.add_ap(apdev[0], params) + hapd0 = hostapd.add_ap(apdev[0], params) params = hs20_ap_params() params['ssid'] = "test-hs20-other" params['domain_name'] = "example.com" - hostapd.add_ap(apdev[1], params) + hapd1 = hostapd.add_ap(apdev[1], params) values = default_cred() values['domain'] = "example.com" - policy_test(dev[0], apdev[1], values, only_one=False) + policy_test(dev[0], apdev[1], hapd1, values, only_one=False) values['domain'] = "example.org" - policy_test(dev[0], apdev[0], values, only_one=False) + policy_test(dev[0], apdev[0], hapd0, values, only_one=False) def test_ap_hs20_req_home_ois(dev, apdev): """Hotspot 2.0 required roaming consortium""" check_eap_capa(dev[0], "MSCHAPV2") params = hs20_ap_params() - hostapd.add_ap(apdev[0], params) + hapd0 = hostapd.add_ap(apdev[0], params) params = hs20_ap_params() params['ssid'] = "test-hs20-other" params['roaming_consortium'] = ["223344"] - hostapd.add_ap(apdev[1], params) + hapd1 = hostapd.add_ap(apdev[1], params) values = default_cred() values['required_home_ois'] = ["223344"] - policy_test(dev[0], apdev[1], values) + policy_test(dev[0], apdev[1], hapd1, values) values['required_home_ois'] = ["112233"] - policy_test(dev[0], apdev[0], values) + policy_test(dev[0], apdev[0], hapd0, values) id = dev[0].add_cred() dev[0].set_cred_quoted(id, "required_home_ois", "112233") @@ -1861,22 +1867,22 @@ def test_ap_hs20_excluded_ssid(dev, apdev): params = hs20_ap_params() params['roaming_consortium'] = ["223344"] params['anqp_3gpp_cell_net'] = "555,444" - hostapd.add_ap(apdev[0], params) + hapd0 = hostapd.add_ap(apdev[0], params) params = hs20_ap_params() params['ssid'] = "test-hs20-other" params['roaming_consortium'] = ["223344"] params['anqp_3gpp_cell_net'] = "555,444" - hostapd.add_ap(apdev[1], params) + hapd1 = hostapd.add_ap(apdev[1], params) values = default_cred() values['excluded_ssid'] = "test-hs20" - events = policy_test(dev[0], apdev[1], values) + events = policy_test(dev[0], apdev[1], hapd1, values) ev = [e for e in events if "INTERWORKING-BLACKLISTED " + apdev[0]['bssid'] in e] if len(ev) != 1: raise Exception("Excluded network not reported") values['excluded_ssid'] = "test-hs20-other" - events = policy_test(dev[0], apdev[0], values) + events = policy_test(dev[0], apdev[0], hapd0, values) ev = [e for e in events if "INTERWORKING-BLACKLISTED " + apdev[1]['bssid'] in e] if len(ev) != 1: raise Exception("Excluded network not reported") @@ -1886,7 +1892,7 @@ def test_ap_hs20_excluded_ssid(dev, apdev): values['eap'] = "TTLS" values['phase2'] = "auth=MSCHAPV2" values['excluded_ssid'] = "test-hs20" - events = policy_test(dev[0], apdev[1], values) + events = policy_test(dev[0], apdev[1], hapd1, values) ev = [e for e in events if "INTERWORKING-BLACKLISTED " + apdev[0]['bssid'] in e] if len(ev) != 1: raise Exception("Excluded network not reported") @@ -1894,7 +1900,7 @@ def test_ap_hs20_excluded_ssid(dev, apdev): values = {'imsi': "555444-333222111", 'eap': "SIM", 'milenage': "5122250214c33e723a5dd523fc145fc0:981d464c7c52eb6e5036234984ad0bcf:000000000123", 'excluded_ssid': "test-hs20"} - events = policy_test(dev[0], apdev[1], values) + events = policy_test(dev[0], apdev[1], hapd1, values) ev = [e for e in events if "INTERWORKING-BLACKLISTED " + apdev[0]['bssid'] in e] if len(ev) != 1: raise Exception("Excluded network not reported") @@ -1993,43 +1999,43 @@ def test_ap_hs20_roaming_partner_preference(dev, apdev): check_eap_capa(dev[0], "MSCHAPV2") params = hs20_ap_params() params['domain_name'] = "roaming.example.org" - hostapd.add_ap(apdev[0], params) + hapd0 = hostapd.add_ap(apdev[0], params) params = hs20_ap_params() params['ssid'] = "test-hs20-other" params['domain_name'] = "roaming.example.net" - hostapd.add_ap(apdev[1], params) + hapd1 = hostapd.add_ap(apdev[1], params) logger.info("Verify default vs. specified preference") values = default_cred() values['roaming_partner'] = "roaming.example.net,1,127,*" - policy_test(dev[0], apdev[1], values, only_one=False) + policy_test(dev[0], apdev[1], hapd1, values, only_one=False) values['roaming_partner'] = "roaming.example.net,1,129,*" - policy_test(dev[0], apdev[0], values, only_one=False) + policy_test(dev[0], apdev[0], hapd0, values, only_one=False) logger.info("Verify partial FQDN match") values['roaming_partner'] = "example.net,0,0,*" - policy_test(dev[0], apdev[1], values, only_one=False) + policy_test(dev[0], apdev[1], hapd1, values, only_one=False) values['roaming_partner'] = "example.net,0,255,*" - policy_test(dev[0], apdev[0], values, only_one=False) + policy_test(dev[0], apdev[0], hapd0, values, only_one=False) def test_ap_hs20_max_bss_load(dev, apdev): """Hotspot 2.0 and maximum BSS load""" check_eap_capa(dev[0], "MSCHAPV2") params = hs20_ap_params() params['bss_load_test'] = "12:200:20000" - hostapd.add_ap(apdev[0], params) + hapd0 = hostapd.add_ap(apdev[0], params) params = hs20_ap_params() params['ssid'] = "test-hs20-other" params['bss_load_test'] = "5:20:10000" - hostapd.add_ap(apdev[1], params) + hapd1 = hostapd.add_ap(apdev[1], params) logger.info("Verify maximum BSS load constraint") values = default_cred() values['domain'] = "example.com" values['max_bss_load'] = "100" - events = policy_test(dev[0], apdev[1], values, only_one=False) + events = policy_test(dev[0], apdev[1], hapd1, values, only_one=False) ev = [e for e in events if "INTERWORKING-AP " + apdev[0]['bssid'] in e] if len(ev) != 1 or "over_max_bss_load=1" not in ev[0]: @@ -2040,7 +2046,7 @@ def test_ap_hs20_max_bss_load(dev, apdev): logger.info("Verify maximum BSS load does not prevent connection") values['max_bss_load'] = "1" - events = policy_test(dev[0], None, values) + events = policy_test(dev[0], None, None, values) ev = [e for e in events if "INTERWORKING-AP " + apdev[0]['bssid'] in e] if len(ev) != 1 or "over_max_bss_load=1" not in ev[0]: @@ -2058,13 +2064,13 @@ def test_ap_hs20_max_bss_load2(dev, apdev): params = hs20_ap_params() params['ssid'] = "test-hs20-other" - hostapd.add_ap(apdev[1], params) + hapd1 = hostapd.add_ap(apdev[1], params) logger.info("Verify maximum BSS load constraint with AP advertisement") values = default_cred() values['domain'] = "example.com" values['max_bss_load'] = "100" - events = policy_test(dev[0], apdev[1], values, only_one=False) + events = policy_test(dev[0], apdev[1], hapd1, values, only_one=False) ev = [e for e in events if "INTERWORKING-AP " + apdev[0]['bssid'] in e] if len(ev) != 1 or "over_max_bss_load=1" not in ev[0]: @@ -2078,12 +2084,12 @@ def test_ap_hs20_max_bss_load_roaming(dev, apdev): check_eap_capa(dev[0], "MSCHAPV2") params = hs20_ap_params() params['bss_load_test'] = "12:200:20000" - hostapd.add_ap(apdev[0], params) + hapd0 = hostapd.add_ap(apdev[0], params) values = default_cred() values['domain'] = "roaming.example.com" values['max_bss_load'] = "100" - events = policy_test(dev[0], apdev[0], values, only_one=True) + events = policy_test(dev[0], apdev[0], hapd0, values, only_one=True) ev = [e for e in events if "INTERWORKING-AP " + apdev[0]['bssid'] in e] if len(ev) != 1: raise Exception("No INTERWORKING-AP event") From patchwork Mon Sep 25 07:20:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Berg X-Patchwork-Id: 1838928 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=xYiy2r2z; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=sipsolutions.net header.i=@sipsolutions.net header.a=rsa-sha256 header.s=mail header.b=bYmdz+uW; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RvDrD1mFqz26jX for ; Mon, 25 Sep 2023 17:23:39 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VWra7FmR1BQHH7T+k6vm3LJ8bKqlFXVY2w3CITNRA2I=; b=xYiy2r2z5hTCw+ qUI/ZaKFpkskTlUFZwsauZFhqZ+j6ynCYWNtij4Ex9F8pXEfwxHzN4L6+r5PiMnj3GSfyUJ0TozFU BZShqlmqRqdki5wzMDmpaNMwZ7nvmHM0ZtS6EYY8cpWtzPg0ltvTbcl7yn3z2W4ZUi5ioNF4tJ0+F MQqZ6D7r3OB3Z/wJOKRLbBcOXWEjXrMeZpCU28AoRbjnx0mcrtiPK0zs1FDZlGCyZNY7tjzLuwvad RFCJ7rvYUOnOHY4jkFKLjMjMnWzK3mOyZ/ly5uQoa7KSwtqSF3NpZUCc0uEdxw5I6fMf5+1+9zyoP 9pZCGX6aWpdBTErrz09g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvd-00DYK4-1J; Mon, 25 Sep 2023 07:22:49 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:242:246e::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvV-00DYE7-1F for hostap@lists.infradead.org; Mon, 25 Sep 2023 07:22:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Content-Type:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=WibSPLfwPe/vGsjeeJvixIuZGtbDB7L9N7i3rjIa5Tg=; t=1695626561; x=1696836161; b=bYmdz+uWrVBepR33RPwHXgaisrXn+bvyVYVPuoclfYzySpR UonICRHGOeIB3wr5wYvPprSdUFn0rUFnzZfaZXnudGLuPJxYeeOEP4/VwoGmEpLNgZh+pprJFofzl AGnATI50BlooqCHk5dTrhVhH65swDhxfucblC4eBRPn/jtdAoZpSSpXY4O35TlqBPnYnhETSoqAZ3 s9GEsqocforQEFVo7zWxTPmzTvXs3eRo+U2cUBnhHc4XkQfd1WfeHvsX6DqczYlDy/hYvyLGmaNNe FyBUtKgg63Y8No8hQmXSDP4/UQj81GifUMVwLEF7mP/7Px+wRmkHgkUUl7ReZXcw==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1qkfvT-003GNz-1h; Mon, 25 Sep 2023 09:22:39 +0200 From: Johannes Berg To: hostap@lists.infradead.org Cc: Johannes Berg Subject: [PATCH 09/17] tests: hwsim: add more tracing Date: Mon, 25 Sep 2023 09:20:49 +0200 Message-ID: <20230925092039.d926184d84d7.Ifc837773384c3539f2cd7559f53ddcf6fafa26f4@changeid> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230925072039.49987-18-johannes@sipsolutions.net> References: <20230925072039.49987-18-johannes@sipsolutions.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_002241_431785_351BE7E4 X-CRM114-Status: UNSURE ( 9.88 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Johannes Berg Add SKB tracing (which shows now why/where a frame was dropped in the stack), and also -T for stack trace at each event. Signed-off-by: Johannes Berg --- tests/hwsim/run-tests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Johannes Berg Add SKB tracing (which shows now why/where a frame was dropped in the stack), and also -T for stack trace at each event. Signed-off-by: Johannes Berg --- tests/hwsim/run-tests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/hwsim/run-tests.py b/tests/hwsim/run-tests.py index f63bb567766c..0d69f303c103 100755 --- a/tests/hwsim/run-tests.py +++ b/tests/hwsim/run-tests.py @@ -132,7 +132,7 @@ class DataCollector(object): def __enter__(self): if self._tracing: output = os.path.abspath(os.path.join(self._logdir, '%s.dat' % (self._testname, ))) - self._trace_cmd = subprocess.Popen(['trace-cmd', 'record', '-o', output, '-e', 'mac80211', '-e', 'cfg80211', '-e', 'printk', 'sh', '-c', 'echo STARTED ; read l'], + self._trace_cmd = subprocess.Popen(['trace-cmd', 'record', '-o', output, '-T', '-e', 'skb', '-e', 'mac80211', '-e', 'cfg80211', '-e', 'printk', 'sh', '-c', 'echo STARTED ; read l'], stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=open('/dev/null', 'w'), From patchwork Mon Sep 25 07:20:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Berg X-Patchwork-Id: 1838919 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Tc/g29ZM; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=sipsolutions.net header.i=@sipsolutions.net header.a=rsa-sha256 header.s=mail header.b=FO7Mcft0; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RvDrC1Vqrz26jP for ; Mon, 25 Sep 2023 17:23:39 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fDdajprizq9NaNm5HrPahU5MaAVsVh3D4QTetgn8Hdk=; b=Tc/g29ZM7UeRjW j735dnrUm1MRUuemr88qbMYDmvYZv/NcdjJ+diaVQxy70lQzjKafTyc2GvNfgCpkl8Xt5zNhYVqxs GSwa8zcOCwPIEJdLHCVuftE5JPBZZdRitKl57Jpm9o4d6zPyRx0542pTxeDcprUCLuALBocDrgsjn 78nfN+laTdcoV0wMS+YK+3L1eMttOasZyefb6M72wj+FKKQl8qt7IEJTd3YzmmqUVz9BM/nVC8GLW bEDXP/VESa9vdlFIyUkjfsP/ZopkHjHlmIQpL+tvyc7G4ODdDHNIUhpVP5dgRGEjOjwMLlI4IA86N mhJy3Hn/46jQWh96zT9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvf-00DYL0-2D; Mon, 25 Sep 2023 07:22:51 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:242:246e::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvW-00DYEj-0w for hostap@lists.infradead.org; Mon, 25 Sep 2023 07:22:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Content-Type:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=ARKvtCtq2RjRtp49qqm0kDx+VE/uxZOenMW/oBFROcI=; t=1695626562; x=1696836162; b=FO7Mcft0k8pxDFe4pE7eH/8SjhyLQ1tCgZZzz4+8YR3y2k1 t01wvO/GaiwO66N35ppZDoc2CEjnrIUfIF7i1D3C7f0sKwXABl3+rXICEcXPSvMzYF7EcmWqwIC0S jeb5qOmAhDnZ99fHfDQ+J55P4D5pgYQqBPNppx/VA/Z8JU7NeuSV4FeU/smIehN+tV5u0K7A98R8T l1GKda+VMQszSxMeGYb8E29pNqp4eHxKv/AyO1Wf0a11RSvx0Al2/eWUZq7HRlJoDsI9l1JBwGyVz M+eBEO+x3mthflZSzdQlb3bLBSN5XCO0F1/zRh+Aez6lxxrdME44Zb7sfQ0CBqsQ==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1qkfvU-003GNz-11; Mon, 25 Sep 2023 09:22:40 +0200 From: Johannes Berg To: hostap@lists.infradead.org Cc: Johannes Berg Subject: [PATCH 10/17] tests: blocked rekey: give slightly more time Date: Mon, 25 Sep 2023 09:20:50 +0200 Message-ID: <20230925092039.9042498b394f.I785dd85e9026eaafb5975efc6485d356cdad72cd@changeid> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230925072039.49987-18-johannes@sipsolutions.net> References: <20230925072039.49987-18-johannes@sipsolutions.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_002242_326949_B7EFAED6 X-CRM114-Status: GOOD ( 11.45 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Johannes Berg Due to scheduling changes, we don't always now succeed to reconnect in exactly 1 second, it might take 1.01. Give it 1.1 for a bit more leeway, it's not clear why it should be exactly 1 second anyway. Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Johannes Berg Due to scheduling changes, we don't always now succeed to reconnect in exactly 1 second, it might take 1.01. Give it 1.1 for a bit more leeway, it's not clear why it should be exactly 1 second anyway. Signed-off-by: Johannes Berg --- tests/hwsim/test_ap_psk.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/hwsim/test_ap_psk.py b/tests/hwsim/test_ap_psk.py index aac104bb7cd6..4d493cb3c6ef 100644 --- a/tests/hwsim/test_ap_psk.py +++ b/tests/hwsim/test_ap_psk.py @@ -250,7 +250,7 @@ def test_ap_wpa2_ptk_rekey_blocked_ap(dev, apdev): raise Exception("PTK rekey timed out") if "WPA: Key negotiation completed" in ev: raise Exception("No disconnect, PTK rekey succeeded") - ev = dev[0].wait_event(["WPA: Key negotiation completed"], timeout=1) + ev = dev[0].wait_event(["WPA: Key negotiation completed"], timeout=1.1) if ev is None: raise Exception("Reconnect too slow") @@ -268,7 +268,7 @@ def test_ap_wpa2_ptk_rekey_blocked_sta(dev, apdev): raise Exception("PTK rekey timed out") if "WPA: Key negotiation completed" in ev: raise Exception("No disconnect, PTK rekey succeeded") - ev = dev[0].wait_event(["WPA: Key negotiation completed"], timeout=1) + ev = dev[0].wait_event(["WPA: Key negotiation completed"], timeout=1.1) if ev is None: raise Exception("Reconnect too slow") From patchwork Mon Sep 25 07:20:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Berg X-Patchwork-Id: 1838924 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=og1GXdHO; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=sipsolutions.net header.i=@sipsolutions.net header.a=rsa-sha256 header.s=mail header.b=Fgb9TtVn; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RvDrB6whTz1yqT for ; Mon, 25 Sep 2023 17:23:38 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v6uUCmD/lW0pjlm08Bs8MZUvaplNyTL63kxPxWpmzB4=; b=og1GXdHO2hkthP /GY87VKLSF5Y8Z1zPWqe1BapL6isbyVZ0Icw/ac8rxhwf7V4yxY+CgGtnSExuJHcIfPYmRADv4iuX 0P8fk/gsWsKEhpHnteUwMuB+SO1KbpjX2jQG/g9QNlwmZOVS/295T7PFIxYMtGGHSiddde0GQY85L fdUYSTXVZGlk68wiz8mnrrbNIEUBJFu6CUcG2QC3nFcCev3I9AV37E3ppkRXCrBJD6Lfxw1Ef5bcl c1KYYXIJxNTN4ArOmXjP5MKzIgQogaQp5NkhNT3H/5+Kob+fPTXSJtiqjlMtzdfVq89gtN0z9d7wD H7jzMKEHEZ5dL5OHds6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvh-00DYLn-0P; Mon, 25 Sep 2023 07:22:53 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:242:246e::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvX-00DYEw-0Q for hostap@lists.infradead.org; Mon, 25 Sep 2023 07:22:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Content-Type:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=j55qdrShNtPkmhf8YGikz+pB0YIfv7eoxYMjmKOcxuk=; t=1695626562; x=1696836162; b=Fgb9TtVnF86Ni6/6gnpCMjaz7GryqTE9I9cL0g566kpc6Fp 8ZMEfcs0tOWtEFs1ORiD+C2k5qAcdsPWucrlSIDWtMqL63Iq7ooRsL/oUbF0tMxfjgkEMwRP8sHJC dR5c+tPNzr+tf/zwmv13sGNH96pt6Ub28/SmoFFPwxVmebKTWISS8jAVFXryJTQpoR10WATu/dP0i vZ4S3sLVf8/gzT7GS/fQV+xEvP6/XDdGI74Qew4YQ0bVvzjNoHKXSVegCvWMadqz0RHcVaZp1AiNH HzKFQ1oXKgatbd1EdFxUkBoGQ/hWOOCWEMHcpVEIrX/bTIwthbqj0XzGgo6TxnAA==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1qkfvV-003GNz-0L; Mon, 25 Sep 2023 09:22:41 +0200 From: Johannes Berg To: hostap@lists.infradead.org Cc: Johannes Berg Subject: [PATCH 11/17] tests: ap_tdls: wait before connectivity checks Date: Mon, 25 Sep 2023 09:20:51 +0200 Message-ID: <20230925092039.7f33bd5e22d1.I9d57c12b83fd0aa689fe1badcfb4f5fff69ed512@changeid> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230925072039.49987-18-johannes@sipsolutions.net> References: <20230925072039.49987-18-johannes@sipsolutions.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_002243_177401_D1022953 X-CRM114-Status: GOOD ( 10.51 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Johannes Berg All processes need to have a bit of time to mark the kernel STAs authorized, otherwise traffic may fail. Give them some time, and also use check_connectivity() in connectivity() since it's the same ch [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Johannes Berg All processes need to have a bit of time to mark the kernel STAs authorized, otherwise traffic may fail. Give them some time, and also use check_connectivity() in connectivity() since it's the same check, just different arguments. Signed-off-by: Johannes Berg --- tests/hwsim/test_ap_tdls.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/hwsim/test_ap_tdls.py b/tests/hwsim/test_ap_tdls.py index 637dd3e531cc..2b6a440b0cf7 100644 --- a/tests/hwsim/test_ap_tdls.py +++ b/tests/hwsim/test_ap_tdls.py @@ -22,9 +22,7 @@ def start_ap_wpa2_psk(ap): return hostapd.add_ap(ap, params) def connectivity(dev, hapd): - hwsim_utils.test_connectivity_sta(dev[0], dev[1]) - hwsim_utils.test_connectivity(dev[0], hapd) - hwsim_utils.test_connectivity(dev[1], hapd) + check_connectivity(dev[0], dev[1], hapd) def connect_2sta(dev, ssid, hapd, sae=False): key_mgmt = "SAE" if sae else "WPA-PSK" @@ -112,6 +110,8 @@ def tdls_check_ap(sta0, sta1, bssid, addr0, addr1): raise Exception("Invalid frames through AP path") def check_connectivity(sta0, sta1, hapd): + # give a bit of time for all sides to mark kernel STAs authorized + time.sleep(0.1) hwsim_utils.test_connectivity_sta(sta0, sta1) hwsim_utils.test_connectivity(sta0, hapd) hwsim_utils.test_connectivity(sta1, hapd) @@ -358,6 +358,8 @@ def test_ap_wpa2_tdls_bssid_mismatch(dev, apdev): bssid=apdev[0]['bssid']) dev[1].connect(ssid, psk=passphrase, scan_freq="2412", bssid=apdev[1]['bssid']) + # give a bit of time for all sides to mark kernel STAs authorized + time.sleep(0.1) hwsim_utils.test_connectivity_sta(dev[0], dev[1]) hwsim_utils.test_connectivity_iface(dev[0], hapd, "ap-br0") hwsim_utils.test_connectivity_iface(dev[1], hapd, "ap-br0") From patchwork Mon Sep 25 07:20:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Berg X-Patchwork-Id: 1838926 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=L5PRPslZ; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=sipsolutions.net header.i=@sipsolutions.net header.a=rsa-sha256 header.s=mail header.b=GajePi4x; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RvDrD0wNVz26jV for ; Mon, 25 Sep 2023 17:23:39 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UfcMHHCxDyDgE8SUkjJapINbN4fZLrHI7n/0dWjPsis=; b=L5PRPslZIcSmF3 2YXgIjtWiluCl626iPYZCpkK+NGRz5I40pxd9H11fTB/akX7QwwpM0jMa80a5TPJukkKi2SI8mBBW CSig0Drebc1UO3/fMJsrk5osb+mc46/be4QO7oTr8QfVIHXGUVtCh/HmGZAvea24V6uTiejZQDjbX CvBCqZxwQwygmzHkXdRwMtHqy5iRjoK56VsQRQ/opXY1jUBhaegGZNxKJ1bi6yKHTN0kxTFZhFnVi ug7KnhR4fuB/6PN94KJCkOmD5NuInOZHrkbIlWPv0+FXgL70DkfZSDsw8z59udsbsML3JXu0w1yM8 fO8UFvWYgNo5LDr7Yfuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvj-00DYMe-03; Mon, 25 Sep 2023 07:22:55 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:242:246e::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvX-00DYFV-2Z for hostap@lists.infradead.org; Mon, 25 Sep 2023 07:22:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Content-Type:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=BOTN6xNw0sfzGUw9DdEnX3CCthUBV3Yhsu1yIIgy4WA=; t=1695626563; x=1696836163; b=GajePi4xOfYW5XK1m6cyL8imCglx3JPxtXXmjm/UmMNMg1M suhcnxxjzcDPrqEjgs5kGtzljqmirjkC3cNSD9M4KOw/qBck9IJpob35lGFCTribH6uZWs0vMmn1i uII1c1kQmyoAeAXaiBmDeb/FFt9I5mUJYjCGWz/kDX00qiXLJoXUFm7LjURUOfIG2bRpHzNnzbo1Q OFYS7geoVisgVuV453988iA7k6V9L8J/04IzNmIYFYhG/+T55wd79Z3O1Rc13ID5oXpYvaGNbG5mI PfFJy/l65IHOc3Rei2De0B9TVqIcy748IRpgQAhITSlp/rcaeSciz+5yPnQEK9vQ==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1qkfvV-003GNz-2J; Mon, 25 Sep 2023 09:22:41 +0200 From: Johannes Berg To: hostap@lists.infradead.org Cc: Johannes Berg Subject: [PATCH 12/17] wpa_s: ctrl_iface: don't disconnect on scan_freq update Date: Mon, 25 Sep 2023 09:20:52 +0200 Message-ID: <20230925092039.f3292bf22637.I504749a3eb922d059d8e17aa34d3f09c87abf901@changeid> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230925072039.49987-18-johannes@sipsolutions.net> References: <20230925072039.49987-18-johannes@sipsolutions.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_002243_837699_FEFBF826 X-CRM114-Status: UNSURE ( 9.76 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Johannes Berg It doesn't make sense to disconnect on updates to the network's scan_freq, and in fact doing so causes some (timing-/scheduling-dependent) test failures. Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Johannes Berg It doesn't make sense to disconnect on updates to the network's scan_freq, and in fact doing so causes some (timing-/scheduling-dependent) test failures. Signed-off-by: Johannes Berg --- wpa_supplicant/ctrl_iface.c | 1 + 1 file changed, 1 insertion(+) diff --git a/wpa_supplicant/ctrl_iface.c b/wpa_supplicant/ctrl_iface.c index b14c78f807d7..eb2d97d06f2c 100644 --- a/wpa_supplicant/ctrl_iface.c +++ b/wpa_supplicant/ctrl_iface.c @@ -3609,6 +3609,7 @@ static int wpa_supplicant_ctrl_iface_update_network( if (os_strcmp(name, "bssid") != 0 && os_strcmp(name, "bssid_hint") != 0 && + os_strcmp(name, "scan_freq") != 0 && os_strcmp(name, "priority") != 0) { wpa_sm_pmksa_cache_flush(wpa_s->wpa, ssid); From patchwork Mon Sep 25 07:20:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Berg X-Patchwork-Id: 1838934 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=gGI6OWWh; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=sipsolutions.net header.i=@sipsolutions.net header.a=rsa-sha256 header.s=mail header.b=JXVoUdub; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RvDrF5Fxwz26jP for ; Mon, 25 Sep 2023 17:23:41 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eOJBrmzvKLBtO+ZBZOtM685EttgMko5hK2YuByz48Zw=; b=gGI6OWWht9qeoH bw8NoXob2zMtyJynM2V5AOnrIPrcWm0NAUfJbCnfwTKjv/vxpovTCOz8mrmQRWg56hF0ghDpGqeWy Uz74jhRoiwZDeuPJw51IHGao3SGFTfgoarOFm+AZ3pCaFpWGjOX+E2lrRiJ3WXBAc3Bf41oXo5svV V/bONaplfx1+BLIN65SBQeJ5bBA6Oo+kWJqVswnNpX5Ti7ZWL6B5BsXE7HV/fbKQ7ak8uZwC1O0wy /FRLzg1xcZPsQXwoUbJZ5zcirheXvbmQ2flpRh5awD15Tx/YuIRfcvn1ItKvBip6ixWUZG9/CwS71 4XBeYC57FYniX3u4x5yw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvl-00DYNi-0u; Mon, 25 Sep 2023 07:22:57 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:242:246e::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvY-00DYFz-2K for hostap@lists.infradead.org; Mon, 25 Sep 2023 07:22:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Content-Type:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=dNwnl+hsf/RgLwCcktspSPa5hCCLKuzFt8c9ezO+Yng=; t=1695626564; x=1696836164; b=JXVoUdubo4ygybaaYpglhcrXBWxf/wEcmn3J01CDBZ1PrS2 QsPAaCrxEGe5n4scZc+Qmruj9g3wd5SVEnlcKLAYRBrDspD9PTd+GlgqbMcErPPNWslQUj10htKsb BWLAY62bmEVCS0wWtbiBGHiXENudwm/Px8RVGtvZle0n9rvKE6/dGVcsbIVylqLKQOSbBchS8Le5X nbU2qzAPGS2EG0rzUATr+OlRvd7aDYKc7I7Rirk38jUnNWboNYY4w9bvYlkw+d/vVRLVW3Ez/ZJ8J bKttIGRNZnBabt/GSjQj80GUadqtgraUfB0GQeDeEdZSOAi3AoxQPdXBdsv2FEUA==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1qkfvW-003GNz-1S; Mon, 25 Sep 2023 09:22:42 +0200 From: Johannes Berg To: hostap@lists.infradead.org Cc: Johannes Berg Subject: [PATCH 13/17] tests: pmksa_cache: wait for STA on AP side before query Date: Mon, 25 Sep 2023 09:20:53 +0200 Message-ID: <20230925092039.461d8eb0a4fe.Ib58ac8bc71a41cfaf4663feb28752431f821684b@changeid> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230925072039.49987-18-johannes@sipsolutions.net> References: <20230925072039.49987-18-johannes@sipsolutions.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_002244_767335_586315B0 X-CRM114-Status: UNSURE ( 9.07 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Johannes Berg Before querying the PMKSA cache, wait for the STA to have appeared on the AP side, otherwise scheduling differences may have us asking when the STA thinks it's connected but the AP hasn't fully proces [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Johannes Berg Before querying the PMKSA cache, wait for the STA to have appeared on the AP side, otherwise scheduling differences may have us asking when the STA thinks it's connected but the AP hasn't fully processed that. Signed-off-by: Johannes Berg --- tests/hwsim/test_pmksa_cache.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/hwsim/test_pmksa_cache.py b/tests/hwsim/test_pmksa_cache.py index 65ef5d8162e8..17f478f1ce60 100644 --- a/tests/hwsim/test_pmksa_cache.py +++ b/tests/hwsim/test_pmksa_cache.py @@ -980,6 +980,7 @@ def test_pmksa_cache_ctrl(dev, apdev): pmksa_sta = dev[0].get_pmksa(bssid) if pmksa_sta is None: raise Exception("No PMKSA cache entry created on STA") + hapd.wait_sta() pmksa_ap = hapd.get_pmksa(addr) if pmksa_ap is None: raise Exception("No PMKSA cache entry created on AP") @@ -1000,6 +1001,7 @@ def test_pmksa_cache_ctrl(dev, apdev): pmksa_sta2 = dev[0].get_pmksa(bssid) if pmksa_sta2 is None: raise Exception("No PMKSA cache entry created on STA after reconnect") + hapd.wait_sta() pmksa_ap2 = hapd.get_pmksa(addr) if pmksa_ap2 is None: raise Exception("No PMKSA cache entry created on AP after reconnect") From patchwork Mon Sep 25 07:20:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Berg X-Patchwork-Id: 1838929 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=d76AI1sR; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=sipsolutions.net header.i=@sipsolutions.net header.a=rsa-sha256 header.s=mail header.b=fR5P2S0Y; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RvDrD2fSyz26jb for ; Mon, 25 Sep 2023 17:23:40 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZiYTeIzhD0tKMl9UCc6BSJ7qNCeZbMTH5NJcxgMJjts=; b=d76AI1sRwCoT9r bqvehZvBDwCIHxAyTgS9zm6ACAK7hHIO/h6bmbPodPXZdSFLOiWQqROKSo9Q2ctOF5nptdo1HYXNY LvmrNGOmMXScsZGk70sHAeylKhysXLFVFaGG0cUoB9sySvgfQn47NT6v9FSg1khfvXM+VYOBT7EGd kIwqASFfdRTaosotsS/d9VpSLDQy58nCCLXiInl6L1r62K3EAiX38sYGmoGtycexVRVJfZjBwzSwp cXIHi9+4DW1C2XCpUNxASMt8btJgnSQE5PHJc2c7Ud1dLOnGLnMfgtcI2tqd3jTjSIqnobnlTIVHJ /oyfizPA8Z733vovWURQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvm-00DYOL-1Z; Mon, 25 Sep 2023 07:22:58 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:242:246e::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvZ-00DYGI-0M for hostap@lists.infradead.org; Mon, 25 Sep 2023 07:22:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Content-Type:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=6lTwv73pztQ9EMaiUIBXK0SltV234jVg5uIl0xAkdRE=; t=1695626564; x=1696836164; b=fR5P2S0YNex8DEIoIUXX13RD+ir7pO+TTnRy4H+bNPz15En y3HU70QbFNOx+HFSwgBiOW5luAN9ST4ZwcUNxFmE2CeG/GTadsbcPbaM2WDzRRgy+rfikhNlkkkvp zzeWD1UK7mEOHQiqZIjiGpLYOpP60hxXxYPWVoEcFrfeyFbvv2mQ5JKVzNRkfn9CSmgR7c6FZhgrS RIAWiTsKKgE63/gpQlnoxsLxzhdGZRyD7ms3Zjhb7fuqMjt35GUUfb1o4ZjNP2TlBaG7WB0Pw/41A BCcblAPU+n5QDHrpzJOURXmv2eYGcAnWNQSFFHhpXFuMmW5SujiPCiAJgPPHIHGw==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1qkfvX-003GNz-0W; Mon, 25 Sep 2023 09:22:43 +0200 From: Johannes Berg To: hostap@lists.infradead.org Cc: Johannes Berg Subject: [PATCH 14/17] tests: ap_pmf: wait for STA appropriately Date: Mon, 25 Sep 2023 09:20:54 +0200 Message-ID: <20230925092039.2968df905e62.Icde7152da27a92c36e1e85043b8145168086b2c2@changeid> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230925072039.49987-18-johannes@sipsolutions.net> References: <20230925072039.49987-18-johannes@sipsolutions.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_002245_150352_CE94DBB0 X-CRM114-Status: UNSURE ( 9.80 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Johannes Berg With PMF, we cannot do even deauth unless we wait for the STA to have fully connected on the AP side, the STA thinking it has isn't sufficient since it immediately says so after M4. Add wait_sta() bef [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Johannes Berg With PMF, we cannot do even deauth unless we wait for the STA to have fully connected on the AP side, the STA thinking it has isn't sufficient since it immediately says so after M4. Add wait_sta() before disconnect, and also before SA_QUERY. Signed-off-by: Johannes Berg --- tests/hwsim/test_ap_pmf.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/hwsim/test_ap_pmf.py b/tests/hwsim/test_ap_pmf.py index fe0955ba2539..e0b5b5782fc8 100644 --- a/tests/hwsim/test_ap_pmf.py +++ b/tests/hwsim/test_ap_pmf.py @@ -87,7 +87,7 @@ def test_ocv_sa_query(dev, apdev): dev[0].connect(ssid, psk="12345678", ieee80211w="1", ocv="1", key_mgmt="WPA-PSK WPA-PSK-SHA256", proto="WPA2", scan_freq="2412") - + hapd.wait_sta() # wait so we can actually request SA_QUERY # Test that client can handle SA Query with OCI element if "OK" not in hapd.request("SA_QUERY " + dev[0].own_addr()): raise Exception("SA_QUERY failed") @@ -144,7 +144,7 @@ def test_ocv_sa_query_csa_missing(dev, apdev): dev[0].connect(ssid, psk="12345678", ieee80211w="1", ocv="1", key_mgmt="WPA-PSK WPA-PSK-SHA256", proto="WPA2", scan_freq="2412") - + hapd.wait_sta() # wait so kernel won't drop deauth frame (MFP) hapd.set("ext_mgmt_frame_handling", "1") dev[0].request("DISCONNECT") dev[0].wait_disconnected() From patchwork Mon Sep 25 07:20:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Berg X-Patchwork-Id: 1838920 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=yEoKx0QX; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=sipsolutions.net header.i=@sipsolutions.net header.a=rsa-sha256 header.s=mail header.b=oeePjkAr; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RvDrC1kSyz26jR for ; Mon, 25 Sep 2023 17:23:39 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IWwbZwDFGC2ZgM1gpJKIPEqGjJ/L2rwhmS5q/D9J+3Y=; b=yEoKx0QX98eC+U 6TqjaotgK205Bj7FALNjQR1vCmfUfjQDLLLcw5pYZ0wWsbHkkpzWufD4eBGXbXDP4BuLSsmBxVwZy eACzqCyGvlvRRmhhpUCaAMuPTgfEM8JGQDvL57A9ZrKFqCF1YgUMXhLCaiRiaBl3XHDpyzK7m02jy pryX/mnQKrAJLR0cz0UohPlOgoVvJS1pr4R7krYw5xiTJmfhKsVzThzt4QgvunlAk/x/jzI6KHGc1 E3uLWgX58wIp1jccaWISJxGLv57+RE+irP12KhWS9liL43MOb5eYIL8bkOQ6ehh+wl2aSdrHNXKza P5YDIoqMtbTJCI5pLvlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvn-00DYOq-2C; Mon, 25 Sep 2023 07:22:59 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:242:246e::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvZ-00DYGb-2D for hostap@lists.infradead.org; Mon, 25 Sep 2023 07:22:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Content-Type:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=DsfX/C1QE07SYUTgNimmGi74yMOeHhfHbelQtMd7Yek=; t=1695626565; x=1696836165; b=oeePjkArUPWQZknCfaIjklhHYitnvWD0W+b0yswFCR8RS0P k4hD56V0Gytje+ZtvjIqG4hDE60DOr198gkMXF5QbIhzKWX9llJw072oSBGvbGo0Wz5Uxu/uPnrlx OJmQbJqHt+dOsDrmi1T80ZPmRPtHtCJft6+VR8YZBa+o2XO6dvqmIXQe5TFb0i5SAnvVJa2N07YIw 87jobfrulu6XMc+ktfvsAtCW3JkHMdO9HZZebv6aJWzSozP5cDYnz4gTWewmDUTCspMRX2KspWjra iA4kbAlIBgb4lriRUzzehjIHqGoRPwtwNiZmKTYOJiJCbvVNLrk9xI7TIYX4nTPg==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1qkfvX-003GNz-2Z; Mon, 25 Sep 2023 09:22:43 +0200 From: Johannes Berg To: hostap@lists.infradead.org Cc: Johannes Berg Subject: [PATCH 15/17] tests: test_ap_open_poll_sta_no_ack: fix mgmt-rx race Date: Mon, 25 Sep 2023 09:20:55 +0200 Message-ID: <20230925092039.8816ce070949.Ic89be05974449c15f923b8852061fc4d65d185a8@changeid> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230925072039.49987-18-johannes@sipsolutions.net> References: <20230925072039.49987-18-johannes@sipsolutions.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_002245_726053_F05C935A X-CRM114-Status: UNSURE ( 9.46 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Johannes Berg We need to wait for the MGMT-RX event before disabling ext_mgmt_frame_handling again, otherwise we might be disabling it and hostapd only receives the deauth frame after we already disable it, defeati [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Johannes Berg We need to wait for the MGMT-RX event before disabling ext_mgmt_frame_handling again, otherwise we might be disabling it and hostapd only receives the deauth frame after we already disable it, defeating the purpose of the test. Signed-off-by: Johannes Berg --- tests/hwsim/test_ap_open.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/hwsim/test_ap_open.py b/tests/hwsim/test_ap_open.py index a3bea763a1c4..beb0e18187b5 100644 --- a/tests/hwsim/test_ap_open.py +++ b/tests/hwsim/test_ap_open.py @@ -725,6 +725,9 @@ def test_ap_open_poll_sta_no_ack(dev, apdev): hapd.set("ext_mgmt_frame_handling", "1") dev[0].request("DISCONNECT") dev[0].wait_disconnected() + # eat up the deauth frame, so it cannot be processed + # after we disable ext_mgmt_frame_handling again + hapd.wait_event(["MGMT-RX"], timeout=1) hapd.set("ext_mgmt_frame_handling", "0") if "OK" not in hapd.request("POLL_STA " + addr): raise Exception("POLL_STA failed") From patchwork Mon Sep 25 07:20:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Berg X-Patchwork-Id: 1838932 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=i3I5amLc; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=sipsolutions.net header.i=@sipsolutions.net header.a=rsa-sha256 header.s=mail header.b=E6sxZYd4; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RvDrF0l28z1yp8 for ; Mon, 25 Sep 2023 17:23:41 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RwaCL13AjjQJGumGA5/a4fWmMkpl1rccC9FPtujDBlc=; b=i3I5amLcdO4jgn aoeDrT2tOL/1ocWq0pNlgXC+BmHvpTKsJwQsUiCmIOYCabM0002kNRKmFnGPAPoQbSac2jsFmTgSS dfgfJZynDywsPtb/vURYNeLrQxmiFiJC//a5dpWftzZpWVEDd9gch6NRnIUxnYDx54AkaUW/STfDp 18cC5/F4OXFhWDoAhyFgYv7RcXNfvcMEDrTBGv4Nf5Ww+feGxHXnCHsDpnYwCe9zBKr5mbjw9jRWK kH9hevhpp/aCDnOnn2+ZTNy0fMRFbGSdQ4Q1O/yoyT93tZY66Q9Qp2PeNjblTqbcaV+Iv8zAyftQc eQwefB85Susu/uivW7/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvo-00DYPQ-32; Mon, 25 Sep 2023 07:23:00 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:242:246e::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkfva-00DYHC-25 for hostap@lists.infradead.org; Mon, 25 Sep 2023 07:22:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Content-Type:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=m82tNTXXRQZDaKWPESQI2w6Tn1IamfQzSCTgcsWB5BM=; t=1695626566; x=1696836166; b=E6sxZYd4SxIOn+Mnu4+ycXfky1W6OWpMJxl/wm/1MdQ/dQs pKr2srn2O6QzvsTRvrjcIm0Npptk54ENfp0hAOdFe0dGNNydxM+Bw0mtCGF7XkOOK2S+Iz82ml/45 pRQDaFe7oRYyGExrFCvHgaYKa1x9E06D7jU1X1LG+qTvkjYddxiFE83TdWEMexAIj0aUxSJz7E88J YTQv8s5PeGQT11lhmhmYIuanTLiAz9U+V3j1i/ljY8CxELEWpmnsCQ1C7YUet4ABebi2hWhRP7fu5 y3nvv27x5gc7qavqr8LQDCWVmR5ZkSbtQdPhbUHd0UZymDthEcWr7mhoBpOkxdjA==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1qkfvY-003GNz-28; Mon, 25 Sep 2023 09:22:44 +0200 From: Johannes Berg To: hostap@lists.infradead.org Cc: Johannes Berg Subject: [PATCH 16/17] tests: gas: wait for STA before ANQP_GET Date: Mon, 25 Sep 2023 09:20:56 +0200 Message-ID: <20230925092039.6c436074c087.I2b23b6821c8e25b7bf959c418a084dc6f2e29075@changeid> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230925072039.49987-18-johannes@sipsolutions.net> References: <20230925072039.49987-18-johannes@sipsolutions.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_002246_697538_16CDB59E X-CRM114-Status: UNSURE ( 9.41 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Johannes Berg We can't do ANQP when the STA is connected but the AP hasn't fully set up the STA yet, so wait on the AP side before continuing. Signed-off-by: Johannes Berg --- tests/hwsim/test_gas.py | 3 +++ 1 file changed, 3 insertions(+) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Johannes Berg We can't do ANQP when the STA is connected but the AP hasn't fully set up the STA yet, so wait on the AP side before continuing. Signed-off-by: Johannes Berg --- tests/hwsim/test_gas.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/hwsim/test_gas.py b/tests/hwsim/test_gas.py index cad2bf3ea46e..adff23be1488 100644 --- a/tests/hwsim/test_gas.py +++ b/tests/hwsim/test_gas.py @@ -1495,6 +1495,7 @@ def _test_gas_anqp_address3_pmf(dev, apdev): password="password", phase2="auth=MSCHAPV2", ca_cert="auth_serv/ca.pem", scan_freq="2412", ieee80211w="2") + hapd.wait_sta() if "OK" not in dev[0].request("ANQP_GET " + bssid + " 258"): raise Exception("ANQP_GET command failed") @@ -1533,6 +1534,7 @@ def test_gas_prot_vs_not_prot(dev, apdev, params): password="password", phase2="auth=MSCHAPV2", ca_cert="auth_serv/ca.pem", scan_freq="2412", ieee80211w="2") + hapd.wait_sta() if "OK" not in dev[0].request("ANQP_GET " + bssid + " 258"): raise Exception("ANQP_GET command failed") @@ -1765,6 +1767,7 @@ def test_gas_anqp_venue_url_pmf(dev, apdev): dev[0].flush_scan_cache() dev[0].connect("gas/anqp/pmf", psk="12345678", ieee80211w="2", scan_freq="2412") + hapd.wait_sta() if "OK" not in dev[0].request("ANQP_GET " + bssid + " 277"): raise Exception("ANQP_GET command failed") From patchwork Mon Sep 25 07:20:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Berg X-Patchwork-Id: 1838933 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=ooVenky+; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=sipsolutions.net header.i=@sipsolutions.net header.a=rsa-sha256 header.s=mail header.b=RAelpJFW; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RvDrH0sx2z1ynF for ; Mon, 25 Sep 2023 17:23:43 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nz4jWRP+NlxVXFwcTYY4NkZX6R53PhHPMVc/i7+kwN0=; b=ooVenky+Tn86pS bIyz1GUSKLZ66HJsya/EsVSVE0xKt62zy40dzX4WtU6O7kd0mh8Ubgm/pglVvpbmMNPYVPsHC7MP6 6K0jATEkfsLRhFVsRxO/RfjAFDGrScpYMuMtq5EB1JrRqjIbyLlyjCji22/srOQVMNDCXfeYjn1FB Z4qiqnQuKgNioRX+O8JJfrsZ8J4N00xc/qoM543Mu2v/gGnXEHb3JiRHNEZIvW7r+NNvEmpCrVqGv 8eQbjOzVeJSe0hf1+dgDjbPhpEk/NLbt1XEpm7nz8NhBvE4S1glastyrD/Vje87LK7swhV6To74Ks tAAmPavPRE23P8Lc//QQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvq-00DYQP-1L; Mon, 25 Sep 2023 07:23:02 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:242:246e::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkfvb-00DYHd-0z for hostap@lists.infradead.org; Mon, 25 Sep 2023 07:22:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Content-Type:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=H6sAMD/HgPmMz3LecthjRHlN8BnjnWJRO4VoaP48x+E=; t=1695626567; x=1696836167; b=RAelpJFWtq27Tm4C/+cSIapEej5JK2eOuAb+Ixt3yPe0CnC iRxBoRYXfGy4JBBGjZ3tj9H6wTFAGu7rCtLguDkpDSckGL4SWOtUvxOO372/a2WRzZSDTddNbX1PT HKtMscPQQzR+dHpXV0OUy9NCbwJCupaRmZQS+fdB6vFqx0Yn2MdHG61PptyyPAbhZxKe3CcQCD+I6 7vr5Vmc0zrirdReIG+XZjU2ZJbjRGANouiTAi8uFCzE6vKd8D03Z5AXV2h5jfe814Pcx2FnhqfsC2 ats1CzHpJ1YOuTUipUmya/jJcqeMLxZ+ViyiNYt88ChUA1z6HNrw7nEL/C93nCyQ==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1qkfvZ-003GNz-13; Mon, 25 Sep 2023 09:22:45 +0200 From: Johannes Berg To: hostap@lists.infradead.org Cc: Johannes Berg Subject: [PATCH 17/17] tests: ap_mixed: give AP time to set up stations Date: Mon, 25 Sep 2023 09:20:57 +0200 Message-ID: <20230925092039.6c0c22b77303.Ic0b9385d1f37aa5ae13c043c013ff80608477270@changeid> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230925072039.49987-18-johannes@sipsolutions.net> References: <20230925072039.49987-18-johannes@sipsolutions.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_002247_372319_02913C65 X-CRM114-Status: UNSURE ( 8.66 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Johannes Berg Give the AP some time to set up stations fully (in the kernel) so that traffic forwarding will work. Signed-off-by: Johannes Berg --- tests/hwsim/test_ap_mixed.py | 1 + 1 file changed, 1 insertion(+) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Johannes Berg Give the AP some time to set up stations fully (in the kernel) so that traffic forwarding will work. Signed-off-by: Johannes Berg --- tests/hwsim/test_ap_mixed.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/hwsim/test_ap_mixed.py b/tests/hwsim/test_ap_mixed.py index e758ae923cdd..45c14f962d2d 100644 --- a/tests/hwsim/test_ap_mixed.py +++ b/tests/hwsim/test_ap_mixed.py @@ -54,6 +54,7 @@ def test_ap_mixed_security(dev, apdev): if sae and dev[2].get_status_field("key_mgmt") != "SAE": raise Exception("Unexpected key_mgmt(3)") + time.sleep(0.1) # give it time for AP to set up stations fully hwsim_utils.test_connectivity(dev[0], dev[1]) if sae: hwsim_utils.test_connectivity(dev[1], dev[2])