From patchwork Wed Apr 4 08:09:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kristian Amlie X-Patchwork-Id: 894888 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=reject dis=none) header.from=northern.tech Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=northern.tech header.i=@northern.tech header.b="EhCZWzcl"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 40GJXv6Dy5z9s0R for ; Wed, 4 Apr 2018 18:10:07 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 841DFC21DFF; Wed, 4 Apr 2018 08:10:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 55550C21C57; Wed, 4 Apr 2018 08:10:01 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id A7710C21C57; Wed, 4 Apr 2018 08:10:00 +0000 (UTC) Received: from mail-lf0-f68.google.com (mail-lf0-f68.google.com [209.85.215.68]) by lists.denx.de (Postfix) with ESMTPS id 4A87FC21C3F for ; Wed, 4 Apr 2018 08:10:00 +0000 (UTC) Received: by mail-lf0-f68.google.com with SMTP id u3-v6so23961576lff.5 for ; Wed, 04 Apr 2018 01:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=northern.tech; s=google; h=from:to:subject:date:message-id; bh=YHi7fedbdvj26m7kirD4TZTRsxHKTxILoYZQWHH55To=; b=EhCZWzclK5tbk1wjkG6eCrlMIgdK8TtwbbBZoWuPAPK/JmlTUAp5Xe7xwt3/ReiKM7 wRR5GGWfSlnls+C6ikA9hpJ8jTiAGMRfv9fCzIQHBrMQbh+7BgoEtB5K+FDKLjXQ6Qev dL6hmf99oH2goMiPifLEl/Vha6iBMAaWo2vfEjzWjOhnaEjyWET9/LiS+xTrog1KSuoy jS9xM/u6lCLJX7mhKnAVowXShas6rF1eWy0ze8/6EjSoDoz8gB3uDnSQNRR0QtLxdG1K LngxsIEnrdGpJ2CHBVWfESx5KlZruV4UzVUMznon6ltmVxGj1j40nVaDqVe+0F1NvMTX DrLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=YHi7fedbdvj26m7kirD4TZTRsxHKTxILoYZQWHH55To=; b=gPnaa5cp911sQjYPwNO+BA0whmbhfw4VdPsoeGmgBkwglhYUPG83spEfQ4WyhPqdKe YcTdYeAM9zqmwwkPwDf624fSjAf1Qd8E6BuaHCwA/5A9SMp6orUb/yAcAvS5ygzgLGo7 2xB1zvgVqGn4ANyZpJkeH7TrYiRBJ5O9umspR5nssIvWY1LVgBrhhUsjxmqNMQiCvuKJ AMln4BHjrnDkysqFlom8N0yLJvbMisMsDNlg9YPobcHSEFGRJcbb0cYh0kuZdRL4GN3r cR3wrQd8+0jzZiS1K6flnWZ5FZu49uow92F50R1mCKjnCjfB/MzzWIIIf8+0XpJUV1hx DC/Q== X-Gm-Message-State: ALQs6tAWwSCqBn/3npW5vZd4nFKzIUIyg5HLV0d0+93ueai+exC54+XV wVbFQ42LQYV0bzHNVXgmScrvjCDnPl4= X-Google-Smtp-Source: AIpwx4/SKR1BN4FESfpehezZvlpLxIG7dCfbHU4DB1j5d19uuyncLve791Li+dLdO5q1Q8D5ij/mTw== X-Received: by 2002:a19:960e:: with SMTP id y14-v6mr10732652lfd.43.1522829399503; Wed, 04 Apr 2018 01:09:59 -0700 (PDT) Received: from localhost.localdomain ([195.159.234.190]) by smtp.googlemail.com with ESMTPSA id w21sm777468ljd.78.2018.04.04.01.09.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 04 Apr 2018 01:09:58 -0700 (PDT) From: Kristian Amlie To: u-boot@lists.denx.de Date: Wed, 4 Apr 2018 10:09:57 +0200 Message-Id: <1522829397-2455-1-git-send-email-kristian.amlie@northern.tech> X-Mailer: git-send-email 2.7.4 Subject: [U-Boot] [PATCH 1/1] fw_printenv: Fix crash due to incorrect size for malloc'ed string. X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Using sizeof gives the size of the pointer only, not the string. This could easily lead to crashes when using -l argument. Signed-off-by: Kristian Amlie --- tools/env/fw_env_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/env/fw_env_main.c b/tools/env/fw_env_main.c index d93a915..fb4afa5 100644 --- a/tools/env/fw_env_main.c +++ b/tools/env/fw_env_main.c @@ -239,7 +239,7 @@ int main(int argc, char *argv[]) argv += optind; if (env_opts.lockname) { - lockname = malloc(sizeof(env_opts.lockname) + + lockname = malloc(strlen(env_opts.lockname) + sizeof(CMD_PRINTENV) + 10); if (!lockname) { fprintf(stderr, "Unable allocate memory");