From patchwork Mon Sep 18 17:40:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siddhesh Poyarekar X-Patchwork-Id: 815052 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-84698-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="qag0q/Un"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xwtZS2VKJz9s7c for ; Tue, 19 Sep 2017 03:40:32 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; q=dns; s= default; b=dhOXkVkSkBD3iMRxXrTZyTFfBhjHOdHzp1WiwlVfdazda/N2BwLLF 6GjzMd5zRA1gybyWGYmulqlbW9wOQV59w9opMh6hcrEl8qi2FKIQb0YVaEUVraTF NsWlDhyUS124DtOM6DDerwNLceT6PBRJoQ46Lj0HzJ6dhbx/CWMH9c= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; s=default; bh=xWqfspYwO9vlncn1z9fatUU5Q/E=; b=qag0q/UnRoBhruMYsItYUk1lL8qg WxMf/s4Bowj7Ms+irgQefHGcqTGqIXyGEqLnOsgMCbCV8ly2sn2RLVpD8FYDMx2F QgTxqcFnQCEw2rGAq8Mbq8qO+olgeibusRz/hj2JEFJhw4A64mXkTrAY4qXRzEBx JFEBDnn0//+KtWg= Received: (qmail 82265 invoked by alias); 18 Sep 2017 17:40:26 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 82189 invoked by uid 89); 18 Sep 2017 17:40:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_NEUTRAL autolearn=ham version=3.3.2 spammy=016, doubling, 0-16, no X-HELO: homiemail-a47.g.dreamhost.com From: Siddhesh Poyarekar To: libc-alpha@sourceware.org Subject: [PATCH 1/2] benchtests: Memory walking benchmark for memcpy Date: Mon, 18 Sep 2017 23:10:13 +0530 Message-Id: <1505756414-12857-1-git-send-email-siddhesh@sourceware.org> This benchmark is an attempt to eliminate cache effects from string benchmarks. The benchmark walks both ways through a large memory area and copies different sizes of memory and alignments one at a time instead of looping around in the same memory area. This is a good metric to have alongside the other memcpy benchmarks, especially for larger sizes where the likelihood of the call being done only once is pretty high. The benchmark is unlike other string benchmarks in that it prints the total data rate achieved during a walk across the memory and not the time taken per execution. * benchtests/bench-memcpy-walk.c: New file. * benchtests/Makefile (string-benchset): Add it. --- benchtests/Makefile | 3 +- benchtests/bench-memcpy-walk.c | 126 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 128 insertions(+), 1 deletion(-) create mode 100644 benchtests/bench-memcpy-walk.c diff --git a/benchtests/Makefile b/benchtests/Makefile index a0c3470..fbdeadf 100644 --- a/benchtests/Makefile +++ b/benchtests/Makefile @@ -37,7 +37,8 @@ string-benchset := bcopy bzero memccpy memchr memcmp memcpy memmem memmove \ strcat strchr strchrnul strcmp strcpy strcspn strlen \ strncasecmp strncat strncmp strncpy strnlen strpbrk strrchr \ strspn strstr strcpy_chk stpcpy_chk memrchr strsep strtok \ - strcoll memcpy-large memcpy-random memmove-large memset-large + strcoll memcpy-large memcpy-random memmove-large memset-large \ + memcpy-walk # Build and run locale-dependent benchmarks only if we're building natively. ifeq (no,$(cross-compiling)) diff --git a/benchtests/bench-memcpy-walk.c b/benchtests/bench-memcpy-walk.c new file mode 100644 index 0000000..df6aa33 --- /dev/null +++ b/benchtests/bench-memcpy-walk.c @@ -0,0 +1,126 @@ +/* Measure memcpy function combined throughput for different alignments. + Copyright (C) 2017 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +/* This microbenchmark measures the throughput of memcpy for various sizes from + 1 byte to 32MiB, doubling every iteration and then misaligning by 0-15 + bytes. The copies are done from source to destination and then back and the + source walks forward across the array and the destination walks backward by + one byte each, thus measuring misaligned accesses as well. The idea is to + avoid caching effects by copying a different string and far enough from each + other, walking in different directions so that we can measure prefetcher + efficiency (software or hardware) more closely than with a loop copying the + same data over and over, which eventually only gives us L1 cache + performance. */ + +#ifndef MEMCPY_RESULT +# define MEMCPY_RESULT(dst, len) dst +# define START_SIZE 1 +# define MIN_PAGE_SIZE (getpagesize () + 32 * 1024 * 1024) +# define TEST_MAIN +# define TEST_NAME "memcpy" +# define TIMEOUT (20 * 60) +# include "bench-string.h" + +IMPL (memcpy, 1) +#endif + +#include "json-lib.h" + +typedef char *(*proto_t) (char *, const char *, size_t); + +static void +do_one_test (json_ctx_t *json_ctx, impl_t *impl, char *dst, char *src, + size_t len) +{ + size_t i, iters = MIN_PAGE_SIZE; + timing_t start, stop, cur; + + char *dst_end = dst + MIN_PAGE_SIZE - len; + char *src_end = src + MIN_PAGE_SIZE - len; + + TIMING_NOW (start); + /* Copy the entire buffer back and forth, LEN at a time. */ + for (i = 0; i < iters && dst_end >= dst && src <= src_end; src++, dst_end--) + { + CALL (impl, dst_end, src, len); + CALL (impl, src, dst_end, len); + i += (len << 1); + } + TIMING_NOW (stop); + + TIMING_DIFF (cur, start, stop); + + json_element_double (json_ctx, (double) iters / (double) cur); +} + +static void +do_test (json_ctx_t *json_ctx, size_t len) +{ + json_element_object_begin (json_ctx); + json_attr_uint (json_ctx, "length", (double) len); + json_array_begin (json_ctx, "timings"); + + FOR_EACH_IMPL (impl, 0) + do_one_test (json_ctx, impl, (char *) buf2, (char *) buf1, len); + + json_array_end (json_ctx); + json_element_object_end (json_ctx); +} + +int +test_main (void) +{ + json_ctx_t json_ctx; + size_t i; + + test_init (); + + json_init (&json_ctx, 0, stdout); + + json_document_begin (&json_ctx); + json_attr_string (&json_ctx, "timing_type", TIMING_TYPE); + + json_attr_object_begin (&json_ctx, "functions"); + json_attr_object_begin (&json_ctx, "memcpy"); + json_attr_string (&json_ctx, "bench-variant", "throughput"); + + json_array_begin (&json_ctx, "ifuncs"); + FOR_EACH_IMPL (impl, 0) + json_element_string (&json_ctx, impl->name); + json_array_end (&json_ctx); + + json_array_begin (&json_ctx, "results"); + for (i = START_SIZE; i <= MIN_PAGE_SIZE; i <<= 1) + { + /* Test length alignments from 0-16 bytes. */ + for (int j = 0; j < 8; j++) + { + do_test (&json_ctx, i + j); + do_test (&json_ctx, i + 16 - j); + } + } + + json_array_end (&json_ctx); + json_attr_object_end (&json_ctx); + json_attr_object_end (&json_ctx); + json_document_end (&json_ctx); + + return ret; +} + +#include From patchwork Mon Sep 18 17:40:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siddhesh Poyarekar X-Patchwork-Id: 815053 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-84699-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="k+D5QeP8"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xwtZf5YYrz9s7g for ; Tue, 19 Sep 2017 03:40:42 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=dE9TRn/n9DGJi3mdtU456jBBR9aqCid VKMUidL7J/QDlYd000U8RYBf1ewlCfi4BnlMseVyos4yAySJpcbZA0nSImpXVMjw 6ALJ6KDqzn4tF2HigDegIo6xB3AhLYe90k3mQP3BAQTMvyaHQoMtY0oKKkUrGAdW xHUahU1wGUrY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; s=default; bh=SUOolgu6gb1gr01KIhibFF/FF/U=; b=k+D5Q eP86zf0oc6IQaIkpVwnr88LT3cIBtoXXiz98pCAjk7kbeCKis1rM4130jiqX0Fge ElNpVSfQUajb5CkRHq9HolFo+eGffJ+pJKl1ONC4VOHTz+KSVNHR1IupGiIFxaCK w74++9vEWt0TEbzwUON7DONkQcNeFh0KTPUznM= Received: (qmail 82395 invoked by alias); 18 Sep 2017 17:40:27 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 82297 invoked by uid 89); 18 Sep 2017 17:40:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_NEUTRAL autolearn=ham version=3.3.2 spammy=UD:png X-HELO: homiemail-a47.g.dreamhost.com From: Siddhesh Poyarekar To: libc-alpha@sourceware.org Subject: [PATCH 2/2] benchtests: Add a new argument -t to read throughput results Date: Mon, 18 Sep 2017 23:10:14 +0530 Message-Id: <1505756414-12857-2-git-send-email-siddhesh@sourceware.org> In-Reply-To: <1505756414-12857-1-git-send-email-siddhesh@sourceware.org> References: <1505756414-12857-1-git-send-email-siddhesh@sourceware.org> String benchmarks that store results as throughput rather than latencies will show positive improvements as negative. Add a flag to fix the output of compare_strings.py in such cases. * benchtests/scripts/compare_strings.py: New option -t. --- benchtests/scripts/compare_strings.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/benchtests/scripts/compare_strings.py b/benchtests/scripts/compare_strings.py index 65119ed..acb64b9 100755 --- a/benchtests/scripts/compare_strings.py +++ b/benchtests/scripts/compare_strings.py @@ -79,7 +79,7 @@ def draw_graph(f, v, ifuncs, results): pylab.savefig('%s-%s.png' % (f, v), bbox_inches='tight') -def process_results(results, attrs, base_func, graph): +def process_results(results, attrs, base_func, graph, throughput): """ Process results and print them Args: @@ -110,6 +110,8 @@ def process_results(results, attrs, base_func, graph): if i != base_index: base = res['timings'][base_index] diff = (base - t) * 100 / base + if throughput: + diff = -diff sys.stdout.write (' (%6.2f%%)' % diff) sys.stdout.write('\t') i = i + 1 @@ -132,7 +134,7 @@ def main(args): attrs = args.attributes.split(',') results = parse_file(args.input, args.schema) - process_results(results, attrs, base_func, args.graph) + process_results(results, attrs, base_func, args.graph, args.throughput) if __name__ == '__main__': @@ -152,6 +154,8 @@ if __name__ == '__main__': help='IFUNC variant to set as baseline.') parser.add_argument('-g', '--graph', action='store_true', help='Generate a graph from results.') + parser.add_argument('-t', '--throughput', action='store_true', + help='Treat results as throughput and not time.') args = parser.parse_args() main(args)