From patchwork Mon Aug 14 14:10:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Simmons-Talbott X-Patchwork-Id: 1821040 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=h7XcKTZ3; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RPbt46vsbz1yfZ for ; Tue, 15 Aug 2023 00:11:24 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E164B3858417 for ; Mon, 14 Aug 2023 14:11:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E164B3858417 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1692022282; bh=sJxu+2Khd97jOnx3Uy6S+7ofldl4fWL1kxhKBDLb4t4=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=h7XcKTZ3tS8ZhgrY8lUFpujaCLsT0JzM/1LoHjPDu6hJKaHVJuvwJtRw+R2DXkyvx dImdiqDJC6zEqlwyMbnhsGNDv4KhK9EuRzS9aXJNFuE0QnnhwYawwzIzR6I2QpqA8s 3l8dkLmGZVyf+nHD9o98kI/MqG8xbX3t+56NTXao= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2F939385842E for ; Mon, 14 Aug 2023 14:11:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2F939385842E Received: from mail-oo1-f69.google.com (mail-oo1-f69.google.com [209.85.161.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-246-tVJODWtIN_G402ZebpjQww-1; Mon, 14 Aug 2023 10:11:07 -0400 X-MC-Unique: tVJODWtIN_G402ZebpjQww-1 Received: by mail-oo1-f69.google.com with SMTP id 006d021491bc7-56ca7604435so4913088eaf.3 for ; Mon, 14 Aug 2023 07:11:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692022266; x=1692627066; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sJxu+2Khd97jOnx3Uy6S+7ofldl4fWL1kxhKBDLb4t4=; b=cBonHmTe4J+FcsMHvAdrqELmECvJZ0iIwKuCAUESfC7bPACOBf7q+esWgJa0UvNtgz 6NRrU2T7FiDJDMxto9nFGcBVzez/ZMRI1QaZ6G8l35ANZr0IZVM1paawok+60+f03yyB DPW9AZ3TRP6dTda0kNdjPAwzR5MOOF/KogzLW2K3mXaiCB0as/mlmtVd6na4P6aqnNas ToUfR0/hpVxJXjIvANCSCVmwq/nLMsEtCGDGtjpsSQYgbDrLK7I6VyWPx7ewzxmy4p0t n6QRc6guYt9tYPbMYDog00y97PHnd7rHUrjEQ/RQbdiV3xjXzWpGmU8tMp0gzCqIx4uF FbCg== X-Gm-Message-State: AOJu0YxFcEa2I2zhWPHPmoNiEnT8sgt3TgSesYUH6+yaVqFQ/Aws/mEb Jzrpe72Yh/+Lq6B24xB92AA6Erk3p4KN3tla1/TPsB7w9Cbjo0mCss2/7I1CidU6FsBthvH7wk1 KeQXaU+DRus+oATt+zPkwFDfRefIVRR1ml22mSKWTU6Nmz9Rn6w6+VASb9JSRcV+u+FldKWwI1p NKN5U0 X-Received: by 2002:a05:6358:7f1a:b0:133:b42:69ca with SMTP id p26-20020a0563587f1a00b001330b4269camr6094260rwn.18.1692022266652; Mon, 14 Aug 2023 07:11:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGlpmgD/G+R8+6cDoEIN1ECq80UnQzDsq76Lk/pZdGhHpx7HwyVLDW+c0OeZUqi4DqdZxtzXA== X-Received: by 2002:a05:6358:7f1a:b0:133:b42:69ca with SMTP id p26-20020a0563587f1a00b001330b4269camr6094239rwn.18.1692022266283; Mon, 14 Aug 2023 07:11:06 -0700 (PDT) Received: from oak.redhat.com (c-71-206-142-238.hsd1.va.comcast.net. [71.206.142.238]) by smtp.gmail.com with ESMTPSA id l25-20020ac84cd9000000b0040331a24f16sm3125079qtv.3.2023.08.14.07.11.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Aug 2023 07:11:05 -0700 (PDT) To: libc-alpha@sourceware.org Cc: Joe Simmons-Talbott Subject: [PATCH v3] resolv/nss_dns/dns-host: Get rid of alloca. Date: Mon, 14 Aug 2023 10:10:35 -0400 Message-ID: <20230814141103.2387799-1-josimmon@redhat.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Joe Simmons-Talbott via Libc-alpha From: Joe Simmons-Talbott Reply-To: Joe Simmons-Talbott Errors-To: libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org Sender: "Libc-alpha" Since the alloca is a small constant size use an array instead. Reviewed-by: Siddhesh Poyarekar --- Changes to v2: * Move tmp back into lower scope resolv/nss_dns/dns-host.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resolv/nss_dns/dns-host.c b/resolv/nss_dns/dns-host.c index 1d60c51f5e..160a017d42 100644 --- a/resolv/nss_dns/dns-host.c +++ b/resolv/nss_dns/dns-host.c @@ -395,8 +395,8 @@ _nss_dns_gethostbyname4_r (const char *name, struct gaih_addrtuple **pat, */ if (strchr (name, '.') == NULL) { - char *tmp = alloca (NS_MAXDNAME); - const char *cp = __res_context_hostalias (ctx, name, tmp, NS_MAXDNAME); + char tmp[NS_MAXDNAME]; + const char *cp = __res_context_hostalias (ctx, name, tmp, sizeof (tmp)); if (cp != NULL) name = cp; }