From patchwork Thu Aug 10 15:13:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Simmons-Talbott X-Patchwork-Id: 1819902 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=WScKbW52; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RM9SV1260z1yYl for ; Fri, 11 Aug 2023 01:14:18 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1AFAD38582B0 for ; Thu, 10 Aug 2023 15:14:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1AFAD38582B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1691680456; bh=7I99fFZx5N/Ri1/9efOYxLNlCBmz/TCM/DawLXGe6qU=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=WScKbW52dadiFIn5vFF0cTMsqB3XlwCjKk3WVK7wYD9PifMU+SBS1r8n4KI04SgT5 kQtyshjp0cKUpyte2RXNx0UGnf5a38PzAytckhWLmVUmbVvo8V+zhzRwiTlEHJkIut XPovoN2wCt6UFucI2WBIRI7fX6RdpAXzilBGgH/s= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1546D3858D32 for ; Thu, 10 Aug 2023 15:14:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1546D3858D32 Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-634-g7JeQCV0P0ON0cnMN9KAhw-1; Thu, 10 Aug 2023 11:14:00 -0400 X-MC-Unique: g7JeQCV0P0ON0cnMN9KAhw-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-76d35f344b0so23292585a.0 for ; Thu, 10 Aug 2023 08:13:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691680438; x=1692285238; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7I99fFZx5N/Ri1/9efOYxLNlCBmz/TCM/DawLXGe6qU=; b=fpIH2/VJHBFvG0TxQ4j8G/q99PLG0V6wn08rvQUjnsLH0LR1RHkK2RwNYdOTKzKG0N eMRxLneBU+DDxSKqayvi7jVCxrdps7ofJiChYmBI08tKxnoSS7CCfkvyNdenYkaK4nDA SBXB5PLvCpGnxlZuY/uC7WVYde41bkLnkOoYCmyOO7Spf+PHa0bC6uRwfAk2jqvdqqYA 1h6TmnQY0ZPRU802V93B7BMHF2x4HWdcFTqMhqEzoEw7EbP+SDmPUL1n69XdSOstT91N eU11Et2GHD/8921W+RSkyLD9OtF3oBSnB/JIOpDZtI902f3htavCI45q71TQJDfC/AMH XEmQ== X-Gm-Message-State: AOJu0YzqtndSpUJTYkjWhq7Lxo+6tAe40D4I9zd6ztyRTJ9HrsaehC05 V7ShBqb1IWizLwBc509boO8tn4+tV+21EXsLbYdUTuFPWvqHGG4AYIftzCQ7m7Z0DrhlI/U1eTV jxkVvxaJskRMHTJ8wRRS7QFS61U9Wl910wLxm0CMN71CWKcbNorBuvcWWDpBKaBksSiWQpjcetk /iUYVB X-Received: by 2002:a37:e118:0:b0:76c:e7a7:ccf4 with SMTP id c24-20020a37e118000000b0076ce7a7ccf4mr2507403qkm.67.1691680438614; Thu, 10 Aug 2023 08:13:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHkm23B7uxCO3ctWfgcTsdkHa2I1NGfaRbE4EGb3d61bs5zIrxBmBYmUQVsmtQboJZZrmgtkw== X-Received: by 2002:a37:e118:0:b0:76c:e7a7:ccf4 with SMTP id c24-20020a37e118000000b0076ce7a7ccf4mr2507378qkm.67.1691680438248; Thu, 10 Aug 2023 08:13:58 -0700 (PDT) Received: from oak.redhat.com (c-71-206-142-238.hsd1.va.comcast.net. [71.206.142.238]) by smtp.gmail.com with ESMTPSA id i21-20020a05620a145500b0076cda7eab11sm537126qkl.133.2023.08.10.08.13.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 08:13:57 -0700 (PDT) To: libc-alpha@sourceware.org Cc: Joe Simmons-Talbott Subject: [PATCH] resolv/nss_dns/dns-host: Get rid of alloca. Date: Thu, 10 Aug 2023 11:13:49 -0400 Message-ID: <20230810151356.743825-1-josimmon@redhat.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Joe Simmons-Talbott via Libc-alpha From: Joe Simmons-Talbott Reply-To: Joe Simmons-Talbott Errors-To: libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org Sender: "Libc-alpha" Since the alloca is a small constant size use an array instead. --- resolv/nss_dns/dns-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resolv/nss_dns/dns-host.c b/resolv/nss_dns/dns-host.c index 1d60c51f5e..f752b7cf4b 100644 --- a/resolv/nss_dns/dns-host.c +++ b/resolv/nss_dns/dns-host.c @@ -378,6 +378,7 @@ _nss_dns_gethostbyname4_r (const char *name, struct gaih_addrtuple **pat, int *herrnop, int32_t *ttlp) { enum nss_status status = check_name (name, herrnop); + char tmp[NS_MAXDNAME]; if (status != NSS_STATUS_SUCCESS) return status; struct resolv_context *ctx = __resolv_context_get (); @@ -395,7 +396,6 @@ _nss_dns_gethostbyname4_r (const char *name, struct gaih_addrtuple **pat, */ if (strchr (name, '.') == NULL) { - char *tmp = alloca (NS_MAXDNAME); const char *cp = __res_context_hostalias (ctx, name, tmp, NS_MAXDNAME); if (cp != NULL) name = cp;