From patchwork Thu Aug 3 14:23:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 1816487 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RGrfH6xwYz1yZl for ; Fri, 4 Aug 2023 00:22:47 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 0870741DB9; Thu, 3 Aug 2023 14:22:46 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 0870741DB9 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QUkPj6SQGQpf; Thu, 3 Aug 2023 14:22:44 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id D89F4402C0; Thu, 3 Aug 2023 14:22:43 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org D89F4402C0 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id B7B4FC0071; Thu, 3 Aug 2023 14:22:43 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 353DBC0032 for ; Thu, 3 Aug 2023 14:22:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id EE80561396 for ; Thu, 3 Aug 2023 14:22:41 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org EE80561396 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4QKqCzU5p2S4 for ; Thu, 3 Aug 2023 14:22:41 +0000 (UTC) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by smtp3.osuosl.org (Postfix) with ESMTPS id 006B2612FA for ; Thu, 3 Aug 2023 14:22:40 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 006B2612FA Received: by mail.gandi.net (Postfix) with ESMTPSA id 3487140013; Thu, 3 Aug 2023 14:22:36 +0000 (UTC) From: Ilya Maximets To: ovs-dev@openvswitch.org Date: Thu, 3 Aug 2023 16:23:11 +0200 Message-Id: <20230803142311.2480008-1-i.maximets@ovn.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-GND-Sasl: i.maximets@ovn.org Cc: Simon Horman , Ilya Maximets , David Marchand Subject: [ovs-dev] [PATCH] ci: Fix OPTS not being passed to OSX builds. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Before GHA, OPTS were always passed as an argument for a *-build.sh script. But that changed. Linux builds are using the OPTS variable from the environment, but OSX script does not, so the options are currently ignored. That wasn't a big issue until now, because SSL was not available or the build actually worked on newer branches. But GHA recently updated OpenSSl to 3.0+ and we have deprecation warnings on branches that do not support OpenSSL 3.0+ (branch 2.16) and that breaks the build. Fixes: 6cb2f5a630e3 ("github: Add GitHub Actions workflow.") Signed-off-by: Ilya Maximets Reviewed-by: David Marchand --- .ci/osx-build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ci/osx-build.sh b/.ci/osx-build.sh index 09df61826..b81744ec9 100755 --- a/.ci/osx-build.sh +++ b/.ci/osx-build.sh @@ -10,7 +10,7 @@ function configure_ovs() ./boot.sh && ./configure $* } -configure_ovs $EXTRA_OPTS $* +configure_ovs $EXTRA_OPTS $OPTS $* if [ "$CC" = "clang" ]; then make CFLAGS="$CFLAGS -Wno-error=unused-command-line-argument"