From patchwork Thu Jul 27 13:36:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Liu, Hongtao" X-Patchwork-Id: 1813779 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=bag476e7; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RBWzB5WTjz1ybX for ; Thu, 27 Jul 2023 23:37:26 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 87159385AFBD for ; Thu, 27 Jul 2023 13:37:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 87159385AFBD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1690465044; bh=acIXBWR5SHqkKdp8jn6jtiBftkxIiX2ToXKTWhOHp9o=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=bag476e74nMp8E8hJ+kdFRFMdTAHctSIEZ6uJs+zoSafKe9xvDYqgR6z5mVlEDc6z 5zq//VpZ7kqfCCfo16SQCRZ14rB/5Y0YfxWjNdIFJE9HiTCF/zHcpGBSRA8gBqYxdo bPOwvLisXOUhl//jiy0/W8ZIKz856PP/LlGh2d7E= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mgamail.intel.com (unknown [192.55.52.115]) by sourceware.org (Postfix) with ESMTPS id ED9FF3858C36 for ; Thu, 27 Jul 2023 13:37:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ED9FF3858C36 X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="368325670" X-IronPort-AV: E=Sophos;i="6.01,235,1684825200"; d="scan'208";a="368325670" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2023 06:36:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="817083790" X-IronPort-AV: E=Sophos;i="6.01,235,1684825200"; d="scan'208";a="817083790" Received: from shvmail03.sh.intel.com ([10.239.245.20]) by FMSMGA003.fm.intel.com with ESMTP; 27 Jul 2023 06:36:40 -0700 Received: from shliclel4217.sh.intel.com (shliclel4217.sh.intel.com [10.239.240.127]) by shvmail03.sh.intel.com (Postfix) with ESMTP id 087EA1007817; Thu, 27 Jul 2023 21:36:40 +0800 (CST) To: gcc-patches@gcc.gnu.org Cc: crazylht@gmail.com, hjl.tools@gmail.com Subject: [PATCH] [x86] Add UNSPEC_MASKOP to vpbroadcastm pattern. Date: Thu, 27 Jul 2023 21:36:39 +0800 Message-Id: <20230727133639.2208533-1-hongtao.liu@intel.com> X-Mailer: git-send-email 2.39.1.388.g2fc9e9ca3c MIME-Version: 1.0 X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: liuhongt via Gcc-patches From: "Liu, Hongtao" Reply-To: liuhongt Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Prevent rtl optimization of vec_duplicate + zero_extend to vpbroadcastm since there could be an extra kmov after RA. Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,} Ready to push to trunk. gcc/ChangeLog: PR target/110788 * config/i386/sse.md (avx512cd_maskb_vec_dup): Add UNSPEC_MASKOP. (avx512cd_maskw_vec_dup: Ditto. gcc/testsuite/ChangeLog: * gcc.target/i386/pr110788.c: New test. --- gcc/config/i386/sse.md | 8 ++++++-- gcc/testsuite/gcc.target/i386/pr110788.c | 11 +++++++++++ 2 files changed, 17 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/gcc.target/i386/pr110788.c diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md index 35fd66ed4aa..51961bbfc0b 100644 --- a/gcc/config/i386/sse.md +++ b/gcc/config/i386/sse.md @@ -26778,11 +26778,14 @@ (define_insn "avx512dq_broadcast_1" (set_attr "prefix" "evex") (set_attr "mode" "")]) +;; Use unspec to prevent rtl optimizer to optimize zero_extend + vec_duplicate +;; to pbroadcastm, there could be an extra kmov after RA. (define_insn "avx512cd_maskb_vec_dup" [(set (match_operand:VI8_AVX512VL 0 "register_operand" "=v") (vec_duplicate:VI8_AVX512VL (zero_extend:DI - (match_operand:QI 1 "register_operand" "k"))))] + (match_operand:QI 1 "register_operand" "k")))) + (unspec [(const_int 0)] UNSPEC_MASKOP)] "TARGET_AVX512CD" "vpbroadcastmb2q\t{%1, %0|%0, %1}" [(set_attr "type" "mskmov") @@ -26793,7 +26796,8 @@ (define_insn "avx512cd_maskw_vec_dup" [(set (match_operand:VI4_AVX512VL 0 "register_operand" "=v") (vec_duplicate:VI4_AVX512VL (zero_extend:SI - (match_operand:HI 1 "register_operand" "k"))))] + (match_operand:HI 1 "register_operand" "k")))) + (unspec [(const_int 0)] UNSPEC_MASKOP)] "TARGET_AVX512CD" "vpbroadcastmw2d\t{%1, %0|%0, %1}" [(set_attr "type" "mskmov") diff --git a/gcc/testsuite/gcc.target/i386/pr110788.c b/gcc/testsuite/gcc.target/i386/pr110788.c new file mode 100644 index 00000000000..4cf1676ccb6 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr110788.c @@ -0,0 +1,11 @@ +/* { dg-do compile } */ +/* { dg-options "-O3 -march=cascadelake --param vect-partial-vector-usage=2" } */ +/* { dg-final { scan-assembler-not "vpbroadcastm" } } */ + +double a[1024], b[1024]; + +void foo (int n) +{ + for (int i = 0; i < n; ++i) + a[i] = b[i] * 3.; +}