From patchwork Thu Mar 29 19:22:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin 'ldir' Darbyshire-Bryant X-Patchwork-Id: 892927 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=darbyshire-bryant.me.uk Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=darbyshire-bryant.me.uk header.i=@darbyshire-bryant.me.uk header.b="A9ZvcIhV"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40Bvlh5DX5z9s24 for ; Fri, 30 Mar 2018 06:22:40 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752027AbeC2TWi (ORCPT ); Thu, 29 Mar 2018 15:22:38 -0400 Received: from mail-eopbgr00089.outbound.protection.outlook.com ([40.107.0.89]:27728 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751179AbeC2TWg (ORCPT ); Thu, 29 Mar 2018 15:22:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darbyshire-bryant.me.uk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=mClIJBmuXK1QEQ5Ssu31qIWtIrbQY34U88hSRtmPbyE=; b=A9ZvcIhVmK3/WqGqKOFbA0G+mIbHYTCra2AwaI9kS6hg4i1+48+1vhWYwpMYYPonQTQgU3Q69wsmes+LZU/Iami6rKdMtEJiWox2s/SL+6r3aa9+xOAtKKLWAGY9Ja0zQUGyb4tTpilsuXm6lnS63ojRYfcXsCfTkZdr8Scuiwk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kevin@darbyshire-bryant.me.uk; Received: from Kevins-MBP.darbyshire-bryant.me.uk (151.231.154.194) by AM6PR0702MB3734.eurprd07.prod.outlook.com (2603:10a6:209:12::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.631.5; Thu, 29 Mar 2018 19:22:33 +0000 From: Kevin Darbyshire-Bryant To: netdev@vger.kernel.org Cc: Kevin Darbyshire-Bryant Subject: [PATCH iproute2] json_print: fix print_uint hidden type promotion Date: Thu, 29 Mar 2018 20:22:20 +0100 Message-Id: <20180329192220.30101-1-ldir@darbyshire-bryant.me.uk> X-Mailer: git-send-email 2.14.3 (Apple Git-98) MIME-Version: 1.0 X-Originating-IP: [151.231.154.194] X-ClientProxiedBy: AM3PR05CA0131.eurprd05.prod.outlook.com (2603:10a6:207:2::33) To AM6PR0702MB3734.eurprd07.prod.outlook.com (2603:10a6:209:12::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 33b5dfe3-6310-4784-d855-08d595aa6c81 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(7021125)(5600026)(4604075)(4534165)(7022125)(4603075)(4627221)(201702281549075)(7048125)(7024125)(7027125)(7028125)(7023125)(2017052603328)(7153060)(7193020); SRVR:AM6PR0702MB3734; X-Microsoft-Exchange-Diagnostics: 1; AM6PR0702MB3734; 3:RidFgwbVtEQwYi/LRF3i392noGAHvhAE8QCdnWiNVDEzjWB7pnYFBlHR7bQ0xImFRPtccJzupY8BL/9itDxyWP6Yw9WqDg07oh1opqvHMOwmVMtt80TXnE5X4BJg8pNfb/nQEIksjzRxFWRluTTW/8UxkCuTSSjuuKu5i+1PKf7Qr8XT18TweZmSdeSvu3zaYHhFX2AC7AN29Gc6iX36hWKwc7vj7KXCkHXawjNYuCptAYtUFfpObLFgOop1f+KX; 25:0j3t4eCvB4txqQygKmdKUpJSrPO/RU2gZW7gOPmVw+Bq8C0u6i/FnfZB+mpLu621TFMbicAEGTICKXHmJfCaUd/KKd2BubIk5pA/s7SbUrJO+nRds0yebMlqYzRt8vHeAQW5P21wQh+M4p1ubkgD8MVOwrB59rtavxTm3UDax0yzpGeh1bcxDFC/x2QKzFNV85hniccTsDERFUyQI7PdkbszwR88n+92+HBu6fOohyIGbPj1O0vyN+QMJzYK27ea26zFh0DIY8kzC8UMbXN3z6cNCeYf7/0FHFUbl8K0aFlfMs44FoXz+argPeod4I5qNPC2awLi1pP15myKnNGB6w==; 31:l4tDkyKnXEtHrfQCgprmFFJ0qDtaV/hXcGLfvdG0IRB1Sqm1HJ3TfMJvstBwZ8rW59TI6TrvwfSd+6lan1WkbnbEt5pQy4u2g3pWSDNtmmeYNTYdz7D3oDou1fQYWt/fTdMqXF7uufnA9pDlxa9FXRIeyenx2xyZume/crXbeAc5ylpgT8j8vA77jgwaYDvnm5e+JYmmd/SqLB7lrbI6B6jQhy3iS7GaLeIN7wmpGAw= X-MS-TrafficTypeDiagnostic: AM6PR0702MB3734: X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231221)(944501327)(52105095)(6041310)(20161123560045)(20161123558120)(20161123564045)(2016111802025)(20161123562045)(6043046)(6072148)(201708071742011); SRVR:AM6PR0702MB3734; BCL:0; PCL:0; RULEID:; SRVR:AM6PR0702MB3734; X-Microsoft-Exchange-Diagnostics: 1; AM6PR0702MB3734; 4:8ZKTtzD9FCZjh2ZcRSHcoAmLNXqeSV7tol2ZebmZqpeu4RO6MkxmZYfkUh+RTMyvOks4mIzWIqfEnOAd4cNP+uylbc04NAv6IYpB+Bw/kqd/g7HeGfmFcHWKCeQlZa+KyMJW2T8WLlGfN/XU9nGteV3uS9lrnNwoeoXnBcmpV6HE1mv+KalJXmIRkzJ3Gs/5t2PwCQrtUMRvzoEyVnNR5lMIAfFVqfBcUaR600ZhpaGXYqB2s26CIo1VJkQ7EAa51kJLGY0rXh0967q0X4+Cow== X-Forefront-PRVS: 0626C21B10 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(366004)(396003)(346002)(39830400003)(39380400002)(199004)(189003)(106356001)(97736004)(956004)(5660300001)(69596002)(8936002)(25786009)(7696005)(68736007)(50226002)(2616005)(105586002)(476003)(4326008)(386003)(81156014)(8676002)(81166006)(6666003)(107886003)(52116002)(478600001)(3846002)(7736002)(2351001)(66066001)(74482002)(26005)(48376002)(305945005)(186003)(316002)(53416004)(6486002)(59450400001)(47776003)(1076002)(6916009)(6116002)(2361001)(16526019)(486005)(486005)(53936002)(36756003)(50466002)(51416003)(16586007)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR0702MB3734; H:Kevins-MBP.darbyshire-bryant.me.uk; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: darbyshire-bryant.me.uk does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; AM6PR0702MB3734; 23:666d+sBUMrWbNN6OkC8k0zzfVkDvRBau7KddodmsFPgDs49galZcolNMj0ct6xXc/D32H2jaxQa3YYjKli9WB5JLkMFNpp0Ue3U6hkHJzZombCXej1R9qDfmS9PEaRWlpSLtlcCPW3rpq9WNHwBeCIxEEE21ZGzYJ3YD74BJN+iqQCcbxu155hWZGndRFI11AgiWG2APhISIp3SwzRLY/pIumiWDlU9w0R1Nf5xSzy7ts0diVgS7s3a1Ba1GSU6ghnkHPy7+Dpyeivm5upeVXW3n5TOIpT2SX8/c4kMPHmCeywbINIFqUp3ys0W5TbMZ5iUaugOlFe2kV5cEBkFIPe3N1lTzj8Z/lMc/CMj8ZI1Lt4wLrxZHfeZ7DuCXUtqd9LIqt2k5saloeZCnMVPhk+YTCZnyAxAhFFfZBdikm1hlCZpOH6B6JILV18u2FgTu0SGT9IqoyIoTDEXQqNqBZbjvD2+WEhQnK+i+6GkLEpCpqHA6z6ADx/7wD2GJAAmH9VdH+baMCt0QmfDgT/7EJU0Njn8V/5RNA/bP+OApYvyMn+8+T2BRZk2mqsDfhyD9dX5BgbgcG5UyhJV9o4aMD2hg5Xf3fbBEGLdvLN9dOZmaOMSi6wdthWyhgkhK+cPOyoyDNxl5vu8y/ciL3DoPOqiYGnj+9aq2H8lZ2rVbe7L0wiwipV4xy+AJWJaTeAZFDX+8jZ1s1l9uI+CPYZNLZdF684b2SQGuV/wqYCoKTiBJQHKBBEtedDnszKuUfxj0qQ1RfKwj5Upds2MpesoRy1rsBVWrDZ2ES45Qeo8KCQ24GBWWrYDlW3uPOnYRU5+smMDW17ouJw7j7nz4xR+iTkabcpMrdY9KyYBPgcG5NRtiMhOWzVkeNl6K7oKhQYwCDPMC8vEmNv6PCCPJbzWix00wVcOZlNWsoFDusOT8t5j2C9BPNmxCx2JYKc+hThtQHRmbz1ZVrAzvwTBhUIdXNSusDdA/mD1H5ZzHC+h7DSr/D6+y4rZDSDQQ6a6pX3jCaCXT7eikO2fUNenbZsXY29qoa+oLnpSBJa7lUBc38rujLK3Tw1xqC8O+YHiWDct89E0irjnOp5YvM95EbZyUWQRCm/1ZVmg692ghqZVqfdrjw/woEGMQeJ3j9xS87cpEYZ81TS3cpNC8TgqMR6QseAd0+mesIOq7HlcATTrJpI7ikrYgaIokbwc3CDWZwgEiDflaF4yXzfv4MtVOUIt/80u5NamI8Fo30dbCR4tNukv5We5hm+HaomszC9O81a2L X-Microsoft-Antispam-Message-Info: /WDll+xNXJhU7A6D079UYD2m0w7GPzPVZfIMNH2cJuv+RLwkkzpyja5xICIHIren+2JIPM5QL7YMw9Hp8x8znQ+GV+wgdWOksNRQ78LEy8W7dfGp2ddzEGM57D0wR/L1s3yx+/f7ftkK+YXWnHBliVChCSLSfHziSd246zeoXufXwd0+LDRHmpop5mkP4RQQ X-Microsoft-Exchange-Diagnostics: 1; AM6PR0702MB3734; 6:eovcN5GyaYJPcMRUX/XwKIERUgviPjJZOeBnOwLzgbstDLTrEcIKljQMwqnas+rVE9nyKeyp0aXFaBF7RpOr7horRW9KzSgkTjYeoFkq29MH6Et52bFDBEMFO+pdLY//8n2DbkCjcJmE6caeJfIgLVbzSvt+ttPyXoMmcaBgTUHCCSHAgamX6EHOJkxgGXNUUjZ92hjasbFmQN/CNUJPrntIk4KWv9XdO+hoRNPY5N+m7/yJl85lSstVTAAFfigF4tRknIcJCqFm9VdGABHueUQoFVA+szH5gGwCqHBeKQwpobVC6op1gdOM+8/5/wLDAFlCf/NyP5UguD+ltV3oEvapn/2Syy71HuIs6I8/2PLxajhJqefKxlUYZSzJwD176ad3dKO901Ix/3J6xt+07BRaVpZdcJAYELbiOJ7H0XQkAf6rxpvHdZh/j2MG3Fqm/SJv0x5DXK4mRv4kDiCgIA==; 5:JUVZQ5EdrHZTzvNWE2k0UX8CoJtkuRD6RqbJKQK5i6uDwxCUypDQlrfTXKgkMpZrso3x9yMnCUhyzrLcSbmnzS4vMe2OQ8wfiX/tlwvkkW6kCxClVTTopYsZl/9iG52GJPGu/SkJxiwipZUDHaNMvqYlKQW6Buhg1oyw0vfOj7c=; 24:oBC8LUcqzXmuWs2YL92dmC2cCQAscKZKKQdQbOptZB2mziumRWTLpfo0l0T9UGXvuFGz4wuC6LNyQRhyCnioXFD1GuS3qiXBexjRWrBxsys= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM6PR0702MB3734; 7:yMbc7Q6GIFjUEwJeZyv/hD24s5sTvXlzYznvbiTvJX2bI0tG53izePytke6wdNLtdbTHFxG7Sc/MPHaNh/SOQxyrgjUivDvAYWPROcIaR6xAvfphUg8xrKDHa3KXCA8wMw3uTMv8XsPYRMxm6eF7sazgAg5x7y8HRt1xcREPR6agg9DPCi7MbPK/Ya6dwZ+Kvn4flOo8wllGbx2ozONqtpsKyXIXQEXuf0MammUTMUHhkd7xoZVCtLsBocq8LGum X-OriginatorOrg: darbyshire-bryant.me.uk X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2018 19:22:33.9420 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 33b5dfe3-6310-4784-d855-08d595aa6c81 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 9151708b-c553-406f-8e56-694f435154a4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0702MB3734 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org print_int used 'int' type internally, whereas print_uint used 'uint64_t' These helper functions eventually call vfprintf(fp, fmt, args) which is a variable argument list function and is dependent upon 'fmt' containing correct information about the length of the passed arguments. Unfortunately print_int v print_uint offered no clue to the programmer that internally passed ints to print_uint were being promoted to 64bits, thus the format passed in 'fmt' string vs the actual passed integer could be different lengths. This is even more interesting on big endian architectures where 'vfprintf' would be looking in the middle of an int64 type. print_u/int now stick with native int size. Signed-off-by: Kevin Darbyshire-Bryant --- include/json_print.h | 2 +- lib/json_print.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/json_print.h b/include/json_print.h index 2ca7830a..45bc653d 100644 --- a/include/json_print.h +++ b/include/json_print.h @@ -56,10 +56,10 @@ void close_json_array(enum output_type type, const char *delim); print_color_##type_name(t, COLOR_NONE, key, fmt, value); \ } _PRINT_FUNC(int, int); +_PRINT_FUNC(uint, unsigned int); _PRINT_FUNC(bool, bool); _PRINT_FUNC(null, const char*); _PRINT_FUNC(string, const char*); -_PRINT_FUNC(uint, uint64_t); _PRINT_FUNC(hu, unsigned short); _PRINT_FUNC(hex, unsigned int); _PRINT_FUNC(0xhex, unsigned int); diff --git a/lib/json_print.c b/lib/json_print.c index 6518ba98..8d54d1d4 100644 --- a/lib/json_print.c +++ b/lib/json_print.c @@ -117,8 +117,8 @@ void close_json_array(enum output_type type, const char *str) } \ } _PRINT_FUNC(int, int); +_PRINT_FUNC(uint, unsigned int); _PRINT_FUNC(hu, unsigned short); -_PRINT_FUNC(uint, uint64_t); _PRINT_FUNC(lluint, unsigned long long int); _PRINT_FUNC(float, double); #undef _PRINT_FUNC