From patchwork Mon Jul 24 17:22:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 1811976 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=Twu0xSbx; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4R8n6h2l3nz1yYC for ; Tue, 25 Jul 2023 03:22:52 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 96E113858C5E for ; Mon, 24 Jul 2023 17:22:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 96E113858C5E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1690219369; bh=PPl2lQXKzguiRgQReRQ8aFEsiaQ/a0WWu8871bjDLoI=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Twu0xSbxjg4sGs8i9u/g0svX/odGFOIGYj8GsLAudDmYMdEWXOr01dNa00oeKkMoF byK/L1h/G69HbfzD1dpm9WACqVc9O5cSdaogYUQq2hNQmOBb+2rhbwu9sCNR91Xx6H 0c+PEfvSpTBFfLCyNp6UKz/OFWixN5EVGSgomFjI= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-oa1-x2d.google.com (mail-oa1-x2d.google.com [IPv6:2001:4860:4864:20::2d]) by sourceware.org (Postfix) with ESMTPS id 056533858C5E for ; Mon, 24 Jul 2023 17:22:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 056533858C5E Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-1bb7a1c2fe5so617350fac.2 for ; Mon, 24 Jul 2023 10:22:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690219352; x=1690824152; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PPl2lQXKzguiRgQReRQ8aFEsiaQ/a0WWu8871bjDLoI=; b=LtwpqkScp5nUlIp+JuvlXatAu+WZqDsV03UPEgAw9afbCk68mVFu/jMV8BxkMJa4/2 VXj0X2l9kqb1Koc3a1xfzDOHQbGf/NxJOOvHe9WHEQscgNTTvNGJ4DL/NoEAoVZ5IYVH tZIdNccaHRssSJcvY4ptFtbmTv7MGpObcrW1XZSNvnAbLqQWbXafHD4E3w2t7au5Q3Jl DjW6doJllDIL1wvbmVEgrY6fsDLNzCkH1h9o1Zyc28nFeC2y8M0arV6gVS13SVrGMcPD cTOvk55CkpsjWX8lWcG/Egjlvi5JVbfCGlUwf/q+J8D/FhXrbzCprzjLJktdwppR2QCJ GPUw== X-Gm-Message-State: ABy/qLY7X6q0K7dYg7uA371+mlF0NugTFtAWPtv0RAz610kAKNt4Acbe MLDdXCOP6G9topwPqDHAURZOIRZQKaCiG4JTLdzRSQ== X-Google-Smtp-Source: APBJJlG0MXt/bO2xlEmtYKk3XIz2Lep9ocnGbDr0xqDMEDHN47iS1l3rSLrUCtVmpEdj+tbQLfi7dg== X-Received: by 2002:a05:6870:8197:b0:1ad:2c77:57a9 with SMTP id k23-20020a056870819700b001ad2c7757a9mr10315949oae.38.1690219352409; Mon, 24 Jul 2023 10:22:32 -0700 (PDT) Received: from mandiga.. ([2804:1b3:a7c0:d4d2:46e0:428c:6669:da90]) by smtp.gmail.com with ESMTPSA id pk27-20020a0568704c1b00b001ad21a705a8sm4506726oab.49.2023.07.24.10.22.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jul 2023 10:22:31 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH] configure: Remove --enable-all-warnings option Date: Mon, 24 Jul 2023 14:22:27 -0300 Message-Id: <20230724172227.2789361-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+incoming=patchwork.ozlabs.org@sourceware.org Sender: "Libc-alpha" The option is not activelly tested and has bitrotten, to fix it would require a lot of work and multiple fixes. A better option would to evaluate each option and enable the warning if it makes sense. Reviewed-by: Siddhesh Poyarekar --- Makeconfig | 7 +------ config.make.in | 1 - configure | 11 ----------- configure.ac | 10 ---------- 4 files changed, 1 insertion(+), 28 deletions(-) diff --git a/Makeconfig b/Makeconfig index 77d7fd14df..c4dd9ea8f2 100644 --- a/Makeconfig +++ b/Makeconfig @@ -857,12 +857,7 @@ host-test-program-cmd = $(host-built-program-cmd) endif # Extra flags to pass to GCC. -ifeq ($(all-warnings),yes) -+gccwarn := -Wall -Wwrite-strings -Wcast-qual -Wbad-function-cast -Wmissing-noreturn -Wmissing-prototypes -Wmissing-declarations -Wcomment -Wcomments -Wtrigraphs -Wsign-compare -Wfloat-equal -Wmultichar -else -+gccwarn := -Wall -Wwrite-strings -endif -+gccwarn += -Wundef +gccwarn := -Wall -Wwrite-strings -Wundef ifeq ($(enable-werror),yes) +gccwarn += -Werror endif diff --git a/config.make.in b/config.make.in index d487a4f4e9..0c4baa2731 100644 --- a/config.make.in +++ b/config.make.in @@ -50,7 +50,6 @@ c++-sysincludes = @CXX_SYSINCLUDES@ c++-cstdlib-header = @CXX_CSTDLIB_HEADER@ c++-cmath-header = @CXX_CMATH_HEADER@ c++-bits-std_abs-h = @CXX_BITS_STD_ABS_H@ -all-warnings = @all_warnings@ enable-werror = @enable_werror@ have-z-execstack = @libc_cv_z_execstack@ diff --git a/configure b/configure index 4ef387146d..eeb3ef49b8 100755 --- a/configure +++ b/configure @@ -705,7 +705,6 @@ libc_cv_nss_crypt build_crypt memory_tagging enable_werror -all_warnings force_install bindnow hardcoded_path_in_tests @@ -804,7 +803,6 @@ enable_static_nss enable_force_install enable_maintainer_mode enable_kernel -enable_all_warnings enable_werror enable_multi_arch enable_memory_tagging @@ -1478,7 +1476,6 @@ Optional Features: sometimes confusing) to the casual installer --enable-kernel=VERSION compile for compatibility with kernel not older than VERSION - --enable-all-warnings enable all useful warnings gcc can issue --disable-werror do not build with -Werror --enable-multi-arch enable single DSO with optimizations for multiple architectures @@ -4526,14 +4523,6 @@ else fi fi -# Check whether --enable-all-warnings was given. -if test ${enable_all_warnings+y} -then : - enableval=$enable_all_warnings; all_warnings=$enableval -fi - - - # Check whether --enable-werror was given. if test ${enable_werror+y} then : diff --git a/configure.ac b/configure.ac index 12d1f50b14..6601331a06 100644 --- a/configure.ac +++ b/configure.ac @@ -277,16 +277,6 @@ else fi fi -dnl For the development we sometimes want gcc to issue even more warnings. -dnl This is not the default since many of the extra warnings are not -dnl appropriate. -AC_ARG_ENABLE([all-warnings], - AS_HELP_STRING([--enable-all-warnings], - [enable all useful warnings gcc can issue]), - [all_warnings=$enableval], - []) -AC_SUBST(all_warnings) - AC_ARG_ENABLE([werror], AS_HELP_STRING([--disable-werror], [do not build with -Werror]),