From patchwork Tue Jul 11 08:12:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Xi Ruoyao X-Patchwork-Id: 1806194 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=KHMFTbtd; dkim-atps=neutral Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4R0YXG0S0Mz20b9 for ; Tue, 11 Jul 2023 18:13:00 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BA5143857704 for ; Tue, 11 Jul 2023 08:12:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BA5143857704 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1689063178; bh=+5XeLia7IDlZsqjX+99JX+OLmWqxOpTbiwNd2GGh0y8=; h=Subject:To:Cc:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=KHMFTbtdM7skh2Runob68eVB7G3NyeJc/KSobkFauH95aANhJrIYk7aEjLEUbWHhC uoEqFdyOPtKZYkSSkN7Qt3TCVs+b9nJpRw0qrbm5yiYfWHFlsULIPcTmlcit2QJY0W wGdgT8HyqWxDSyB5JP3TmSb2kytyjy0FjQNlN/cM= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id B6B823858CDA for ; Tue, 11 Jul 2023 08:12:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B6B823858CDA Received: from [IPv6:240e:358:11c0:7200:dc73:854d:832e:2] (unknown [IPv6:240e:358:11c0:7200:dc73:854d:832e:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 3DD25663DE; Tue, 11 Jul 2023 04:12:32 -0400 (EDT) Message-ID: <2a5b1036e11476a31c79b0c9d53cca3d7bbe7db2.camel@xry111.site> Subject: [PATCH pushed] testsuite: Unbreak pr110557.cc where long is 32-bit (was Re: Pushed: [PATCH v2] vect: Fix vectorized BIT_FIELD_REF for signed bit-fields [PR110557]) To: Prathamesh Kulkarni Cc: Richard Biener , gcc-patches@gcc.gnu.org, Andre Vieira , Jakub Jelinek , Hongtao Liu Date: Tue, 11 Jul 2023 16:12:26 +0800 In-Reply-To: References: <20230707131857.2386125-2-xry111@xry111.site> User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, LIKELY_SPAM_FROM, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Xi Ruoyao via Gcc-patches From: Xi Ruoyao Reply-To: Xi Ruoyao Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" On Tue, 2023-07-11 at 13:04 +0530, Prathamesh Kulkarni wrote: /* snip */ > Hi Xi, > Your commit: > https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=63ae6bc60c0f67fb2791991bf4b6e7e0a907d420, > > seems to cause following regressions on arm-linux-gnueabihf: > FAIL: g++.dg/vect/pr110557.cc  -std=c++98 (test for excess errors) > FAIL: g++.dg/vect/pr110557.cc  -std=c++14 (test for excess errors) > FAIL: g++.dg/vect/pr110557.cc  -std=c++17 (test for excess errors) > FAIL: g++.dg/vect/pr110557.cc  -std=c++20 (test for excess errors) > > Excess error: > gcc/testsuite/g++.dg/vect/pr110557.cc:12:8: warning: width of > 'Item::y' exceeds its type Ah sorry, I didn't consider ports with 32-bit long. The attached patch should fix the issue. It has been tested and pushed r14-2427 and r13-7555. From 312839653b8295599c63cae90278a87af528edad Mon Sep 17 00:00:00 2001 From: Xi Ruoyao Date: Tue, 11 Jul 2023 15:55:54 +0800 Subject: [PATCH] testsuite: Unbreak pr110557.cc where long is 32-bit On ports with 32-bit long, the test produced excess errors: gcc/testsuite/g++.dg/vect/pr110557.cc:12:8: warning: width of 'Item::y' exceeds its type Reported-by: Prathamesh Kulkarni gcc/testsuite/ChangeLog: * g++.dg/vect/pr110557.cc: Use long long instead of long for 64-bit type. (test): Remove an unnecessary cast. --- gcc/testsuite/g++.dg/vect/pr110557.cc | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/gcc/testsuite/g++.dg/vect/pr110557.cc b/gcc/testsuite/g++.dg/vect/pr110557.cc index e1fbe1caac4..effb67e2df3 100644 --- a/gcc/testsuite/g++.dg/vect/pr110557.cc +++ b/gcc/testsuite/g++.dg/vect/pr110557.cc @@ -1,7 +1,9 @@ // { dg-additional-options "-mavx" { target { avx_runtime } } } -static inline long -min (long a, long b) +typedef long long i64; + +static inline i64 +min (i64 a, i64 b) { return a < b ? a : b; } @@ -9,16 +11,16 @@ min (long a, long b) struct Item { int x : 8; - long y : 55; + i64 y : 55; bool z : 1; }; -__attribute__ ((noipa)) long +__attribute__ ((noipa)) i64 test (Item *a, int cnt) { - long size = 0; + i64 size = 0; for (int i = 0; i < cnt; i++) - size = min ((long)a[i].y, size); + size = min (a[i].y, size); return size; } -- 2.41.0