From patchwork Thu Jun 22 19:19:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josh Triplett X-Patchwork-Id: 1798576 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=5CEWKwV6; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=joshtriplett.org header.i=@joshtriplett.org header.a=rsa-sha256 header.s=fm1 header.b=cKc5M8i/; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=bdSACyKr; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Qn9Dh4H03z20Xt for ; Fri, 23 Jun 2023 05:20:04 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XII9fG8aSj5fpmF7TW/Y1j/rbsRgvDRY8o1nwleO79s=; b=5CEWKwV6nt5Jd9 0YAqOUqk0brgS830QjTLE2iDocVJfgyZua81ijDUyXDPTHCqPKVJkObkvYvaZDrQLTffNmyF4Tvdt fS2jvSZIU4GPF1YoF14duVyjXAq1atZbsEDZwm97CCngow3KUiXFKMq5xxHmDPJZEcZ8sl/aPwOe8 2JKBuufYV26q/XNKmU2AXpMOivrBN3T/FD4x00PcXEtN/IoWQKBlN9YZBPr2SwBSCydS7jam7O7Ts xKsf5GJ8hKumrHTXWC8ESiGGV+EdAy0eVcJOURL4dC82/+0xcSmTM+GyeE6geGUfsCr0IptVOew5J T9cMXS7bne7bZBDneRaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qCPqb-001Xtt-09; Thu, 22 Jun 2023 19:20:01 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qCPqX-001XtA-34 for linux-snps-arc@lists.infradead.org; Thu, 22 Jun 2023 19:19:59 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id B210E320092A; Thu, 22 Jun 2023 15:19:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 22 Jun 2023 15:19:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= joshtriplett.org; h=cc:cc:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1687461596; x=1687547996; bh=6+6r2jl0FgLMZhz62vz2TuajhsbnfKNl/0S YnIJgOYk=; b=cKc5M8i/kxkAd48cHUJPl/dMTVQeBtrTTPo3fcmtqYcNAoVtikC L66GZDOJ8ySjYAko8YPGVGDBaLQGFW8fxIgAgIyQ+AQIBfItHSJ6xo6DZQUNCemk 4lirbqL5J/JiPmYEO8u6X3YAaU6/LHgkPub3hwi2Kz3+n7ZY8BSqyEI29V0tA6KR T0UDAdYPNyQXjvd/CoXvhAG2kNTZEME+ZW4MwxkmQytphbPk++lh8pdyPBYx/Zhk IOo71hSiLDCss0wuHwI2T00VBPgKycmlTkR7u+IAE2Qj9DXqv7xRt6d2jfOv+3L8 Z/mi4gfNXHHkC4vl7Vo/JGbGo/fGMGoCvOA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1687461596; x=1687547996; bh=6+6r2jl0FgLMZ hz62vz2TuajhsbnfKNl/0SYnIJgOYk=; b=bdSACyKrfoSxEzz3j8tmMKJgKOTjs d1v5Y9JB8u4kRSXpc+LyIY88+HFfrr2YQ1yJ/6kUylSzPdA05Ist8JhhEa9QzKKE ytiJGk7wJBOmgDGlcnOJYy/onAbwc0Rr+bGTrHqKR0pcfPOWuOMuuJlo0e/y4GrR BcGQDp7ykjbhjB2ZtXERGpIOAEaCjmMVymHLDjzjK+pS+luFViTdK1Glm2ANHtCe 8yhsepfIkjP06N5dMO4sDHYgAfnrFZGoF0TYksDKKHtwX+bpDVU4dxP/WvDYP9zQ niufq1rHAQG8mM6XcjRkI/DYBEf6MYQy7jvGjV/MIZnWTPvflm7chy71A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeeguddgudefhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeflohhs hhcuvfhrihhplhgvthhtuceojhhoshhhsehjohhshhhtrhhiphhlvghtthdrohhrgheqne cuggftrfgrthhtvghrnhepvdekleffgfetfeeijedtieehtdeuhfegueejkeevueeileff gfduleffjeffuddvnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjohhshhesjhhoshhhthhr ihhplhgvthhtrdhorhhg X-ME-Proxy: Feedback-ID: i83e94755:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Jun 2023 15:19:54 -0400 (EDT) Date: Thu, 22 Jun 2023 12:19:53 -0700 From: Josh Triplett To: linux-kbuild@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Ben Hutchings , linux-snps-arc@lists.infradead.org, Masahiro Yamada Subject: [PATCH] kbuild: builddeb: always make modules_install, to install modules.builtin* Message-ID: References: <20230615111743.883891-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230615111743.883891-1-masahiroy@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230622_121958_025638_2578BABC X-CRM114-Status: GOOD ( 10.92 ) X-Spam-Score: -0.9 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Even for a non-modular kernel, the kernel builds modules.builtin and modules.builtin.modinfo, with information about the built-in modules. Tools such as initramfs-tools need these files to build a wor [...] Content analysis details: (-0.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [64.147.123.20 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Even for a non-modular kernel, the kernel builds modules.builtin and modules.builtin.modinfo, with information about the built-in modules. Tools such as initramfs-tools need these files to build a working initramfs on some systems, such as those requiring firmware. Now that `make modules_install` works even in non-modular kernels and installs these files, unconditionally invoke it when building a Debian package. Signed-off-by: Josh Triplett Reviewed-by: Nicolas Schier --- This patch depends on https://lore.kernel.org/lkml/20230615111743.883891-1-masahiroy@kernel.org/ scripts/package/builddeb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/package/builddeb b/scripts/package/builddeb index 252faaa5561c..f500e3910158 100755 --- a/scripts/package/builddeb +++ b/scripts/package/builddeb @@ -62,8 +62,8 @@ install_linux_image () { ${MAKE} -f ${srctree}/Makefile INSTALL_DTBS_PATH="${pdir}/usr/lib/linux-image-${KERNELRELEASE}" dtbs_install fi + ${MAKE} -f ${srctree}/Makefile INSTALL_MOD_PATH="${pdir}" modules_install if is_enabled CONFIG_MODULES; then - ${MAKE} -f ${srctree}/Makefile INSTALL_MOD_PATH="${pdir}" modules_install rm -f "${pdir}/lib/modules/${KERNELRELEASE}/build" rm -f "${pdir}/lib/modules/${KERNELRELEASE}/source" if [ "${SRCARCH}" = um ] ; then