From patchwork Tue May 16 14:21:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Herbrechtsmeier X-Patchwork-Id: 1782082 X-Patchwork-Delegate: monstr@monstr.eu Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=weidmueller.onmicrosoft.com header.i=@weidmueller.onmicrosoft.com header.a=rsa-sha256 header.s=selector1-weidmueller-onmicrosoft-com header.b=IFAlXyYX; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QLJML638dz20dg for ; Wed, 17 May 2023 00:21:34 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F3FC286102; Tue, 16 May 2023 16:21:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=weidmueller.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=weidmueller.onmicrosoft.com header.i=@weidmueller.onmicrosoft.com header.b="IFAlXyYX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 09DB986129; Tue, 16 May 2023 16:21:30 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FORGED_SPF_HELO,SPF_HELO_PASS,T_SCC_BODY_TEXT_LINE, T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on061f.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0c::61f]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CD5A0860C3 for ; Tue, 16 May 2023 16:21:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=weidmueller.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=stefan.herbrechtsmeier-oss@weidmueller.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ljkncdto2vKtujVhOyJdlSpiAHFF1NQDH6qio3AFeBxNoko/2rzVHlh0waYtQYvCVHQ4Cp1fp4Lpq1DEJXVo1sEuI1yNspnpgiECa8zWphAQTvm/NHO1HoOd0XoZbs/3Ipucy+gOru0zhhzK908rKAAVVcwMoSHTtsLHrIrqkwQmGWqLA7wbcmkxzft+ixxBZJaYss97pJQSIxpEiDKvcMdO9DtQ6ZWhGXbM89WX/x8lUMzGWLW9wyKe4SZDe41jgVySFGVOQID3w+6jTjJiVoNvge8wVKysMZQUcTlgN6XVLRdWqoa2qmQxJcWQJ8eeO3KtysBSUpQNJ9ZDOO5RjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=01zZ9kH/Ci2sWhM61FpjTlhjfuZ3DYSTuBoWCIlz1sc=; b=WdBgPG/fPAmMbrSYzsk6VcP5RVUAsH4s4q3uqIjFsGGklaNd71m4E97jmXN8QwgNAcHYLF/gZf9zJcxgqZcNjRcwoX7TuzGgKH2FAuxA/wdqcd3sMLkenFsu39cewFNXsXacXxAKM4E6gNX1RkkZvRfny3tmr17nWitRgR8xRzwLGxy2LIZfY6X1pjQhTXBGNQy6h+M0N7Obr5rvsynvrxNeg20tCfgls6uV+uEOBnOJZU0mK+LuBBR2IrXkKj76ybnVF5FgIkVrXlAXIN0NKifd2urbIqiygNJZfj8DEm2UHHbrdzQOIqzSbqtDZBLPXKT8oFR2KyvaOHr+Jh/V1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.onmicrosoft.com; s=selector1-weidmueller-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=01zZ9kH/Ci2sWhM61FpjTlhjfuZ3DYSTuBoWCIlz1sc=; b=IFAlXyYXqCH5OObgIR5KQVNwHfkL4dt338RzrJ4ENfwoaRyzDOtLQujsouSJFjRpQDJLJLg9S9akMvtXHW7uO/9Ub6dBA6B525n+74zNRQ66cKv829CsrLjti5GMcnT3UkT4yRiTmuz8s7VgK0/sTNdoJaoYayWDNhOkBOpaWYM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=weidmueller.com; Received: from PAXPR08MB6969.eurprd08.prod.outlook.com (2603:10a6:102:1d8::23) by AS8PR08MB6102.eurprd08.prod.outlook.com (2603:10a6:20b:23d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.32; Tue, 16 May 2023 14:21:26 +0000 Received: from PAXPR08MB6969.eurprd08.prod.outlook.com ([fe80::5979:132b:6e3:cfb2]) by PAXPR08MB6969.eurprd08.prod.outlook.com ([fe80::5979:132b:6e3:cfb2%6]) with mapi id 15.20.6387.030; Tue, 16 May 2023 14:21:26 +0000 From: Stefan Herbrechtsmeier To: u-boot@lists.denx.de Cc: Stefan Herbrechtsmeier , Jaehoon Chung , Michal Simek , Peng Fan Subject: [RFC PATCH] mmc: zynq_sdhci: Dependable card detect Date: Tue, 16 May 2023 16:21:16 +0200 Message-Id: <20230516142116.29996-1-stefan.herbrechtsmeier-oss@weidmueller.com> X-Mailer: git-send-email 2.30.2 X-ClientProxiedBy: FR0P281CA0168.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b4::17) To PAXPR08MB6969.eurprd08.prod.outlook.com (2603:10a6:102:1d8::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR08MB6969:EE_|AS8PR08MB6102:EE_ X-MS-Office365-Filtering-Correlation-Id: 93ea9f96-e0ce-45bd-99a0-08db5618d554 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pxWl6XJUwO88a+W6FA7pwC30u/J24A1Fxa9GKdhF2egUL8+mb8FvmAi4UfLcm4VBy/0f9j2nDcnUKmeS87OVk5ULRyCRy8EGRR6OTmtV+H7r633RHTsZ8gayWOHcR5NOcNeAqcdOlBKzelsrM+KI34xgBSc6mY763lI3u1xRmJNeO135Chy+bVhK+ZEn68C2fZueZZtCEdmuygAxkvA6AfIcoWP6/WWBXj30i3ynPhen6auIyH6de+fRdgwlRupfOz2Dl2nh4ZJgnBHIepqOSR8wVj/y2sXfyfs6qfZclkJXcHhni0zgtdxCVlvXPAKM/+7XzSV+9TY2xxjPelrc8xrFbBOWeT6s5PR1YEobaHnwyrTISTtjd7jNr/g3xsFJVQLP5duJzDZFhINylY9LFDtV/PFopExhcw0078xwzi7yC9pg3uSFj+xXVuvP0RhVzVQqu0nmBGKTueEIgeqDArr6bTPoKqF6pZaVlXE6GvNJDcg4uSOvdzlbYGB47jIgraJp7rhoZdWoP9F3+l1KFaekKV+lVe7TpAJnjATzJeeaipP4ljqkXQUdV86cVlV4GqtU4KSC1iJNF8TGPWCkGxaZ9Q+PFNqEKZNSulqDn1pZnmvuh8fWzApgCoy3J9+d X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR08MB6969.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(396003)(136003)(376002)(346002)(366004)(451199021)(52116002)(66476007)(6916009)(478600001)(66556008)(86362001)(66946007)(4326008)(316002)(54906003)(6486002)(36756003)(83380400001)(26005)(6506007)(1076003)(186003)(2616005)(6512007)(6666004)(5660300002)(8936002)(2906002)(8676002)(38100700002)(38350700002)(41300700001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: isVD9rIW0IPPCPIdI1ldvfKZPDiV/cjuhswMuUMMkQO3EIxYq9nRIhXMka9CLT8Kuo986kVjMh8g+yO8TWWMyq/B6vEcEKMUtqlpgPjRqa8XLOLnDiJqV/QhSyw8Y8ukYkyc+F2CwQ4CZWyfzcZnWr1iwqzoxQToFv70NUWQA2vVwdGEq4Ez9ztKsUPCKZuHnFZkXvlzp4xy6T0931xHEzxXqbEs2cWi1mtHujK3ud9scYGp1CvClB7U8pDV1HdEc/JNCyHMGpnXC33qRKOK+uKKQ3Uy1dNE3mOmnF11L0r6iuxkkwJwpW6SUMJAMTThfshFQ+Hc/MQkV5QXPDqzfjHD0xglAEspURQgf85hpbPgG8YDL3Qcq1wmiGCkGD2un8OW3PHTPzQR/p6bop1IBo95cm+z7OUrXmdehX8wtc/Det/ZnlOztd7vSWd5oYPUG2rIRIArbeYTYjYc6nxGp9N1KVLnElF+ga48N+8yCYmMJm5nK13IKfWaOLou1pV263QfAG7/K+QozQw6BdetMfOBqMeHJepvrybbpbItAPetrZbsjpamHj2yLqCbRKRueWp1XnGCGq7FUgt77+NgG+QXUVr1wXjuDWIhDS6/7Z0AscVYePcvmxEjtzpI5Wo3MzTxz18rG/cQ0mM2g4/FbTGpZT9KRvZ/gVjTuPapdy7S2iuuUjPJZ/ylT5yn4vUjC+HE6GMWJke4hqs5yP4zGobanqWI+pL93W9u7ivqBvWr2vD+d/LqumEQqUZgndRApIPQiInqPDb3ilPa8bRNLIEZUN6vr39RGBWWczJOcSCaLx7bY5SviDGcWY9XUoT4K2ycf+5SzoXeiz9TvZwb2YjxMIUTYtx2SJ9PRN8IZLjATs//8q2M6SXBfUfLh5O56IOKJayVtqsprOXkyMyzm9s1PoIFNeLerEXtNxRKxOT9fg8yB9TBjTG+iNn+KfySLk4zG0CcCz1aFP1gVn+MGp5kPWG7i3reJBsuAUrrWoQTacsdVyqjrxUH4NJIhHwYSidMsUIbP6v4Z+p+njgUUIJTg5znhd8FCtG7orPc+lGhOFp6DxkZuoREUN/EqXrDep3bOu0OFNcdTtd2OWRuujvz1cpuCDmzFvzp2tBrJR1WI2b04pZykg7XEgopBPT8p3GpStkfUaUzpH/tpKdicIg2+Mn2h7ClShd4o6qCB7zY8k74qlD27Y8EX28DBs3N5FyAqK8MTJQDTub2BeiX2BeF5EebdjQWhOljmbged8iPHklyf7bDbM7FFakzhjzUCxuFltRlIXoTtHr/D/lTjIgRnhP2pRf3ExwUV/HynGssFaOwWe5uH18GxjireMjj9x/QC9L+8N/RqGU1ZgKlAk5mX93BZXZdSrGGk6jJ6g0ld8o5tP3UNJC4MCc6oV+xtryHGIqFjM7vteMG8teTdxn+jza8b+ScDBrEZ+Xds804ihCEgrI7lxcc96csU9u/QPqITuvfnzRQAyFshq8QkwNLf3dl5JtWFCTUVy4derAKGZpqlNfdm0wtUpR+VpNwGxwrcRS22W5I01HiuKB5Z6FUho/HKkmYuEiruqdccXHPrIQgvn30iOi3LL4g26pJCvI2jyllw2dpZMF3u4ruTw== X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: 93ea9f96-e0ce-45bd-99a0-08db5618d554 X-MS-Exchange-CrossTenant-AuthSource: PAXPR08MB6969.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2023 14:21:26.2758 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dOcDCngHC2a9CSQu9+kXQIofklLr4lZ6pQVqtEPqAuvSsoiCXzp1HiJ5K/6xzjxKvunfaY0OQw4tROHcu/0Zuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6102 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean From: Stefan Herbrechtsmeier The card detect logic needs a short card present signal to work dependable. Without a present card the SDHCI_CARD_STATE_STABLE signal is not set dependable after a reset. Use the internal fixed card present signal to initiate the card detect logic. Signed-off-by: Stefan Herbrechtsmeier --- On our hardware we get a "Sdhci card detect state not stable" error in the SPL if no mmc card is present. It is unclear if this patch is the correct solution, but a short card inserts or a fixed card present signal leads to a SDHCI_CARD_STATE_STABLE signal with and without card. drivers/mmc/zynq_sdhci.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/mmc/zynq_sdhci.c b/drivers/mmc/zynq_sdhci.c index e44868aaec..a88feeb367 100644 --- a/drivers/mmc/zynq_sdhci.c +++ b/drivers/mmc/zynq_sdhci.c @@ -1075,6 +1075,26 @@ static int sdhci_zynqmp_set_dynamic_config(struct arasan_sdhci_priv *priv, return ret; } + /* The card detect logic needs a short card present signal to work + * dependable. Without a present card the SDHCI_CARD_STATE_STABLE + * signal is not set dependable after a reset. Use the internal + * fixed card present signal to initiate the card detect logic. + */ + if (!dev_read_bool(dev, "non-removable")) { + ret = zynqmp_pm_set_sd_config(priv->node_id, SD_CONFIG_EMMC_SEL, + 1); + if (ret) { + dev_err(dev, "SD_CONFIG_EMMC_SEL failed\n"); + return ret; + } + ret = zynqmp_pm_set_sd_config(priv->node_id, SD_CONFIG_EMMC_SEL, + 0); + if (ret) { + dev_err(dev, "SD_CONFIG_EMMC_SEL failed\n"); + return ret; + } + } + return 0; } #endif