From patchwork Fri May 12 16:43:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uros Bizjak X-Patchwork-Id: 1780737 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=SQfkK0EH; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QHvk63lZJz20KD for ; Sat, 13 May 2023 02:44:29 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D7D833858426 for ; Fri, 12 May 2023 16:44:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D7D833858426 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1683909866; bh=wPUcZnvDv2s/FfRkKnueCcQyZoX0bsq7N04jhGJnBB4=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=SQfkK0EHpAlx884PrkELZs7XB4O+7evqA417MWVDHjHQcq1JdI9KIcFTapyOB+t6Z BhztllFoQxnqg/Jrr847jQAEKC61VAaUb6r92wCIdmBjn0kQ39PNF8wyNWrLPSF1gE 3KR5MiKSa/6zfneH5jDMHkV05JZ1sY1ki0ygD4Ps= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) by sourceware.org (Postfix) with ESMTPS id E9B9B3858C54 for ; Fri, 12 May 2023 16:44:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E9B9B3858C54 Received: by mail-qk1-x736.google.com with SMTP id af79cd13be357-75131c2997bso3489319985a.1 for ; Fri, 12 May 2023 09:44:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683909842; x=1686501842; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=wPUcZnvDv2s/FfRkKnueCcQyZoX0bsq7N04jhGJnBB4=; b=Nu3/JCtovtL/uSBUKV5Bu2eWKLBrfvv7kHjmD4ekhfbKY19e+lyxNG3VDtqhhrigVh /O1dz8Kep1e0jcgEgLftoqF2gVY+ZJ8TlVu54O69rrhl1cSzHPHwDuv9deTyeFC/9gQ9 9BbfLeHQmplslQ9eGw/JZlUdkmWb7PIDMu8JdwqOxFQWPOhJyi6gxbWwfhALIPbzWujF eJTOrl1XzeRcff1b5jL3Y3QEw8bGPBTllaJMhEzSydoe8KezvZdv77QY+Q/f5HiptIQg tupbZLIUnKu3HtowUTZZmtysaVUFgqvA0GEOAzjnPFsW+ikEAN1/ieLupgFtckMZxtel Co6A== X-Gm-Message-State: AC+VfDwmQaXtev6dGdPM6fHqpwiw2Z/QvFQUiNb3H+Ds6ijDRIkssKar fIcSe3Ev17Dmv0CLXQNTggCRn60XazCbNI7mciJYeP8Iuk0kIA== X-Google-Smtp-Source: ACHHUZ57XwQ+pfaahcssGeIfhKgTkg6fQ6+q98u9Hts4YZMj//QXwfeQe7JHxXTkigsFeDdiIMeM52IKh0DHm34SqHk= X-Received: by 2002:ad4:5cce:0:b0:5ac:96c3:14d4 with SMTP id iu14-20020ad45cce000000b005ac96c314d4mr37893456qvb.17.1683909841961; Fri, 12 May 2023 09:44:01 -0700 (PDT) MIME-Version: 1.0 Date: Fri, 12 May 2023 18:43:50 +0200 Message-ID: Subject: [PATCH] i386: Remove mulv2si emulated sequence for TARGET_SSE2 [PR109797] To: "gcc-patches@gcc.gnu.org" X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Uros Bizjak via Gcc-patches From: Uros Bizjak Reply-To: Uros Bizjak Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Remove mulv2si emulated sequence for TARGET_SSE2 and enable only native PMULLD instruction for TARGET_SSE4_1. Ideally, the vectorization for TARGET_SSE2 should depend on more precise cost estimation (the PR contains patch for ix86_multiplication_cost), but even with patched cost function the runtime regression was not fixed. PR target/109797 gcc/ChangeLog: * config/i386/mmx.md (mulv2si3): Remove expander. (mulv2si3): Rename insn pattern from *mulv2si. Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. Pushed to master. Uros. diff --git a/gcc/config/i386/mmx.md b/gcc/config/i386/mmx.md index e7ca921dd2b..b2954fff8ae 100644 --- a/gcc/config/i386/mmx.md +++ b/gcc/config/i386/mmx.md @@ -2092,39 +2092,7 @@ (define_insn "*3" (set_attr "type" "sseadd") (set_attr "mode" "TI")]) -(define_expand "mulv2si3" - [(set (match_operand:V2SI 0 "register_operand") - (mult:V2SI - (match_operand:V2SI 1 "register_operand") - (match_operand:V2SI 2 "register_operand")))] - "TARGET_MMX_WITH_SSE" -{ - if (!TARGET_SSE4_1) - { - rtx op1 = lowpart_subreg (V4SImode, force_reg (V2SImode, operands[1]), - V2SImode); - rtx op2 = lowpart_subreg (V4SImode, force_reg (V2SImode, operands[2]), - V2SImode); - - rtx tmp1 = gen_reg_rtx (V4SImode); - emit_insn (gen_vec_interleave_lowv4si (tmp1, op1, op1)); - rtx tmp2 = gen_reg_rtx (V4SImode); - emit_insn (gen_vec_interleave_lowv4si (tmp2, op2, op2)); - - rtx res = gen_reg_rtx (V2DImode); - emit_insn (gen_vec_widen_umult_even_v4si (res, tmp1, tmp2)); - - rtx op0 = gen_reg_rtx (V4SImode); - emit_insn (gen_sse2_pshufd_1 (op0, gen_lowpart (V4SImode, res), - const0_rtx, const2_rtx, - const0_rtx, const2_rtx)); - - emit_move_insn (operands[0], lowpart_subreg (V2SImode, op0, V4SImode)); - DONE; - } -}) - -(define_insn "*mulv2si3" +(define_insn "mulv2si3" [(set (match_operand:V2SI 0 "register_operand" "=Yr,*x,v") (mult:V2SI (match_operand:V2SI 1 "register_operand" "%0,0,v")