From patchwork Thu May 11 15:50:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frode Nordahl X-Patchwork-Id: 1780149 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::133; helo=smtp2.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=UmkvGCPA; dkim-atps=neutral Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QHGZ333wZz214S for ; Fri, 12 May 2023 01:50:19 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 6088D42C84; Thu, 11 May 2023 15:50:17 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 6088D42C84 Authentication-Results: smtp2.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=UmkvGCPA X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Md2Icq0sIbu8; Thu, 11 May 2023 15:50:16 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id 7040C404C4; Thu, 11 May 2023 15:50:15 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 7040C404C4 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3F301C0036; Thu, 11 May 2023 15:50:15 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6050BC002A for ; Thu, 11 May 2023 15:50:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 3425A40A08 for ; Thu, 11 May 2023 15:50:14 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 3425A40A08 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bqLg5v-yZk5Q for ; Thu, 11 May 2023 15:50:13 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org AB1C5404C4 Received: from smtp-relay-canonical-0.canonical.com (smtp-relay-canonical-0.canonical.com [185.125.188.120]) by smtp2.osuosl.org (Postfix) with ESMTPS id AB1C5404C4 for ; Thu, 11 May 2023 15:50:12 +0000 (UTC) Received: from frode-threadripper.. (2.general.frode.uk.vpn [10.172.193.251]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id E9E2A40E4E for ; Thu, 11 May 2023 15:50:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1683820209; bh=uU1U0bgMi07BmaRcSME1MMhuo77KYp25lEI87gOE+iQ=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=UmkvGCPAzKYWOErCcGZz3wDeCXBzIiRWkiVfjsDj/YDEKt7rsJJcV8q0O7kFwCuuQ xK1r6HM3M4oSCX3yZJty8QRRbozmWDSq3rOblGRXeV/jlTWrkaeQiMuZhU2ih/XsbM I0yQ1IWqwQJH3hVwC945683aBokNBF0oBXacLLVVPIAKDiQLjxxVsB3Ed1Bi8NpSZm JVS6j0Zmfh5m8j2YhO3zmR8YopZ/zjUggFrC4oIbjTlBHmLYiWUf2/QJrpB6gg6n5o HmxsiwWMAsH+oxhJxsXfEJu26kMeT6AtVZ1PH70HN8yfqCQUNtkDdcZigWDAwTK/1x i53A7wSkhaU1g== From: Frode Nordahl To: dev@openvswitch.org Date: Thu, 11 May 2023 17:50:07 +0200 Message-Id: <20230511155007.4133573-1-frode.nordahl@canonical.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Subject: [ovs-dev] [PATCH] tests dpdk: Allow passing in dpdk-extra arguments. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" At present, the system-dpdk-testsuite makes assumptions about environment configuration, and will error out if DPDK compatible interfaces not configured for DPDK are present in the system with a message like: INFO|EAL: Probe PCI driver: net_virtio (1af4:1000) device: 0000:00:03.0 (socket -1) ERR|eth_virtio_pci_init(): Failed to init PCI device ERR|EAL: Requested device 0000:00:03.0 cannot be used The system-dpdk-testsuite is useful even with no DPDK PHY available, as the tests requiring a PHY will skip gracefully when none present. This patch allows passing in values that will be set in `other_config:dpdk-extra` before the test runs, which among other things, would allow to use the DPDK EAL block (-b) and allow (-a) options. Having those available would make it possible to run the testsuite unaltered in more environments. We will use this patch in a follow-up, enabling more elaborate Debian autopkgtests for Open vSwitch. Signed-off-by: Frode Nordahl --- tests/system-dpdk-macros.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/system-dpdk-macros.at b/tests/system-dpdk-macros.at index dfdb3bd30..c74e8a0f1 100644 --- a/tests/system-dpdk-macros.at +++ b/tests/system-dpdk-macros.at @@ -72,7 +72,7 @@ m4_define([OVS_DPDK_START_OVSDB], # m4_define([OVS_DPDK_START_VSWITCHD], [dnl Change DPDK drivers log levels so that tests only catch errors - AT_CHECK([ovs-vsctl --no-wait set Open_vSwitch . other_config:dpdk-extra='-a ffff:ff:ff.f --log-level=pmd.*:error']) + AT_CHECK([ovs-vsctl --no-wait set Open_vSwitch . other_config:dpdk-extra="--log-level=pmd.*:error $TESTSUITE_DPDK_EXTRA"]) dnl Start ovs-vswitchd. AT_CHECK([ovs-vswitchd --detach --no-chdir --pidfile --log-file -vvconn -vofproto_dpif -vunixctl], [0], [stdout], [stderr])