From patchwork Mon Mar 27 07:54:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Liu X-Patchwork-Id: 1761387 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=B0VraFfm; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PlQ8t1Vl7z1yXq for ; Mon, 27 Mar 2023 18:55:26 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EB32A85CFA; Mon, 27 Mar 2023 09:55:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="B0VraFfm"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0754A85C95; Mon, 27 Mar 2023 09:55:11 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B899885D00 for ; Mon, 27 Mar 2023 09:55:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=net147@gmail.com Received: by mail-pl1-x636.google.com with SMTP id u10so7593534plz.7 for ; Mon, 27 Mar 2023 00:55:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679903706; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=X/hJF48BdhBLbQ93Ji0PJ4LoT11l/DZ5Fbb99FZJuZM=; b=B0VraFfm2NX7cMfM19QY6BykpONgpS0DWX39zIEcLaRZHfbQgHM0T6qYZ24FNaOP/x 8Oyf7bfvFSg/Nm5gWtpPJnR9vStp27ZZKFVciT9VHplkUASfSr6hNLsoIkH5rxte+PHn t/N22St/e+ZSqpxEdULXEYjV4LOrdt70iO9LnbkxcJN0M/5r/BQ4LV/3kHHqz+pCyTtK h0gkIJ53Rod0Ph6c49fO6s5J05ta70MuxFHttXRhQHI+9WalNwra9yS++8V8FAxjmuv6 e3XFeMuIykhHqyVxmUIKSxHVb44QunXWTwUwPsFRkwEaaP0CN4yoKmtdWwEpDjEiBTC2 fRCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679903706; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=X/hJF48BdhBLbQ93Ji0PJ4LoT11l/DZ5Fbb99FZJuZM=; b=NOuUQtUBRL/4kseKtigq9o74U0ZEEtpctdFQOzFJHlUZ3LohNCjzYSZpu0LMcwgxcW FjrL9VoMhTHQ3sS2bnJXhyq4uJ7NLHsCkJPclJ9qB3P40pXv63B4wroWFbcE8/xjcNk9 3YqZNLezieuu+XfEXFqoe3sb1A9EEQRB9YXD4ygcP/eZfsWW1cO4wvRtPj3piWMPcFeZ vHbrqMu5Z6P3baRUOS7mII1ZZFZySm7lJzcmq7lgKM1EaB6mYK/qQi0Dv2d6YorOFE7b T5Ascno+8CDqMvhtyKUyA3dVycS/hdh9CDIYaO1W500lSuKABlGdaKZPLr5GzTq1s7xm MClQ== X-Gm-Message-State: AAQBX9dCk5+KJfdByHUgz+jCclVctlSF5GWdWo9EfvN1XkmKYFh3oYja VNmgGoU/uMkDegn9OPXf57hTaxLGStROYw== X-Google-Smtp-Source: AKy350ZzFvbrMqubbe106lGXyjDp8eU/wcUY0QCEqyfPTYX/gAFuASlo1mRgQnGayz2QWRcqdvXSSw== X-Received: by 2002:a17:902:ea08:b0:1a1:9666:7a30 with SMTP id s8-20020a170902ea0800b001a196667a30mr11895800plg.54.1679903705945; Mon, 27 Mar 2023 00:55:05 -0700 (PDT) Received: from 167-179-157-192.a7b39d.syd.nbn.aussiebb.net (167-179-157-192.a7b39d.syd.nbn.aussiebb.net. [167.179.157.192]) by smtp.gmail.com with ESMTPSA id u4-20020a170902b28400b001a19d4592e1sm18352179plr.282.2023.03.27.00.55.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 00:55:05 -0700 (PDT) From: Jonathan Liu To: Michal Simek Cc: u-boot@lists.denx.de, Jonathan Liu Subject: [PATCH] sysreset: gpio: fix gpio_reboot_request return value Date: Mon, 27 Mar 2023 18:54:55 +1100 Message-Id: <20230327075455.420404-1-net147@gmail.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean It should return -EINPROGRESS if successful otherwise sysreset-uclass will continue to the next sysreset device. Signed-off-by: Jonathan Liu Reviewed-by: Simon Glass --- drivers/sysreset/sysreset_gpio.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/sysreset/sysreset_gpio.c b/drivers/sysreset/sysreset_gpio.c index dfca10ccc8..d12e491ffe 100644 --- a/drivers/sysreset/sysreset_gpio.c +++ b/drivers/sysreset/sysreset_gpio.c @@ -17,6 +17,7 @@ struct gpio_reboot_priv { static int gpio_reboot_request(struct udevice *dev, enum sysreset_t type) { struct gpio_reboot_priv *priv = dev_get_priv(dev); + int r; /* * When debug log is enabled please make sure that chars won't end up @@ -26,7 +27,11 @@ static int gpio_reboot_request(struct udevice *dev, enum sysreset_t type) debug("GPIO reset\n"); /* Writing 1 respects polarity (active high/low) based on gpio->flags */ - return dm_gpio_set_value(&priv->gpio, 1); + r = dm_gpio_set_value(&priv->gpio, 1); + if (r < 0) + return r; + + return -EINPROGRESS; } static struct sysreset_ops gpio_reboot_ops = {