From patchwork Fri Mar 16 11:56:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 886748 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-474854-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=mentor.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="sNuTIGR2"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 402kSk13pkz9sC7 for ; Fri, 16 Mar 2018 22:56:21 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:from:cc:message-id:date:mime-version :in-reply-to:content-type; q=dns; s=default; b=v/uLT4R2jd5IN203E XuJWBwatXl+ZvLBXZZ+iwnybCq9u/HzwaJqYgt0W9dL+Q4EC1t0wakU2/L+kKVH4 N89bb9UjnL6JmIM+P4TsATo7BwrdkvLZ725SLpEhjud8Ttm+8xCzMgsR6dlbbgJe IieeOT10DMvc9Q9a0lB8uoviwg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:from:cc:message-id:date:mime-version :in-reply-to:content-type; s=default; bh=9496g+JhWEKCKHAVELxH2+e BtU0=; b=sNuTIGR2jkr50kTTMXDJRETT2eMbJjaeweeSKvOF2dzMt92QB5hjUh7 gWY0U2hVXkQtWMpr/pYIvZnRsmLtGTRG43K8szugpjiuhpX8H/HtU3C+X6fyfCvZ JIijkuwtdz3+ef1OjRVM+v8CKU1OSOF0tXbKaOa7eShs2NdUa2T0= Received: (qmail 121243 invoked by alias); 16 Mar 2018 11:56:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 121229 invoked by uid 89); 16 Mar 2018 11:56:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS, URIBL_RED autolearn=ham version=3.3.2 spammy=Hx-languages-length:1871 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 Mar 2018 11:56:13 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-04.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1ewnxz-0001oD-3H from Tom_deVries@mentor.com ; Fri, 16 Mar 2018 04:56:11 -0700 Received: from [172.30.73.136] (137.202.0.87) by SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Fri, 16 Mar 2018 11:56:07 +0000 Subject: [testsuite] Require label_values in builtin-unreachable-6.c To: Jeff Law References: From: Tom de Vries CC: gcc-patches Message-ID: <2509e81d-ed06-a8b2-cd36-5ec490a4b41a@mentor.com> Date: Fri, 16 Mar 2018 12:56:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) [ was: Re: [PATCH][committed][PR tree-optimization/82123] 02/06 Perform EVRP analysis in sprintf warning pass ] On 02/20/2018 07:52 PM, Jeff Law wrote: > This twiddles one test -- adding the calls into the analyzer from the > sprintf pass causes us to record a range for an object that didn't have > one before and compromises the test. I just turn off VRP which is > sufficient to obscure things so that we don't remove the > __builtin_unreachable. > > diff --git a/gcc/testsuite/gcc.dg/builtin-unreachable-6.c b/gcc/testsuite/gcc.dg/builtin-unreachable-6.c > index 1915dd1..b0504be 100644 > --- a/gcc/testsuite/gcc.dg/builtin-unreachable-6.c > +++ b/gcc/testsuite/gcc.dg/builtin-unreachable-6.c > @@ -1,5 +1,5 @@ > /* { dg-do compile } */ > -/* { dg-options "-O2 -fdump-tree-fab1 -fno-tree-dominator-opts" } */ > +/* { dg-options "-O2 -fdump-tree-fab1 -fno-tree-dominator-opts -fno-tree-vrp" } */ > > void > foo (int b, int c) > Preventing vrp triggered "sorry, unimplemented: target cannot support label values" on nvptx. Fixed by requiring the effective target label_values. Thanks, - Tom [testsuite] Require label_values in builtin-unreachable-6.c 2018-03-16 Tom de Vries * gcc.dg/builtin-unreachable-6.c: Require effective target label_values. --- gcc/testsuite/gcc.dg/builtin-unreachable-6.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/testsuite/gcc.dg/builtin-unreachable-6.c b/gcc/testsuite/gcc.dg/builtin-unreachable-6.c index b0504be..4c3b9bb 100644 --- a/gcc/testsuite/gcc.dg/builtin-unreachable-6.c +++ b/gcc/testsuite/gcc.dg/builtin-unreachable-6.c @@ -1,5 +1,6 @@ /* { dg-do compile } */ /* { dg-options "-O2 -fdump-tree-fab1 -fno-tree-dominator-opts -fno-tree-vrp" } */ +/* { dg-require-effective-target label_values } */ void foo (int b, int c)