From patchwork Tue Dec 6 17:10:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 1712904 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=X5b3vKE1; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.a=rsa-sha256 header.s=google header.b=dyXoW4R5; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NRRm854xDz23yq for ; Wed, 7 Dec 2022 04:11:52 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C9pTe3gCZWgkVzPILLHrl3i2jZgFyKIxW9YEqBNFxrc=; b=X5b3vKE1ynirs/ TGMqMT8CvY9EDR5yE7sYp5tKlDt0fX1hrAKAqNzqJWxn5yfGRJTNsOfP9FHl7RwfED8nxTBzfVNpq fFj2YOewI18lAn3SW/vZWW3VN5T6miOt6kyKmcPl5svSsSI02ucep2Wvx1kL2MXUNsVzJr01d1P4O p1lLVUA/LnVeLBulqSXPRvsQrwIwWP3OdDF3rdBf64isKV2TBihgTVqFfp78fkGmEiUj91RIPD1lG r63d4tKPs4vLgyUteOmhyM1wTq2qBADRUKd9uOe8jhUeqMjJ1t4FKY1JQrVycq1HsF6HqiTftpv4q Voc1gxYMfgtUnq5Yo8xQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2bTj-00FhVA-NZ; Tue, 06 Dec 2022 17:11:35 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2bTL-00FhAH-BB for linux-arm-kernel@lists.infradead.org; Tue, 06 Dec 2022 17:11:12 +0000 Received: by mail-wr1-x433.google.com with SMTP id h7so18422997wrs.6 for ; Tue, 06 Dec 2022 09:11:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+0eEedGwGTs0kfi7RPmjpdf2WkKmieSTXamBFgfWsLQ=; b=dyXoW4R5nzvhrF2ArwJVeg/RNvPFTxGysEkFtaM0+/WmSby6JpBEEzAuzb6dm/IUrO loetYRVTWv84boZgega8by8OHA894AB3cBdImVYzS/zG45qSdtvD+P+IrHwFWTQ9kaNQ dbXYFqDbgEchx56LERT2IZVmK/P54IfFI/v7k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+0eEedGwGTs0kfi7RPmjpdf2WkKmieSTXamBFgfWsLQ=; b=pvmu7wMrJI8U/hMsGyTNjyQ6x3qc3xUR7MzZ81wn+X17rqBr6ossj7UIqUJZoTdL/1 bIczBBTImd2KGJGe6Qv+Ko/+EX/d/zWxpenoD1SKArcPHos2/T7JpWEche+QGPaQhJHH BQ5vx9JJ2lmSjl7jHU9pKs4SZB7Keo/xlT2Ud+SvPrVCMftLyeDljDMgnt1qwtSrPtrq QoCPdfuxmoOrqF/O7PYvAAm2yApnj+IwgeNJp1XULvfQTAZgB6ua/cYSH+Blhufyl472 V/qiKwQYhgYyQa7aV3fglpwLAIGZUxkifngfAT4xGgvGv3geVEnUFRPmxTiaiMV4bAS9 evtg== X-Gm-Message-State: ANoB5pna0dCufA5j4iWn9tIiuB8j0/vBAzVDwQ15D1+c9/uEYDyquA2U 6t/sIYTpSq904fS3tl+CCdvXkA== X-Google-Smtp-Source: AA0mqf5VYzXR0eKaEheU+DSuzIPtiiZXxadgFHz/ASXvN/BUlPG5unQLLOG06Nxd5Dcsf4wUCuWsVA== X-Received: by 2002:a05:6000:18c1:b0:236:5d8c:97fd with SMTP id w1-20020a05600018c100b002365d8c97fdmr54257190wrq.473.1670346667896; Tue, 06 Dec 2022 09:11:07 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.pdxnet.pdxeng.ch (host-82-54-95-136.retail.telecomitalia.it. [82.54.95.136]) by smtp.gmail.com with ESMTPSA id k10-20020a056000004a00b002365730eae8sm17298534wrx.55.2022.12.06.09.11.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Dec 2022 09:11:07 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , Dario Binacchi , Fabio Estevam , Martin Kaiser , NXP Linux Team , Pengutronix Kernel Team , Russell King , Sascha Hauer , Shawn Guo , linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/5] ARM: imx25: add missing of_node_put() Date: Tue, 6 Dec 2022 18:10:45 +0100 Message-Id: <20221206171049.3316611-2-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20221206171049.3316611-1-dario.binacchi@amarulasolutions.com> References: <20221206171049.3316611-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221206_091111_409854_EC0C2C05 X-CRM114-Status: UNSURE ( 9.29 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: In mx25_read_cpu_rev(), of_find_compatible_node() returns a node pointer with refcount incremented. Use of_node_put() on it when done. Fixes: 8b88f7ef31dde ("ARM: mx25: Retrieve IIM base from dt") Signed-off-by: Dario Binacchi --- Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:433 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org In mx25_read_cpu_rev(), of_find_compatible_node() returns a node pointer with refcount incremented. Use of_node_put() on it when done. Fixes: 8b88f7ef31dde ("ARM: mx25: Retrieve IIM base from dt") Signed-off-by: Dario Binacchi --- arch/arm/mach-imx/cpu-imx25.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-imx/cpu-imx25.c b/arch/arm/mach-imx/cpu-imx25.c index 3e63445cde06..cc86977d0a34 100644 --- a/arch/arm/mach-imx/cpu-imx25.c +++ b/arch/arm/mach-imx/cpu-imx25.c @@ -23,6 +23,7 @@ static int mx25_read_cpu_rev(void) np = of_find_compatible_node(NULL, NULL, "fsl,imx25-iim"); iim_base = of_iomap(np, 0); + of_node_put(np); BUG_ON(!iim_base); rev = readl(iim_base + MXC_IIMSREV); iounmap(iim_base); From patchwork Tue Dec 6 17:10:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 1712903 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=paXt+Vej; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.a=rsa-sha256 header.s=google header.b=MkbkbT4e; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NRRm641d5z23yq for ; Wed, 7 Dec 2022 04:11:50 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/v4OQBrMBXqUUTtoxZvpP9II6wqjSrAyWbdrfn30tqc=; b=paXt+Vej6L21HD QiRr1qyUjuRv9zzuRkKGyCSQ11Yh31wO1NNGnXpBUu9P3LvUw1fY/iED8HtePkX3eEOv/ma92ZB7S s0COpO/WBlw+HJRB/+37B9GRA5hbFHH6fPThYlARKlMXBpMQhrbfY+o91sHNDHzP0qs7cep9wkYH0 bIq79qlcJDilsNSqyIcwrIgYPlUkSyU5HXPE937KV/H1xDcycDLDQayZiLn/MKk2pD6rubgFPa47H ERtI/ZDrysa30d/ciSEaNRH/7tXcsE/ZtC1BKvm0O4qEJ1nTlRFHPpQeZPgcxWazgJksmEuNZwDiT CG8e/qBunHhKilWvETnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2bTZ-00FhOi-7A; Tue, 06 Dec 2022 17:11:25 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2bTK-00FhCQ-IR for linux-arm-kernel@lists.infradead.org; Tue, 06 Dec 2022 17:11:11 +0000 Received: by mail-wr1-x435.google.com with SMTP id h7so18423092wrs.6 for ; Tue, 06 Dec 2022 09:11:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YmzucAOYeRO1Za2FBpNv+O/C9sORhwUJDwZR4toHbGw=; b=MkbkbT4elwmyTpFZMWHeouGW8MXnzkaicMClIaoEPhafVK6G/gOdEqkoCthjepgvjI zEqKhpIuaBMlQNFJh2elQbq49ozfBehJl8b7swZPkU8nDYLb2edrIvRhKfoRaWLFoI2I CjpxHQ0b/PEP/AKvsDPjtQ21In0cGNlRH6rBs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YmzucAOYeRO1Za2FBpNv+O/C9sORhwUJDwZR4toHbGw=; b=xUnbF049tYWDWDnf+pT5HD6tGJp/yxJ4JO6x4Hn//4zvdGT+kcZ1aVgV91OTJ2CLBU mDxMd9/7JG7tWnxUVwl+bZcT1hz36qqPVvXDdMR6OFLCP6GiFidzU6sb+pwFvDhiJvNW z/2eA6oHjseHmUaBFxKrD3QxEgCH3D6iqhWnmjMGTkm152ctzBRYXL1wuLDGQ8IFqCNm 4CBDQeCbGp8Ge3QMKB7G8ZGFwRjElJyMtgjYcdDkuiLaDihnHkUFX5a8ErzhnNUEgDEz txfG+WcJZjzZr+o0RbWJf0i8lK055WxCip7f96NoEzmoX2k2bS31FysCe/A/R1PcuV2v 8H2w== X-Gm-Message-State: ANoB5plemdF+j6IT9R02svu3nfWeLEbKBvVLdgR+VGX3+iZwiPlQk0By vMpbXEoxPlO/clqPdM2jzy6ccQ== X-Google-Smtp-Source: AA0mqf4Wm8rkIFD1VSowgEiyUmqd7dnA3qkC4S1F8gLh99B7TegLePQHEbez1bAclFIrsmYtMKkLtA== X-Received: by 2002:adf:ff90:0:b0:242:46f1:1de0 with SMTP id j16-20020adfff90000000b0024246f11de0mr10925436wrr.640.1670346669143; Tue, 06 Dec 2022 09:11:09 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.pdxnet.pdxeng.ch (host-82-54-95-136.retail.telecomitalia.it. [82.54.95.136]) by smtp.gmail.com with ESMTPSA id k10-20020a056000004a00b002365730eae8sm17298534wrx.55.2022.12.06.09.11.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Dec 2022 09:11:08 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , Dario Binacchi , Arnd Bergmann , Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team , Russell King , Sascha Hauer , Shawn Guo , linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/5] ARM: imx27: add missing of_node_put() Date: Tue, 6 Dec 2022 18:10:46 +0100 Message-Id: <20221206171049.3316611-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20221206171049.3316611-1-dario.binacchi@amarulasolutions.com> References: <20221206171049.3316611-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221206_091110_634870_40204CB3 X-CRM114-Status: UNSURE ( 9.76 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: In mx27_read_cpu_rev(), of_find_compatible_node() returns a node pointer with refcount incremented. Use of_node_put() on it when done. Fixes: 94b2bec1b0e05 ("ARM: imx27: Retrieve the SYSCTRL base address from devicetree") Signed-off-by: Dario Binacchi --- Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:435 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org In mx27_read_cpu_rev(), of_find_compatible_node() returns a node pointer with refcount incremented. Use of_node_put() on it when done. Fixes: 94b2bec1b0e05 ("ARM: imx27: Retrieve the SYSCTRL base address from devicetree") Signed-off-by: Dario Binacchi --- arch/arm/mach-imx/cpu-imx27.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-imx/cpu-imx27.c b/arch/arm/mach-imx/cpu-imx27.c index bf70e13bbe9e..1d2893908368 100644 --- a/arch/arm/mach-imx/cpu-imx27.c +++ b/arch/arm/mach-imx/cpu-imx27.c @@ -28,6 +28,7 @@ static int mx27_read_cpu_rev(void) np = of_find_compatible_node(NULL, NULL, "fsl,imx27-ccm"); ccm_base = of_iomap(np, 0); + of_node_put(np); BUG_ON(!ccm_base); /* * now we have access to the IO registers. As we need From patchwork Tue Dec 6 17:10:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 1712905 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=EzOgZVef; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.a=rsa-sha256 header.s=google header.b=liDhJDy7; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NRRmQ0hwWz23yq for ; Wed, 7 Dec 2022 04:12:06 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yitbQJL4J/L0Vp31EflNgB5Ry4XDRc9kOCHSbJzMB54=; b=EzOgZVefT570Uh rZ2rPcJVwmewZBOc57C2TWTolqaaNMA7ALj7uHdFdPIbBNIyizaWBfVVrMDr6wcBpEmBJH4pIzEwL xwdV3Pq0CkLk6re/D+FZL5IK1AE3yOCICFYeY+JQLjTHcDHy7zaCwVxQHORtu+FtJ5i2RLDNzEGC7 ZAoBuACE/q08E1t8GKk88pmpAQ4hrLv/Iz69VHVI8OEAZHR5+EY6APgo9l1uW5O9X73z1rVteJufI GmZrIyTGhmUWhNuYKvduwy/ASo/bqowMEPuOvWeyGzYsEaLT8jVa8lS6epTU5HRLbi3szIVdHtSDO 3JYcYL75fVPV/EEf2YVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2bTw-00Fhe2-29; Tue, 06 Dec 2022 17:11:48 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2bTN-00FhD0-Ua for linux-arm-kernel@lists.infradead.org; Tue, 06 Dec 2022 17:11:15 +0000 Received: by mail-wr1-x436.google.com with SMTP id h11so24371043wrw.13 for ; Tue, 06 Dec 2022 09:11:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5v14ZTzRH5HsyEn9mY20Ymo8gJAzpokyO92zkSj5WYg=; b=liDhJDy7GxeAOMF/LzJSmXP1wdT5+iq4LBiLncSq2Xj1dmUStASD9aScVhhvdFuL6R G2a1AUzuGUMecb/sYwv1ZH8DqCqE4SSC+cDIHK0cBPBceWOPkZR4Zvvr+v3gluXm0+EI Dt2bJ/n4s6zWupvA7VQFg3g0hGhiyLmALr5U8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5v14ZTzRH5HsyEn9mY20Ymo8gJAzpokyO92zkSj5WYg=; b=xvvqIgMSVXGixSOENMlD/l0WvEssnCgbXnp//FvNFjPr4fSeW4XXg1VPVNtw+gD1Nw lVvGu3w1nIkIx3WmO4Aa3HMjcV0O3hYoAvJlZqUH/Jrhs7WYhxWvS+P5zbPNBlC2LD4z 9S+ran5bPwVIUApS2x8BJoZboc8fc8H18BKc4GeXmdTC2EKp8LU7Hy2gTa4G0rLUTnh/ 3Yt/XU9Q+zi23MARl99EdkVjA2ZTf+S3MIEz1F5SiZmQk8RnExXe+9mQeMP/tH4apKQJ vMZ/H2m1eI1gWvMQalWaMYc//NX7lBfl5vLvQ88CiaQnUBGmpqwB7mSnxAS/onPWRgbn 2sfg== X-Gm-Message-State: ANoB5pkZFKoXfKE9L2E49pUsc7KjWBH8JxjS9K41jUZ8NLwbtynV62ri kXPrJ9ro9xss1NzMGw6wsgo/BA== X-Google-Smtp-Source: AA0mqf5rVnGYyi6nQo2ffozLqpG/dpJo+1+F9RpCIVSPq3Ms5qsq2nMwoa4dGTdeTh9jFtNJ7uqSeA== X-Received: by 2002:adf:e98f:0:b0:242:7f7f:da0a with SMTP id h15-20020adfe98f000000b002427f7fda0amr426399wrm.168.1670346670455; Tue, 06 Dec 2022 09:11:10 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.pdxnet.pdxeng.ch (host-82-54-95-136.retail.telecomitalia.it. [82.54.95.136]) by smtp.gmail.com with ESMTPSA id k10-20020a056000004a00b002365730eae8sm17298534wrx.55.2022.12.06.09.11.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Dec 2022 09:11:10 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , Dario Binacchi , Arnd Bergmann , Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team , Russell King , Sascha Hauer , Shawn Guo , linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/5] ARM: imx31: add missing of_node_put() Date: Tue, 6 Dec 2022 18:10:47 +0100 Message-Id: <20221206171049.3316611-4-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20221206171049.3316611-1-dario.binacchi@amarulasolutions.com> References: <20221206171049.3316611-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221206_091114_007710_54A0E20D X-CRM114-Status: GOOD ( 10.00 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: In mx31_read_cpu_rev(), of_find_compatible_node() returns a node pointer with refcount incremented. Use of_node_put() on it when done. Fixes: 3172225d45bd9 ("ARM: imx31: Retrieve the IIM base address from devicetree") Signed-off-by: Dario Binacchi --- Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:436 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org In mx31_read_cpu_rev(), of_find_compatible_node() returns a node pointer with refcount incremented. Use of_node_put() on it when done. Fixes: 3172225d45bd9 ("ARM: imx31: Retrieve the IIM base address from devicetree") Signed-off-by: Dario Binacchi --- arch/arm/mach-imx/cpu-imx31.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-imx/cpu-imx31.c b/arch/arm/mach-imx/cpu-imx31.c index b9c24b851d1a..35c544924e50 100644 --- a/arch/arm/mach-imx/cpu-imx31.c +++ b/arch/arm/mach-imx/cpu-imx31.c @@ -39,6 +39,7 @@ static int mx31_read_cpu_rev(void) np = of_find_compatible_node(NULL, NULL, "fsl,imx31-iim"); iim_base = of_iomap(np, 0); + of_node_put(np); BUG_ON(!iim_base); /* read SREV register from IIM module */ From patchwork Tue Dec 6 17:10:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 1712906 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=sKI9SIMw; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.a=rsa-sha256 header.s=google header.b=jBQD+O7X; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NRRmj1RVlz23yq for ; Wed, 7 Dec 2022 04:12:21 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JJZk+BZqZ+Am1BVrBALPINDUJsTHiunNeuJOLqcUFoM=; b=sKI9SIMwZfu4UM aEE93aGHRUpSVtSBm+pmx5/LHOnQFPGI5p916lN4b0e5e97PMGliMyrX3KDYnifeZZCPPvYZMXyff 3WkalP9ZL5mUKSoG47mWKhuQZcZ1CxBECY0vOUoBsfMHYrFsb7PJiI9+wwaMk8fSmwuIkO/q7FcXH VqKf8Y0RosFdCmDPN/NmUy+KoHLMfNT2AZ4Cuig/AKq2wwSLXko5Bh9QvBKkzo0dPOWNYe5BPWBDF kCSAw+66XwUSdVh8IKUsWtPwz5Zg7Xh5+oEhTOGxfU8sj0XntI3JzJIPhjWQwS3gfVts0tWhzglhR iHbuVj0401oEwboQkupw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2bUB-00Fhoi-EG; Tue, 06 Dec 2022 17:12:03 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2bTP-00FhDb-DB for linux-arm-kernel@lists.infradead.org; Tue, 06 Dec 2022 17:11:16 +0000 Received: by mail-wr1-x42a.google.com with SMTP id y16so24445907wrm.2 for ; Tue, 06 Dec 2022 09:11:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JTKzSC4xiELtOhvYcPg625CE+pmvLexXVke2DqyU21Q=; b=jBQD+O7XNs5SbP+46Ou8Fyj8CECu5cE2sdTpHJmBujn+wNPZOhaoLoKc0GCA9Gwq+G 1W76vEZ8MT1Ki6hKHJmSamfFN23/9WUPMg3FLo5RE+CBZw8/MKoEOrQcCBc6raTMcr6m awNNnOPDL1KREISMcuOhPUhoWkJRWzRXpKnqw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JTKzSC4xiELtOhvYcPg625CE+pmvLexXVke2DqyU21Q=; b=OcVn5U0YjxzfHmjvEpzfWRuyKLMmyZx3jpwYT/bMq3GaqW6TXE3GEfsfeijz9AL7HG NO2BtJZWfqbEzOinlALC/f3BY5mDKcV8kIlU9YwVgd0TaVR7UKA1qzQOdrqoC6HL5Dz2 vjTR4AolvQW694gKxDxlT90NTgDAiOjdIyOxWjRJQO6ZnHGHjLK9FVAZ1w6WC6NWdEyC kEObDtiivpyIruFFsHp3C5PnweBoyukUjHK6W9IN22vzwNpVYpAYSVquBFs3UCuTnuM5 hB1/ZNe4GYO6wbOYgvQrMHuiACJGIY9HNkGfQqvoIqiDAPUE7PyYnAHkT08ANuoTConI DoYQ== X-Gm-Message-State: ANoB5plnnKyJs2guheRCsseHmjD92iQkxvihgumsVzxve0XUFmyEOU2L L4Jg/IXltGKb4uO9on5JX025kw== X-Google-Smtp-Source: AA0mqf46qOghPsTK5SHdLa1G/B2hktQOKTAgXMfUJJ8bJ8Lem5+VEr3rDWh1zK2Rir3AyuSd6Vrewg== X-Received: by 2002:adf:f54e:0:b0:242:1534:7b57 with SMTP id j14-20020adff54e000000b0024215347b57mr26622429wrp.404.1670346671934; Tue, 06 Dec 2022 09:11:11 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.pdxnet.pdxeng.ch (host-82-54-95-136.retail.telecomitalia.it. [82.54.95.136]) by smtp.gmail.com with ESMTPSA id k10-20020a056000004a00b002365730eae8sm17298534wrx.55.2022.12.06.09.11.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Dec 2022 09:11:11 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , Dario Binacchi , Arnd Bergmann , Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team , Russell King , Sascha Hauer , Shawn Guo , linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/5] ARM: imx35: add missing of_node_put() Date: Tue, 6 Dec 2022 18:10:48 +0100 Message-Id: <20221206171049.3316611-5-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20221206171049.3316611-1-dario.binacchi@amarulasolutions.com> References: <20221206171049.3316611-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221206_091115_485660_DC738EE8 X-CRM114-Status: UNSURE ( 9.88 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: In mx35_read_cpu_rev(), of_find_compatible_node() returns a node pointer with refcount incremented. Use of_node_put() on it when done. Fixes: f68ea682d1da7 ("ARM: imx35: Retrieve the IIM base address from devicetree") Signed-off-by: Dario Binacchi --- Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:42a listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org In mx35_read_cpu_rev(), of_find_compatible_node() returns a node pointer with refcount incremented. Use of_node_put() on it when done. Fixes: f68ea682d1da7 ("ARM: imx35: Retrieve the IIM base address from devicetree") Signed-off-by: Dario Binacchi --- arch/arm/mach-imx/cpu-imx35.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-imx/cpu-imx35.c b/arch/arm/mach-imx/cpu-imx35.c index 80e7d8ab9f1b..1fe75b39c2d9 100644 --- a/arch/arm/mach-imx/cpu-imx35.c +++ b/arch/arm/mach-imx/cpu-imx35.c @@ -21,6 +21,7 @@ static int mx35_read_cpu_rev(void) np = of_find_compatible_node(NULL, NULL, "fsl,imx35-iim"); iim_base = of_iomap(np, 0); + of_node_put(np); BUG_ON(!iim_base); rev = imx_readl(iim_base + MXC_IIMSREV); From patchwork Tue Dec 6 17:10:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 1712907 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=3bS4vCt/; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.a=rsa-sha256 header.s=google header.b=dEPxQkXm; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NRRn140xKz23yq for ; Wed, 7 Dec 2022 04:12:37 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ddw9x2CprXc2zCV2x1nlxdPnUWmIq18M7PxgEVhA7dc=; b=3bS4vCt/MjCnaK LbKH901EUnfM4jBYgSLKShfnCnCkwcw1Qpnt97acthzQiV1WsXslifJCvW9k9db+O/PGHyW4KMomZ LgDZXE5g06GmAJjUOXNWGd7PnfVIkMUgFj/xqUX0f28nE3U9qZHFmxcFHUySTdWP0YqFRUI0fUvaF uLNuF8y5o95YZD3XfWN6Nr+gn3vhjx7DO1wO7WB7uw4IJk3H7rZ//EosYgYCcOfC/+AwKASA9PnQL 7CJfzIRfw6AUK1+dpYzel+BE8T64P0HdUCbbxfxCTtu2jf9p62f/L8wuHHUxbJnRR10IC2csYowtJ wjIqGzwuJsGdSPmZx3mg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2bUT-00Fi2i-Jl; Tue, 06 Dec 2022 17:12:21 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2bTQ-00FhE5-PV for linux-arm-kernel@lists.infradead.org; Tue, 06 Dec 2022 17:11:18 +0000 Received: by mail-wr1-x42c.google.com with SMTP id d1so24400396wrs.12 for ; Tue, 06 Dec 2022 09:11:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=isZl4Ib1GW4IZeJsKLQaicOT0yx6KllCfAA6o2HK4Yo=; b=dEPxQkXmaa3Wz4HA8Yfy4fjbqIBuD8Ml8aDTOT+KBrwUbxD+kTSbbJTMFiCypHQQy0 EdWFSrsW0nLMoZS9mdzEuuPi3t0rCF2jSEWf661q7y6nP9OosPtcKIxPFfr2X2iiPdMZ isoMpp4rHtsiKXLJ7En2CQMGDu3H0HQlGE5as= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=isZl4Ib1GW4IZeJsKLQaicOT0yx6KllCfAA6o2HK4Yo=; b=NST7DWCVW+xnX0whjdS4+Km1dNzSJAFHybBpxwkzVX1Fz7rnmWT7yM1JLNUXvUNhph EAKBG8fgyhHRC09kkrj9DkFttdIAdQdXidw95840BlaEecH1cQwqJriUyMHzpa2VeBHw Dx09lslCSaaxEf4RRet5eh/UTPAOAwZbCsodOX5lOe62Jhr/xnfg0Z+wDKvjEw7p0CDu LJqOAtUquVHd8fmo5EVVaFO+eb6UyPXbzl3oI9NU4WzyR3N5RQzCa0bUVsXg2cr/wQIv 2TrXtp+iZDZ2SS6RcNpSpm+4JTm58tjXs57siJ8uDvyViIhC+qunp2bl5lNlmrGt5fNC +Rpg== X-Gm-Message-State: ANoB5pm5A19YyNCe/n9atyoSrIIML5JqtYF4TdjM0dgket9yOVpsGIwT uC+aXw8S5tPI7I5TeZunANH3Kw== X-Google-Smtp-Source: AA0mqf5HkhTdPQ7nLSvemacCYX845ggXLdSFFWJJy2A++pl3KnIlWOQwnMoPoDxTURKlIWKDNu6RrQ== X-Received: by 2002:adf:d1ca:0:b0:242:fce:543b with SMTP id b10-20020adfd1ca000000b002420fce543bmr28536302wrd.244.1670346673302; Tue, 06 Dec 2022 09:11:13 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.pdxnet.pdxeng.ch (host-82-54-95-136.retail.telecomitalia.it. [82.54.95.136]) by smtp.gmail.com with ESMTPSA id k10-20020a056000004a00b002365730eae8sm17298534wrx.55.2022.12.06.09.11.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Dec 2022 09:11:13 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , Dario Binacchi , Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team , Russell King , Sascha Hauer , Shawn Guo , linux-arm-kernel@lists.infradead.org Subject: [PATCH 5/5] ARM: imx5: add missing of_node_put() Date: Tue, 6 Dec 2022 18:10:49 +0100 Message-Id: <20221206171049.3316611-6-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20221206171049.3316611-1-dario.binacchi@amarulasolutions.com> References: <20221206171049.3316611-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221206_091116_871189_0863748C X-CRM114-Status: UNSURE ( 9.03 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: In imx5_read_srev_reg(), of_find_compatible_node() returns a node pointer with refcount incremented. Use of_node_put() on it when done. Fixes: ee18a7154ee08 ("ARM: imx5: retrieve iim base from device tree") Signed-off-by: Dario Binacchi Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:42c listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org In imx5_read_srev_reg(), of_find_compatible_node() returns a node pointer with refcount incremented. Use of_node_put() on it when done. Fixes: ee18a7154ee08 ("ARM: imx5: retrieve iim base from device tree") Signed-off-by: Dario Binacchi --- arch/arm/mach-imx/cpu-imx5.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-imx/cpu-imx5.c b/arch/arm/mach-imx/cpu-imx5.c index ad56263778f9..a67c89bf155d 100644 --- a/arch/arm/mach-imx/cpu-imx5.c +++ b/arch/arm/mach-imx/cpu-imx5.c @@ -28,6 +28,7 @@ static u32 imx5_read_srev_reg(const char *compat) np = of_find_compatible_node(NULL, NULL, compat); iim_base = of_iomap(np, 0); + of_node_put(np); WARN_ON(!iim_base); srev = readl(iim_base + IIM_SREV) & 0xff;