From patchwork Mon Dec 5 20:49:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Ruth X-Patchwork-Id: 1712460 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=1y9x3ew8; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=FE0XTyRD; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NQwfK53srz23p1 for ; Tue, 6 Dec 2022 07:50:01 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=p2P4vl2GUEWHEvBMGysuNqg74LVEQORJ6uz9rNpVvnQ=; b=1y9x3ew8e6E8y/ ss/jmJl4weNjtgm+9FEX5rd8rp0AH9fFLhsYPhqqJIW+tov29TKkGQ0ZWYbKcKE3TRqtOHRKMUEf4 7A5EckfDf1lSTdK244ZTGVJ8uM4kIWeoF+tIt+u3eRuKh2kc/PGev43fcknTVI3a9+MD5q7lEJ6QV GVRM43YFeKva53/tgj++rHossk9DLfHCLEjWJSDDMYi7+UcCF2iFffR0Y+MZQSdSLDGEbrcwQQkkc iJM7SO5obFehrc3So7Tn+lJhJayd8TB0ijHZwxJghRgtiC1Mh2PYUwZPRBVu487PMAY+a8xRUsE5I oJ9qg7VcCRWSykEkvsmQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2IOk-00AT7A-Rc; Mon, 05 Dec 2022 20:49:10 +0000 Received: from mail-qk1-x72a.google.com ([2607:f8b0:4864:20::72a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2IOh-00AT5R-Oz for hostap@lists.infradead.org; Mon, 05 Dec 2022 20:49:09 +0000 Received: by mail-qk1-x72a.google.com with SMTP id k2so5997357qkk.7 for ; Mon, 05 Dec 2022 12:49:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=D3v/VpBmQF/0mTuPHyxYEZ7kkEL63TGjN4Jx9+63cmc=; b=FE0XTyRDQdL/eriNkldWAYyP3M3l0cN/61qHmG/ITCZnIvf5XCwLU5+opiA8fVvf04 CElEdJNrxjaVlXziPNT9wB7oKpURnMWUt07gupsNGKVunSmVgmwCvxFbTu+/Kv4ZxgMS qnxNCcbQ5xg3shQfnH68Ft2+hcSL4i3YdRvVo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=D3v/VpBmQF/0mTuPHyxYEZ7kkEL63TGjN4Jx9+63cmc=; b=O04dDQRzPn4hyOVbeisJxAcHNtI1fbzgpOTT6590KG5pQhOxwY7wbdOX87WrKBSVa0 6Tsldz+yTT53n1gj8F78LyP0y6LnzNj5Gz0jCzybbAiKeUE1PKB08hqmH7+LQZUFnOVh TgDOtY5WnKmpim93Fq2BPcWuxJ+A2OR/0EhnCqe3/OjFqt8CohnQaKn+sDT5nP0kzUb4 hX9p1vPHoVYySgEgp35O4vVPkWQm0RSoqNJ+0C+jcBg5VIJe4MPxwoYLDjc3k4OioemF zJ+/hkUB2/3FizhQe9yq3fvosFszWPM3JKl9G9GcRTvo07lXjAb9IdZD+lTMI/5OulKd xb/g== X-Gm-Message-State: ANoB5pl9JE/3ieAHglfKWZtl0E/8hrY9ufpmKDkqASwRfm4rAkEVZBzI nJjrTgan7F7QGMGMnk5TC9RtTe0o1uWoljwf X-Google-Smtp-Source: AA0mqf52INjyj9qZieTqmvJY+kw0Huw1L7/QhOuhHeUkNnJO3VM0V6K8G9Bvlxu6uSkFpBG+gndaNA== X-Received: by 2002:a05:620a:1014:b0:6fa:6c8c:c8e6 with SMTP id z20-20020a05620a101400b006fa6c8cc8e6mr73999682qkj.120.1670273344696; Mon, 05 Dec 2022 12:49:04 -0800 (PST) Received: from localhost (228.221.150.34.bc.googleusercontent.com. [34.150.221.228]) by smtp.gmail.com with UTF8SMTPSA id w7-20020ac843c7000000b003a7e2aea23esm3071581qtn.86.2022.12.05.12.49.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Dec 2022 12:49:04 -0800 (PST) From: David Ruth To: hostap Cc: David Ruth Subject: [PATCH] Actually get and store TX Retries. Date: Mon, 5 Dec 2022 20:49:00 +0000 Message-Id: <20221205204900.601856-1-druth@chromium.org> X-Mailer: git-send-email 2.39.0.rc0.267.gcb52ba06e7-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221205_124907_898110_7F8C7C28 X-CRM114-Status: GOOD ( 11.05 ) X-Spam-Score: -0.4 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Fix an issue from commit ad4fa5dd3cf1168676715dcd2dea0c2c9b258d23 that results in TX Failures being stored where TX Retries belongs. Signed-off-by: David Ruth --- Content analysis details: (-0.4 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:72a listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.2 DKIMWL_WL_HIGH DKIMwl.org - High trust sender X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Fix an issue from commit ad4fa5dd3cf1168676715dcd2dea0c2c9b258d23 that results in TX Failures being stored where TX Retries belongs. Signed-off-by: David Ruth --- src/drivers/driver_nl80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c index c04b71bbe..1b76fcc4f 100644 --- a/src/drivers/driver_nl80211.c +++ b/src/drivers/driver_nl80211.c @@ -7432,7 +7432,7 @@ static int get_sta_handler(struct nl_msg *msg, void *arg) nla_get_u32(stats[NL80211_STA_INFO_TX_PACKETS]); if (stats[NL80211_STA_INFO_TX_RETRIES]) data->tx_retry_count = - nla_get_u32(stats[NL80211_STA_INFO_TX_FAILED]); + nla_get_u32(stats[NL80211_STA_INFO_TX_RETRIES]); if (stats[NL80211_STA_INFO_TX_FAILED]) data->tx_retry_failed = nla_get_u32(stats[NL80211_STA_INFO_TX_FAILED]);