From patchwork Wed Nov 30 12:34:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcin Szycik X-Patchwork-Id: 1710466 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256 header.s=default header.b=WznxUlUg; dkim-atps=neutral Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NMdw22DQ4z23nv for ; Wed, 30 Nov 2022 23:35:29 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 2666841578; Wed, 30 Nov 2022 12:35:27 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 2666841578 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1669811727; bh=wlutla7pQSTS56X5HS7zjNxTXUBubc5khXArUgyL98M=; h=From:To:Date:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:Cc:From; b=WznxUlUgYVV/E67Jx2eUxRekdxoz1Cicl5QtSJBCR1iczQO4gWxo776kSvKbQpWCG vnZDveiYtpOqfkFaNf+t02dsBS0y/IxIHOkf3lmuIfHxfFOcnUdcL38GI62PCYZ9D/ Pr2SMd+0QjGkL1MEkNperYzfNGJU0j5m3s+/rUVqeW+XUxSPHjPUgj9lcui7C+kKA5 LGkn2YcMSvMQokOGsddGLiG5e2DC4N5e/7W++akmMl+G8M44RGLn/7Nk/AxrWVNuWK he10tIoMU/AWb23o3leK/IUcpmoDKxhQY08YNgArH8zmJE16amSb019er15MH56toB E6iiOXVIj+thQ== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7QOh3PPodPwg; Wed, 30 Nov 2022 12:35:26 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id EF1B5415BF; Wed, 30 Nov 2022 12:35:25 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org EF1B5415BF X-Original-To: intel-wired-lan@lists.osuosl.org Delivered-To: intel-wired-lan@lists.osuosl.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 4E05C1BF3E3 for ; Wed, 30 Nov 2022 12:35:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 27FC240377 for ; Wed, 30 Nov 2022 12:35:24 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 27FC240377 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bl7hn8PiQwv3 for ; Wed, 30 Nov 2022 12:35:23 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 4486140121 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by smtp2.osuosl.org (Postfix) with ESMTPS id 4486140121 for ; Wed, 30 Nov 2022 12:35:23 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6500,9779,10546"; a="295080564" X-IronPort-AV: E=Sophos;i="5.96,206,1665471600"; d="scan'208";a="295080564" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2022 04:35:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10546"; a="707631238" X-IronPort-AV: E=Sophos;i="5.96,206,1665471600"; d="scan'208";a="707631238" Received: from irvmail001.ir.intel.com ([10.43.11.63]) by fmsmga008.fm.intel.com with ESMTP; 30 Nov 2022 04:35:20 -0800 Received: from rozewie.igk.intel.com (rozewie.igk.intel.com [10.211.8.69]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id 2AUCZIEK027695; Wed, 30 Nov 2022 12:35:18 GMT From: Marcin Szycik To: intel-wired-lan@lists.osuosl.org Date: Wed, 30 Nov 2022 13:34:14 +0100 Message-Id: <20221130123414.892879-1-marcin.szycik@linux.intel.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669811723; x=1701347723; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=btLG74tAby/hcJpBjoOqrJGVzSJlq5cHTtvHnTda1jE=; b=OGG4UKaxCvb3wUFCtC9sRzYZcOeWClvlcnOGC/t+Mi6dQmD39g2bxa3u UWrNBL0zDYn9cDfK0jXA8Q6BFaP5kcBG6SpxPsZtJgwEDR+TwjQmhZnsD kU73mqNwm6uZtuEZzeGrHE9Vsaks+Rm3OOVXg+rR5pS1Z2EnSmHdJvJMf KsqIk1Tc8298PpTQSjgxCezaRtuF5EYYSlgy/Wwm2+cLQwKIW0bnxTW5a /4YV5QS/5FUtuOVzSzbH0tKXTAkk55kGEZt8Thw18UFnb8XV/U4SmLbS9 Kxyo1yDNy7myVucFyOQBArQeD0+kOrlXpMuKtkzjmL0SJqYnfmj601nMt g==; X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=OGG4UKax Subject: [Intel-wired-lan] [PATCH net-next] ice: Do not use WQ_MEM_RECLAIM flag for workqueue X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mustafa.ismail@intel.com, shiraz.saleem@intel.com Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" When both ice and the irdma driver are loaded, a warning in check_flush_dependency is being triggered. This seems to be because of the ice driver workqueue is allocated with the WQ_MEM_RECLAIM flag, and the irdma one is not. Looking at the kernel documentation, it doesn't seem like the ice driver needs to use WQ_MEM_RECLAIM. Remove it. Signed-off-by: Anirudh Venkataramanan Signed-off-by: Marcin Szycik --- drivers/net/ethernet/intel/ice/ice_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c index 69984fea7fce..d01d1073ffec 100644 --- a/drivers/net/ethernet/intel/ice/ice_main.c +++ b/drivers/net/ethernet/intel/ice/ice_main.c @@ -5617,7 +5617,7 @@ static int __init ice_module_init(void) pr_info("%s\n", ice_driver_string); pr_info("%s\n", ice_copyright); - ice_wq = alloc_workqueue("%s", WQ_MEM_RECLAIM, 0, KBUILD_MODNAME); + ice_wq = alloc_workqueue("%s", 0, 0, KBUILD_MODNAME); if (!ice_wq) { pr_err("Failed to create workqueue\n"); return -ENOMEM;