From patchwork Tue Nov 22 05:18:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ashok Reddy Soma X-Patchwork-Id: 1707641 X-Patchwork-Delegate: monstr@monstr.eu Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=ZBtaCD7l; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NGXcZ3GTTz23nR for ; Tue, 22 Nov 2022 16:19:26 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 82F4A8544F; Tue, 22 Nov 2022 06:19:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="ZBtaCD7l"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2AE1A852E7; Tue, 22 Nov 2022 06:19:22 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=0.9 required=5.0 tests=AC_FROM_MANY_DOTS,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS, SPF_PASS autolearn=no autolearn_force=no version=3.4.2 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on20630.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe5a::630]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7FBA08548C for ; Tue, 22 Nov 2022 06:19:19 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=ashok.reddy.soma@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jo2Ygt5fFDkuAjKJ+pfh7m3SgOHdBuICTvC8NXjwcDDAvoqg11OcVgqyAJdOiLVXRwf6tsL/FuQIrCETVcn7npYDFSp8SzAI4/4j/HTLAS2jcBndwRpo8km3mfihIhL/A6qzz10dFI/KJiOthRFJQXn6DEj8kVrap85M/Ge79MrBRshYzUMyYqgjqo80mFpZBC9R7QxT9YYHMTIa+uueunUi39UsW0B4xbCNQM9I2lJIx4e1hetc6OCiBXeVbYLYmNUq4+LYUV1m4qOW5e2N5oBFT4EqjoVF7lAIl1e3eQBUmtLYqEuKAPNRO4rIO0a9XYCjj7oY/stzEBBNwEWJnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RD92txvGzE+JX/UCjoyaKOBG6SsAVlHiL4gJbwuewW0=; b=EavPTgQ3PPSu5aGpinnLEQLry7FvDdO5xa6/ZVyp11eFFuqNXJg0wz+aZMKnu9K1RN10R6dJJxTwczOasv6GZQd8A+GmVI1KlA5+vcbV+lMx5Tyb6Tc1GSZCKtReeke1NHpvAYNaJQijHZ8B/b/m+W9tS+fdu7FbHYrJsVGTACNChhlEoIcEOYdWNI4SvItVukIdpltVJK4LaIa2Z+v+VaDPantofkFEcnWGeH57NytwGoLg1U34pIHBVu2dMBtZhOokiXroCy9ikj7GSuc5Hbn6kObTzydp+V7MFg6k5/tCj3JZHdwKZoP3tEyJi4hrIWUUGtAaXtIMx/YYKXAckg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.denx.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RD92txvGzE+JX/UCjoyaKOBG6SsAVlHiL4gJbwuewW0=; b=ZBtaCD7lS5On8GtYxLlDG2AbeiC+UrIzniMQ6IMZbd8cVIPL1jqVRtFZuVtEyNOy8dET8Dashk2E5Jx/j4P8glYNXPKB/iZ1FzlkqyxkTfln6NUbUKJb1+28OJLPwQNLb1SNtgHlYV1ptIG5hxGDDfa30fza+Bxo17R6fohDlSg= Received: from BN9PR03CA0138.namprd03.prod.outlook.com (2603:10b6:408:fe::23) by BY5PR12MB4065.namprd12.prod.outlook.com (2603:10b6:a03:202::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Tue, 22 Nov 2022 05:19:15 +0000 Received: from BN8NAM11FT031.eop-nam11.prod.protection.outlook.com (2603:10b6:408:fe:cafe::94) by BN9PR03CA0138.outlook.office365.com (2603:10b6:408:fe::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15 via Frontend Transport; Tue, 22 Nov 2022 05:19:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT031.mail.protection.outlook.com (10.13.177.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Tue, 22 Nov 2022 05:19:14 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 21 Nov 2022 23:19:13 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 21 Nov 2022 23:18:44 -0600 Received: from xhdashokred41.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34 via Frontend Transport; Mon, 21 Nov 2022 23:18:41 -0600 From: Ashok Reddy Soma To: CC: , , , , , , "Algapally Santosh Sagar" , Ashok Reddy Soma Subject: [PATCH] mtd: spi-nor-core: Invert logic to reflect sst26 flash unlocked Date: Mon, 21 Nov 2022 22:18:33 -0700 Message-ID: <20221122051833.13306-1-ashok.reddy.soma@amd.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT031:EE_|BY5PR12MB4065:EE_ X-MS-Office365-Filtering-Correlation-Id: 834471d9-2818-48a8-7805-08dacc49187d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ckg6aEnlwxuPTA53PyLCz6Ppui3seVoz5MwCBBHoLfoIAgK+4UqoNL8bcky8BWHHa7+fsHHxxgRh7YUypnXy3Tl8vEbRJNeXgzYXk90oWeRH36pxE+UKiAcWOA6BLm0Jw6HCRkiy8KQJBIgbURPkFAwuSAoyh6Q6Dnsgv1McrNB9/dbLivH32+7BY9Zf6yx8fQh2pAORXSzf2WctKaLTreqy5cT7b5u/gMyPMvKTsUZ403/k18/XYdypJYgtb8u4qTRt1c/KYI2bZcDh44T+ENtTKkWK3/oS7FgqPCdLBNQLsSiZFALnwZaqztmu4jLwV1WuRgnxAuRuRKWbCC/NQCt0Cl80+QtmseKgl4ngQghZBq3rORsDqRCT2enx3TH8aDJ9v8Id+wJ3BzRCaMDav0Gjj5D8+4RRE6vRC7lbf9b4FrTxW+kWTvIoycUNINavI5Y7FXbJ3f2gJWJgld9VpUn9b3+8H2RXU9bddPmMm/PQR9TzPNvR5wQpfDPDJE+vZ8C4XE/zQfTaG6UCJgipKry4VFBGKCzGrJ/22AVMMKJhxepE9Eh2uJQ881eJ4rCmbAc4KhDF4WuYBJy4uG2IvyKf0z10uiaT8KDsd3/BfSaDXybOkdtbb0fvw1IQuVrwAQRK7LaHsrs47njBMBxThsgPuXgqKJX5QodzUhD8AywehURzO1J6kszHjk0mMdVYELej6ekkb3srm6gQ52Cpgz8oQA1InVre+rt2NcNoBjM= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB03.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(376002)(346002)(396003)(136003)(451199015)(46966006)(40470700004)(36840700001)(86362001)(36860700001)(82740400003)(83380400001)(47076005)(426003)(41300700001)(2906002)(81166007)(6916009)(40460700003)(8936002)(82310400005)(40480700001)(5660300002)(478600001)(1076003)(6666004)(2616005)(4326008)(336012)(316002)(8676002)(54906003)(26005)(186003)(356005)(70206006)(70586007)(36756003)(103116003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 05:19:14.1432 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 834471d9-2818-48a8-7805-08dacc49187d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT031.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4065 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean From: Algapally Santosh Sagar flash_is_locked is changed to flash_is_unlocked with commit 513c6071ce73 ("mtd: spi: Convert is_locked callback to is_unlocked"). sst26_is_locked() is also changed to sst26_is_unlocked() but the logic remained same. Invert the logic for the flash lock/unlock to work properly. Signed-off-by: Algapally Santosh Sagar Signed-off-by: Ashok Reddy Soma Reviewed-by: Dhruva Gole Reviewed-by: Jan Kiszka --- drivers/mtd/spi/spi-nor-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/spi/spi-nor-core.c b/drivers/mtd/spi/spi-nor-core.c index 78de3c5281..1ea8363d9f 100644 --- a/drivers/mtd/spi/spi-nor-core.c +++ b/drivers/mtd/spi/spi-nor-core.c @@ -1600,7 +1600,7 @@ static int sst26_is_unlocked(struct spi_nor *nor, loff_t ofs, uint64_t len) ofs -= ofs & (SZ_64K - 1); len = len & (SZ_64K - 1) ? (len & ~(SZ_64K - 1)) + SZ_64K : len; - return sst26_lock_ctl(nor, ofs, len, SST26_CTL_CHECK); + return !sst26_lock_ctl(nor, ofs, len, SST26_CTL_CHECK); } static int sst_write_byteprogram(struct spi_nor *nor, loff_t to, size_t len,