From patchwork Thu Mar 8 06:12:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Manlunas, Felix" X-Patchwork-Id: 882970 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=cavium.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com header.i=@CAVIUMNETWORKS.onmicrosoft.com header.b="WKXDz3Ku"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zxgCy3n6qz9s35 for ; Thu, 8 Mar 2018 17:12:46 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935431AbeCHGMo (ORCPT ); Thu, 8 Mar 2018 01:12:44 -0500 Received: from mail-co1nam03on0080.outbound.protection.outlook.com ([104.47.40.80]:51735 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935225AbeCHGMm (ORCPT ); Thu, 8 Mar 2018 01:12:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=whJ3KBSkJwFT/hKgwU0OQsA0tOXXK6Ct5eD+cRHEEYE=; b=WKXDz3KuYNF3myFtAChjmEgbYNd6sU2k1brvZQhDGxr6dOfmx2ZTazrbGkFuRmzrAPaiew/10niYn9Gz75mCpA7j1e+AridDVFX1rQev4xLVqooJ7jt48oqeWsZGzVGyCmqou8/o/cec4NllOMVCvDL+2n5mZJYKncBS2jnkGWM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Felix.Manlunas@cavium.com; Received: from localhost (50.233.148.156) by DM6PR07MB4220.namprd07.prod.outlook.com (2603:10b6:5:bd::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.13; Thu, 8 Mar 2018 06:12:39 +0000 Date: Wed, 7 Mar 2018 22:12:24 -0800 From: Felix Manlunas To: davem@davemloft.net Cc: netdev@vger.kernel.org, raghu.vatsavayi@cavium.com, derek.chickles@cavium.com, satananda.burla@cavium.com, intiyaz.basha@cavium.com, felix.manlunas@cavium.com Subject: [PATCH net-next] liquidio: Resolved mbox read issue while reading more than one 64bit data Message-ID: <20180308061224.GA5299@felix-thinkpad.cavium.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [50.233.148.156] X-ClientProxiedBy: SC1P215CA0048.LAMP215.PROD.OUTLOOK.COM (2603:10d6:4:41::34) To DM6PR07MB4220.namprd07.prod.outlook.com (2603:10b6:5:bd::29) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f5d513eb-148e-4d75-3063-08d584bb9921 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DM6PR07MB4220; X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4220; 3:rNQObmjb8V3L5rI8oieA5z1iSQPsOufO7NObeOEhUdCnjvTrxIlGd5iWkJHKw45q1HrCMXhm8IJaPzmY6mUaU3feIGSdhi3P5x9ULEpvihAJz8/WXWcGBVeAo7iId3LDraKULOfK3ASjZqEK/A97STPyb/nc2qOsgwjakfJ+D8fxA0QbVGDc7cMxNhgT+mHkBB0eyLA+xtFtLtkNkyiceQr6AarR6FkOsvWdSfZmshuDVIkXtkN4j2PHSvdLQT0D; 25:rrwr6PJd4Vitbb9t+uxdQ4YqRuBqpiru3JlS8lV8ZkA9HtxGLcg3YF+EyfFI8u1HCxELCzt+6dECUkAR97J/Y2sPoNuQAzK5Ibimzt4Kaa0f2h2COhCcKy64I2GS0BFw5PnugySFCClEI1y5twHPqY1PO8F8a0vcAZZ+r3YVACHwkXcD261TE4LWZnSZ9mRX+Cr8M6haVL7o2I6CHP03Us4tw8JgyRn5D3ticgBptuDktvcwm9opp2FMIOk4J7jlZC81BCtioeuttphwix6cGKdGQpTzdnlu2JVogpdV4T22CEbdmfJN37vm269OyhAOeJ40EXhokHviLyGb2hlISw==; 31:HwtWUh+XJj72veF395BtOydEveW4DBNJRzQ8ENxHARsZV39TitCNu7uDBsvNS4Ea2MTJEYmZ3vLBumfJ8/XCEYj8kIkymJ52oDXZzMQryd+JQS1L6x+u2rXc1nNlhuLBZF68qpRFJZ6jWO9osLq0iyvfHR8jiFeQQUaMo3/vZ0FrvTPh+kXdoizYj17k/0QRTD41+PJ7idtwX0Vc6JsE0TNu98NcbYb0yMWTkpnAttw= X-MS-TrafficTypeDiagnostic: DM6PR07MB4220: X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4220; 20:dum2QjLpud5ygxnD4zJIGzXL/npIzFuoO8aYoJwc2PLbITe7BWAixa1SegCss6RI3heImB3uwL5AHFr1AAZJUESYdMy/PQcZRv4cM3EUXKId5Jk8wWd4aqdxSYewj053PqF2cUOIEvPAMThTKnF1aJKAtRtTF5yfgMPwGXJ+ZAzKHCBzI7TwQWgJHoIeq3jBMHfe5HdASyggMaMYA+HX6PVX6tgL51Nph6fsdRm4aOtTzxk0jtzaEz25G2P7trtf8SjJCshIyDQUlVruW/na7SuiBoX/kBfiVB9O3RFRy2qQyD7MDg9IeS3OHe71kA37gBhWXeAOwVqedl0parvR3j5q+UJNfmcS3dy6kFCOEMVFmC6pwYukuAy1gy8k5jn0nyOSKHyDesAeTAWoO4PEATCD8vTiY8Qj4f6wOPghgvNRrxhBoc9ZUvRpm/5wixGDIcmozfBPCNpCCBj9cj1FdxR4+vD8P47Ip1NV/9kUsnnm2Iehz7KrD7eF2kBK9Ija; 4:A3tOPv77/6SK71N3kuIU+UgXAqrvtqAroTsfQ80kteTjTD8gQnTZIYXRpC/l4mQwDCCbstJR0nKUkFr1oXVxuCB8227MJlBzU010G58J1q7hSN4In2EKWq/Dj0xtsxMQjW1BrfbxGiy/grw9n2+CdY+ZYKm5GG0T+nYbYAemfhrVraeWPf2+ifkQ/LvpvrAwRrYn2udOJvtO4EPYeZ2YTSydZMpUiESGLuEme6v14jL/y3vJRL0cHMDFTjGxCv+yCU2UtXhzA7yvpiPHUdcJ+A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231220)(944501244)(52105095)(6041288)(20161123562045)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011); SRVR:DM6PR07MB4220; BCL:0; PCL:0; RULEID:; SRVR:DM6PR07MB4220; X-Forefront-PRVS: 060503E79B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(396003)(366004)(346002)(376002)(39860400002)(39380400002)(189003)(199004)(3846002)(52116002)(68736007)(23726003)(386003)(59450400001)(26005)(107886003)(478600001)(8676002)(1076002)(6116002)(186003)(16526019)(4326008)(25786009)(86362001)(47776003)(8936002)(6496006)(66066001)(2906002)(58126008)(6666003)(50466002)(16586007)(305945005)(316002)(81156014)(81166006)(6916009)(76506005)(105586002)(6486002)(72206003)(2351001)(53936002)(2361001)(5660300001)(33656002)(7736002)(97736004)(106356001)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR07MB4220; H:localhost; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4220; 23:4MVZlVG3r+KAbhppXSksGvVPixYSCygkheKCkHZnLH1BQNi63afuMYdDnc/dsODuSOHn7VxwQgxdr2Jm1yjLxsNzxq/M2KCBsnW6sbFWdeHM3LbAtVDeNnUf+Ravy74PkxbNoavAQvQjX5WmDcxsFo8bwepYHVnCuOpvMgA7R2fMMc6t8aLahISpQ0LEPeY+9GDXbuAlngcmlqTzuUE0SrQegOzA9OJG+u9q00dH4MVwjhUG90S+MjuQeNgI0cHm2YBiv0M2Z7np/56bshbx9cOMcCv2pRe65ClbRujCqjBo/5xJ8lOsxt8wvqaxFg7oqDlAE8/x0bjGuCe0dSPciHdmOl4+aoF39c09BueMawk9s+J6M+05bA58KBfG9zTVQIHtrn0TwD7Api4wE8Uf5PeaXZPfmXShRoTVx9/atcJpmdNhIhnyx2cKhnMATSjSvx5m3Pl03eOjQj9EI9qGGTx6R5peXAONT1ggjOqwpN5/gty9x5G8ihxyxy29nxmSkRhC4DaEOv1kOb76PZ1GH8CFwUMaPWqhZcIZ5cmmwqlVJodRJ4Ui6lSkh1WArZxQSvY7gniH/fUzhEBk1IxypdlM8cw8SpnSLgfMBGW2RU28Glc4yDE6khyvjtAL0GHnQXH/kTcc7pMRAC0woILblKZXTTBOIvs2++fHzAiPMfeGUOPg34VkwRmbctU2kuvEYnVWiO+uCvg729LN6yYeyNsRgnkMoIz/Xyh0NZutzHVzRzjGas0K8YLJFE5zSS+/mb0m7PDnXZW2dLz9frW3SYVXXunmmu/8S61Ge2/WGzPuLmams3xRpjZoHUCwLj0EwZzkteksjOI9hTeBqksLDbezPmxFp00pKXMsx62t7kqe9q4F4YRG3NKjy+7ngIn8PIWAezlEifHaseP8ksBI0BLd8moooSx9Tc2FAZ6Z3zjwmKixaoU4zizd7MO9Hu9bKUGSd7tiFLzujuDbUCcn74T2Fwew+wJucOTAQ1hsNHHdcWcIV+2eo70I9cYecJhDtWcAvZZycmc5+tNUbt7/S1XC9vAMJHjFvfhkDm7COb0pAhdstlRxU3YqV+ioozIQ/w1klGx2z/h3mk+vGYB/lQ53W8a5K6NTOM6VnB/QkcTBpCx8Qbpb8/mlllOywjdNu17H/Hev2HmGvdBgU0MUKjtX3Lh/QYP2VGDod3zEh8dvoG2P0yPuVrWzDuo55aNQ X-Microsoft-Antispam-Message-Info: 8m4yg8+95zjb56VwoJ3OLUrdjcDmdN0MDk5cfoOUKypqbM3P6morCHAym0X3FAF/q+wMZUTDiAnDm5dO6xUzH9ctiHdl93LAI8breWl6CIdVboAKukGJoNxDrV3sssLfJQoRmIzuUX7UnM9L9DTF9egRq33tZQ9pgrN6yUiXfil0O/52LOWU+Nie9muv2CVD X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4220; 6:liNWKun8klXFHDc4Hpt4TOjTtm0pgTfTuM2RE/10YaFlFoHjISmj6DPhYipyLtx6hy9dYOKA1vnOBrYSf/2dbjeRg0uYSaozOZ3hSoD5mQJQ7VG78ipWTfgMl3JpoqHCh6dLn1goPizZVi94tDKMFlfo6ECFcmJKAqXPHgsi6/I0eS0cXzMcgpk17gRFHPyH/vc4gSdPdFfMlR1nUJCx/7j6NFASOYa+sIv87DAwCdrxpxmcq5KAowZQgk0DEGvep2tE5jNrbq6BZ95lZdvG7l4lF7BqawVhLGcCqi3vspSctSdMFaBG60UAwH2s8thbXdPmUPTyWs0vkss0BGiZl8f0GgQsXD1h38y6VQunZK0=; 5:6WaMQ6WPofBOA0wmKNsFPr07WxXQac+x8CqGslclDLcYIM1Ss59TfCHi9Nkx77IsHSemVsipA2mceAev7+KgahIp43HY0lW7iy6CQ+mMg5MczCPSv8/ZNpvuyZ905HWBC7yvMt+HRW0vXjMoGOaFTMYHGO0Y2KmT/icyLXyGn00=; 24:iotYN9qwJfioY/3gAIyh3yQyet1fhOZyTnF/iskX0LHlO2ryguFklnDFrvMZQVcMMMQDDa2WcC8g+CqZBODcb7Gb4PdFhCYobAjaJ/yk70Y=; 7:AmzXJEPb/ma0VR1VGDVWErjC7gkggwIubw/vLeORML3VIMNiL89VyNjQKh44zDIbwQTH2KsVDFdYWZl/Ba6iqI56p+yg2/jZCarE35FsMHAQ7PkVCL4DyGO9//v+uXdG69TGIJqrWC6UCozfD2JWGS8Ie8rtf1ePMED4LHYk//g0V8NtUtZWMauf/yCU0g0rimz1pb68O9CPrmGbOST9Lv3g1+hhlBpSYHDYEmVWuOhwispOSbHMomd854hLcuni SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2018 06:12:39.8601 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f5d513eb-148e-4d75-3063-08d584bb9921 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB4220 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Intiyaz Basha Corrected length check when data received in the mbox is more than one 64 bit data value Signed-off-by: Intiyaz Basha Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c b/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c index 57af7df..28e74ee 100644 --- a/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c +++ b/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c @@ -87,7 +87,7 @@ int octeon_mbox_read(struct octeon_mbox *mbox) } if (mbox->state & OCTEON_MBOX_STATE_REQUEST_RECEIVING) { - if (mbox->mbox_req.recv_len < msg.s.len) { + if (mbox->mbox_req.recv_len < mbox->mbox_req.msg.s.len) { ret = 0; } else { mbox->state &= ~OCTEON_MBOX_STATE_REQUEST_RECEIVING; @@ -96,7 +96,8 @@ int octeon_mbox_read(struct octeon_mbox *mbox) } } else { if (mbox->state & OCTEON_MBOX_STATE_RESPONSE_RECEIVING) { - if (mbox->mbox_resp.recv_len < msg.s.len) { + if (mbox->mbox_resp.recv_len < + mbox->mbox_resp.msg.s.len) { ret = 0; } else { mbox->state &=