From patchwork Sun Mar 4 02:29:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?J=2E_Neusch=C3=A4fer?= X-Patchwork-Id: 881137 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.net Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zv6Ts6gylz9sWj for ; Sun, 4 Mar 2018 13:30:57 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751878AbeCDCaM (ORCPT ); Sat, 3 Mar 2018 21:30:12 -0500 Received: from mout.gmx.net ([212.227.17.21]:55633 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751309AbeCDCaK (ORCPT ); Sat, 3 Mar 2018 21:30:10 -0500 Received: from latitude ([88.153.6.235]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MCxfb-1f0Jsu2ehf-009g6y; Sun, 04 Mar 2018 03:30:03 +0100 From: =?utf-8?q?Jonathan_Neusch=C3=A4fer?= To: linux-kernel@vger.kernel.org Cc: =?utf-8?q?Jonathan_Neusch=C3=A4fer?= , "David S. Miller" , netdev@vger.kernel.org Subject: [PATCH 1/3] net: core: dst_cache: Fix a typo in a comment Date: Sun, 4 Mar 2018 03:29:51 +0100 Message-Id: <20180304022953.4508-1-j.neuschaefer@gmx.net> X-Mailer: git-send-email 2.16.1 MIME-Version: 1.0 X-Provags-ID: V03:K0:prrSDsyYumpL8hk8Vp0cRurG7cdM/0nR3vMd3mL5vYzu2Sij5z5 LEZVvMccZxHiDF5JYegJEskg1Iu5u2V1eZ5K3Die2PnNvG4VEh7mZXC2cvevDWrpw6X2AE4 UR6ivwhwcXKl05v11EWcprHX7aoJ7uToe2/ZqnWmULQvIp3dylBJzcI+2lp6FaMcOdWCJEB yxBdVC720PTfkHrL3iWIw== X-UI-Out-Filterresults: notjunk:1; V01:K0:rhh74UpawhA=:hcn0nUZLKdep2uGpmlbZRk itFlYFdKsubOcBdcHB5KhAI74YcIKiT3PeeIM58ba55bk3vBSE2wF4eyPZzgiWLQH/DC/1Pxq 8ocaW8SlE/qGl8F/goM4Th2q2IHWpV5dKJ28A1nnEbRQc7gTdxeGNEBsphaPflVWtyS2dWBM1 +o7mdhmpmtw8mabjoat81u7YBxpw9G7B7qoi4vhAEb9RO+305t43XZK37yrluzMA7Mday1w/R 0wTmJpV3dz7vDxaSOqX3PH57DqaGFgUxUvw2WiGi8XwSATiDobXGldEh9AhARKMa+U4OTyj6t mWgYe2nzASA8t/pkSc2sRJTu/YLpMmvLZXqjPkJOvPhDdnX8+XmFsh3IqKDJ1ZgFuQ7YlBmvq /ePhS8pAXPaFVvyZgdSamUV9ZGfnZxjeBEKAQcEAyCt3ezvEMnU4gqGKRLTbhD/GayTRQkqz6 rDtokt7FLixG7QOWA1fMwujqCt35vGuX9qMIQSttUnUYC+jrTkypTUW1zIt/LJ1X7zSJw3V1F rYbKRIowl4Uti8yI+sOjLT1tIyas6YF3yQp/UJZkuYqi0L7EDDxf8MDwgp1nOff687AEZg2Vb 492DRFf6ZQiuS3AudswYmHGB7AIkEK1OV+WWcHGbegCaQFgi/T+FpxKwaWtbwXuMDb5h+26BR 03ZkZNxTxiy/GiGaz5QNhAXzxZu0sYdmaHMiYSnBdw5zPUDlj+r3RD5zpwkxW77G5tpUDRpo+ HODh76svOtlAOqGLtsqLGiHlZlzx9UQmhN1/vXeiUoNSS0eUFLUoU83dLy5I14ZjdeDCmB0Hc XLaeBJG7McPtsEueHkb3axlefp0SAyvXMh196RxF0Xlvw1xZwk= Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Signed-off-by: Jonathan Neuschäfer --- include/net/dst_cache.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/dst_cache.h b/include/net/dst_cache.h index 72fd5067c353..844906fbf8c9 100644 --- a/include/net/dst_cache.h +++ b/include/net/dst_cache.h @@ -71,7 +71,7 @@ struct dst_entry *dst_cache_get_ip6(struct dst_cache *dst_cache, * dst_cache_reset - invalidate the cache contents * @dst_cache: the cache * - * This do not free the cached dst to avoid races and contentions. + * This does not free the cached dst to avoid races and contentions. * the dst will be freed on later cache lookup. */ static inline void dst_cache_reset(struct dst_cache *dst_cache) From patchwork Sun Mar 4 02:29:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?J=2E_Neusch=C3=A4fer?= X-Patchwork-Id: 881136 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.net Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zv6Tj6yNdz9sWj for ; Sun, 4 Mar 2018 13:30:47 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752295AbeCDCaM (ORCPT ); Sat, 3 Mar 2018 21:30:12 -0500 Received: from mout.gmx.net ([212.227.17.21]:39983 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751340AbeCDCaL (ORCPT ); Sat, 3 Mar 2018 21:30:11 -0500 Received: from latitude ([88.153.6.235]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0M5IdH-1eUR4S15Jv-00zXdp; Sun, 04 Mar 2018 03:30:07 +0100 From: =?utf-8?q?Jonathan_Neusch=C3=A4fer?= To: linux-kernel@vger.kernel.org Cc: =?utf-8?q?Jonathan_Neusch=C3=A4fer?= , "David S. Miller" , netdev@vger.kernel.org Subject: [PATCH 2/3] net: core: dst_cache_set_ip6: Rename 'addr' parameter to 'saddr' for consistency Date: Sun, 4 Mar 2018 03:29:52 +0100 Message-Id: <20180304022953.4508-2-j.neuschaefer@gmx.net> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180304022953.4508-1-j.neuschaefer@gmx.net> References: <20180304022953.4508-1-j.neuschaefer@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K0:Xqc2Rmy0/MKLa1yrvm3YnruDy3ryWQjs2eB4452yqdYNzJvFtYd FPRWkODxzuwlXKTSuOSJgWI9MDohfg7ydpX9C91Q7RF02NUDvDC3OZgUPeVI8CKHQCK8HlC eiiIx0qTNqetHt4VboEV8kbk3W6D3gyBGbUVZfcZ2x1KwhHn56H2njOfWJcFoU1JMMUmn1i SrS+KUbcfk7mlueTOmtlw== X-UI-Out-Filterresults: notjunk:1; V01:K0:8kCpGQjjegI=:KCp8eVg+P8V3JVSSEdPMXe bWu6t+9Fc+nletfiWoBE81/RcCBoHhfYjs2RqYNunv8NPQ/sHMvGyp9IjwOhqc9TbpsJJjLd6 cLnhywbD+sscJIbt9G194btdIKgUjl+ohUxTd9L6zP5nrnofLM6c3v/zBwgDCMxlzXFmc0DXW W5eBVkh918ujhEWOpf6FtqTGYi1192uBTlw7FgofF894eiZ47VZewrVTtpHJKQuFEMFeawafH 7uLckRKyTvgklnQj9mUdfU/m5gfOZ/AX2Ud2E3xaNL3oJmdcAHlX3DoXGBOabQpR0ybGKuVPz mP85evfgrFSTQoyhYhbfCvjzMWMAOcWs5SjyeX2tvOgmacyRfRe5skYyiySFebgTCV+4l5fEA ASUX3HXLPIAfFxhwwVWyGA+7agWy8SWDHcFmtgi/XQfH3oHPYDom4+2O9bMPQar83+1yw5bfK DDWwa69+Khb8Nbfb4tflc4f/k2gVYChPVdX4xCOSKcwFtjtCMljIsYPyyF4dmlcYg9HNrGVab MMFV6k6FOl0LpPwKg4AyUJ+dgxnaCUX58AvYFAKy+ZS6PHkyGlm3sW4P4BKNueOtUQ7NXuBXg XbG3UYoAb8RBAh7OtoNoHU2Aff3HqfU1pw3QFnwZlzv2iPJTPDx+L41OKIRQ6do3qZnqZoMB8 iDGMmrE8Dr56PQgQjLJ0/+04rpayXFaNb+tUYWDCj3pErc3SpJFd+dKKbW0mZHHrtVNlCnZVF kPe3/1bPh2FC7Ob0pg3JBjYpbjFClGVhkzDIRAOCCYrUEn5g5flotuhY11wrzLlBaEC96Akqa YXB1WVjz2g9KXLLdzH++5Aos7gFPk1iDIhPU1wVQoNQTEo0rTk= Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The other dst_cache_{get,set}_ip{4,6} functions, and the doc comment for dst_cache_set_ip6 use 'saddr' for their source address parameter. Rename the parameter to increase consistency. This fixes the following kernel-doc warnings: ./include/net/dst_cache.h:58: warning: Function parameter or member 'addr' not described in 'dst_cache_set_ip6' ./include/net/dst_cache.h:58: warning: Excess function parameter 'saddr' description in 'dst_cache_set_ip6' Fixes: 911362c70df5 ("net: add dst_cache support") Signed-off-by: Jonathan Neuschäfer --- include/net/dst_cache.h | 2 +- net/core/dst_cache.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/net/dst_cache.h b/include/net/dst_cache.h index 844906fbf8c9..67634675e919 100644 --- a/include/net/dst_cache.h +++ b/include/net/dst_cache.h @@ -54,7 +54,7 @@ void dst_cache_set_ip4(struct dst_cache *dst_cache, struct dst_entry *dst, * local BH must be disabled. */ void dst_cache_set_ip6(struct dst_cache *dst_cache, struct dst_entry *dst, - const struct in6_addr *addr); + const struct in6_addr *saddr); /** * dst_cache_get_ip6 - perform cache lookup and fetch ipv6 source address diff --git a/net/core/dst_cache.c b/net/core/dst_cache.c index 554d36449231..64cef977484a 100644 --- a/net/core/dst_cache.c +++ b/net/core/dst_cache.c @@ -107,7 +107,7 @@ EXPORT_SYMBOL_GPL(dst_cache_set_ip4); #if IS_ENABLED(CONFIG_IPV6) void dst_cache_set_ip6(struct dst_cache *dst_cache, struct dst_entry *dst, - const struct in6_addr *addr) + const struct in6_addr *saddr) { struct dst_cache_pcpu *idst; @@ -117,7 +117,7 @@ void dst_cache_set_ip6(struct dst_cache *dst_cache, struct dst_entry *dst, idst = this_cpu_ptr(dst_cache->cache); dst_cache_per_cpu_dst_set(this_cpu_ptr(dst_cache->cache), dst, rt6_get_cookie((struct rt6_info *)dst)); - idst->in6_saddr = *addr; + idst->in6_saddr = *saddr; } EXPORT_SYMBOL_GPL(dst_cache_set_ip6); From patchwork Sun Mar 4 02:29:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?J=2E_Neusch=C3=A4fer?= X-Patchwork-Id: 881135 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.net Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zv6TR1Yh5z9sWm for ; Sun, 4 Mar 2018 13:30:35 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752462AbeCDCaP (ORCPT ); Sat, 3 Mar 2018 21:30:15 -0500 Received: from mout.gmx.net ([212.227.17.22]:57201 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752409AbeCDCaO (ORCPT ); Sat, 3 Mar 2018 21:30:14 -0500 Received: from latitude ([88.153.6.235]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Mb31L-1f6oA70l2J-00KhKM; Sun, 04 Mar 2018 03:30:08 +0100 From: =?utf-8?q?Jonathan_Neusch=C3=A4fer?= To: linux-kernel@vger.kernel.org Cc: =?utf-8?q?Jonathan_Neusch=C3=A4fer?= , "David S. Miller" , netdev@vger.kernel.org Subject: [PATCH 3/3] net: core: dst: Add kernel-doc for 'net' parameter Date: Sun, 4 Mar 2018 03:29:53 +0100 Message-Id: <20180304022953.4508-3-j.neuschaefer@gmx.net> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180304022953.4508-1-j.neuschaefer@gmx.net> References: <20180304022953.4508-1-j.neuschaefer@gmx.net> MIME-Version: 1.0 X-Provags-ID: V03:K0:ymtn87BSSHgLp7NedXUq1pd3aoC/rkoJ0l/WjZ4ZzyU5QVyQ38o B/LoidkOk/SHzg6YjsGKXsVL1qOkuJI1K8a+COJ3xzJNfRGjm/q16H3doJ+TFm4P+VytBps eV6wLwMmucnA6WBbDwthjdTZwcsMXy023oLRlzebEcOish6fKFS8lFgcHU4Zm8Acd3WtBsj 9801hiXLDd1sRiBw+ze4Q== X-UI-Out-Filterresults: notjunk:1; V01:K0:cygDGMWrtzw=:BhKicx7UIcunwOGZvLRCyJ NS0qUCe9SdirHlrY4c799sSo30CzweHxDumFFF5sysPebWPg3nFycIRSGBR+ejQW8fHm/NY0L VgbanXeb39klW+VFLRyH5d+TYBdaof6nrBfcfZBLZ5tQoL+EaJ4irLIvYwr96zsbr2HR0wpFp mhOQwDx0Zpth30QEHzwHfrH+oQFa1eNoJUR6WNnzLYIZ8h1V3AccPy6mM1et1h9P/6f0PIpn8 vTHZlf8hNr3NHAWo0Sv431dHBxqvkaOGnxPqvZ+ZJmqPTKgYwc+HjZkbJBL5xvuYwRAqGwsl8 mxrXYd8sm8/lmH+jTefBGeembhRvCyQauA+nR94B2zELFxXJ/RFX8pFwnwapbGTuWyNJP1nbt kRKLOfNylr54tJ2+0aG4sJXMMQE+j298jnVenGEtRBGqfjyjaSoHnSKjnGSJh1r1XQzY+kvNn wu9Ayrb6FAXimJSf87hUpVD/VMngg7CajPQT+plkwTVjmytHnR0qtA7UFnQDP9/SBz02q6M3c MbKlRARn0NHSKWgiF+nMZy9cd/8gftqxG+NjO/Hl8WmgPTlR9uNkqt2nt3hsSAg8KuJ39TcOF eg0/ogAjvw7JOo32NiSfvZu83JT4CHiF0nIWZ6JhFnH7ZS9G354l7Xk+c79Aa/1S2KjzEOgBr HapO4FUbm+UVpExxzgNbeAibdOYMqN+JA92ouRwvvXc8PsZBasLi4L68r4+Kin12XYkDtDVXi h+9shExOu1XynBKzjAfG+2jr/ZEpAK1DMfsw2CHiFcd7LC2AGeVOCTj1fAoLE1RsHLbnYsTsH IzKfOuyrRpQj+qRflhXYyvkwi9JKcJi5iDuiDCeAjrmBrDL58c= Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This fixes the following kernel-doc warning: ./include/net/dst.h:366: warning: Function parameter or member 'net' not described in 'skb_tunnel_rx' Fixes: ea23192e8e57 ("tunnels: harmonize cleanup done on skb on rx path") Signed-off-by: Jonathan Neuschäfer --- include/net/dst.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/net/dst.h b/include/net/dst.h index c63d2c37f6e9..b3219cd8a5a1 100644 --- a/include/net/dst.h +++ b/include/net/dst.h @@ -356,6 +356,7 @@ static inline void __skb_tunnel_rx(struct sk_buff *skb, struct net_device *dev, * skb_tunnel_rx - prepare skb for rx reinsert * @skb: buffer * @dev: tunnel device + * @net: netns for packet i/o * * After decapsulation, packet is going to re-enter (netif_rx()) our stack, * so make some cleanups, and perform accounting.