From patchwork Fri Sep 2 18:51:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 1673707 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2620:137:e000::1:20; helo=out1.vger.email; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Y1q/QIDa; dkim-atps=neutral Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by legolas.ozlabs.org (Postfix) with ESMTP id 4MK6VP2Wp0z1ynd for ; Sat, 3 Sep 2022 04:52:45 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230118AbiIBSwo (ORCPT ); Fri, 2 Sep 2022 14:52:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230130AbiIBSwi (ORCPT ); Fri, 2 Sep 2022 14:52:38 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EE00110DB3 for ; Fri, 2 Sep 2022 11:52:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662144755; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mMXlQl3McI8LljLOfD/beUo4yXAI3eoC9II432XUfis=; b=Y1q/QIDa8RiUa4fmi5yxNfrZA/3mri44TOG/fCdPXHsWZS601gAyQSm6sbT4LH9SXTXFTR fFs8qhAhpGY6dge6PnfW6BIrkLJ7BTOs7SFEtWe425NeKIkeqJd06os/X6Ts+gTSt+roZe KeeaU4t6AwC2yGJjka2RZbZ8lfeaC3Y= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-648-AA03WsxQMcSfJTpDNxw56A-1; Fri, 02 Sep 2022 14:52:25 -0400 X-MC-Unique: AA03WsxQMcSfJTpDNxw56A-1 Received: by mail-qt1-f197.google.com with SMTP id z10-20020a05622a124a00b003445680ff47so2163845qtx.8 for ; Fri, 02 Sep 2022 11:52:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=mMXlQl3McI8LljLOfD/beUo4yXAI3eoC9II432XUfis=; b=y5fkghPkwQ6Qs8JdQgqxJPmk3s4b+l8wtUba/RkASu9nwG2wYvl/vrjla08SaE2b3v VksPGCnlRybhG7tACs3vphwJ7FCt7bCJMBadH6DDprytIy2yPCXKb63Bml/s8ly/WIcQ bwnF1QUHGdyyjcqDNg2O56a7mtTQ7L6YKpQS9Ri4NYgDsQe/RUkqMRYuKZ65KRRQ7iD4 OSf/WxODmVlhZtM+h5T1aJnZrer/xYYwhZoPi1vdQK/fACJOZ4F0+58B8JTkHmZCLyXt b+XqZq+ws5/neVcyJ+1qDox5DJjzXdgqpvYUIMqpXNqrspgI9xxm2o7dFhdnNVSzWWfY DsmA== X-Gm-Message-State: ACgBeo3UuP+8wgCpWwGcmgjMM15BhXlrKe0oJ9P+XJepK+us3wsEJucJ ZsmS6f0ejOLD9KSSGZ9aJL4DqUeDyePDMScl7TSIWlXmdUMBxyuq5PD5cBewbr322+/AVRLVWKl ZWVh5YgSe1EA5k51vm9qjHQ== X-Received: by 2002:ac8:5a4a:0:b0:344:56b3:7eac with SMTP id o10-20020ac85a4a000000b0034456b37eacmr30002983qta.656.1662144745537; Fri, 02 Sep 2022 11:52:25 -0700 (PDT) X-Google-Smtp-Source: AA6agR4ogEKHDJ2+aO2zqFgKOn0rePP35V50OUqeadZCgV7OcOEFgnmwuKzmiq0+0YezCsI8iP5uqA== X-Received: by 2002:ac8:5a4a:0:b0:344:56b3:7eac with SMTP id o10-20020ac85a4a000000b0034456b37eacmr30002963qta.656.1662144745324; Fri, 02 Sep 2022 11:52:25 -0700 (PDT) Received: from halaneylaptop.redhat.com ([2600:1700:1ff0:d0e0::48]) by smtp.gmail.com with ESMTPSA id j4-20020ac874c4000000b0031ef0081d77sm1403168qtr.79.2022.09.02.11.52.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Sep 2022 11:52:25 -0700 (PDT) From: Andrew Halaney To: agross@kernel.org, andersson@kernel.org, konrad.dybcio@somainline.org, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dianders@chromium.org, johan@kernel.org, Andrew Halaney Subject: [PATCH 1/3] regulator: dt-bindings: qcom,rpmh: Use additionalProperties Date: Fri, 2 Sep 2022 13:51:46 -0500 Message-Id: <20220902185148.635292-2-ahalaney@redhat.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220902185148.635292-1-ahalaney@redhat.com> References: <20220902185148.635292-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Right now, running make dt_binding_check results in this snippet: /mnt/extrassd/git/linux-next/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml: 'additionalProperties' is a required property hint: A schema without a "$ref" to another schema must define all properties and use "additionalProperties" from schema $id: http://devicetree.org/meta-schemas/base.yaml# SCHEMA Documentation/devicetree/bindings/processed-schema.json /mnt/extrassd/git/linux-next/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml: ignoring, error in schema: Which results in the schema not being properly evaluated. Swap out unevaluatedProperties which doesn't seem to be doing anything for additionalProperties. Signed-off-by: Andrew Halaney --- .../devicetree/bindings/regulator/qcom,rpmh-regulator.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml index 9a36bee750af..b3fd60b21610 100644 --- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml +++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml @@ -106,6 +106,8 @@ patternProperties: $ref: "regulator.yaml#" description: smps/ldo regulator nodes(s). +additionalProperties: false + required: - compatible - qcom,pmic-id @@ -351,8 +353,6 @@ allOf: "^vdd-l2[01]-supply$": true "^vdd-s[1-8]-supply$": true -unevaluatedProperties: false - examples: - | #include From patchwork Fri Sep 2 18:51:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 1673706 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2620:137:e000::1:20; helo=out1.vger.email; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=DEgrurzH; dkim-atps=neutral Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by legolas.ozlabs.org (Postfix) with ESMTP id 4MK6VN40Vjz1ynd for ; Sat, 3 Sep 2022 04:52:44 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229658AbiIBSwl (ORCPT ); Fri, 2 Sep 2022 14:52:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230129AbiIBSwi (ORCPT ); Fri, 2 Sep 2022 14:52:38 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B348CE2C74 for ; Fri, 2 Sep 2022 11:52:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662144751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uLJN7/BLiss15VoCQRispsUH3s6wfzk4G5XVQwrvZI0=; b=DEgrurzHMf4AYc0NzQwbCJGPeZc5KAwhBxcAowHu8UvP6w/8X/1XqRyLkXfrUJ7hkrdpjm oRs8ImaPAFXEoh+aV8zStoq/+r1UMT0hGoTaEbThXHf2MUI5z6yQ6vzRhQyLbhXJUpIQUm eVZKFv+Yimbw+/KllSQdXJ1wOLtI1oA= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-442-dnJgBkL2NqCaFBpIl7UM1Q-1; Fri, 02 Sep 2022 14:52:30 -0400 X-MC-Unique: dnJgBkL2NqCaFBpIl7UM1Q-1 Received: by mail-qk1-f198.google.com with SMTP id j13-20020a05620a288d00b006be7b2a758fso2623072qkp.1 for ; Fri, 02 Sep 2022 11:52:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=uLJN7/BLiss15VoCQRispsUH3s6wfzk4G5XVQwrvZI0=; b=X+evJUot7HajLoRu+rWkYecIxpU0a7No3TsIdeguPv+3dcl0HmOyrsLTlutCAtMn87 qML5ZmtDBy31Nm4gve6zz9VHbG3nTBR+5LpKzzUULEFLKWJzkdWPR1IAF+Z1OOaYCApi 5c43D+9bYafrDV3EnobRlCNG94qXE5fRSff7aKPhI6ZDlDvfKloryCCPj53Je0ZJARJG S+OqSdfjsi1WJ6iPxeljUy52RCu/Gk5B6I9IYF7iIaEqCMSvEwwG2mWhY1bhgkbZXt8K XF3ojKoxixfKqbtkE1ayymKfVtq1uhBwssxUfSL/t3oea7KRW567qj6CYbkOYaJPyD59 mdrA== X-Gm-Message-State: ACgBeo0zoy+S7/chmLWC4h2gAfVVcd51RxTRv12twrqmmOaev1MOOhdT PWIBkFM8/hrgEvq07zAqYhPXAXbgCDrQk6IqzVbHGsZHymD14xYMy+AGeuGgip4DJWvs25bn19j dep7k4ZT2HVqNZqnKvu0iww== X-Received: by 2002:a0c:9d46:0:b0:476:ff07:3fe7 with SMTP id n6-20020a0c9d46000000b00476ff073fe7mr30933295qvf.15.1662144750213; Fri, 02 Sep 2022 11:52:30 -0700 (PDT) X-Google-Smtp-Source: AA6agR7aZwLqxASsgLyT6pr2oLxtShydapkDDS6erqpAYgTyjpgPuDnQlYnCVVNVGOO0dY0TwHgdKg== X-Received: by 2002:a0c:9d46:0:b0:476:ff07:3fe7 with SMTP id n6-20020a0c9d46000000b00476ff073fe7mr30933279qvf.15.1662144749987; Fri, 02 Sep 2022 11:52:29 -0700 (PDT) Received: from halaneylaptop.redhat.com ([2600:1700:1ff0:d0e0::48]) by smtp.gmail.com with ESMTPSA id j4-20020ac874c4000000b0031ef0081d77sm1403168qtr.79.2022.09.02.11.52.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Sep 2022 11:52:29 -0700 (PDT) From: Andrew Halaney To: agross@kernel.org, andersson@kernel.org, konrad.dybcio@somainline.org, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dianders@chromium.org, johan@kernel.org, Andrew Halaney Subject: [PATCH 2/3] regulator: dt-bindings: qcom,rpmh: Specify supply property Date: Fri, 2 Sep 2022 13:51:47 -0500 Message-Id: <20220902185148.635292-3-ahalaney@redhat.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220902185148.635292-1-ahalaney@redhat.com> References: <20220902185148.635292-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The top level RPMh nodes have a supply property, make sure to specify it so the patternProperties later that are keyed off of the PMIC version are properly honored. Without this, and the dt-binding containing additionalProperties: false, you will see the following when running make dt_binding_check: DTEX Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.example.dts DTC Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.example.dtb CHECK Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.example.dtb /mnt/extrassd/git/linux-next/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.example.dtb: pm8998-rpmh-regulators: 'vdd-l7-l12-l14-l15-supply' does not match any of the regexes: '^(smps|ldo|lvs)[0-9]+$', 'pinctrl-[0-9]+' From schema: /mnt/extrassd/git/linux-next/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml That supply pattern is intended to be considered correct for the qcom,pm8998-rpmh-regulators compatible, and is no longer complained about with the supply property described. Unfortunately this pattern is wide enough that it no longer complains when you bork the expected supply for a compatible. I.e. for qcom,pm8998-rpmh-regulators, if I change the example usage in the binding to: vdd-l0-l12-l14-l15-supply = <&pm8998_s5>; I get no warning, when really it should be of the pattern: vdd-l7-l12-l14-l15-supply = <&pm8998_s5>; Signed-off-by: Andrew Halaney --- .../devicetree/bindings/regulator/qcom,rpmh-regulator.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml index b3fd60b21610..86265b513de3 100644 --- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml +++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml @@ -106,6 +106,9 @@ patternProperties: $ref: "regulator.yaml#" description: smps/ldo regulator nodes(s). + ".*-supply$": + description: Input supply phandle(s) for this node + additionalProperties: false required: From patchwork Fri Sep 2 18:51:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 1673708 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2620:137:e000::1:20; helo=out1.vger.email; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=jI9ftbiB; dkim-atps=neutral Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by legolas.ozlabs.org (Postfix) with ESMTP id 4MK6VR4kt4z1ynd for ; Sat, 3 Sep 2022 04:52:47 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230123AbiIBSwo (ORCPT ); Fri, 2 Sep 2022 14:52:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230117AbiIBSwk (ORCPT ); Fri, 2 Sep 2022 14:52:40 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16B8CDD75A for ; Fri, 2 Sep 2022 11:52:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662144758; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uWCWlSmZFYEaKyKiurVFOsZ2PihsSoTnqTvGm6hbF8A=; b=jI9ftbiB87gs1t9Gr5THkpSnyxEhyQ38AYZRYhoQ8fo+Eh6qDBL9AIC6rD03k6mrPQiNw2 guiALd0DhMJw59xN3ZjgA2AMONW99n2TnZi/wNfD7gHJ4HjLuTBjEO49k7i1N2FSyACsB5 OF8z/mg7I/swCAzgdL2qk+4xTDN+aok= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-84-MbhtHuHtNc6z1oLGAVtBPA-1; Fri, 02 Sep 2022 14:52:37 -0400 X-MC-Unique: MbhtHuHtNc6z1oLGAVtBPA-1 Received: by mail-qt1-f199.google.com with SMTP id s2-20020ac85cc2000000b00342f8ad1f40so2166249qta.12 for ; Fri, 02 Sep 2022 11:52:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=uWCWlSmZFYEaKyKiurVFOsZ2PihsSoTnqTvGm6hbF8A=; b=irFCqsbSVXcgHrkrxFudXZJ2CzE8l28HN2cnWfuf1ZjjBhg6GZmPVdEkeB3M/qRCtw 1tEjFR07C/p/mxyzSgtpD0tEU+mpJ/snojSmEvuTgVGfZ9PCKc+Z4qtJHoDjKneRC3YK mgPeyjX0isTl2tpn9MlESEErb9LSx1crc5epKMENMave4VbHHJy6DtYF8j5PVrZI57d+ EI7u2Up01SBK9ccgWZFJPK03Kf55yMKw7+S484ctMGMWlRqOncBuBVQm1WHpkgRx+02j jxgQTc/a1spUslgPvAH503zmCQu9dj33SCRkZQQBxTcua5tcN6Tp7uRam6hVe2PHYsSe b0GQ== X-Gm-Message-State: ACgBeo2LwsR0Q0GjkHRFGa/oq8gbpH+xBV/HrdCiQwzrYTM0pAlX6wjH 2azwLBQ60dx+xqep10Jf9SaPUGdwjRb6X+72z3E1stu14Kc4vmw6JJ2Xdz+rI2fCIoWrgZm0vrI /KQpRTUJ+QJbFpGpquK5EAg== X-Received: by 2002:a05:6214:5299:b0:47e:89e9:e27b with SMTP id kj25-20020a056214529900b0047e89e9e27bmr30305777qvb.52.1662144756902; Fri, 02 Sep 2022 11:52:36 -0700 (PDT) X-Google-Smtp-Source: AA6agR6sQ1Y+//dmjxKBj3ZEaXYuHYln+NL61ZdmgRorPSxsIvkkcjpHQ8qd63mv5wb+6ajlx/wzPA== X-Received: by 2002:a05:6214:5299:b0:47e:89e9:e27b with SMTP id kj25-20020a056214529900b0047e89e9e27bmr30305759qvb.52.1662144756618; Fri, 02 Sep 2022 11:52:36 -0700 (PDT) Received: from halaneylaptop.redhat.com ([2600:1700:1ff0:d0e0::48]) by smtp.gmail.com with ESMTPSA id j4-20020ac874c4000000b0031ef0081d77sm1403168qtr.79.2022.09.02.11.52.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Sep 2022 11:52:36 -0700 (PDT) From: Andrew Halaney To: agross@kernel.org, andersson@kernel.org, konrad.dybcio@somainline.org, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dianders@chromium.org, johan@kernel.org, Andrew Halaney Subject: [PATCH 3/3] regulator: dt-bindings: qcom,rpmh: Indicate regulator-allow-set-load dependencies Date: Fri, 2 Sep 2022 13:51:48 -0500 Message-Id: <20220902185148.635292-4-ahalaney@redhat.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220902185148.635292-1-ahalaney@redhat.com> References: <20220902185148.635292-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org For RPMH regulators it doesn't make sense to indicate regulator-allow-set-load without saying what modes you can switch to, so be sure to indicate a dependency on regulator-allowed-modes. With this in place devicetree validation can catch issues like this: /mnt/extrassd/git/linux-next/arch/arm64/boot/dts/qcom/sm8350-hdk.dtb: pm8350-rpmh-regulators: ldo5: 'regulator-allowed-modes' is a dependency of 'regulator-allow-set-load' From schema: /mnt/extrassd/git/linux-next/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml Suggested-by: Johan Hovold Signed-off-by: Andrew Halaney --- .../devicetree/bindings/regulator/qcom,rpmh-regulator.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml index 86265b513de3..1cfd9cfd9ba6 100644 --- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml +++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml @@ -99,12 +99,16 @@ properties: type: object $ref: "regulator.yaml#" description: BOB regulator node. + dependencies: + regulator-allow-set-load: ["regulator-allowed-modes"] patternProperties: "^(smps|ldo|lvs)[0-9]+$": type: object $ref: "regulator.yaml#" description: smps/ldo regulator nodes(s). + dependencies: + regulator-allow-set-load: ["regulator-allowed-modes"] ".*-supply$": description: Input supply phandle(s) for this node