From patchwork Thu Mar 1 11:31:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 879755 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="edNnGq6m"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zsVfq4TCsz9s12 for ; Thu, 1 Mar 2018 22:33:07 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030250AbeCALck (ORCPT ); Thu, 1 Mar 2018 06:32:40 -0500 Received: from mail-it0-f67.google.com ([209.85.214.67]:36718 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967708AbeCALci (ORCPT ); Thu, 1 Mar 2018 06:32:38 -0500 Received: by mail-it0-f67.google.com with SMTP id u5so7462636itc.1; Thu, 01 Mar 2018 03:32:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=bSltLOV6yk5d7AB70P7kfnRMcNXcfFNp9a5+BEocV4Q=; b=edNnGq6mnWzZAyIbOSm4xMsckiS9dOCMm27vMcTyXMhzIAAlrYjOvkYj7ggSIlSi6a NO6k+3LVATjnpoUzlGP05aJkE+qE+f05NtGJgIGUx0ziZuFQ/fK3yizPOO657nPRf3EV iDKJunw5hfYek2RthcUVI5Hha5kD+hHrx+mmAlg6zowVooTOwiNV8DVXJkWD1MkDPSRy yLZmjt3sUDCrFl1PVWtIMRPiHheLff6ZpvEppPGgalkrRhQHqFq7cULRwkOLbdebNo1+ FqqlpOaayJeuBVkEqddNL41+iD1cF1/otP5y/tmG4mlMrdBql19N4I0Wj4Zk6ITqkU3H 1PPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=bSltLOV6yk5d7AB70P7kfnRMcNXcfFNp9a5+BEocV4Q=; b=oJYIaoLtE+Xk7WYdsm+qky1jrhw+1A/CNA1Lo4PrxOCVuaJ0NKdowUH11k6mIMTYQV AQD6NQh/7IDhS6x22dGR9cmBwCPz2ZjnZJB5FyLh95/Uo1wKkC2pXly+d7SsfejsMISd MUo0clKMGyAuNIhvat7uJAxf7C79DEs40PS+9irxg/g/ujpaCmTsXDwXRgJEbpb9/7Yh 4p6yB2v0VM3HjgsE3WaXkQSUbDmWDuxp2AzWZENFAedBy1vF7tzMHI3txNG2S/9RjilQ HNJpIzqgyFP9ZKTs6oNtQQnG5OwnxM8kNAifSo+ZxhoEd72lpsnlWnXhQVNL1WNaXbsV Vh0w== X-Gm-Message-State: AElRT7G9AGmBzdU8+UDRj8oQMFxBT/7BlCt6P4RDGhNLBXzPQzmYTwLv yN9PXgl9mTUEhA9huaZWTbDVkg== X-Google-Smtp-Source: AG47ELtt+FXJmnCf37OTGf5upyPV0FpdSnmA8tsvHPlo7n0gXdj7V45yaE0SdMR0IbXLtNJe9DTYrg== X-Received: by 10.36.95.140 with SMTP id r134mr1055426itb.70.1519903958271; Thu, 01 Mar 2018 03:32:38 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([149.23.17.254]) by smtp.googlemail.com with ESMTPSA id j28sm2923349ioo.63.2018.03.01.03.32.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 01 Mar 2018 03:32:37 -0800 (PST) From: Arvind Yadav To: jwi@linux.vnet.ibm.com, ubraun@linux.vnet.ibm.com, davem@davemloft.net Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3] net: iucv: Free memory obtained by kzalloc Date: Thu, 1 Mar 2018 17:01:57 +0530 Message-Id: <1519903917-11575-1-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Free memory by calling put_device(), if afiucv_iucv_init is not successful. Signed-off-by: Arvind Yadav Reviewed-by: Cornelia Huck --- changes in v2: Calling put_device() before kfree(). changes in v3: No need to call kfree(). So removed kfree(). net/iucv/af_iucv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c index 1e8cc7b..9e2643a 100644 --- a/net/iucv/af_iucv.c +++ b/net/iucv/af_iucv.c @@ -2433,9 +2433,11 @@ static int afiucv_iucv_init(void) af_iucv_dev->driver = &af_iucv_driver; err = device_register(af_iucv_dev); if (err) - goto out_driver; + goto out_iucv_dev; return 0; +out_iucv_dev: + put_device(af_iucv_dev); out_driver: driver_unregister(&af_iucv_driver); out_iucv: