From patchwork Wed Jul 20 16:26:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Phelan, Michael" X-Patchwork-Id: 1658714 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=nmiQbxan; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.136; helo=smtp3.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Lp1LF0WXbz9sFs for ; Thu, 21 Jul 2022 02:26:44 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 971C16129C; Wed, 20 Jul 2022 16:26:41 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 971C16129C Authentication-Results: smtp3.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=nmiQbxan X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TibzBMqAqLHz; Wed, 20 Jul 2022 16:26:40 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id B6F4B60B22; Wed, 20 Jul 2022 16:26:39 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org B6F4B60B22 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6C1A3C0033; Wed, 20 Jul 2022 16:26:39 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1921BC002D for ; Wed, 20 Jul 2022 16:26:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id DD20760B22 for ; Wed, 20 Jul 2022 16:26:37 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org DD20760B22 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GM3E-dWDE64f for ; Wed, 20 Jul 2022 16:26:36 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 713CD60AE3 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by smtp3.osuosl.org (Postfix) with ESMTPS id 713CD60AE3 for ; Wed, 20 Jul 2022 16:26:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658334396; x=1689870396; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=mmWbdmb3UpFaDbvJdJWmN6acTKoQXResXZhJnTK1wf4=; b=nmiQbxan0sDUUhjjeOdCKK79YfdRmFczc/t1ApAjzlKwOSyXYiTAT3Zy TWAbH7sQPeLOk27NP0C3ztlz2JGxqN358W4zZGh00eBQ2vnED2dtYz9MD wq0gRwjK7NStQ6Ujiz6L3Pup4LJw4CF37s7p0erbCUDm4LWwaJV7phU+N lyddsapXs9v43vwOFwfvO8ewPFOVsXMp3+Y+Lh9ycTwnmKs7AWNudJNKD IwK4Q/BmiC4/DoWpFfMo8FBgzpxuASvnTp2+b9t+66TZAJfh/Ev9+7tLJ 96B6muwtFl1UEhJNNhUBT9WoDQOsy+epU2IXMVxyI58gylI1I8E8kedXU g==; X-IronPort-AV: E=McAfee;i="6400,9594,10414"; a="348518207" X-IronPort-AV: E=Sophos;i="5.92,286,1650956400"; d="scan'208";a="348518207" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2022 09:26:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,286,1650956400"; d="scan'208";a="625731609" Received: from silpixa00401063.ir.intel.com ([10.243.23.46]) by orsmga008.jf.intel.com with ESMTP; 20 Jul 2022 09:26:34 -0700 From: Michael Phelan To: dev@openvswitch.org Date: Wed, 20 Jul 2022 16:26:20 +0000 Message-Id: <20220720162620.444109-1-michael.phelan@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Cc: i.maximets@ovn.org Subject: [ovs-dev] [PATCH] system-dpdk: Add testpmd clean up in MTU unit tests. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" The MTU vport unit tests do not clean up testpmd after use which causes them to fail randomly. This commit amends the MTU vport unit tests to clean up testpmd after running. Fixes: bf47829116a8feb54fe795aa19915f6e6283af93 ("tests: Add OVS-DPDK MTU unit tests.") Signed-off-by: Michael Phelan Acked-by: Kumar Amber Acked-by: Sunil Pai G Reported-by: Ilya Maximets --- tests/system-dpdk.at | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/tests/system-dpdk.at b/tests/system-dpdk.at index 3beccda44..15f97097a 100644 --- a/tests/system-dpdk.at +++ b/tests/system-dpdk.at @@ -669,6 +669,9 @@ AT_CHECK([ovs-vsctl set Interface dpdkvhostuserclient0 mtu_request=9000]) AT_CHECK([ovs-appctl dpctl/show], [], [stdout]) AT_CHECK([egrep 'mtu=9000' stdout], [], [stdout]) +dnl Clean up the testpmd now +pkill -f -x -9 'tail -f /dev/null' + dnl Clean up AT_CHECK([ovs-vsctl del-port br10 dpdkvhostuserclient0], [], [stdout], [stderr]) OVS_VSWITCHD_STOP("m4_join([], [SYSTEM_DPDK_ALLOWED_LOGS], [ @@ -723,6 +726,9 @@ AT_CHECK([ovs-vsctl set Interface dpdkvhostuserclient0 mtu_request=2000]) AT_CHECK([ovs-appctl dpctl/show], [], [stdout]) AT_CHECK([egrep 'mtu=2000' stdout], [], [stdout]) +dnl Clean up the testpmd now +pkill -f -x -9 'tail -f /dev/null' + dnl Clean up AT_CHECK([ovs-vsctl del-port br10 dpdkvhostuserclient0], [], [stdout], [stderr]) OVS_VSWITCHD_STOP("m4_join([], [SYSTEM_DPDK_ALLOWED_LOGS], [ @@ -852,6 +858,9 @@ dnl Set MTU value above upper bound and check for error AT_CHECK([ovs-vsctl set Interface dpdkvhostuserclient0 mtu_request=9711]) AT_CHECK([grep "dpdkvhostuserclient0: unsupported MTU 9711" ovs-vswitchd.log], [], [stdout]) +dnl Clean up the testpmd now +pkill -f -x -9 'tail -f /dev/null' + dnl Clean up AT_CHECK([ovs-vsctl del-port br10 dpdkvhostuserclient0], [], [stdout], [stderr]) OVS_VSWITCHD_STOP("m4_join([], [SYSTEM_DPDK_ALLOWED_LOGS], [ @@ -906,6 +915,8 @@ dnl Set MTU value below lower bound and check for error AT_CHECK([ovs-vsctl set Interface dpdkvhostuserclient0 mtu_request=67]) AT_CHECK([grep "dpdkvhostuserclient0: unsupported MTU 67" ovs-vswitchd.log], [], [stdout]) +dnl Clean up the testpmd now +pkill -f -x -9 'tail -f /dev/null' dnl Clean up AT_CHECK([ovs-vsctl del-port br10 dpdkvhostuserclient0], [], [stdout], [stderr])