From patchwork Wed Feb 28 09:24:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arkadi Sharshevsky X-Patchwork-Id: 879005 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="RVK8J8zM"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zrqs944fJz9s3Y for ; Wed, 28 Feb 2018 20:24:45 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752348AbeB1JYn (ORCPT ); Wed, 28 Feb 2018 04:24:43 -0500 Received: from mail-eopbgr40072.outbound.protection.outlook.com ([40.107.4.72]:63430 "EHLO EUR03-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752330AbeB1JYk (ORCPT ); Wed, 28 Feb 2018 04:24:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=V9sj7+juRNJOuz70AIiSOMKMEnn2/g6V7QEfKydMrYY=; b=RVK8J8zMPiphnTpkETSA1B0WNtRlEwVGl8w707M4/msoiO++nkpvVNdZm6AM5HoAc4s2zVxCqLA67CTUJmqe5k1Xxa3L2ZdW8QnkiAKCdaMV4H6OGEfwiIVw3Iw3lxGf/7A2iCMROC6MrrT+iZN4tWFUkXZxC4cgVnrtoEqeRT0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=arkadis@mellanox.com; Received: from dev-r-vrt-156.mtr.labs.mlnx (37.142.13.130) by VI1PR0501MB2463.eurprd05.prod.outlook.com (2603:10a6:800:68::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.527.15; Wed, 28 Feb 2018 09:24:35 +0000 From: Arkadi Sharshevsky To: netdev@vger.kernel.org Cc: davem@davemloft.net, stephen@networkplumber.org, dsa@cumulusnetworks.com, mlxsw@mellanox.com, Arkadi Sharshevsky Subject: [PATCH iproute2] devlink: Fix error reporting Date: Wed, 28 Feb 2018 11:24:22 +0200 Message-Id: <1519809862-61464-1-git-send-email-arkadis@mellanox.com> X-Mailer: git-send-email 2.4.11 MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: HE1PR0102CA0064.eurprd01.prod.exchangelabs.com (2603:10a6:7:7d::41) To VI1PR0501MB2463.eurprd05.prod.outlook.com (2603:10a6:800:68::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: d1e3078a-d017-4df0-ce4b-08d57e8d15db X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:VI1PR0501MB2463; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2463; 3:kmoJFZAzua2IOpLxWBnGE/+fPKaGIQZwUNOk3N3v/hPRVlToRQjUMcRpzzHTi4i0uDko/8ZPLywIYjQAl0Q/PZO/aXhXg56kCboijXhqH60xhJ20kIkyN1TcuajU5C5An3yZbckPgfuSsB/usPFH7ZV9hP6kjGuerwpbhl61Se4wRmeNJk/gVJgokfSZXBnFYhCNVA0VCuM0JhDaCEn9ec017wE08PTGcz6RCkl54TmWdCdCQLYYCnNiyojdX7Cw; 25:pl/bFzvmnyZiUPUYOV92ll5B2xoAq4xP1gNrFZGjsVggVXo6VSNo4+ptsSGo0PAZhoWLP8w8mEFSP7rPgcPLBN1c+aGKp347xhrLzS2lsxdzcjzGxJgCbeei4BT5fzPRl0pesKKhWppw8BsK34DbzDhf+FdpweIh4K+Co2NNir/cCj9hoJW6rEnYNawl3wvUfyunB7N/6SOmPyX5c5udbgMg32i975Cp23Twv3Oe+3M3OmJml63wppY3MMRtn8+iBlZa2tfu1orpSnm8/Dce3k+jZcJ9iZq2cfKkcDXDwGchcijppQFWClSFfQJphpnMgakHu6NhYFaHhRs7DqgsCA==; 31:iKz743uXTegLzVaHoUfNz1TPNwRPGT4OJJ5KrmYefyHQ9d1VJqhDvh1Fw9PZ/4GNcNTouKLTr/N0wtaA6oGxwV/6gTtG9B96ZxQoEZNaqXcPKrAu3YwVulUxylPoezdURIGMaXZrj1m2wF9MxUjR9L0n0oeNetIPFNMC6UotWVV25utyPYcT5PSo1DuD2h+WGrMO6NwUg/5KRR82DP2xVPthxNxB+QMFcQJSmO6ris8= X-MS-TrafficTypeDiagnostic: VI1PR0501MB2463: X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2463; 20:j+xHQiiNZ+z67KqhrmN8Gukk+Zqzw/7sahCX8w0I83Ko/Nlj84M+xp1poWlLPPOtOIe5McvrOz1adi8oOY48kpscC5lEQnPcDqwz0In6qVNvcv2NOLqaQFR0RQVRpTXqdIxuF/6lIjClleVak4b1RJEVDNJsQsGtX+VX5rjyQtzUKJiq/XGxP5MzijQedcciOPyrHAXkfSCjvDAanLWLAHdP/U9DI0VdE/NLO2HHJCXHGfjfYQHz0Bpvq2yo6OM/PReRDkbsTu325zvt2czOknPZKZYC5sqFqxjV11O9jplF9jpdRjiJSDzXIP3NII0yDRyRBux0/En5nh789Xp5BifGHngrCAqWiM6yv9EGklai3wkyfEHMy27nvGMlV9aELLyDf0BO5Bwjo0wuT+V09p8BYrT8EtzqcLrXp6xedapdESVqy91KMP0+XQBThjFa2WDOo0x9tlGLfFaGC/LvHOFuerWItiPe/8JgHiE1IWEPhgmlMN8mMn+cQVkz4SVm; 4:S9XTJiAciF2iVO25+wi6Z2GfbZAkqBFXqUYNnprYhwZhKF9r/9v+oyEZr3YXOWfG4wTB4IF9JbOoqOhghKXGPcjXDrJCwzPa2+0CD44xxqMnKo9U5/a4peJ6jYuMaJt+DrqZGub+5cD9Z+g14kChEwLoSm7kbQN8fxeDYaSp+5Zg0Dq6yPbX5SLl/syJMOPTnRlLXwKYVK4LIQXyt1Wi2/CVKqVL16aTurdcHdUQn0P1m/N9i8vp6kjhvSs44r1/2vedN44w81D2Bkz6CkXVCNl0DwPlAnrlH/a5mGYSlztFbNbL5SZGt8W4ojglPLBg X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(211171220733660); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231220)(944501161)(3002001)(6055026)(6041288)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123564045)(6072148)(201708071742011); SRVR:VI1PR0501MB2463; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2463; X-Forefront-PRVS: 0597911EE1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(376002)(39860400002)(39380400002)(396003)(366004)(189003)(199004)(386003)(25786009)(47776003)(66066001)(48376002)(50466002)(186003)(16526019)(51416003)(305945005)(105586002)(4326008)(81166006)(8676002)(81156014)(68736007)(97736004)(36756003)(26005)(6506007)(86362001)(52116002)(6512007)(8936002)(316002)(2351001)(2361001)(106356001)(53936002)(7736002)(50226002)(6486002)(6116002)(16586007)(107886003)(6666003)(5660300001)(6916009)(478600001)(2906002)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2463; H:dev-r-vrt-156.mtr.labs.mlnx; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2463; 23:plrFtQqJ5jw/3Sj4Nq0wAYiXSmmOekMx4FrtGPWXfXm/zSRkt1bLhLHAo9gg+8JpKq2lpAizo+zlZ6sk2q3q8Jr/tuVoDaV0n67ytL1NE88mktD45BmdzDh1ZvW4d1Evpzd/8Sfr+DRCs3AD4oy7OO1gA/cUyxHSIeyJwQ3w1a2CtQpdi2vAJDNJ51WSu2B0EVjXFicQMDEyJYMfKk/V3UhWAqSOyAJsw1fNgLg7cph6+NH8eHkcmh3EhFAjJnihYGM3P3DIQorbnY4UHmKgoPfYxedPAesV4BZQ/5vfVd3Vn/u8KZNqRZArZlswms/BJRyWvCr/AcQxT1Q+PQ6m2HlBxqzmaPTRvYw8Pv9FjpxwfaLpmhdSLNx6GCrzXJdcU/movm2EO5qckqqIovJj2nLcXKxBJAlv6naf7/AX5QfFtzRWX8ClN+XUPM/jbIwHOmD+3LJFBIEbINnX+alNfmS+ZeFLxar7lUAXn5UxrfO+EiGPrKs7UsXz3ANATGThd45NfI0V3J/1qp3DGHYJQ7PjJ2r6s8ffG+FWu345Etdjop+X90nNs7CvVeyqZWe1QZdUxcCQhDI5zaBzYa58r431HG0CFEl47Ab3hPmRnxcpkeqeZQm41xDg8qUHnWsVB1M+SAvO6R5Ue+3BMWHCZs8HXy+EYqQVnsJIQo6LZ7rLHBF2vMXtg3vmNs/dHIkyiUDpEN3XR1hBm4QGieCRfaqamsPY367uPDwztBdGW87vV03O4ylBHi1Kg41CFwfILtZPysbxtdscoHJHKKbJIItaRs0wzJFWeaXQ0MqyDdXHvyjIWPHNgDArgSbs4dtm84QW/CmFoUGzujLT6EZ+Iu38zsWU+aLgIOdAXUBXZtMKXzuThf9LStRDuOg4dR4CdxVGjcKhDp4BEEHqH8HCJNl70vvUSuBbH1J4/jm3J38AT+xg0bxrTrW8UuzXzurxqUjYLw8MIaTxDftLG8GzirtoMHzW8SYbHOg0E61z0RBeT2lMwAXhn0E94Ha1WcnxpmXYTVScUw9TJUS7ciUdKg7vLIhWMqK0H+YdHWwGLmW0KynBxyh/QIIvEMM7XUKrSNiQMllgx16kJouy3EwnVAMkR7NbFCkgyIByr/Aiaoo= X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2463; 6:ZKkBOT8IcjCsEJ0RNMqjY/qsra7zAlPQXr+CM5lQGd6tSBbKS1EpJwr6ODaTguE8j8ebVXjAk184L6uLNvdsot3NKaLpJOUJ5mFA9odJ1bOKVy04T3QRVPVDSu9jjibjMmB7Vh1LJVH2KzzuERTIeXjhdUOCdfrz9/NiQOwhK4S90wn85VZkRVQU1uHhOLF7rrMaOLV7ZpGpZzHAjQRDdUp24Hb4/bRWjGLiTORfy4f1SUO/VVXkbjGVp+WnLS51Aycurg7yTYq269vuld+k0uj+7+ys9r2TKjB8jJo4sU612fV7m+r8VcWJ/N4zijTX83UhgM4DbTgPpSMa4VR70Oq5XJRqPLNK+ZxxJbC/AXo=; 5:+UC8WA4tEcBR0lI5LLBlnJOxsh3AsajI8zAzcatbi4kqIDJP+O8zWATD4Pcqyen/HA7PUjMHhxqC7VAeJJDsaZkux2rjx5jXcqtmf5ftoTbHmKJYV5ONljv/Ri9G3idtW85PgpBZKgPgezVs1ttKydg9MPap3MfaGZ4hDGO8yJw=; 24:TVF7ZoFMy+1A5lp+22Ssn5/8fxAiUoo7yQv6AkUREpi7+HmxGLT7pMa9iqxCAZX5hGhY3fRVZDXrTNapiSm+0qusppMBn+OW8jb8L22z+fA=; 7:ZaUE/G1t3J6k9lgG7yxzaTv2bhdd4evSZQnBrvgBQ4k50p/AdnM5hTfeN0ur/AlN0xaZKBq2augw0WDEWOxwdw0yZGppvxM03d5+NQRolYNsJKdL8aXgAIr+9XYKiauOdtiGF3iBas2AERRz83M0FWa2i68PPNNBv+DkGx2qrG2Ut/S66RZfAni/G9qN1cpEq2Kq1Gzpi1DtCCWx8h4MNVa5gmKpRf1dxKWKSGiSZLYO8uTYekXVCxEuSZEOjot/ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2018 09:24:35.1570 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d1e3078a-d017-4df0-ce4b-08d57e8d15db X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2463 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The current code doesn't set errno in case of extended ack. Fixes: 049c58539f5d ("devlink: mnlg: Add support for extended ack") Signed-off-by: Arkadi Sharshevsky Acked-by: Jiri Pirko --- devlink/mnlg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/devlink/mnlg.c b/devlink/mnlg.c index 37c5687..3d28453 100644 --- a/devlink/mnlg.c +++ b/devlink/mnlg.c @@ -71,15 +71,15 @@ static int mnlg_cb_error(const struct nlmsghdr *nlh, void *data) { const struct nlmsgerr *err = mnl_nlmsg_get_payload(nlh); - if (nl_dump_ext_ack(nlh, NULL)) - return MNL_CB_STOP; - /* Netlink subsystems returns the errno value with different signess */ if (err->error < 0) errno = -err->error; else errno = err->error; + if (nl_dump_ext_ack(nlh, NULL)) + return MNL_CB_ERROR; + return err->error == 0 ? MNL_CB_STOP : MNL_CB_ERROR; }