From patchwork Thu Jul 7 05:52:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jiang, Haochen" X-Patchwork-Id: 1653304 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=irgmUMUW; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Ldltp0mDxz9s09 for ; Thu, 7 Jul 2022 15:52:48 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EED98385702C for ; Thu, 7 Jul 2022 05:52:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EED98385702C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1657173163; bh=S23axylttfmXWEU0GbwuRA/fZk/wrIM5e+K5f9QkpDY=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=irgmUMUWt3juKaSIo4GkLGzumkUONmT36JlDXbnxzwNhIrXC6fBPH5kHJy6FSlbK6 CoiPLl0PdpvpvRyS4kvshdNj0WEWdi2mu0VTvW2ZAqfCrHUmQkKIztoXyTMNs2SJKX Ebw5WywChVkaL1Dn3kOCR23uWpkGfh1oXnluBcBk= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by sourceware.org (Postfix) with ESMTPS id A26B03858D32 for ; Thu, 7 Jul 2022 05:52:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A26B03858D32 X-IronPort-AV: E=McAfee;i="6400,9594,10400"; a="345626563" X-IronPort-AV: E=Sophos;i="5.92,252,1650956400"; d="scan'208";a="345626563" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2022 22:52:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,252,1650956400"; d="scan'208";a="661248180" Received: from shvmail03.sh.intel.com ([10.239.245.20]) by fmsmga004.fm.intel.com with ESMTP; 06 Jul 2022 22:52:19 -0700 Received: from shliclel314.sh.intel.com (shliclel314.sh.intel.com [10.239.240.214]) by shvmail03.sh.intel.com (Postfix) with ESMTP id 9122B10056A5; Thu, 7 Jul 2022 13:52:18 +0800 (CST) To: gcc-patches@gcc.gnu.org Subject: [PATCH] i386: Handle memory operand for direct call to cvtps2pd in unpack Date: Thu, 7 Jul 2022 13:52:18 +0800 Message-Id: <20220707055218.663144-1-haochen.jiang@intel.com> X-Mailer: git-send-email 2.18.2 X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Haochen Jiang via Gcc-patches From: "Jiang, Haochen" Reply-To: Haochen Jiang Cc: jakub@redhat.com, hongtao.liu@intel.com Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Hi all, This patch aim to fix the ICE for vec unpack using for memory after the commit r13-1418 on inproper insn of cvtps2pd. Regtested on x86_64-pc-linux-gnu. Ok for trunk? BRs, Haochen gcc/ChangeLog: PR target/106180 * config/i386/sse.md (sse2_cvtps2pd_1): Rename from *sse2_cvtps2pd_1. (vec_unpacks_lo_v4sf): Add handler for memory operand. gcc/testsuite/ChangeLog: PR target/106180 * g++.target/i386/pr106180-1.C: New test. --- gcc/config/i386/sse.md | 12 +++++++-- gcc/testsuite/g++.target/i386/pr106180-1.C | 31 ++++++++++++++++++++++ 2 files changed, 41 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/g++.target/i386/pr106180-1.C diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md index 3396ff748da..5b91c7be54e 100644 --- a/gcc/config/i386/sse.md +++ b/gcc/config/i386/sse.md @@ -9208,7 +9208,7 @@ (set_attr "prefix" "maybe_vex") (set_attr "mode" "V2DF")]) -(define_insn "*sse2_cvtps2pd_1" +(define_insn "sse2_cvtps2pd_1" [(set (match_operand:V2DF 0 "register_operand" "=v") (float_extend:V2DF (match_operand:V2SF 1 "memory_operand" "m")))] @@ -9270,7 +9270,15 @@ (vec_select:V2SF (match_operand:V4SF 1 "vector_operand") (parallel [(const_int 0) (const_int 1)]))))] - "TARGET_SSE2") + "TARGET_SSE2" +{ + if (MEM_P (operands[1])) + { + operands[1] = adjust_address_nv (operands[1], V2SFmode, 0); + emit_insn (gen_sse2_cvtps2pd_1 (operands[0], operands[1])); + DONE; + } +}) (define_expand "vec_unpacks_lo_v8sf" [(set (match_operand:V4DF 0 "register_operand") diff --git a/gcc/testsuite/g++.target/i386/pr106180-1.C b/gcc/testsuite/g++.target/i386/pr106180-1.C new file mode 100644 index 00000000000..7f734536001 --- /dev/null +++ b/gcc/testsuite/g++.target/i386/pr106180-1.C @@ -0,0 +1,31 @@ +/* { dg-do compile } */ +/* { dg-options "-O3 -c -ffloat-store -std=c++11" } */ + +struct PointT +{ + double x, y; +}; +using PointF = PointT; + +template struct __array_traits { typedef PointT _Type[_Nm]; }; +template struct array +{ + typename __array_traits<_Nm>::_Type _M_elems; +}; + +float SampleGrid_low, SampleGrid_high; +using QuadrilateralF = array<4>; +struct PerspectiveTransform +{ + PerspectiveTransform (QuadrilateralF, QuadrilateralF); +}; + +void SampleGrid() +{ + PerspectiveTransform + { + { PointF {SampleGrid_high, SampleGrid_low}, + SampleGrid_low, SampleGrid_high }, + {} + }; +}