From patchwork Tue Feb 27 11:58:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Shtylyov X-Patchwork-Id: 878480 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=cogentembedded.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="SdmmGeCi"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zrHJx36qxz9rx7 for ; Tue, 27 Feb 2018 22:58:25 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752397AbeB0L6V (ORCPT ); Tue, 27 Feb 2018 06:58:21 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:41578 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752160AbeB0L6T (ORCPT ); Tue, 27 Feb 2018 06:58:19 -0500 Received: by mail-lf0-f66.google.com with SMTP id m69so27103437lfe.8 for ; Tue, 27 Feb 2018 03:58:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:organization:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=F44SIf9lDb+foQG5jjoyGTtzz9lOfDzgX4wrSPJHJWc=; b=SdmmGeCizodgm6i4XljstP0NcJ6kNlO2ehwj6nU6SKajvQDs8OqIbwfOv7dpbjvnvz 2/Ak4X/7C7kjVsL/sgbtyD/Ql7Ww6vABmzeqeaOGlJzxVjVe1sYA8MhWqt/yLOUelwMk 6vjecKACyMRq8pML8YcEzxlhndDzBY5LMehtR2H/62pC0zvO/9sR+s0h8Ao06MiYUh8P bxqdq2S3bMmRyjvKJOdJVubDh93Qh+LFH4x0i3FVYSzUIhN5r34EdY2SsEg/tXa5pp5k FYmKDUUdL/5e5W9eXIWUvMSpcC/SLms5MhkCITM/p/3JjWmiT0EoebHwgiU6mMrYnVP8 yRaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:organization:message-id:date :user-agent:mime-version:content-language:content-transfer-encoding; bh=F44SIf9lDb+foQG5jjoyGTtzz9lOfDzgX4wrSPJHJWc=; b=Sr9Ivgkw67qpdeE+kzmKHXHvd2dNAjzFn852fbVGB2ldgAjDZ/pOMgaa0eHl2jQ2dV 2iwobCP13YU0iLmcdfnrE3BqEemenr1nbLcSR1kmRhe6BOYUHg0HLC5w4FjUdwBnrnPw BJRYDdrz7K4ia+/TTa2eVJDinYLsa+FfSDibz8P7eS1hKKM7UFYsm1n399ImdOEThKdN ukYgwfFX8/mEha7Dz5NCPvdPOhilBSVU2RrF2zsDnspd6F99QmA6s+zmlxEMcERwUt1r BqmKtN9HSDLU1XbkzZmaWCh9XnNy9KCOHC5y+7QO6W0UTmr1Y6lN/lLQBh4lyYfIsiIx ypZQ== X-Gm-Message-State: APf1xPDdPDmwWkElp+PBHbPnnaNgaPsbO8Dxxbp21C0KLydYYL0XRhvn HqkIxWQyC2itBKOjsPhrb/pwZQ== X-Google-Smtp-Source: AH8x226/Hi0CxpectXUUxcRjAi6zkZMS1+sVm5QXxNGlRKdE/7mx/Uowih0Ow9rvJ+exFYP4We4QvQ== X-Received: by 10.25.228.18 with SMTP id b18mr9864804lfh.61.1519732698378; Tue, 27 Feb 2018 03:58:18 -0800 (PST) Received: from wasted.cogentembedded.com ([31.173.80.12]) by smtp.gmail.com with ESMTPSA id b7sm2518907ljf.18.2018.02.27.03.58.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Feb 2018 03:58:17 -0800 (PST) From: Sergei Shtylyov Subject: [PATCH net-next] sh_eth: uninline TSU register accessors To: netdev@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org Organization: Cogent Embedded Message-ID: Date: Tue, 27 Feb 2018 14:58:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Language: en-MW Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org We have uninlined the sh_eth_{read|write}() functions introduced in the commit 4a55530f38e ("net: sh_eth: modify the definitions of register"). Now remove *inline* from sh_eth_tsu_{read|write}() as well and move these functions from the header to the driver itself. This saves 684 more bytes of object code (ARM gcc 4.8.5)... Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/renesas/sh_eth.c | 11 +++++++++++ drivers/net/ethernet/renesas/sh_eth.h | 11 ----------- 2 files changed, 11 insertions(+), 11 deletions(-) Index: net-next/drivers/net/ethernet/renesas/sh_eth.c =================================================================== --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c +++ net-next/drivers/net/ethernet/renesas/sh_eth.c @@ -439,6 +439,17 @@ static void sh_eth_modify(struct net_dev enum_index); } +static void sh_eth_tsu_write(struct sh_eth_private *mdp, u32 data, + int enum_index) +{ + iowrite32(data, mdp->tsu_addr + mdp->reg_offset[enum_index]); +} + +static u32 sh_eth_tsu_read(struct sh_eth_private *mdp, int enum_index) +{ + return ioread32(mdp->tsu_addr + mdp->reg_offset[enum_index]); +} + static bool sh_eth_is_gether(struct sh_eth_private *mdp) { return mdp->reg_offset == sh_eth_offset_gigabit; Index: net-next/drivers/net/ethernet/renesas/sh_eth.h =================================================================== --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.h +++ net-next/drivers/net/ethernet/renesas/sh_eth.h @@ -568,15 +568,4 @@ static inline void *sh_eth_tsu_get_offse return mdp->tsu_addr + mdp->reg_offset[enum_index]; } -static inline void sh_eth_tsu_write(struct sh_eth_private *mdp, u32 data, - int enum_index) -{ - iowrite32(data, mdp->tsu_addr + mdp->reg_offset[enum_index]); -} - -static inline u32 sh_eth_tsu_read(struct sh_eth_private *mdp, int enum_index) -{ - return ioread32(mdp->tsu_addr + mdp->reg_offset[enum_index]); -} - #endif /* #ifndef __SH_ETH_H__ */